From: "Siluvery, Arun" <arun.siluvery@linux.intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] lib/rendercopy_gen9: WaBindlessSurfaceStateModifyEnable
Date: Wed, 12 Aug 2015 10:47:30 +0100 [thread overview]
Message-ID: <55CB1632.8080904@linux.intel.com> (raw)
In-Reply-To: <1439295937-4707-1-git-send-email-mika.kuoppala@intel.com>
On 11/08/2015 13:25, Mika Kuoppala wrote:
> Don't set the size of bindless surface state on rendercopy.
> And as of doing so, take into account the workaround for setting
> the command size.
>
> This was tried during hunting for
> https://bugs.freedesktop.org/show_bug.cgi?id=89959. But no
> impact was found.
>
> Cc: Arun Siluvery <arun.siluvery@linux.intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> lib/rendercopy_gen9.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
> index 0766192..4a4a604 100644
> --- a/lib/rendercopy_gen9.c
> +++ b/lib/rendercopy_gen9.c
> @@ -511,7 +511,11 @@ gen7_emit_push_constants(struct intel_batchbuffer *batch) {
>
> static void
> gen9_emit_state_base_address(struct intel_batchbuffer *batch) {
> - OUT_BATCH(GEN6_STATE_BASE_ADDRESS | (19 - 2));
> +
> + /* WaBindlessSurfaceStateModifyEnable:skl,bxt */
> + /* The length has to be one less if we dont modify
> + bindless state */
> + OUT_BATCH(GEN6_STATE_BASE_ADDRESS | (19 - 1 - 2));
>
> /* general */
> OUT_BATCH(0 | BASE_ADDRESS_MODIFY);
> @@ -544,9 +548,9 @@ gen9_emit_state_base_address(struct intel_batchbuffer *batch) {
> OUT_BATCH(1 << 12 | 1);
>
> /* Bindless surface state base address */
> - OUT_BATCH(0 | BASE_ADDRESS_MODIFY);
> OUT_BATCH(0);
> - OUT_BATCH(0xfffff000);
> + OUT_BATCH(0);
> + OUT_BATCH(0);
> }
>
> static void
>
Agrees with spec and looks good to me. No impact observed with
gem_concurrent_blit subtests.
Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com>
regards
Arun
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-08-12 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 12:25 [PATCH] lib/rendercopy_gen9: WaBindlessSurfaceStateModifyEnable Mika Kuoppala
2015-08-12 9:47 ` Siluvery, Arun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB1632.8080904@linux.intel.com \
--to=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox