Re: [PATCH 10/21] drm/i915/gtt: Remove superfluous free_pd with gen6/7

Michel Thierry
2015-06-02T14:07:55Z

On 5/22/2015 6:05 PM, Mika Kuoppala wrote:
> This has slipped in somewhere but it was harmless
> as we check the page pointer before teardown.
>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>

Right, free_pd is only for gen8+.

Reviewed-by: Michel Thierry <michel.thierry@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index f58aa63..f747bd3 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -1416,7 +1416,6 @@ static void gen6_ppgtt_cleanup(struct i915_address_space *vm)
> }
>
> free_pt(ppgtt->base.dev, ppgtt->scratch_pt);
> - free_pd(ppgtt->base.dev, &ppgtt->pd);
> }
>
> static int gen6_ppgtt_allocate_page_directories(struct i915_hw_ppgtt *ppgtt)
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx