From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timo Aaltonen Subject: Re: [PATCH 1/2 v2 addendum v2] drm/i915: Allow parsing of variable size child device entries from VBT Date: Fri, 14 Aug 2015 11:07:02 +0300 Message-ID: <55CDA1A6.6010108@ubuntu.com> References: <1436526655-2965-1-git-send-email-antti.koskipaa@linux.intel.com> <1436526655-2965-2-git-send-email-antti.koskipaa@linux.intel.com> <20150804135552.GC6150@boom> <20150805085900.GM17734@phenom.ffwll.local> <55C3682E.6080103@intel.com> <20150806140855.GE6150@boom> <20150806153102.GW17734@phenom.ffwll.local> <20150812102917.GL6150@boom> <8737zotwqw.fsf@intel.com> <20150813131415.GO6150@boom> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id 151486EDDC for ; Fri, 14 Aug 2015 01:07:06 -0700 (PDT) In-Reply-To: <20150813131415.GO6150@boom> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Daniel Vetter , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMTMuMDguMjAxNSAxNjoxNCwgRGF2aWQgV2VpbmVoYWxsIHdyb3RlOgo+IE9uIFdlZCwgQXVn IDEyLCAyMDE1IGF0IDA1OjE5OjM1UE0gKzAzMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+PiBPbiBX ZWQsIDEyIEF1ZyAyMDE1LCBEYXZpZCBXZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+Pj4gU29tZSBtb3JlIGZpeHVwIGlzIG5lZWRlZDsgdGhlIGJpdHMg ZnJvbSBBbnR0aSdzIHBhdGNoCj4+PiB0aGF0IGFjdHVhbGx5IGV4cGFuZGVkIHRoZSBzdHJ1Y3Qg dG8gZnVsbHkgZml0IHRoZSBuZXdlcgo+Pj4gdmVyc2lvbnMgb2YgdGhlIGNoaWxkX2RldmljZV9j b25maWcgd2FzIHBhcnQgb2YgdGhlIHNlY29uZAo+Pj4gcGF0Y2g7IHNpbmNlIHRoYXQgcGF0Y2gg aGFzbid0IGJlZW4gbWVyZ2VkIHlldCB3ZSBuZWVkIHRoaXMgYml0Ogo+Pj4KPj4+IFRoaXMgYXBw bGllcyBvbiB0b3Agb2YgdGhlIHBhdGNoIHlvdSBhbHJlYWR5IG1lcmdlZAo+Pj4gKHRoZSBJYm9v c3QgcGF0Y2ggd2lsbCBuZWVkIGNvcnJlc3BvbmRpbmcgYWRqdXN0bWVudCB0bwo+Pj4gIHJlbW92 ZSB0aGUgY2hhbmdlcyBJIHNwbGl0IG91dCk6Cj4+Pgo+Pj4gRXhwYW5kIGNvbW1vbl9jaGlsZF9k ZXZfY29uZmlnIHRvIGJlIGFibGUgdG8gZml0IGFsbCBpbmZvcm1hdGlvbgo+Pj4gZGVmaW5lZCBi eSB0aGUgbGF0ZXN0IFZCVCBzcGVjaWZpY2F0aW9uLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IERh dmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVoYWxsQGxpbnV4LmludGVsLmNvbT4KPj4+IENDOiBB bnR0aSBLb3NraXBhYSA8YW50dGkua29za2lwYWFAbGludXguaW50ZWwuY29tPgo+Pj4gLS0tCj4+ PiAgaW50ZWxfYmlvcy5jIHwgICAgNyArKysrKystCj4+PiAgaW50ZWxfYmlvcy5oIHwgICAgNCAr KysrCj4+PiAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+Pj4gaW5kZXggOTkwYWNjMjA3NzFh Li40MGUyY2M0ZTc0MTkgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9iaW9zLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+Pj4g QEAgLTEwMzgsNiArMTAzOCwxMCBAQCBwYXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+PiAgCQlEUk1fREVCVUdfS01TKCJObyBnZW5lcmFsIGRl ZmluaXRpb24gYmxvY2sgaXMgZm91bmQsIG5vIGRldmljZXMgZGVmaW5lZC5cbiIpOwo+Pj4gIAkJ cmV0dXJuOwo+Pj4gIAl9Cj4+PiArCS8qIFJlbWVtYmVyIHRvIGtlZXAgdGhpcyBpbiBzeW5jIHdp dGggY2hpbGRfZGV2aWNlX2NvbmZpZzsKPj4+ICsJICogd2hlbmV2ZXIgYSBuZXcgZmVhdHVyZSBp cyBhZGRlZCB0byBCREIgdGhhdCBjYXVzZXMgdGhhdAo+Pj4gKwkgKiBzdHJ1Y3QgdG8gZ3JvdyB0 aGlzIG5lZWRzIHRvIGJlIHVwZGF0ZWQgdG9vCj4+PiArCSAqLwo+Pj4gIAlpZiAoYmRiLT52ZXJz aW9uIDwgMTk1KSB7Cj4+PiAgCQlleHBlY3RlZF9zaXplID0gMzM7Cj4+PiAgCX0gZWxzZSBpZiAo YmRiLT52ZXJzaW9uID09IDE5NSkgewo+Pj4gQEAgLTEwNTEsNyArMTA1NSw4IEBAIHBhcnNlX2Rl dmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4+ICAJfQo+ Pj4gIAo+Pj4gIAlpZiAoZXhwZWN0ZWRfc2l6ZSA+IHNpemVvZigqcF9jaGlsZCkpIHsKPj4+IC0J CURSTV9FUlJPUigiY2hpbGRfZGV2aWNlX2NvbmZpZyBjYW5ub3QgZml0IGluIHBfY2hpbGRcbiIp Owo+Pj4gKwkJRFJNX0VSUk9SKCJjaGlsZF9kZXZpY2VfY29uZmlnIChzaXplICV1KSBjYW5ub3Qg Zml0IGluIHBfY2hpbGQgKHNpemUgJXUpOyBiZGItPnZlcnNpb246ICV1XG4iLAo+Pj4gKwkJCSAg ZXhwZWN0ZWRfc2l6ZSwgc2l6ZW9mKCpwX2NoaWxkKSwgYmRiLT52ZXJzaW9uKTsKPj4KPj4gZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jOiBJbiBmdW5jdGlvbiDigJhwYXJzZV9kZXZp Y2VfbWFwcGluZ+KAmToKPj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jOjEwNTg6 Mzogd2FybmluZzogZm9ybWF0IOKAmCV14oCZIGV4cGVjdHMgYXJndW1lbnQgb2YgdHlwZSDigJh1 bnNpZ25lZCBpbnTigJksIGJ1dCBhcmd1bWVudCAzIGhhcyB0eXBlIOKAmGxvbmcgdW5zaWduZWQg aW504oCZIFstV2Zvcm1hdD1dCj4+ICAgIERSTV9FUlJPUigiY2hpbGRfZGV2aWNlX2NvbmZpZyAo c2l6ZSAldSkgY2Fubm90IGZpdCBpbiBwX2NoaWxkIChzaXplICV1KTsgYmRiLT52ZXJzaW9uOiAl dVxuIiwKPj4gICAgXgo+PiAgIENDIFtNXSAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmlm b191bmRlcnJ1bi5vCj4gCj4gV2VsbCBzcG90dGVkLiAgT3IgcmF0aGVyLCBzdHVwaWQgb2YgbWUg dG8gZm9yZ2V0IHRoYXQgc2l6ZW9mIHlpZWxkcwo+IHNpemVfdCBhcyB0eXBlLCB0aHVzIG5lY2Vz c2l0YXRpbmcgJXp1IGFzIGNvbnZlcnNpb24gc3BlY2lmaWVyLgo+IAo+IEZpeGVkIHZlcnNpb246 Cj4gCj4gRXhwYW5kIGNvbW1vbl9jaGlsZF9kZXZfY29uZmlnIHRvIGJlIGFibGUgdG8gZml0IGFs bCBpbmZvcm1hdGlvbgo+IGRlZmluZWQgYnkgdGhlIGxhdGVzdCBWQlQgc3BlY2lmaWNhdGlvbi4K PiAKPiB2MjogVXNlIHByb3BlciBjb252ZXJzaW9uIHNwZWNpZmllciBmb3Igc2l6ZV90ICglenUp Cj4gCj4gU2lnbmVkLW9mZi1ieTogRGF2aWQgV2VpbmVoYWxsIDxkYXZpZC53ZWluZWhhbGxAbGlu dXguaW50ZWwuY29tPgo+IENDOiBBbnR0aSBLb3NraXBhYSA8YW50dGkua29za2lwYWFAbGludXgu aW50ZWwuY29tPgo+IAo+ICBpbnRlbF9iaW9zLmMgfCAgICA3ICsrKysrKy0KPiAgaW50ZWxfYmlv cy5oIHwgICAgNCArKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9i aW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiBpbmRleCA5OTBhY2My MDc3MWEuLjU2NzNlZDUzNzk3YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9iaW9zLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiBA QCAtMTAzOCw2ICsxMDM4LDEwIEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlEUk1fREVCVUdfS01TKCJObyBnZW5lcmFsIGRlZmlu aXRpb24gYmxvY2sgaXMgZm91bmQsIG5vIGRldmljZXMgZGVmaW5lZC5cbiIpOwo+ICAJCXJldHVy bjsKPiAgCX0KPiArCS8qIFJlbWVtYmVyIHRvIGtlZXAgdGhpcyBpbiBzeW5jIHdpdGggY2hpbGRf ZGV2aWNlX2NvbmZpZzsKPiArCSAqIHdoZW5ldmVyIGEgbmV3IGZlYXR1cmUgaXMgYWRkZWQgdG8g QkRCIHRoYXQgY2F1c2VzIHRoYXQKPiArCSAqIHN0cnVjdCB0byBncm93IHRoaXMgbmVlZHMgdG8g YmUgdXBkYXRlZCB0b28KPiArCSAqLwo+ICAJaWYgKGJkYi0+dmVyc2lvbiA8IDE5NSkgewo+ICAJ CWV4cGVjdGVkX3NpemUgPSAzMzsKPiAgCX0gZWxzZSBpZiAoYmRiLT52ZXJzaW9uID09IDE5NSkg ewo+IEBAIC0xMDUxLDcgKzEwNTUsOCBAQCBwYXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAl9Cj4gIAo+ICAJaWYgKGV4cGVjdGVkX3NpemUg PiBzaXplb2YoKnBfY2hpbGQpKSB7Cj4gLQkJRFJNX0VSUk9SKCJjaGlsZF9kZXZpY2VfY29uZmln IGNhbm5vdCBmaXQgaW4gcF9jaGlsZFxuIik7Cj4gKwkJRFJNX0VSUk9SKCJjaGlsZF9kZXZpY2Vf Y29uZmlnIChzaXplICV1KSBjYW5ub3QgZml0IGluIHBfY2hpbGQgKHNpemUgJXp1KTsgYmRiLT52 ZXJzaW9uOiAldVxuIiwKPiArCQkJICBleHBlY3RlZF9zaXplLCBzaXplb2YoKnBfY2hpbGQpLCBi ZGItPnZlcnNpb24pOwo+ICAJCXJldHVybjsKPiAgCX0KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Jpb3MuaAo+IGluZGV4IGY3YWQ2YTU4NTEyOS4uNzFjYjk2Zjc3ODcwIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Jpb3MuaAo+IEBAIC0yMzksNiArMjM5LDEwIEBAIHN0cnVjdCBjb21tb25f Y2hpbGRfZGV2X2NvbmZpZyB7Cj4gIAl1OCBub3RfY29tbW9uMlsyXTsKPiAgCXU4IGRkY19waW47 Cj4gIAl1MTYgZWRpZF9wdHI7Cj4gKwl1OCBvYnNvbGV0ZTsKPiArCXU4IGZsYWdzXzE7Cj4gKwl1 OCBub3RfY29tbW9uM1sxM107Cj4gKwl1OCBpYm9vc3RfbGV2ZWw7Cj4gIH0gX19wYWNrZWQ7Cj4g IAo+ICAvKiBUaGlzIGZpZWxkIGNoYW5nZXMgZGVwZW5kaW5nIG9uIHRoZSBCREIgdmVyc2lvbiwg c28gdGhlIG1vc3QgcmVsaWFibGUgd2F5IHRvCgpQbGVhc2UgYXBwbHkgdGhpcywgZml4ZXMgaXNz dWVzIG9uIHNvbWUgbWFjaGluZShzKSBoZXJlLiBQcm9iYWJseSBhbHNvCmNjOnN0YWJsZSBzaW5j ZSBpdCBhcHBsaWVzIHRvIEJTVyBhcyB3ZWxsIGFzIFNLTC4KCmFuZCB0aGUgdXBzdHJlYW0gYnVn IGNvdWxkIGJlIHJlZmVyZW5jZWQgdG9vLCBpdCdzCmh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5v cmcvc2hvd19idWcuY2dpP2lkPTkxNjEzCgotLSAKdApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=