Re: [PATCH 04/18] tests/drm_import_export: mark flink and prime tests as basic

Daniel Vetter
2015-08-14T12:26:51Z

On Thu, Aug 13, 2015 at 01:31:27PM -0700, Jesse Barnes wrote:
> They're testing basic functionality and don't involve stress or race
> induction.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

These are more stress-tests in nature I think. For basic testscases of
prime I'd recommend instead

prime_self_import: Everything not marked with *-race

gem_flink: all of them.

instead of this patch here.
-Daniel

> ---
> tests/drm_import_export.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/drm_import_export.c b/tests/drm_import_export.c
> index e24e0df..6a63ef9 100644
> --- a/tests/drm_import_export.c
> +++ b/tests/drm_import_export.c
> @@ -265,7 +265,7 @@ igt_main {
> test_import_close_race();
> }
>
> - igt_subtest("flink") {
> + igt_subtest("basic-flink") {
> use_flink = true;
>
> pthread_create(&test_thread_id1, NULL, test_thread, NULL);
> @@ -279,7 +279,7 @@ igt_main {
> pthread_join(test_thread_id4, NULL);
> }
>
> - igt_subtest("prime") {
> + igt_subtest("basic-prime") {
> use_flink = false;
>
> pthread_create(&test_thread_id1, NULL, test_thread, NULL);
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation