Re: [PATCH 12/18] tests/kms_addfb: mark simple fb creation tests as basic

Daniel Vetter
2015-08-14T12:42:36Z

On Thu, Aug 13, 2015 at 01:31:35PM -0700, Jesse Barnes wrote:
> We should always be able to create simple and tiled objects.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

There's are all super-fast abi tests which don't even do a modeset. Imo
add them all by renaming the testcase to kms_addfb_basic. The real
functional testcases are somewhere else (x/y-tiled flipping, rotation,
stuff like that).
-Daniel

> ---
> tests/kms_addfb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_addfb.c b/tests/kms_addfb.c
> index 42ee632..f10e12b 100644
> --- a/tests/kms_addfb.c
> +++ b/tests/kms_addfb.c
> @@ -121,7 +121,7 @@ static void pitch_tests(int fd)
> }
>
> f.handles[0] = gem_bo;
> - igt_subtest("normal") {
> + igt_subtest("basic") {
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == 0);
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
> f.fb_id = 0;
> @@ -139,7 +139,7 @@ static void pitch_tests(int fd)
> gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
> f.pitches[0] = 1024*4;
>
> - igt_subtest("X-tiled") {
> + igt_subtest("basic-X-tiled") {
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == 0);
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
> f.fb_id = 0;
> @@ -162,7 +162,7 @@ static void pitch_tests(int fd)
> igt_fixture
> gem_set_tiling(fd, gem_bo, I915_TILING_Y, 1024*4);
> f.pitches[0] = 1024*4;
> - igt_subtest("Y-tiled") {
> + igt_subtest("basic-Y-tiled") {
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> errno == EINVAL);
> }
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation