Re: [PATCH 01/18] tests/gem_storedw_loop: add new store_dword test to unify per-ring ones

From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 01/18] tests/gem_storedw_loop: add new store_dword test to unify per-ring ones
Date: Fri, 14 Aug 2015 08:21:12 -0700	[thread overview]
Message-ID: <55CE0768.9080705@virtuousgeek.org> (raw)
In-Reply-To: <20150814121934.GZ17734@phenom.ffwll.local>

On 08/14/2015 05:19 AM, Daniel Vetter wrote:
> On Thu, Aug 13, 2015 at 01:31:24PM -0700, Jesse Barnes wrote:
>> There was a lot of duplication going on...  Mark as basic while we're at
>> it as these should never fail.
>>
>> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>> ---
>>  tests/Makefile.sources   |   1 +
>>  tests/gem_storedw_loop.c | 181 +++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 182 insertions(+)
>>  create mode 100644 tests/gem_storedw_loop.c
>>
>> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
>> index b9a4cb4..cdcee33 100644
>> --- a/tests/Makefile.sources
>> +++ b/tests/Makefile.sources
>> @@ -138,6 +138,7 @@ TESTS_progs = \
>>  	gem_seqno_wrap \
>>  	gem_set_tiling_vs_gtt \
>>  	gem_set_tiling_vs_pwrite \
>> +	gem_storedw_loop \
>>  	gem_storedw_loop_blt \
>>  	gem_storedw_loop_bsd \
>>  	gem_storedw_loop_render \
> 
> Why not remove the old ones while at it? This just means more gunk in the
> overall igt set. Also please update .gitignore here for these ...

Yeah figured that would be a separate patch assuming this one looked ok.  I added it to the .gitignore in a later patch to update it all at once.

Jesse

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx