From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Hoath Subject: Re: [PATCH] drm/i915: Split alloc from init for lrc Date: Wed, 19 Aug 2015 15:40:58 +0100 Message-ID: <55D4957A.7040003@intel.com> References: <1439987068-4037-1-git-send-email-nicholas.hoath@intel.com> <20150819123747.GN8742@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id DE97C6EBE9 for ; Wed, 19 Aug 2015 07:41:01 -0700 (PDT) In-Reply-To: <20150819123747.GN8742@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMTkvMDgvMjAxNSAxMzozNywgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IE9uIFdlZCwgQXVnIDE5 LCAyMDE1IGF0IDAxOjI0OjI4UE0gKzAxMDAsIE5pY2sgSG9hdGggd3JvdGU6Cj4+IEV4dGVuZCBp bml0L2luaXRfaHcgc3BsaXQgdG8gY29udGV4dCBpbml0Lgo+PiAgICAgLSBNb3ZlIGNvbnRleHQg aW5pdGlhbGlzYXRpb24gaW4gdG8gaTkxNV9nZW1faW5pdF9odwo+PiAgICAgLSBNb3ZlIG9uZSBv ZmYgaW5pdGlhbGlzYXRpb24gZm9yIHJlbmRlciByaW5nIHRvCj4+ICAgICAgICAgIGk5MTVfZ2Vt X3ZhbGlkYXRlX2NvbnRleHQKPj4gICAgIC0gTW92ZSBkZWZhdWx0IGNvbnRleHQgaW5pdGlhbGlz YXRpb24gdG8gbG9naWNhbF9yaW5nX2luaXQKPj4KPj4gUmVuYW1lIGludGVsX2xyX2NvbnRleHRf ZGVmZXJyZWRfY3JlYXRlIHRvCj4+IGludGVsX2xyX2NvbnRleHRfZGVmZXJyZWRfYWxsb2MsIHRv IHJlZmxlY3QgcmVkdWNlZCBmdW5jdGlvbmFsaXR5ICYKPj4gYWxsb2MvaW5pdCBzcGxpdC4KPj4K Pj4gVGhpcyBwYXRjaCBpcyBpbnRlbmRlZCB0byBzcGxpdCBvdXQgdGhlIGFsbG9jYXRpb24gb2Yg cmVzb3VyY2VzICYgaW5pdGlhbGlzYXRpb24KPj4gdG8gYWxsb3cgZWFzaWVyIHJldXNlIG9mIGNv ZGUgZm9yIHJlc3VtZS9ncHUgcmVzZXQuCj4+Cj4+IHYyOiBSZW1vdmVkIGZ1bmN0aW9uIHB0ciB3 cmFwcGluZyBvZiBkb19zd2l0Y2hfY29udGV4dCAoRGFuaWVsIFZldHRlcikKPj4gICAgICBMZWZ0 IC0+aW5pdF9jb250ZXh0IGludCBpbnRlbF9scl9jb250ZXh0X2RlZmVycmVkX2FsbG9jIChEYW5p ZWwgVmV0dGVyKQo+PiAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBpbml0IGZsYWcgJiByaW5nIHR5 cGUgdGVzdC4gKERhbmllbCBWZXR0ZXIpCj4+ICAgICAgSW1wcm92ZSBjb21taXQgbWVzc2FnZSAo RGFuaWVsIFZldHRlcikKPj4gdjM6IE9uIGluaXQvcmVpbml0LCBzZXQgdGhlIGh3IG5leHQgc2Vx dWVuY2UgbnVtYmVyIHRvIHRoZSBzdyBuZXh0IHNlcXVlbmNlCj4+ICAgICAgbnVtYmVyLiBUaGlz IGlzIHNldCB0byAxIGF0IGRyaXZlciBsb2FkIHRpbWUuIFRoaXMgcHJldmVudHMgdGhlIHNlcW5v Cj4+ICAgICAgYmVpbmcgcmVzZXQgb24gcmVpbml0IChDaHJpcyBXaWxzb24pCj4+Cj4+IElzc3Vl OiBWSVotNDc5OAo+PiBTaWduZWQtb2ZmLWJ5OiBOaWNrIEhvYXRoIDxuaWNob2xhcy5ob2F0aEBp bnRlbC5jb20+Cj4+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IC0tLQo+PiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAgICB8ICAgMSAtCj4+ICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgICAgIHwgIDE4ICsrLS0KPj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgfCAgIDMgKy0KPj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgICAgfCAxNDcgKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuaCAgICAgICAgICAgfCAgIDQgKy0KPj4gICA1IGZpbGVzIGNoYW5nZWQsIDg2IGluc2VydGlv bnMoKyksIDg3IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gaW5k ZXggZjdmZDUxOS4uODQ0Y2NmMCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IEBA IC04ODAsNyArODgwLDYgQEAgc3RydWN0IGludGVsX2NvbnRleHQgewo+PiAgIAl9IGxlZ2FjeV9o d19jdHg7Cj4+Cj4+ICAgCS8qIEV4ZWNsaXN0cyAqLwo+PiAtCWJvb2wgcmNzX2luaXRpYWxpemVk Owo+PiAgIAlzdHJ1Y3Qgewo+PiAgIAkJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKnN0YXRl Owo+PiAgIAkJc3RydWN0IGludGVsX3JpbmdidWZmZXIgKnJpbmdidWY7Cj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYwo+PiBpbmRleCA3MzI5M2I0Li5lYjdjMWYyIDEwMDY0NAo+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMKPj4gQEAgLTQ2MDMsMTQgKzQ2MDMsOCBAQCBpbnQgaTkxNV9nZW1faW5pdF9y aW5ncyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgIAkJCWdvdG8gY2xlYW51cF92ZWJveF9y aW5nOwo+PiAgIAl9Cj4+Cj4+IC0JcmV0ID0gaTkxNV9nZW1fc2V0X3NlcW5vKGRldiwgKCh1MzIp fjAgLSAweDEwMDApKTsKPj4gLQlpZiAocmV0KQo+PiAtCQlnb3RvIGNsZWFudXBfYnNkMl9yaW5n Owo+PiAtCj4+ICAgCXJldHVybiAwOwo+Pgo+PiAtY2xlYW51cF9ic2QyX3Jpbmc6Cj4+IC0JaW50 ZWxfY2xlYW51cF9yaW5nX2J1ZmZlcigmZGV2X3ByaXYtPnJpbmdbVkNTMl0pOwo+PiAgIGNsZWFu dXBfdmVib3hfcmluZzoKPj4gICAJaW50ZWxfY2xlYW51cF9yaW5nX2J1ZmZlcigmZGV2X3ByaXYt PnJpbmdbVkVDU10pOwo+PiAgIGNsZWFudXBfYmx0X3Jpbmc6Cj4+IEBAIC00NjI5LDYgKzQ2MjMs NyBAQCBpOTE1X2dlbV9pbml0X2h3KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAgCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+ICAgCXN0 cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmc7Cj4+ICAgCWludCByZXQsIGksIGo7Cj4+ICsJc3Ry dWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXE7Cj4+Cj4+ICAgCWlmIChJTlRFTF9JTkZPKGRl diktPmdlbiA8IDYgJiYgIWludGVsX2VuYWJsZV9ndHQoKSkKPj4gICAJCXJldHVybiAtRUlPOwo+ PiBAQCAtNDY4MCw5ICs0Njc1LDEyIEBAIGk5MTVfZ2VtX2luaXRfaHcoc3RydWN0IGRybV9kZXZp Y2UgKmRldikKPj4gICAJCQlnb3RvIG91dDsKPj4gICAJfQo+Pgo+PiArCXJldCA9IGk5MTVfZ2Vt X3NldF9zZXFubyhkZXYsIGRldl9wcml2LT5uZXh0X3NlcW5vKTsKPj4gKwlpZiAocmV0KQo+PiAr CQlnb3RvIG91dDsKPgo+IFRoZSBvbmx5IHJlYXNvbiB0byBkbyB0aGlzIHdvdWxkIGJlIHRvIGVu c3VyZSB0aGF0IHRoZSBjb250ZW50cyBvZiB0aGUKPiByZWdpc3RlcnMgYXJlIHZhbGlkIChhc3N1 bWluZyB3ZSB0YWtlIG92ZXIgZnJvbSBvdXJzZWx2ZXMpLiBUaGUgcmlnaHQKPiB2YWx1ZSB0byB1 c2UgdGhlbiBpcyBsYXN0X3NlcW5vLgppOTE1X2dlbV9zZXRfc2Vxbm8gdXNlcyB0aGUgZm9sbG93 aW5nIGNvZGU6CglyZXQgPSBpOTE1X2dlbV9pbml0X3NlcW5vKGRldiwgc2Vxbm8gLSAxKTsKLi4u Li4uCglkZXZfcHJpdi0+bmV4dF9zZXFubyA9IHNlcW5vOwoJZGV2X3ByaXYtPmxhc3Rfc2Vxbm8g PSBzZXFubyAtIDE7CgpTbyB1c2luZyBsYXN0X3NlcW5vIHdvdWxkIHJld2luZCB0aGUgc2Vxbm8g Ynkgb25lLi4uCj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X2V4ZWNidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIu Ywo+PiBpbmRleCA5MjNhM2M0Li45NWYxYTBkIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4+IEBAIC05OTQsNiArOTk0LDcgQEAgaTkxNV9nZW1f dmFsaWRhdGVfY29udGV4dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGUsCj4+ICAgewo+PiAgIAlzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY3R4ID0gTlVMTDsKPj4g ICAJc3RydWN0IGk5MTVfY3R4X2hhbmdfc3RhdHMgKmhzOwo+PiArCWludCByZXQ7Cj4+Cj4+ICAg CWlmIChyaW5nLT5pZCAhPSBSQ1MgJiYgY3R4X2lkICE9IERFRkFVTFRfQ09OVEVYVF9IQU5ETEUp Cj4+ICAgCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPj4gQEAgLTEwMDksNyArMTAxMCw3IEBA IGk5MTVfZ2VtX3ZhbGlkYXRlX2NvbnRleHQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0 IGRybV9maWxlICpmaWxlLAo+PiAgIAl9Cj4+Cj4+ICAgCWlmIChpOTE1LmVuYWJsZV9leGVjbGlz dHMgJiYgIWN0eC0+ZW5naW5lW3JpbmctPmlkXS5zdGF0ZSkgewo+PiAtCQlpbnQgcmV0ID0gaW50 ZWxfbHJfY29udGV4dF9kZWZlcnJlZF9jcmVhdGUoY3R4LCByaW5nKTsKPj4gKwkJcmV0ID0gaW50 ZWxfbHJfY29udGV4dF9kZWZlcnJlZF9hbGxvYyhjdHgsIHJpbmcpOwo+PiAgIAkJaWYgKHJldCkg ewo+PiAgIAkJCURSTV9ERUJVRygiQ291bGQgbm90IGNyZWF0ZSBMUkMgJXU6ICVkXG4iLCBjdHhf aWQsIHJldCk7Cj4+ICAgCQkJcmV0dXJuIEVSUl9QVFIocmV0KTsKPgo+IFN0aWxsIG1vZGlmeWlu ZyB0aGlzIGZvciBubyByZWFzb24sIGFuZCB5b3Ugc3RpbGwgaGF2ZW4ndCByZWFsaXNlZCB0aGlz Cj4gY2FsbCBpcyByZWR1bmRhbnQgKGhpbnQgdGhlcmUgaXMgYWxyZWFkeSBhIGhvb2sgaW4gYWxs b2NfcmVxdWVzdCkuCj4KPiAgRnJvbSBsYXN0IHllYXI6Cj4gaHR0cDovL2NnaXQuZnJlZWRlc2t0 b3Aub3JnL35pY2tsZS9saW51eC0yLjYvY29tbWl0Lz9pZD0zN2ZiZDM3MDE1MjIxMTY4OGJjNWJj ZTNkMjhkMTMyMzNjZmU3ZDhiCj4KPiBNb3JlIHJlY2VudCAoaS5lIGEgY291cGxlIG9mIG1vbnRo cyBhZ28pOgo+IGh0dHA6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+aWNrbGUvbGludXgtMi42L2Nv bW1pdC8/aD1uaWdodGx5JmlkPWJhNDk1MGE4ZjQ4OWQ1NGVjNDg5OGY5NGRhZDQ0ZjllYzEzMzAx ZDIKPiAtQ2hyaXMKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK