From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sivakumar Thulasimani Subject: Re: [PATCH 1/3] drm/i915: read sink_count dpcd always Date: Wed, 26 Aug 2015 15:37:28 +0530 Message-ID: <55DD8FE0.5090709@intel.com> References: <1440503438-13470-1-git-send-email-sivakumar.thulasimani@intel.com> <1440503438-13470-2-git-send-email-sivakumar.thulasimani@intel.com> <87fv368jpa.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id A0AAB6E995 for ; Wed, 26 Aug 2015 03:07:54 -0700 (PDT) In-Reply-To: <87fv368jpa.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiA4LzI2LzIwMTUgMzoxNyBQTSwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gT24gVHVlLCAyNSBB dWcgMjAxNSwgU2l2YWt1bWFyIFRodWxhc2ltYW5pIDxzaXZha3VtYXIudGh1bGFzaW1hbmlAaW50 ZWwuY29tPiB3cm90ZToKPj4gRnJvbTogIlRodWxhc2ltYW5pLFNpdmFrdW1hciIgPHNpdmFrdW1h ci50aHVsYXNpbWFuaUBpbnRlbC5jb20+Cj4+Cj4+IFRoaXMgcGF0Y2ggcmVhZHMgc2lua19jb3Vu dCBkcGNkIGFsd2F5cyBhbmQgcmVtb3ZlcyBpdHMKPj4gcmVhZCBvcGVyYXRpb24gYmFzZWQgb24g dmFsdWVzIGluIGRvd25zdHJlYW0gcG9ydCBkcGNkLiBBbHNvCj4+IHdlIHNob3VsZCByZWFkIGl0 IGlycmVzcGVjdGl2ZSBvZiBjdXJyZW50IHN0YXR1cyBvZiBzaW5rLgo+IEhhdmluZyB0byB3cml0 ZSAiYWxzbyIgaW4gYSBjb21taXQgbWVzc2FnZSBpcyBhIGdvb2QgaGludCB0byBzdG9wIGFuZAo+ IHRoaW5rIGFib3V0IHdoZXRoZXIgdGhhdCBzaG91bGQgYmUgYSBzZXBhcmF0ZSBwYXRjaC4gTWF5 YmUgaXQgc2hvdWxkIGJlLAo+IGhlcmUgdG9vPwo+Cj4gQlIsCj4gSmFuaS4KOikgaSB0aG91Z2h0 IGFib3V0IGl0IHNpbmNlIHRoYXQgcGFydCBvZiB0aGUgbWVzc2FnZSB3YXMgYWRkZWQgbGFzdCwg c2luY2UKd2l0aG91dCB0aG9zZSBjaGFuZ2VzIHRoaXMgcGF0Y2ggd2lsbCBub3QgYmUgInJlYWQg c2lua19jb3VudCBhbHdheXMiLgoKd2lsbCBzcGxpdCBpdCBpbnRvIHR3byBwYXRjaGVzIGFuZCBy ZW5hbWUgdGhlbSBhY2NvcmRpbmdseS4KPj4gU0lOS19DT1VOVCBkcGNkIGlzIG5vdCBkZXBlbmRl bnQgb24gRE9XTlNUUkVBTV9QT1JUX1BSRVNFTlQgZHBjZC4KPj4gU0lOS19DT1VOVCBkZW5vdGVz IGlmIGEgZGlzcGxheSBpcyBhdHRhY2hlZCwgd2hpbGUKPj4gRE9XTlNUUkVBTV9QT1JUX1BSRVNF VCBpbmRpY2F0ZXMgaG93IG1hbnkgcG9ydHMgYXJlIGF2YWlsYWJsZQo+PiBpbiB0aGUgZG9uZ2xl IHdoZXJlIGRpc3BsYXkgY2FuIGJlIGF0dGFjaGVkLiBzbyBpdCBpcyBwb3NzaWJsZQo+PiBmb3Ig c2luayBjb3VudCB0byBjaGFuZ2UgaXJyZXNwZWN0aXZlIG9mIHZhbHVlIGluIGRvd25zdHJlYW0K Pj4gcG9ydCBkcGNkLgo+Pgo+PiBIZXJlIGlzIGEgdGFibGUgb2YgcG9zc2libGUgdmFsdWVzIGFu ZCBzY2VuYXJpb3MKPj4KPj4gc2lua19jb3VudAlkb3duc3RyZWFtX3BvcnQKPj4gCQlwcmVzZW50 Cj4+IDAJCTAJCW5vIGRpc3BsYXkgaXMgYXR0YWNoZWQKPj4gMAkJMQkJZG9uZ2xlIGlzIGNvbm5l Y3RlZCB3aXRob3V0IGRpc3BsYXkKPj4gMQkJMAkJZGlzcGxheSBjb25uZWN0ZWQgZGlyZWN0bHkK Pj4gMQkJMQkJZGlzcGxheSBjb25uZWN0ZWQgdGhyb3VnaCBkb25nbGUKPj4KPj4gU2lnbmVkLW9m Zi1ieTogU2l2YWt1bWFyIFRodWxhc2ltYW5pIDxzaXZha3VtYXIudGh1bGFzaW1hbmlAaW50ZWwu Y29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgICAzMyAr KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMTQg aW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAu Ywo+PiBpbmRleCA4YTY2YTQ0Li45ZTRlMjdkIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMKPj4gQEAgLTM4OTgsNiArMzg5OCw3IEBAIGludGVsX2RwX2dldF9kcGNkKHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHApCj4+ICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkaWdfcG9ydC0+ YmFzZS5iYXNlLmRldjsKPj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g ZGV2LT5kZXZfcHJpdmF0ZTsKPj4gICAJdWludDhfdCByZXY7Cj4+ICsJdWludDhfdCByZWc7Cj4+ ICAgCj4+ICAgCWlmIChpbnRlbF9kcF9kcGNkX3JlYWRfd2FrZSgmaW50ZWxfZHAtPmF1eCwgMHgw MDAsIGludGVsX2RwLT5kcGNkLAo+PiAgIAkJCQkgICAgc2l6ZW9mKGludGVsX2RwLT5kcGNkKSkg PCAwKQo+PiBAQCAtMzkwOCw2ICszOTA5LDEzIEBAIGludGVsX2RwX2dldF9kcGNkKHN0cnVjdCBp bnRlbF9kcCAqaW50ZWxfZHApCj4+ICAgCWlmIChpbnRlbF9kcC0+ZHBjZFtEUF9EUENEX1JFVl0g PT0gMCkKPj4gICAJCXJldHVybiBmYWxzZTsgLyogRFBDRCBub3QgcHJlc2VudCAqLwo+PiAgIAo+ PiArCWlmIChpbnRlbF9kcF9kcGNkX3JlYWRfd2FrZSgmaW50ZWxfZHAtPmF1eCwgRFBfU0lOS19D T1VOVCwKPj4gKwkJCQkJICAgICZyZWcsIDEpIDwgMCkKPj4gKwkJCXJldHVybiBmYWxzZTsKPj4g Kwo+PiArCWlmICghRFBfR0VUX1NJTktfQ09VTlQocmVnKSkKPj4gKwkJcmV0dXJuIGZhbHNlOwo+ PiArCj4+ICAgCS8qIENoZWNrIGlmIHRoZSBwYW5lbCBzdXBwb3J0cyBQU1IgKi8KPj4gICAJbWVt c2V0KGludGVsX2RwLT5wc3JfZHBjZCwgMCwgc2l6ZW9mKGludGVsX2RwLT5wc3JfZHBjZCkpOwo+ PiAgIAlpZiAoaXNfZWRwKGludGVsX2RwKSkgewo+PiBAQCAtNDM3NCwxMiArNDM4Miw2IEBAIGlu dGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4+ICAg Cj4+ICAgCVdBUk5fT04oIWRybV9tb2Rlc2V0X2lzX2xvY2tlZCgmZGV2LT5tb2RlX2NvbmZpZy5j b25uZWN0aW9uX211dGV4KSk7Cj4+ICAgCj4+IC0JaWYgKCFpbnRlbF9lbmNvZGVyLT5iYXNlLmNy dGMpCj4+IC0JCXJldHVybjsKPj4gLQo+PiAtCWlmICghdG9faW50ZWxfY3J0YyhpbnRlbF9lbmNv ZGVyLT5iYXNlLmNydGMpLT5hY3RpdmUpCj4+IC0JCXJldHVybjsKPj4gLQo+PiAgIAkvKiBUcnkg dG8gcmVhZCByZWNlaXZlciBzdGF0dXMgaWYgdGhlIGxpbmsgYXBwZWFycyB0byBiZSB1cCAqLwo+ PiAgIAlpZiAoIWludGVsX2RwX2dldF9saW5rX3N0YXR1cyhpbnRlbF9kcCwgbGlua19zdGF0dXMp KSB7Cj4+ICAgCQlyZXR1cm47Cj4+IEBAIC00MzkwLDYgKzQzOTIsMTIgQEAgaW50ZWxfZHBfY2hl Y2tfbGlua19zdGF0dXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPj4gICAJCXJldHVybjsK Pj4gICAJfQo+PiAgIAo+PiArCWlmICghaW50ZWxfZW5jb2Rlci0+YmFzZS5jcnRjKQo+PiArCQly ZXR1cm47Cj4+ICsKPj4gKwlpZiAoIXRvX2ludGVsX2NydGMoaW50ZWxfZW5jb2Rlci0+YmFzZS5j cnRjKS0+YWN0aXZlKQo+PiArCQlyZXR1cm47Cj4+ICsKPj4gICAJLyogVHJ5IHRvIHJlYWQgdGhl IHNvdXJjZSBvZiB0aGUgaW50ZXJydXB0ICovCj4+ICAgCWlmIChpbnRlbF9kcC0+ZHBjZFtEUF9E UENEX1JFVl0gPj0gMHgxMSAmJgo+PiAgIAkgICAgaW50ZWxfZHBfZ2V0X3NpbmtfaXJxKGludGVs X2RwLCAmc2lua19pcnFfdmVjdG9yKSkgewo+PiBAQCAtNDQyNywxOSArNDQzNSw2IEBAIGludGVs X2RwX2RldGVjdF9kcGNkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4+ICAgCWlmICghKGRw Y2RbRFBfRE9XTlNUUkVBTVBPUlRfUFJFU0VOVF0gJiBEUF9EV05fU1RSTV9QT1JUX1BSRVNFTlQp KQo+PiAgIAkJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkOwo+PiAgIAo+PiAtCS8q IElmIHdlJ3JlIEhQRC1hd2FyZSwgU0lOS19DT1VOVCBjaGFuZ2VzIGR5bmFtaWNhbGx5ICovCj4+ IC0JaWYgKGludGVsX2RwLT5kcGNkW0RQX0RQQ0RfUkVWXSA+PSAweDExICYmCj4+IC0JICAgIGlu dGVsX2RwLT5kb3duc3RyZWFtX3BvcnRzWzBdICYgRFBfRFNfUE9SVF9IUEQpIHsKPj4gLQkJdWlu dDhfdCByZWc7Cj4+IC0KPj4gLQkJaWYgKGludGVsX2RwX2RwY2RfcmVhZF93YWtlKCZpbnRlbF9k cC0+YXV4LCBEUF9TSU5LX0NPVU5ULAo+PiAtCQkJCQkgICAgJnJlZywgMSkgPCAwKQo+PiAtCQkJ cmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNfdW5rbm93bjsKPj4gLQo+PiAtCQlyZXR1cm4gRFBfR0VU X1NJTktfQ09VTlQocmVnKSA/IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkCj4+IC0JCQkJCSAg ICAgIDogY29ubmVjdG9yX3N0YXR1c19kaXNjb25uZWN0ZWQ7Cj4+IC0JfQo+PiAtCj4+ICAgCS8q IElmIG5vIEhQRCwgcG9rZSBEREMgZ2VudGx5ICovCj4+ICAgCWlmIChkcm1fcHJvYmVfZGRjKCZp bnRlbF9kcC0+YXV4LmRkYykpCj4+ICAgCQlyZXR1cm4gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0 ZWQ7Cj4+IC0tIAo+PiAxLjcuOS41Cj4+CgotLSAKcmVnYXJkcywKU2l2YWt1bWFyCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=