* [PATCH] doc: drm: Fix mis-spelling of i915_guc_submission includes
@ 2015-08-24 13:41 Graham Whaley
2015-08-25 9:24 ` Daniel Vetter
2015-08-27 18:15 ` Dave Gordon
0 siblings, 2 replies; 3+ messages in thread
From: Graham Whaley @ 2015-08-24 13:41 UTC (permalink / raw)
To: daniel.vetter, jani.nikula, intel-gfx, dri-devel; +Cc: Graham Whaley
In commit
d1675198e: drm/i915: Integrate GuC-based command submission
the drm.tmpl include lines reference the intel_guc_submission.c but the
patch adds the file i915_guc_submission.c. drm.tmpl fails to build with:
docproc: .//drivers/gpu/drm/i915/intel_guc_submission.c:
No such file or directory
Change the file reference to the actual file.
Signed-off-by: Graham Whaley <graham.whaley@linux.intel.com>
---
This looks/feels like the right fix to me, but I am not intimate enough
with the APIs to verify for sure - some confirmation would be good.
Documentation/DocBook/drm.tmpl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index a01fca9..66bc646 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -4160,8 +4160,8 @@ int num_ioctls;</synopsis>
</sect2>
<sect2>
<title>GuC Client</title>
-!Pdrivers/gpu/drm/i915/intel_guc_submission.c GuC-based command submissison
-!Idrivers/gpu/drm/i915/intel_guc_submission.c
+!Pdrivers/gpu/drm/i915/i915_guc_submission.c GuC-based command submissison
+!Idrivers/gpu/drm/i915/i915_guc_submission.c
</sect2>
</sect1>
--
2.4.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: drm: Fix mis-spelling of i915_guc_submission includes
2015-08-24 13:41 [PATCH] doc: drm: Fix mis-spelling of i915_guc_submission includes Graham Whaley
@ 2015-08-25 9:24 ` Daniel Vetter
2015-08-27 18:15 ` Dave Gordon
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2015-08-25 9:24 UTC (permalink / raw)
To: Graham Whaley; +Cc: daniel.vetter, intel-gfx, dri-devel
On Mon, Aug 24, 2015 at 02:41:21PM +0100, Graham Whaley wrote:
> In commit
> d1675198e: drm/i915: Integrate GuC-based command submission
>
> the drm.tmpl include lines reference the intel_guc_submission.c but the
> patch adds the file i915_guc_submission.c. drm.tmpl fails to build with:
> docproc: .//drivers/gpu/drm/i915/intel_guc_submission.c:
> No such file or directory
>
> Change the file reference to the actual file.
>
> Signed-off-by: Graham Whaley <graham.whaley@linux.intel.com>
Applied to drm-intel-next-queued, thanks.
-Daniel
> ---
> This looks/feels like the right fix to me, but I am not intimate enough
> with the APIs to verify for sure - some confirmation would be good.
>
> Documentation/DocBook/drm.tmpl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index a01fca9..66bc646 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -4160,8 +4160,8 @@ int num_ioctls;</synopsis>
> </sect2>
> <sect2>
> <title>GuC Client</title>
> -!Pdrivers/gpu/drm/i915/intel_guc_submission.c GuC-based command submissison
> -!Idrivers/gpu/drm/i915/intel_guc_submission.c
> +!Pdrivers/gpu/drm/i915/i915_guc_submission.c GuC-based command submissison
> +!Idrivers/gpu/drm/i915/i915_guc_submission.c
> </sect2>
> </sect1>
>
> --
> 2.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: drm: Fix mis-spelling of i915_guc_submission includes
2015-08-24 13:41 [PATCH] doc: drm: Fix mis-spelling of i915_guc_submission includes Graham Whaley
2015-08-25 9:24 ` Daniel Vetter
@ 2015-08-27 18:15 ` Dave Gordon
1 sibling, 0 replies; 3+ messages in thread
From: Dave Gordon @ 2015-08-27 18:15 UTC (permalink / raw)
To: intel-gfx
On 24/08/15 14:41, Graham Whaley wrote:
> In commit
> d1675198e: drm/i915: Integrate GuC-based command submission
>
> the drm.tmpl include lines reference the intel_guc_submission.c but the
> patch adds the file i915_guc_submission.c. drm.tmpl fails to build with:
> docproc: .//drivers/gpu/drm/i915/intel_guc_submission.c:
> No such file or directory
>
> Change the file reference to the actual file.
>
> Signed-off-by: Graham Whaley <graham.whaley@linux.intel.com>
> ---
> This looks/feels like the right fix to me, but I am not intimate enough
> with the APIs to verify for sure - some confirmation would be good.
>
> Documentation/DocBook/drm.tmpl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index a01fca9..66bc646 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -4160,8 +4160,8 @@ int num_ioctls;</synopsis>
> </sect2>
> <sect2>
> <title>GuC Client</title>
> -!Pdrivers/gpu/drm/i915/intel_guc_submission.c GuC-based command submissison
> -!Idrivers/gpu/drm/i915/intel_guc_submission.c
> +!Pdrivers/gpu/drm/i915/i915_guc_submission.c GuC-based command submissison
> +!Idrivers/gpu/drm/i915/i915_guc_submission.c
> </sect2>
> </sect1>
Yes, that file got renamed late in development, and obviously the
drm.tmpl entry wasn't updated to match.
Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-27 18:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-24 13:41 [PATCH] doc: drm: Fix mis-spelling of i915_guc_submission includes Graham Whaley
2015-08-25 9:24 ` Daniel Vetter
2015-08-27 18:15 ` Dave Gordon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).