From: Arun Siluvery <arun.siluvery@linux.intel.com>
To: Michel Thierry <michel.thierry@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: WaEnableForceRestoreInCtxtDescForVCS is for video engines only
Date: Thu, 10 Sep 2015 18:34:48 +0100 [thread overview]
Message-ID: <55F1BF38.4040809@linux.intel.com> (raw)
In-Reply-To: <1441367955-22006-1-git-send-email-michel.thierry@intel.com>
On 04/09/2015 12:59, Michel Thierry wrote:
> Also check for correct revision id in each Gen9 platform (SKL until B0
> and BXT until A0).
>
> Cc: Nick Hoath <nicholas.hoath@intel.com>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 28a712e..d8b605f 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -301,10 +301,10 @@ uint64_t intel_lr_context_descriptor(struct intel_context *ctx,
> /* desc |= GEN8_CTX_FORCE_RESTORE; */
>
> /* WaEnableForceRestoreInCtxtDescForVCS:skl */
> - if (IS_GEN9(dev) &&
> - INTEL_REVID(dev) <= SKL_REVID_B0 &&
> - (ring->id == BCS || ring->id == VCS ||
> - ring->id == VECS || ring->id == VCS2))
> + /* WaEnableForceRestoreInCtxtDescForVCS:bxt */
> + if (((IS_SKYLAKE(dev) && INTEL_REVID(dev) <= SKL_REVID_B0) ||
> + (IS_BROXTON(dev) && INTEL_REVID(dev) == BXT_REVID_A0)) &&
> + (ring->id == VCS || ring->id == VCS2))
> desc |= GEN8_CTX_FORCE_RESTORE;
>
> return desc;
>
Maybe we can drop SKL as they are early revisions? even if we choose to
retain it looks good to me,
Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com>
regards
Arun
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-10 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 11:59 [PATCH 1/2] drm/i915: WaEnableForceRestoreInCtxtDescForVCS is for video engines only Michel Thierry
2015-09-04 11:59 ` [PATCH 2/2] drm/i915/lrc: Prevent preemption when lite-restore is disabled Michel Thierry
2015-09-04 16:15 ` Daniele Ceraolo Spurio
2015-09-10 17:37 ` Arun Siluvery
2015-09-14 8:25 ` Daniel Vetter
2015-09-10 17:34 ` Arun Siluvery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F1BF38.4040809@linux.intel.com \
--to=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel.thierry@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox