public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 5/5] drm/i915: skip modeset if compatible for everyone.
Date: Thu, 10 Sep 2015 12:31:33 -0700	[thread overview]
Message-ID: <55F1DA95.20701@virtuousgeek.org> (raw)
In-Reply-To: <1440683046-27110-6-git-send-email-maarten.lankhorst@linux.intel.com>

On 08/27/2015 06:44 AM, Maarten Lankhorst wrote:
> This is done as a separate commit, to make it easier to revert
> when things break.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h      | 1 -
>  drivers/gpu/drm/i915/i915_params.c   | 5 -----
>  drivers/gpu/drm/i915/intel_display.c | 3 +--
>  3 files changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 61244455347f..c75d343ff26b 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2628,7 +2628,6 @@ struct i915_params {
>  	int enable_cmd_parser;
>  	/* leave bools at the end to not create holes */
>  	bool enable_hangcheck;
> -	bool fastboot;
>  	bool prefault_disable;
>  	bool load_detect_test;
>  	bool reset;
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 5ae4b0aba564..47d41da9d942 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -40,7 +40,6 @@ struct i915_params i915 __read_mostly = {
>  	.preliminary_hw_support = IS_ENABLED(CONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT),
>  	.disable_power_well = 1,
>  	.enable_ips = 1,
> -	.fastboot = 0,
>  	.prefault_disable = 0,
>  	.load_detect_test = 0,
>  	.reset = true,
> @@ -132,10 +131,6 @@ MODULE_PARM_DESC(disable_power_well,
>  module_param_named(enable_ips, i915.enable_ips, int, 0600);
>  MODULE_PARM_DESC(enable_ips, "Enable IPS (default: true)");
>  
> -module_param_named(fastboot, i915.fastboot, bool, 0600);
> -MODULE_PARM_DESC(fastboot,
> -	"Try to skip unnecessary mode sets at boot time (default: false)");
> -
>  module_param_named_unsafe(prefault_disable, i915.prefault_disable, bool, 0600);
>  MODULE_PARM_DESC(prefault_disable,
>  	"Disable page prefaulting for pread/pwrite/reloc (default:false). "
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index d3874a68cdb9..b4fb5dec2e38 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13035,8 +13035,7 @@ static int intel_atomic_check(struct drm_device *dev,
>  		if (ret)
>  			return ret;
>  
> -		if (i915.fastboot &&
> -		    intel_pipe_config_compare(state->dev,
> +		if (intel_pipe_config_compare(state->dev,
>  					to_intel_crtc_state(crtc->state),
>  					pipe_config, true)) {
>  			crtc_state->mode_changed = false;
> 

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Now we just need to test it everywhere...
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-09-10 19:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 13:44 [PATCH v2 0/5] Faster modeset support Maarten Lankhorst
2015-08-27 13:44 ` [PATCH v2 1/5] drm/i915: Set csc coefficients in update_pipe_size Maarten Lankhorst
2015-09-10 19:25   ` Jesse Barnes
2015-09-10 19:27     ` Jesse Barnes
2015-08-27 13:44 ` [PATCH v2 2/5] drm/i915: Remove references to crtc->active from intel_fbdev.c Maarten Lankhorst
2015-09-10 19:26   ` Jesse Barnes
2015-08-27 13:44 ` [PATCH v2 3/5] drm/i915: Always try to inherit the initial fb Maarten Lankhorst
2015-09-10 19:26   ` Jesse Barnes
2015-08-27 13:44 ` [PATCH v2 4/5] drm/i915: Make updating pipe without modeset atomic Maarten Lankhorst
2015-08-27 13:58   ` Ville Syrjälä
2015-08-27 14:06     ` Maarten Lankhorst
2015-08-27 14:33       ` Ville Syrjälä
2015-09-10 19:31   ` Jesse Barnes
2015-09-14  8:05     ` Daniel Vetter
2015-08-27 13:44 ` [PATCH v2 5/5] drm/i915: skip modeset if compatible for everyone Maarten Lankhorst
2015-08-29 23:57   ` shuang.he
2015-09-10 19:31   ` Jesse Barnes [this message]
2015-09-14  8:08     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F1DA95.20701@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox