From: "Kamble, Sagar A" <sagar.a.kamble@intel.com>
To: "O'Rourke, Tom" <Tom.O'Rourke@intel.com>, akash.goel@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915/bxt: WaGsvDisableTurbo
Date: Fri, 11 Sep 2015 17:54:50 +0530 [thread overview]
Message-ID: <55F2C812.4000804@intel.com> (raw)
In-Reply-To: <55F2735E.2080608@intel.com>
Hi Tom, Akash
Kindly review this patch.
Thanks
Sagar
On 9/11/2015 11:53 AM, Kamble, Sagar A wrote:
> Gentle reminder for review.
>
> Thanks
> Sagar
>
> On 8/23/2015 5:52 PM, Sagar Arun Kamble wrote:
>> Disable Turbo on steppings prior to B0 on BXT due to hangs seen
>> during GT CPD exit.
>>
>> Change-Id: I50c5c03f59f5ba092db19e17234951d89db42c6c
>> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_pm.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c
>> b/drivers/gpu/drm/i915/intel_pm.c
>> index fff0c22..75f1c8c 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -4450,6 +4450,10 @@ static void gen6_set_rps(struct drm_device
>> *dev, u8 val)
>> {
>> struct drm_i915_private *dev_priv = dev->dev_private;
>> + /* WaGsvDisableTurbo: Workaround to disable turbo on BXT A* */
>> + if (IS_BROXTON(dev) && (INTEL_REVID(dev) < BXT_REVID_B0))
>> + return;
>> +
>> WARN_ON(!mutex_is_locked(&dev_priv->rps.hw_lock));
>> WARN_ON(val > dev_priv->rps.max_freq);
>> WARN_ON(val < dev_priv->rps.min_freq);
>> @@ -4770,6 +4774,12 @@ static void gen9_enable_rps(struct drm_device
>> *dev)
>> gen6_init_rps_frequencies(dev);
>> + /* WaGsvDisableTurbo: Workaround to disable turbo on BXT A* */
>> + if (IS_BROXTON(dev) && (INTEL_REVID(dev) < BXT_REVID_B0)) {
>> + intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL);
>> + return;
>> + }
>> +
>> /* Program defaults and thresholds for RPS*/
>> I915_WRITE(GEN6_RC_VIDEO_FREQ,
>> GEN9_FREQUENCY(dev_priv->rps.rp1_freq));
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-11 12:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 12:22 [PATCH 0/5] RC6/Forcewake/Turbo related changes for Gen9 Sagar Arun Kamble
2015-08-23 12:22 ` [PATCH 1/5] drm/i915: Increase maximum polling time to 50ms for forcewake request/clear ack Sagar Arun Kamble
2015-08-26 9:26 ` Daniel Vetter
2015-09-22 9:06 ` Tvrtko Ursulin
2015-09-22 9:15 ` Chris Wilson
2015-09-22 9:48 ` Tvrtko Ursulin
2015-09-21 16:43 ` Yu Dai
2015-09-23 8:04 ` Daniel Vetter
2015-08-23 12:22 ` [PATCH 2/5] drm/i915/bxt: WaGsvDisableTurbo Sagar Arun Kamble
2015-09-11 6:23 ` Kamble, Sagar A
2015-09-11 12:24 ` Kamble, Sagar A [this message]
2015-09-21 16:43 ` Yu Dai
2015-09-23 7:46 ` Daniel Vetter
2015-08-23 12:22 ` [PATCH 3/5] drm/i915: WaRsDisableCoarsePowerGating Sagar Arun Kamble
2015-09-11 6:22 ` Kamble, Sagar A
2015-09-11 9:11 ` [PATCH 1/2] drm/i915: Add IS_SKL_GT3 and IS_SKL_GT4 macro Sagar Arun Kamble
2015-09-11 9:11 ` [PATCH 2/2] drm/i915: WaRsDisableCoarsePowerGating Sagar Arun Kamble
2015-09-11 11:46 ` [PATCH v2 1/1] " Sagar Arun Kamble
2015-09-21 16:43 ` [PATCH 3/5] " Yu Dai
2015-09-23 7:47 ` Daniel Vetter
2015-08-23 12:22 ` [PATCH 4/5] drm/i915: Use only blitter forcewake Sagar Arun Kamble
2015-08-23 12:30 ` Chris Wilson
2015-09-11 13:23 ` Kamble, Sagar A
2015-09-11 13:37 ` Ville Syrjälä
2015-09-11 13:54 ` Kamble, Sagar A
2015-09-11 14:02 ` Ville Syrjälä
2015-09-12 18:15 ` Kamble, Sagar A
2015-08-23 12:22 ` [PATCH 5/5] drm/i915: Notify Coarse Power Gating changes to GuC Sagar Arun Kamble
2015-08-27 19:55 ` O'Rourke, Tom
2015-09-11 6:16 ` Kamble, Sagar A
2015-09-11 17:17 ` Yu Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F2C812.4000804@intel.com \
--to=sagar.a.kamble@intel.com \
--cc=Tom.O'Rourke@intel.com \
--cc=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox