From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kamble, Sagar A" Subject: Re: [PATCH 4/5] drm/i915: Use only blitter forcewake Date: Fri, 11 Sep 2015 18:53:26 +0530 Message-ID: <55F2D5CE.20906@intel.com> References: <1440332571-20761-1-git-send-email-sagar.a.kamble@intel.com> <1440332571-20761-5-git-send-email-sagar.a.kamble@intel.com> <20150823123012.GA25712@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0023665081==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BF8F6E441 for ; Fri, 11 Sep 2015 06:23:30 -0700 (PDT) In-Reply-To: <20150823123012.GA25712@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.orgchris@chris-wilson.co.uk Cc: akash.goel@intel.com List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============0023665081== Content-Type: multipart/alternative; boundary="------------030107070208070501020407" This is a multi-part message in MIME format. --------------030107070208070501020407 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Thanks Chris. Domain refcount tracking is not common single function. its present in __force_wake_get, __intel_uncore_forcewake_get and likewise for put functions. Either we will have to bring them together in fw_domains_get and then add change you have suggested Or Prepare WA version of __force_wake_get and __intel_uncore_forcewake_get Or approach in the current patch where we only init blitter domain. This will work from __intel_uncore_forcewake_get as well as it filters domains based on dev_priv->uncore.fw_domains. Let me know which approach looks good. On 8/23/2015 6:00 PM, Chris Wilson wrote: > On Sun, Aug 23, 2015 at 05:52:50PM +0530, Sagar Arun Kamble wrote: >> Coarse power gating is disabled prior to BXT B0 and till SKL E0, >> hence even for render and media well registers blitter forcewake request >> need to be used. > Just insert a custom force_wake_get/put for the w/a. > > Something like > > gen9_force_wake_get_wa() > { > return fw_domains_get(BLITTER); > } > > The fw counting will make it work just fine. > -Chris > --------------030107070208070501020407 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit Thanks Chris.

Domain refcount tracking is not common single function.
its present in __force_wake_get, __intel_uncore_forcewake_get and likewise for put functions.

Either we will have to bring them together in fw_domains_get and then add change you have suggested
Or
Prepare WA version of __force_wake_get and __intel_uncore_forcewake_get
Or
approach in the current patch where we only init blitter domain.
This will work from __intel_uncore_forcewake_get as well as it filters domains based on dev_priv->uncore.fw_domains.

Let me know which approach looks good.



On 8/23/2015 6:00 PM, Chris Wilson wrote:
On Sun, Aug 23, 2015 at 05:52:50PM +0530, Sagar Arun Kamble wrote:

Coarse power gating is disabled prior to BXT B0 and till SKL E0,
hence even for render and media well registers blitter forcewake request
need to be used.

Just insert a custom force_wake_get/put for the w/a.

Something like

gen9_force_wake_get_wa()
{
	return fw_domains_get(BLITTER);
}

The fw counting will make it work just fine.
-Chris

--------------030107070208070501020407-- --===============0023665081== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0023665081==--