From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: fix crash in error state readout on non-execlist platforms Date: Mon, 14 Sep 2015 17:45:29 +0100 Message-ID: <55F6F9A9.70700@intel.com> References: <1441921209-3430-1-git-send-email-jbarnes@virtuousgeek.org> <55F1FC83.80807@intel.com> <55F1FCFE.9050300@virtuousgeek.org> <55F1FF04.3020107@intel.com> <20150914092139.GU3383@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E1706E261 for ; Mon, 14 Sep 2015 09:45:43 -0700 (PDT) In-Reply-To: <20150914092139.GU3383@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, "Dai, Yu" , "Barnes, Jesse" List-Id: intel-gfx@lists.freedesktop.org T24gMTQvMDkvMTUgMTA6MjEsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gVGh1LCBTZXAgMTAs IDIwMTUgYXQgMDM6MDc6MDBQTSAtMDcwMCwgWXUgRGFpIHdyb3RlOgo+PiBBZ3JlZS4gVGhlIExS QyBwcmVmaXggaXMgY29uZnVzaW5nLiBUaGFua3MgZm9yIHRoZSBwYXRjaC4gLUFsZXgKPgo+IENh cmUgdG8gZG8gYW4gb2ZmaWNpYWwgci1iPwo+Cj4gVGhhbmtzLCBEYW5pZWwKPgo+Pgo+PiBPbiAw OS8xMC8yMDE1IDAyOjU4IFBNLCBKZXNzZSBCYXJuZXMgd3JvdGU6Cj4+PiBUaGF0IGxvb2tzIGxp a2UgaXQgd291bGQsIGJ1dCBJIHRoaW5rIGl0J3Mgc3RpbGwgY29uZnVzaW5nIHRvIHJlZmVyZW5j ZSBMUkMgc3RhdGUgd2hlbiB3ZSBoYXZlbid0IGluaXRpYWxpemVkIGV4ZWNsaXN0cyBhdCBhbGwu Li4KPj4+Cj4+PiBKZXNzZQo+Pj4KPj4+IE9uIDA5LzEwLzIwMTUgMDI6NTYgUE0sIFl1IERhaSB3 cm90ZToKPj4+PiBKZXNzZSwKPj4+Pgo+Pj4+IFdpbGwgdGhlIHBhdGNoIGhlcmUgZml4IHRoZSBp c3N1ZT8gSXQgc2hvdWxkIGhlbHAgb3RoZXIgY2FzZXMgd2hlcmUgTFJDX1BQSFdTUF9QTiBpcyBy ZWZlcmVuY2VkIG9uIG5vbi1leGVjbGlzdCAvIGd1YyBwbGF0Zm9ybXMuCj4+Pj4KPj4+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuaAo+Pj4+IGluZGV4IDRjYzU0YjMuLjIzM2E5MzAgMTAwNjQ0Cj4+ Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmgKPj4+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaAo+Pj4+IEBAIC03MSw3ICs3MSw3IEBAIHN0YXRp YyBpbmxpbmUgdm9pZCBpbnRlbF9sb2dpY2FsX3JpbmdfZW1pdChzdHJ1Y3QgaW50ZWxfcmluZ2J1 ZmZlciAqcmluZ2J1ZiwKPj4+Pgo+Pj4+ICAgLyogT25lIGV4dHJhIHBhZ2UgaXMgYWRkZWQgYmVm b3JlIExSQyBmb3IgR3VDIGFzIHNoYXJlZCBkYXRhICovCj4+Pj4gICAjZGVmaW5lIExSQ19HVUNT SFJfUE4gICgwKQo+Pj4+IC0jZGVmaW5lIExSQ19QUEhXU1BfUE4gIChMUkNfR1VDU0hSX1BOICsg MSkKPj4+PiArI2RlZmluZSBMUkNfUFBIV1NQX1BOICAoTFJDX0dVQ1NIUl9QTiArIGk5MTUuZW5h YmxlX2d1Y19zdWJtaXNzaW9uID8gMSA6IDApCj4+Pj4gICAjZGVmaW5lIExSQ19TVEFURV9QTiAg IChMUkNfUFBIV1NQX1BOICsgMSkKCkkgZG9uJ3QgbGlrZSB0aGlzIGFwcHJvYWNoIG9mIGhpZGlu ZyB0aGUgcnVudGltZSBjb25kaXRpb25hbCBvZmZzZXQgaW4gCnRoZSBtYWNyby4gSSB0aGluayBp dCB3b3VsZCBiZSBiZXR0ZXIgdG8gbGVhdmUgdGhpcyBhbG9uZSBhbmQgdXNlIHRoZSAKdGVjaG5p cXVlIGluIHRoZSBjb2RlIGJlbG93IHdoZXJlIHRoZSAoY29uc3QpIG1hY3JvcyBuYW1lZCAnTFJD XyonIGFyZSAKdXNlZCBvbmx5IGluc2lkZSBjbGF1c2VzIGd1YXJkZWQgYnkgYW4gImlmIChpOTE1 LmVuYWJsZV9leGVjbGlzdHMpIi4gClRoYXQgd2F5IHRoZSBjb2RlIHdvbid0IG1lbnRpb24gdGhl IExSQ18qIHN5bWJvbHMgZXhjZXB0IHdoZXJlIHRoZXkncmUgCmtub3duIHRwIGJlIG1lYW5pbmdm dWwuCgpPZiB0aGVzZSBzeW1ib2xzLCBMUkNfR1VDU0hSX1BOIGlzIG5vdCB1c2VkIGV4Y2VwdCBp biBHdUMtc3BlY2lmaWMgY29kZSwgCmFuZCBMUkNfU1RBVEVfUE4gaXMgdXNlZCBvbmx5IGluIEd1 QyBhbmQvb3IgTFJDIChleGVjbGlzdC1tb2RlKSBzcGVjaWZpYyAKY29kZS4gU28gaXQncyBvbmx5 IExSQ19QUEhXU1BfUE4gdGhhdCBuZWVkcyB0byBiZSB1c2VkIHNlbGVjdGl2ZWx5IAooc3BlY2lm aWNhbGx5LCBhZGRlZCB0byB0aGUgYmFzZSBvZiBhIGNvbnRleHQgb2JqZWN0IHdoZW4gdXNpbmcg ZXhlY2xpc3QgCm1vZGUpLiBBbmQgdGhlIGNvZGUgYmVsb3cgYWxyZWFkeSBhY2NvbXBsaXNoZXMg dGhhdCB3aXRob3V0IGNoYW5naW5nIHRoZSAKbWFjcm8uCgo+Pj4+ICAgdm9pZCBpbnRlbF9scl9j b250ZXh0X2ZyZWUoc3RydWN0IGludGVsX2NvbnRleHQgKmN0eCk7Cj4+Pj4KPj4+PiBUaGFua3Ms Cj4+Pj4gQWxleAo+Pj4+Cj4+Pj4gT24gMDkvMTAvMjAxNSAwMjo0MCBQTSwgSmVzc2UgQmFybmVz IHdyb3RlOgo+Pj4+PiBMb29rcyBsaWtlIHRoaXMgd2FzIGludHJvZHVjZWQgaW46Cj4+Pj4+IGNv bW1pdCBkMTY3NTE5OGVkMWYyMWFlYzZlMDM2MzM2ZTQzNDBjNDBiNzI2NDk3Cj4+Pj4+IEF1dGhv cjogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+Pj4+IERhdGU6ICAgV2VkIEF1ZyAxMiAx NTo0Mzo0MyAyMDE1ICswMTAwCj4+Pj4+Cj4+Pj4+ICAgICAgIGRybS9pOTE1OiBJbnRlZ3JhdGUg R3VDLWJhc2VkIGNvbW1hbmQgc3VibWlzc2lvbgo+Pj4+Pgo+Pj4+PiBUaGlzIHBhdGNoIGFzc3Vt ZWQgTFJDIGNvbnRleHRzIGFuZCBIV1MgbGF5b3V0LCB3aGljaCBpcyBpbmNvcnJlY3Qgb24KPj4+ Pj4gcGxhdGZvcm1zIHdpdGhvdXQgZXhlY2xpc3RzLiAgVGhpcyBjYW4gbGVhZCB0byBhIGNyYXNo IGluIEdQVSBlcnJvcgo+Pj4+PiBzdGF0ZSByZWFkb3V0IG9uIHRob3NlIHBsYXRmb3Jtcy4KPj4+ Pj4KPj4+Pj4gSSBkb24ndCBzZWUgYSBidWcgZmlsZWQgZm9yIHRoaXMsIGJ1dCB0aGVyZSBtYXkg YmUgb25lIHRoYXQgSSBoYXZlbid0Cj4+Pj4+IGZvdW5kLgo+Pj4+Pgo+Pj4+PiBDYzogQWxleCBE YWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEplc3NlIEJhcm5lcyA8 amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgo+Pj4+PiAtLS0KPj4+Pj4gICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYyB8IDE5ICsrKysrKysrKysrKystLS0tLS0KPj4+Pj4g ICAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4+Pj4+ Cj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+Pj4+PiBpbmRleCAzMzc5 ZjljLi5kMDgyMmY4IDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dwdV9lcnJvci5jCj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vy cm9yLmMKPj4+Pj4gQEAgLTQ1NywxNyArNDU3LDI0IEBAIGludCBpOTE1X2Vycm9yX3N0YXRlX3Rv X3N0cihzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfc3RhdGVfYnVmICptLAo+Pj4+PiAgICAgICAgICAg IH0KPj4+Pj4gICAgICAgICAgICAgIGlmICgob2JqID0gZXJyb3ItPnJpbmdbaV0uaHdzX3BhZ2Up KSB7Cj4+Pj4+ICsgICAgICAgICAgICB1NjQgaHdzX29mZnNldCA9IGxvd2VyXzMyX2JpdHMob2Jq LT5ndHRfb2Zmc2V0KTsKCk5vIG5lZWQgdG8gdGFrZSBvbmx5IGxvd2VyIDMyIGJpdHMgaGVyZSwg dGhlIHZhcmlhYmxlIGlzIGFscmVhZHkgdTY0IGFuZCAKdGhlIGZvcm1hdCBiZWxvdyBpcyAweCUw OGxseCwgc28gd2UnbGwgZ2V0IGEgMzItYml0IHZhbHVlIGluIHRoZSBvdXRwdXQgCih1bmxlc3Mg aXQgYWN0dWFsbHkgaXMgYmlnZ2VyIHRoYW4gMzIgYml0cywgd2hpY2ggc2hvdWxkbid0IGhhcHBl biBhbmQgCndoaWNoIHdlJ2Qgd2FudCB0byBrbm93IGFib3V0ISkuCgo+Pj4+PiArICAgICAgICAg ICAgdTMyICpod3NfcGFnZSA9ICZvYmotPnBhZ2VzWzBdWzBdOwo+Pj4+PiArCj4+Pj4+ICsgICAg ICAgICAgICBpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKSB7Cj4+Pj4+ICsgICAgICAgICAgICAg ICAgaHdzX29mZnNldCA9IG9iai0+Z3R0X29mZnNldCArIExSQ19QUEhXU1BfUE4gKgo+Pj4+PiAr ICAgICAgICAgICAgICAgICAgICBQQUdFX1NJWkU7CgpJZiB3ZSBrZWVwIHRoZSBmdWxsIDY0LWJp dCB2YWx1ZSAob3IgZXZlbiBpZiB3ZSBkb24ndCksIHRoaXMgc2hvdWxkIApzaW1wbGlmeSB0byAi aHdzX29mZnNldCArPSBMUkNfUFBIV1NQX1BOKlBBR0VfU0laRTsiCgo+Pj4+PiArICAgICAgICAg ICAgICAgIGh3c19wYWdlID0gJm9iai0+cGFnZXNbTFJDX1BQSFdTUF9QTl1bMF07Cj4+Pj4+ICsg ICAgICAgICAgICB9Cj4+Pj4+ICAgICAgICAgICAgICAgIGVycl9wcmludGYobSwgIiVzIC0tLSBI VyBTdGF0dXMgPSAweCUwOGxseFxuIiwKPj4+Pj4gLSAgICAgICAgICAgICAgICBkZXZfcHJpdi0+ cmluZ1tpXS5uYW1lLAo+Pj4+PiAtICAgICAgICAgICAgICAgIG9iai0+Z3R0X29mZnNldCArIExS Q19QUEhXU1BfUE4gKiBQQUdFX1NJWkUpOwo+Pj4+PiArICAgICAgICAgICAgICAgICAgIGRldl9w cml2LT5yaW5nW2ldLm5hbWUsIGh3c19vZmZzZXQpOwo+Pj4+PiAgICAgICAgICAgICAgICBvZmZz ZXQgPSAwOwo+Pj4+PiAgICAgICAgICAgICAgICBmb3IgKGVsdCA9IDA7IGVsdCA8IFBBR0VfU0la RS8xNjsgZWx0ICs9IDQpIHsKPj4+Pj4gICAgICAgICAgICAgICAgICAgIGVycl9wcmludGYobSwg IlslMDR4XSAlMDh4ICUwOHggJTA4eCAlMDh4XG4iLAo+Pj4+PiAgICAgICAgICAgICAgICAgICAg ICAgICAgIG9mZnNldCwKPj4+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgb2JqLT5wYWdlc1tM UkNfUFBIV1NQX1BOXVtlbHRdLAo+Pj4+PiAtICAgICAgICAgICAgICAgICAgICAgICBvYmotPnBh Z2VzW0xSQ19QUEhXU1BfUE5dW2VsdCsxXSwKPj4+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAg b2JqLT5wYWdlc1tMUkNfUFBIV1NQX1BOXVtlbHQrMl0sCj4+Pj4+IC0gICAgICAgICAgICAgICAg ICAgICAgIG9iai0+cGFnZXNbTFJDX1BQSFdTUF9QTl1bZWx0KzNdKTsKPj4+Pj4gKyAgICAgICAg ICAgICAgICAgICAgICAgaHdzX3BhZ2VbZWx0XSwKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAg ICAgaHdzX3BhZ2VbZWx0KzFdLAo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICBod3NfcGFn ZVtlbHQrMl0sCj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGh3c19wYWdlW2VsdCszXSk7 Cj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgb2Zmc2V0ICs9IDE2Owo+Pj4+PiAgICAgICAg ICAgICAgICB9Cj4+Pj4+ICAgICAgICAgICAgfQoKV2l0aCB0aGUgNjQtYml0IGhhbmRsaW5nIGNo YW5nZWQsIEknZCBiZSBoYXBweSB0byByLWIgSmVzc2UncyBvcmlnaW5hbCAKcGF0Y2gsIGJ1dCBu b3QgQWxleCdzIHJlZGVmaW5pdGlvbiBvZiBMUkNfUFBIV1NQX1BOLgoKQ2hlZXJzLAouRGF2ZS4K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK