From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH 2/2] drm/i915/gtt: Avoid using addresses in non-canonical form. Date: Tue, 15 Sep 2015 15:01:24 +0100 Message-ID: <55F824B4.70205@intel.com> References: <1442323816-4712-1-git-send-email-michal.winiarski@intel.com> <1442323816-4712-2-git-send-email-michal.winiarski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 8695E6E979 for ; Tue, 15 Sep 2015 07:01:28 -0700 (PDT) In-Reply-To: <1442323816-4712-2-git-send-email-michal.winiarski@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?Q?Micha=c5=82_Winiarski?= , intel-gfx@lists.freedesktop.org Cc: Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org T24gOS8xNS8yMDE1IDI6MzAgUE0sIE1pY2hhxYIgV2luaWFyc2tpIHdyb3RlOgo+IEFjY29yZGlu ZyB0byBic3BlYywgc29tZSBwYXJ0cyBvZiBIVyBleHBlY3QgdGhlIGFkZHJlc3NlcyB0byBiZSBp bgo+IGEgY2Fub25pY2FsIGZvcm0gd2hlcmUgYml0cyBbNjM6NDhdID09IFs0N10uIExldHMgc2F0 aXNmeSB0aGUgSFcgYnkKPiBjb252ZXJ0aW5nIHRoZSBhZGRyZXNzIHByaW9yIHRvIGFsbG9jYXRp bmcvY2xlYXJpbmcgdGhlIGVudHJpZXMgaW4gcGFnZQo+IHRhYmxlcy4KClRoYW5rcyBmb3Igc2Vu ZGluZyB0aGlzLiBBIGNvdXBsZSBvZiBjb21tZW50cyBiZWxvdy4KPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2d0dC5jCj4gaW5kZXggN2ZmNzIzOS4uZjI1YTMzZiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gQEAgLTc2Niw2ICs3NjYsNyBAQCBzdGF0aWMgdm9pZCBn ZW44X3BwZ3R0X2NsZWFyX3JhbmdlKHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAg CX0gZWxzZSB7Cj4gICAJCXVpbnQ2NF90IHRlbXBsNCwgcG1sNGU7Cj4gICAJCXN0cnVjdCBpOTE1 X3BhZ2VfZGlyZWN0b3J5X3BvaW50ZXIgKnBkcDsKPiArCQlzdGFydCA9IGdlbjhfY2Fub25pY2Fs X2FkZHIoc3RhcnQpOwo+Cj4gICAJCWdlbjhfZm9yX2VhY2hfcG1sNGUocGRwLCAmcHBndHQtPnBt bDQsIHN0YXJ0LCBsZW5ndGgsIHRlbXBsNCwgcG1sNGUpIHsKPiAgIAkJCWdlbjhfcHBndHRfY2xl YXJfcHRlX3JhbmdlKHZtLCBwZHAsIHN0YXJ0LCBsZW5ndGgsCj4gQEAgLTEyMjcsMTUgKzEyMjgs MTAgQEAgc3RhdGljIGludCBnZW44X2FsbG9jX3ZhX3JhbmdlXzNsdmwoc3RydWN0IGk5MTVfYWRk cmVzc19zcGFjZSAqdm0sCj4gICAJdWludDMyX3QgcGRwZXMgPSBJOTE1X1BEUEVTX1BFUl9QRFAo ZGV2KTsKPiAgIAlpbnQgcmV0Owo+Cj4gLQkvKiBXcmFwIGlzIG5ldmVyIG9rYXkgc2luY2Ugd2Ug Y2FuIG9ubHkgcmVwcmVzZW50IDQ4YiwgYW5kIHdlIGRvbid0Cj4gLQkgKiBhY3R1YWxseSB1c2Ug dGhlIG90aGVyIHNpZGUgb2YgdGhlIGNhbm9uaWNhbCBhZGRyZXNzIHNwYWNlLgo+IC0JICovCj4g KwkvKiBXcmFwIGlzIG5ldmVyIG9rYXkgKi8KPiAgIAlpZiAoV0FSTl9PTihzdGFydCArIGxlbmd0 aCA8IHN0YXJ0KSkKPiAgIAkJcmV0dXJuIC1FTk9ERVY7CgpzdGFydCBjYW4gYmUgaW4gY2Fub25p Y2FsIGZvcm0gaGVyZSAoYWxsb2NfdmFfcmFuZ2VfNGx2bCBjYWxscyAKYWxsb2NfdmFfcmFuZ2Vf M2x2bCksIGFuZCB0aGVuIHRoaXMgY2hlY2sgY291bGQgZmFpbCwgZS5nOiBmaXJzdCBhbGxvYyAK d2hlbiB1c2luZyB0b3AtZG93bi4KSnVzdCBtb3ZlIGl0IHRvIGdlbjhfYWxsb2NfdmFfcmFuZ2Ug bGlrZSB5b3UgZGlkIHRvIHRoZSBjaGVjayBiZWxvdy4KCj4KPiAtCWlmIChXQVJOX09OKHN0YXJ0 ICsgbGVuZ3RoID4gdm0tPnRvdGFsKSkKPiAtCQlyZXR1cm4gLUVOT0RFVjsKPiAtCj4gICAJcmV0 ID0gYWxsb2NfZ2VuOF90ZW1wX2JpdG1hcHMoJm5ld19wYWdlX2RpcnMsICZuZXdfcGFnZV90YWJs ZXMsIHBkcGVzKTsKPiAgIAlpZiAocmV0KQo+ICAgCQlyZXR1cm4gcmV0Owo+IEBAIC0xMzMzLDYg KzEzMjksOCBAQCBzdGF0aWMgaW50IGdlbjhfYWxsb2NfdmFfcmFuZ2VfNGx2bChzdHJ1Y3QgaTkx NV9hZGRyZXNzX3NwYWNlICp2bSwKPiAgIAl1aW50NjRfdCB0ZW1wLCBwbWw0ZTsKPiAgIAlpbnQg cmV0ID0gMDsKPgo+ICsJc3RhcnQgPSBnZW44X2Nhbm9uaWNhbF9hZGRyKHN0YXJ0KTsKPiArCgpD YW4geW91IG1vdmUgdGhpcyB0byBnZW44X2FsbG9jX3ZhX3JhbmdlICg0OGJpdCBwYXRoKSBpbnN0 ZWFkPwpUaGF0IHdpbGwga2VlcCBpdCBpbiBzeW5jIHRvIF9jbGVhcl9yYW5nZS4KCkFsc28sIEkg a25vdyBpdCBpc24ndCByZWFsbHkgcmVxdWlyZWQgaW4gZ2VuOF9wcGd0dF9pbnNlcnRfZW50cmll cyAoYXMgCml0IG9ubHkgcmVsaWVzIGluIHBkcC9wZHAvcHQgaW5kZXhlcyksIGJ1dCBpdCB3aWxs IGJlIG5pY2UgdG8gaGF2ZSAKYWxsb2MvaW5zZXJ0L2NsZWFyIGZ1bmN0aW9ucyBpbiBzeW5jLgoK PiAgIAkvKiBEbyB0aGUgcG1sNCBhbGxvY2F0aW9ucyBmaXJzdCwgc28gd2UgZG9uJ3QgbmVlZCB0 byB0cmFjayB0aGUgbmV3bHkKPiAgIAkgKiBhbGxvY2F0ZWQgdGFibGVzIGJlbG93IHRoZSBwZHAg Ki8KPiAgIAliaXRtYXBfemVybyhuZXdfcGRwcywgR0VOOF9QTUw0RVNfUEVSX1BNTDQpOwo+IEBA IC0xMzc3LDYgKzEzNzUsOSBAQCBzdGF0aWMgaW50IGdlbjhfYWxsb2NfdmFfcmFuZ2Uoc3RydWN0 IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gICAJc3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0 ID0KPiAgIAkJY29udGFpbmVyX29mKHZtLCBzdHJ1Y3QgaTkxNV9od19wcGd0dCwgYmFzZSk7Cj4K PiArCWlmIChXQVJOX09OKHN0YXJ0ICsgbGVuZ3RoID4gdm0tPnRvdGFsKSkKPiArCQlyZXR1cm4g LUVOT0RFVjsKPiArCj4gICAJaWYgKFVTRVNfRlVMTF80OEJJVF9QUEdUVCh2bS0+ZGV2KSkKPiAg IAkJcmV0dXJuIGdlbjhfYWxsb2NfdmFfcmFuZ2VfNGx2bCh2bSwgJnBwZ3R0LT5wbWw0LCBzdGFy dCwgbGVuZ3RoKTsKPiAgIAllbHNlCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2d0dC5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiBp bmRleCA4Mjc1MDA3Li45Mzk3Mzg3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2d0dC5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0 LmgKPiBAQCAtNTAzLDYgKzUwMywxMSBAQCBzdGF0aWMgaW5saW5lIHNpemVfdCBnZW44X3B0ZV9j b3VudCh1aW50NjRfdCBhZGRyZXNzLCB1aW50NjRfdCBsZW5ndGgpCj4gICAJcmV0dXJuIGk5MTVf cHRlX2NvdW50KGFkZHJlc3MsIGxlbmd0aCwgR0VOOF9QREVfU0hJRlQpOwo+ICAgfQo+Cj4gK3N0 YXRpYyBpbmxpbmUgdWludDY0X3QgZ2VuOF9jYW5vbmljYWxfYWRkcih1aW50NjRfdCBhZGRyZXNz KQoKRmVlbCBmcmVlIHRvIGlnbm9yZSB0aGlzIG9uZSwgYnV0IHRoaXMgaXNuJ3QgZ2VuOCBwZXIg c2UsIHNvIEkgdm90ZSBmb3IgCnRvX2Nhbm9uaWNhbF9hZGRyKCkuCgo+ICt7Cj4gKwlyZXR1cm4g KChpbnQ2NF90KWFkZHJlc3MgPDwgMTYpID4+IDE2Owo+ICt9Cj4gKwo+ICAgc3RhdGljIGlubGlu ZSBkbWFfYWRkcl90Cj4gICBpOTE1X3BhZ2VfZGlyX2RtYV9hZGRyKGNvbnN0IHN0cnVjdCBpOTE1 X2h3X3BwZ3R0ICpwcGd0dCwgY29uc3QgdW5zaWduZWQgbikKPiAgIHsKPgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=