From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 06/14] drm/i915/skl: Eliminate usage of pipe_wm_parameters from SKL-style WM (v2) Date: Thu, 17 Sep 2015 15:24:11 +0200 Message-ID: <55FABEFB.5020708@linux.intel.com> References: <1442283570-26824-1-git-send-email-matthew.d.roper@intel.com> <1442283570-26824-7-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 610706E587 for ; Thu, 17 Sep 2015 06:24:13 -0700 (PDT) In-Reply-To: <1442283570-26824-7-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGV5LAoKT3AgMTUtMDktMTUgb20gMDQ6MTkgc2NocmVlZiBNYXR0IFJvcGVyOgo+IEp1c3QgcHVs bCB0aGUgaW5mbyBvdXQgb2YgdGhlIHN0YXRlIHN0cnVjdHVyZXMgcmF0aGVyIHRoYW4gc3RhZ2lu Zwo+IGl0IGluIGFuIGFkZGl0aW9uYWwgc2V0IG9mIHN0cnVjdHVyZXMuICBUbyBtYWtlIHRoaXMg bW9yZQo+IHN0cmFpZ2h0Zm9yd2FyZCwgd2UgY2hhbmdlIHRoZSBzaWduYXR1cmUgb2Ygc2V2ZXJh bCBpbnRlcm5hbCBXTQo+IGZ1bmN0aW9ucyB0byB0YWtlIHRoZSBjcnRjIHN0YXRlIGFzIGEgcGFy YW1ldGVyLgo+Cj4gdjI6Cj4gIC0gRG9uJ3QgZm9yZ2V0IHRvIHNraXAgY3Vyc29yIHBsYW5lcyBv biBhIGxvb3AgaW4gdGhlIEREQiBhbGxvY2F0aW9uCj4gICAgZnVuY3Rpb24gdG8gbWF0Y2ggb3Jp Z2luYWwgYmVoYXZpb3IuICAoQW5kZXIpCj4gIC0gQ2hhbmdlIGEgdXNlIG9mIGludGVsX2NydGMt PmFjdGl2ZSB0byBjc3RhdGUtPmFjdGl2ZS4gIFRoZXkgc2hvdWxkCj4gICAgYmUgaWRlbnRpY2Fs LCBidXQgaXQncyBiZXR0ZXIgdG8gYmUgY29uc2lzdGVudC4gIChBbmRlcikKPiAgLSBSZXdvcmsg bW9yZSBmdW5jdGlvbiBzaWduYXR1cmVzIHRvIHBhc3Mgc3RhdGVzIHJhdGhlciB0aGFuIGNydGMg Zm9yCj4gICAgY29uc2lzdGVuY3kuIChBbmRlcikKPgo+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9w ZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMgfCAzMjYgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTUxIGluc2VydGlvbnMoKyksIDE3NSBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IGluZGV4IDcxMTUzNjguLjUxZGJkYTcgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBAQCAtMTc4NywxMyArMTc4Nyw2IEBAIHN0YXRp YyB1aW50MzJfdCBpbGtfd21fZmJjKHVpbnQzMl90IHByaV92YWwsIHVpbnQzMl90IGhvcml6X3Bp eGVscywKPiAgCXJldHVybiBESVZfUk9VTkRfVVAocHJpX3ZhbCAqIDY0LCBob3Jpel9waXhlbHMg KiBieXRlc19wZXJfcGl4ZWwpICsgMjsKPiAgfQo+ICAKPiAtc3RydWN0IHNrbF9waXBlX3dtX3Bh cmFtZXRlcnMgewo+IC0JYm9vbCBhY3RpdmU7Cj4gLQl1aW50MzJfdCBwaXBlX2h0b3RhbDsKPiAt CXVpbnQzMl90IHBpeGVsX3JhdGU7IC8qIGluIEtIeiAqLwo+IC0Jc3RydWN0IGludGVsX3BsYW5l X3dtX3BhcmFtZXRlcnMgcGxhbmVbSTkxNV9NQVhfUExBTkVTXTsKPiAtfTsKPiAtCj4gIHN0cnVj dCBpbGtfd21fbWF4aW11bXMgewo+ICAJdWludDE2X3QgcHJpOwo+ICAJdWludDE2X3Qgc3ByOwo+ IEBAIC0yODM0LDE4ICsyODI3LDQwIEBAIHN0YXRpYyBib29sIGlsa19kaXNhYmxlX2xwX3dtKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICNkZWZpbmUgU0tMX0REQl9TSVpFCQk4OTYJLyogaW4g YmxvY2tzICovCj4gICNkZWZpbmUgQlhUX0REQl9TSVpFCQk1MTIKPiAgCj4gKy8qCj4gKyAqIFJl dHVybiB0aGUgaW5kZXggb2YgYSBwbGFuZSBpbiB0aGUgU0tMIEREQiBhbmQgd20gcmVzdWx0IGFy cmF5cy4gIFByaW1hcnkKPiArICogcGxhbmUgaXMgYWx3YXlzIGluIHNsb3QgMCwgY3Vyc29yIGlz IGFsd2F5cyBpbiBzbG90IEk5MTVfTUFYX1BMQU5FUy0xLCBhbmQKPiArICogb3RoZXIgdW5pdmVy c2FsIHBsYW5lcyBhcmUgaW4gaW5kaWNlcyAxLi5uLiAgTm90ZSB0aGF0IHRoaXMgbWF5IGxlYXZl IHVudXNlZAo+ICsgKiBpbmRpY2VzIGJldHdlZW4gdGhlIHRvcCAic3ByaXRlIiBwbGFuZSBhbmQg dGhlIGN1cnNvci4KPiArICovCj4gK3N0YXRpYyBpbnQKPiArc2tsX3dtX3BsYW5lX2lkKGNvbnN0 IHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUpCj4gK3sKPiArCXN3aXRjaCAocGxhbmUtPmJhc2Uu dHlwZSkgewo+ICsJY2FzZSBEUk1fUExBTkVfVFlQRV9QUklNQVJZOgo+ICsJCXJldHVybiAwOwo+ ICsJY2FzZSBEUk1fUExBTkVfVFlQRV9DVVJTT1I6Cj4gKwkJcmV0dXJuIFBMQU5FX0NVUlNPUjsK PiArCWNhc2UgRFJNX1BMQU5FX1RZUEVfT1ZFUkxBWToKPiArCQlyZXR1cm4gcGxhbmUtPnBsYW5l OwpTaG91bGRuJ3QgdGhpcyBiZSBwbGFuZSArIDEgb24gc2t5bGFrZT8gVGhvdWdoIGl0J3Mgbm90 IHRoZSBvbmx5IGNvZGUgaW4gaTkxNSB0aGF0IGdldHMgaXQgd3JvbmcsCmFzc2VydF9zcHJpdGVz X2Rpc2FibGVkIGhhcyB0aGUgc2FtZSBpc3N1ZSBvbiBTS0wuLiBPOi0pCgo+ICsJZGVmYXVsdDoK PiArCQlNSVNTSU5HX0NBU0UocGxhbmUtPmJhc2UudHlwZSk7Cj4gKwkJcmV0dXJuIHBsYW5lLT5w bGFuZTsKPiArCX0KPiArfQo+ICsKPiAgc3RhdGljIHZvaWQKPiAgc2tsX2RkYl9nZXRfcGlwZV9h bGxvY2F0aW9uX2xpbWl0cyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+IC0JCQkJICAgc3RydWN0 IGRybV9jcnRjICpmb3JfY3J0YywKPiArCQkJCSAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjc3RhdGUsCj4gIAkJCQkgICBjb25zdCBzdHJ1Y3QgaW50ZWxfd21fY29uZmlnICpjb25m aWcsCj4gLQkJCQkgICBjb25zdCBzdHJ1Y3Qgc2tsX3BpcGVfd21fcGFyYW1ldGVycyAqcGFyYW1z LAo+ICAJCQkJICAgc3RydWN0IHNrbF9kZGJfZW50cnkgKmFsbG9jIC8qIG91dCAqLykKPiAgewo+ ICsJc3RydWN0IGRybV9jcnRjICpmb3JfY3J0YyA9IGNzdGF0ZS0+YmFzZS5jcnRjOwo+ICAJc3Ry dWN0IGRybV9jcnRjICpjcnRjOwo+ICAJdW5zaWduZWQgaW50IHBpcGVfc2l6ZSwgZGRiX3NpemU7 Cj4gIAlpbnQgbnRoX2FjdGl2ZV9waXBlOwo+ICAKPiAtCWlmICghcGFyYW1zLT5hY3RpdmUpIHsK PiArCWlmICghY3N0YXRlLT5iYXNlLmFjdGl2ZSkgewo+ICAJCWFsbG9jLT5zdGFydCA9IDA7Cj4g IAkJYWxsb2MtPmVuZCA9IDA7Cj4gIAkJcmV0dXJuOwo+IEBAIC0yOTExLDE5ICsyOTI2LDI5IEBA IHZvaWQgc2tsX2RkYl9nZXRfaHdfc3RhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ICB9Cj4gIAo+ICBzdGF0aWMgdW5zaWduZWQgaW50Cj4gLXNrbF9wbGFuZV9yZWxhdGl2 ZV9kYXRhX3JhdGUoY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3dtX3BhcmFtZXRlcnMgKnAsIGlu dCB5KQo+ICtza2xfcGxhbmVfcmVsYXRpdmVfZGF0YV9yYXRlKGNvbnN0IHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjc3RhdGUsCj4gKwkJCSAgICAgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9zdGF0 ZSAqcHN0YXRlLAo+ICsJCQkgICAgIGludCB5KQo+ICB7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAq aW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3N0YXRlLT5iYXNlLmNydGMpOwo+ICsJc3RydWN0 IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBwc3RhdGUtPmZiOwo+ICAKPiAgCS8qIGZvciBwbGFuYXIg Zm9ybWF0ICovCj4gLQlpZiAocC0+eV9ieXRlc19wZXJfcGl4ZWwpIHsKPiArCWlmIChmYi0+cGl4 ZWxfZm9ybWF0ID09IERSTV9GT1JNQVRfTlYxMikgewo+ICAJCWlmICh5KSAgLyogeS1wbGFuZSBk YXRhIHJhdGUgKi8KPiAtCQkJcmV0dXJuIHAtPmhvcml6X3BpeGVscyAqIHAtPnZlcnRfcGl4ZWxz ICogcC0+eV9ieXRlc19wZXJfcGl4ZWw7Cj4gKwkJCXJldHVybiBpbnRlbF9jcnRjLT5jb25maWct PnBpcGVfc3JjX3cgKgo+ICsJCQkJaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY19oICoKPiAr CQkJCWRybV9mb3JtYXRfcGxhbmVfY3BwKGZiLT5waXhlbF9mb3JtYXQsIDApOwo+ICAJCWVsc2Ug ICAgLyogdXYtcGxhbmUgZGF0YSByYXRlICovCj4gLQkJCXJldHVybiAocC0+aG9yaXpfcGl4ZWxz LzIpICogKHAtPnZlcnRfcGl4ZWxzLzIpICogcC0+Ynl0ZXNfcGVyX3BpeGVsOwo+ICsJCQlyZXR1 cm4gKGludGVsX2NydGMtPmNvbmZpZy0+cGlwZV9zcmNfdy8yKSAqCj4gKwkJCQkoaW50ZWxfY3J0 Yy0+Y29uZmlnLT5waXBlX3NyY19oLzIpICoKPiArCQkJCWRybV9mb3JtYXRfcGxhbmVfY3BwKGZi LT5waXhlbF9mb3JtYXQsIDEpOwo+ICAJfQo+ICAKPiAgCS8qIGZvciBwYWNrZWQgZm9ybWF0cyAq Lwo+IC0JcmV0dXJuIHAtPmhvcml6X3BpeGVscyAqIHAtPnZlcnRfcGl4ZWxzICogcC0+Ynl0ZXNf cGVyX3BpeGVsOwo+ICsJcmV0dXJuIGludGVsX2NydGMtPmNvbmZpZy0+cGlwZV9zcmNfdyAqCj4g KwkJaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY19oICoKPiArCQlkcm1fZm9ybWF0X3BsYW5l X2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAxKTsKXkdpdmVzIGEgbmFzdHkgZGl2aWRlIGJ5IHplcm8g ZXJyb3Igb24gbXkgc2tsIHdoZW4gdG90YWxfZGF0YV9yYXRlIGVuZHMgdXAgYmVpbmcgMC4uCllv dSB3YW50IHRvIGNoYW5nZSBsYXN0IGFyZ3VtZW50IHRvIDAgaGVyZS4gOy0pCj4gIH0KPiAgCj4g IC8qCj4gQEAgLTI5MzIsNDYgKzI5NTcsNTEgQEAgc2tsX3BsYW5lX3JlbGF0aXZlX2RhdGFfcmF0 ZShjb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfd21fcGFyYW1ldGVycyAqcCwgaW50IHkpCj4gICAq ICAgMyAqIDQwOTYgKiA4MTkyICAqIDQgPCAyXjMyCj4gICAqLwo+ICBzdGF0aWMgdW5zaWduZWQg aW50Cj4gLXNrbF9nZXRfdG90YWxfcmVsYXRpdmVfZGF0YV9yYXRlKHN0cnVjdCBpbnRlbF9jcnRj ICppbnRlbF9jcnRjLAo+IC0JCQkJIGNvbnN0IHN0cnVjdCBza2xfcGlwZV93bV9wYXJhbWV0ZXJz ICpwYXJhbXMpCj4gK3NrbF9nZXRfdG90YWxfcmVsYXRpdmVfZGF0YV9yYXRlKGNvbnN0IHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUpCj4gIHsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICpp bnRlbF9jcnRjID0gdG9faW50ZWxfY3J0Yyhjc3RhdGUtPmJhc2UuY3J0Yyk7Cj4gKwlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gaW50ZWxfY3J0Yy0+YmFzZS5kZXY7Cj4gKwljb25zdCBzdHJ1Y3Qg aW50ZWxfcGxhbmUgKmludGVsX3BsYW5lOwo+ICAJdW5zaWduZWQgaW50IHRvdGFsX2RhdGFfcmF0 ZSA9IDA7Cj4gLQlpbnQgcGxhbmU7Cj4gIAo+IC0JZm9yIChwbGFuZSA9IDA7IHBsYW5lIDwgaW50 ZWxfbnVtX3BsYW5lcyhpbnRlbF9jcnRjKTsgcGxhbmUrKykgewo+IC0JCWNvbnN0IHN0cnVjdCBp bnRlbF9wbGFuZV93bV9wYXJhbWV0ZXJzICpwOwo+ICsJZm9yX2VhY2hfaW50ZWxfcGxhbmVfb25f Y3J0YyhkZXYsIGludGVsX2NydGMsIGludGVsX3BsYW5lKSB7Cj4gKwkJY29uc3Qgc3RydWN0IGRy bV9wbGFuZV9zdGF0ZSAqcHN0YXRlID0gaW50ZWxfcGxhbmUtPmJhc2Uuc3RhdGU7Cj4gIAo+IC0J CXAgPSAmcGFyYW1zLT5wbGFuZVtwbGFuZV07Cj4gLQkJaWYgKCFwLT5lbmFibGVkKQo+ICsJCWlm IChXQVJOX09OKHBzdGF0ZS0+ZmIgPT0gTlVMTCkpCj4gIAkJCWNvbnRpbnVlOwpeV2h5IGlzIHRo aXMgYSBXQVJOX09OPwoKQWxsIGluIGFsbCwgdGhlIHNlcmllcyBsb29rcyBnb29kLgoKV2l0aCB0 aG9zZSBmaXhlcyBmZWVsIGZyZWUgdG8gYWRkIHRoaXMgdG8gYWxsIHBhdGNoZXM6ClJldmlld2Vk LWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29t PgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=