public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Patchwork <patchwork@emeril.freedesktop.org>,
	intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.BAT: warning for drm/i915: Guc code reorg
Date: Sat, 30 Sep 2017 20:11:10 +0530	[thread overview]
Message-ID: <55aed3f6-c421-2744-c0ff-19dfa8d7bf35@intel.com> (raw)
In-Reply-To: <op.y7dlm0fxxaggs7@mwajdecz-mobl1.ger.corp.intel.com>



On 9/30/2017 4:47 PM, Michal Wajdeczko wrote:
> On Sat, 30 Sep 2017 10:30:16 +0200, Sagar Arun Kamble 
> <sagar.a.kamble@intel.com> wrote:
>
>>
>>
>> On 9/30/2017 3:26 AM, Michal Wajdeczko wrote:
>>> On Fri, 29 Sep 2017 20:07:48 +0200, Patchwork 
>>> <patchwork@emeril.freedesktop.org> wrote:
>>>
>>>> == Series Details ==
>>>>
>>>> Series: drm/i915: Guc code reorg
>>>> URL   : https://patchwork.freedesktop.org/series/31199/
>>>> State : warning
>>>>
>>>> == Summary ==
>>>>
>>>> Series 31199v1 drm/i915: Guc code reorg
>>>> https://patchwork.freedesktop.org/api/1.0/series/31199/revisions/1/mbox/ 
>>>>
>>>>
>>>> Test chamelium:
>>>>         Subgroup dp-edid-read:
>>>>                 pass       -> FAIL       (fi-kbl-7500u) fdo#102672
>>>>         Subgroup hdmi-crc-fast:
>>>>                 dmesg-warn -> PASS       (fi-skl-6700k) fdo#103019
>>>> Test kms_busy:
>>>>         Subgroup basic-flip-c:
>>>>                 incomplete -> PASS       (fi-bxt-j4205) fdo#102035
>>>> Test drv_module_reload:
>>>>         Subgroup basic-reload:
>>>>                 pass       -> DMESG-WARN (fi-snb-2520m)
>>>>                 pass       -> DMESG-WARN (fi-snb-2600)
>>>>                 pass       -> DMESG-WARN (fi-ivb-3520m)
>>>>                 pass       -> DMESG-WARN (fi-ivb-3770)
>>>>                 pass       -> DMESG-WARN (fi-byt-j1900)
>>>>                 pass       -> DMESG-WARN (fi-byt-n2820)
>>>>                 pass       -> DMESG-WARN (fi-hsw-4770)
>>>>                 pass       -> DMESG-WARN (fi-hsw-4770r)
>>>>                 pass       -> DMESG-WARN (fi-bdw-5557u)
>>>>                 pass       -> DMESG-WARN (fi-bdw-gvtdvm)
>>>>         Subgroup basic-no-display:
>>>>                 pass       -> DMESG-WARN (fi-snb-2520m)
>>>>                 pass       -> DMESG-WARN (fi-snb-2600)
>>>>                 pass       -> DMESG-WARN (fi-ivb-3520m)
>>>>                 pass       -> DMESG-WARN (fi-ivb-3770)
>>>>                 pass       -> DMESG-WARN (fi-byt-j1900)
>>>>                 pass       -> DMESG-WARN (fi-byt-n2820)
>>>>                 pass       -> DMESG-WARN (fi-hsw-4770)
>>>>                 pass       -> DMESG-WARN (fi-hsw-4770r)
>>>>                 pass       -> DMESG-WARN (fi-bdw-5557u)
>>>>                 pass       -> DMESG-WARN (fi-bdw-gvtdvm)
>>>>         Subgroup basic-reload-inject:
>>>>                 pass       -> DMESG-WARN (fi-snb-2520m)
>>>>                 pass       -> DMESG-WARN (fi-snb-2600)
>>>>                 pass       -> DMESG-WARN (fi-ivb-3520m)
>>>>                 pass       -> DMESG-WARN (fi-ivb-3770)
>>>>                 pass       -> DMESG-WARN (fi-byt-j1900)
>>>>                 pass       -> DMESG-WARN (fi-byt-n2820)
>>>>                 pass       -> DMESG-WARN (fi-hsw-4770)
>>>>                 pass       -> DMESG-WARN (fi-hsw-4770r)
>>>>                 pass       -> DMESG-WARN (fi-bdw-5557u)
>>>>                 pass       -> DMESG-WARN (fi-bdw-gvtdvm)
>>>>                 dmesg-warn -> PASS       (fi-glk-1) fdo#102777
>>>>
>>>> fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
>>>> fdo#103019 https://bugs.freedesktop.org/show_bug.cgi?id=103019
>>>> fdo#102035 https://bugs.freedesktop.org/show_bug.cgi?id=102035
>>>> fdo#102777 https://bugs.freedesktop.org/show_bug.cgi?id=102777
>>>>
>>>> fi-bdw-5557u     total:289  pass:265  dwarn:3   dfail:0 fail:0   
>>>> skip:21  time:440s
>>>> fi-bdw-gvtdvm    total:289  pass:262  dwarn:3   dfail:0 fail:0   
>>>> skip:24  time:474s
>>>> fi-blb-e6850     total:289  pass:224  dwarn:1   dfail:0 fail:0   
>>>> skip:64  time:419s
>>>> fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0 fail:0   
>>>> skip:46  time:523s
>>>> fi-bwr-2160      total:289  pass:184  dwarn:0   dfail:0 fail:0   
>>>> skip:105 time:278s
>>>> fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0 fail:0   
>>>> skip:30  time:496s
>>>> fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0 fail:0   
>>>> skip:29  time:514s
>>>> fi-byt-j1900     total:289  pass:251  dwarn:4   dfail:0 fail:0   
>>>> skip:34  time:499s
>>>> fi-byt-n2820     total:289  pass:247  dwarn:4   dfail:0 fail:0   
>>>> skip:38  time:478s
>>>> fi-cfl-s         total:289  pass:256  dwarn:1   dfail:0 fail:0   
>>>> skip:32  time:557s
>>>> fi-cnl-y         total:289  pass:261  dwarn:1   dfail:0 fail:0   
>>>> skip:27  time:644s
>>>> fi-elk-e7500     total:289  pass:230  dwarn:0   dfail:0 fail:0   
>>>> skip:59  time:415s
>>>> fi-glk-1         total:289  pass:260  dwarn:0   dfail:0 fail:0   
>>>> skip:29  time:568s
>>>> fi-hsw-4770      total:289  pass:260  dwarn:3   dfail:0 fail:0   
>>>> skip:26  time:423s
>>>> fi-hsw-4770r     total:289  pass:260  dwarn:3   dfail:0 fail:0   
>>>> skip:26  time:409s
>>>> fi-ilk-650       total:289  pass:229  dwarn:0   dfail:0 fail:0   
>>>> skip:60  time:436s
>>>> fi-ivb-3520m     total:289  pass:258  dwarn:3   dfail:0 fail:0   
>>>> skip:28  time:491s
>>>> fi-ivb-3770      total:289  pass:258  dwarn:3   dfail:0 fail:0   
>>>> skip:28  time:465s
>>>> fi-kbl-7500u     total:289  pass:263  dwarn:1   dfail:0 fail:1   
>>>> skip:24  time:474s
>>>> fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0 fail:0   
>>>> skip:19  time:581s
>>>> fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0 fail:0   
>>>> skip:27  time:590s
>>>> fi-pnv-d510      total:289  pass:223  dwarn:1   dfail:0 fail:0   
>>>> skip:65  time:542s
>>>> fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0 fail:0   
>>>> skip:20  time:450s
>>>> fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0 fail:0   
>>>> skip:24  time:755s
>>>> fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0 fail:0   
>>>> skip:20  time:488s
>>>> fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0 fail:0   
>>>> skip:23  time:473s
>>>> fi-snb-2520m     total:289  pass:248  dwarn:3   dfail:0 fail:0   
>>>> skip:38  time:572s
>>>> fi-snb-2600      total:289  pass:247  dwarn:3   dfail:0 fail:0   
>>>> skip:39  time:412s
>>>>
>>>> e650b9cdaff616445f38986379b1c0c4b03a4282 drm-tip: 
>>>> 2017y-09m-29d-11h-52m-41s UTC integration manifest
>>>> 6d4769343a2a drm/i915: Move intel_guc_allocate_vma to guc.c
>>>> 59480c574191 drm/i915: Move intel_guc_suspend/resume to guc.c
>>>> d2893f8cbf4e drm/i915: Move intel_guc_auth_huc to guc.c
>>>> 1a0dd7cc4a5f drm/i915: Move intel_guc_sample_forcewake to guc.c
>>>> 4fca849cd959 drm/i915: Move core GuC functions into dedicated file
>>>> 80014876b93d drm/i915: Move GuC declarations into dedicated header
>>>> 0ca0dc99d1b8 drm/i915: Move HuC declarations into dedicated header
>>>> e47aeb8fe88c drm/i915: Move uC fw helper code into dedicated files
>>>> c09aa8ff2ac9 drm/i915: Drop unnecessary forward declaration
>>>>
>>>> == Logs ==
>>>>
>>>> For more details see: 
>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5863/
>>>
>>>
>>> Hmm, I'm not sure that these WARN_ON are correct. What about 
>>> removing them?
>> Pulling out guc_init_send_regs from guc_init_early and calling it as 
>> part of i915_driver_init_mmio post intel_uncore_init is
>> proper order.
>
> Yep. I was mislead by this comment:
> "i915_driver_init_early - setup state not requiring device access"
> but it looks that uncore has no corresponding 'early' init code.
uncore init needs device access. so it is part of init_mmio path. we 
should have intel_uc_init_mmio() along this path as it depends on uncore 
init.
>
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_uncore.c 
>>> b/drivers/gpu/drm/i915/intel_uncore.c
>>> index b3c3f94..5fcc562 100644
>>> --- a/drivers/gpu/drm/i915/intel_uncore.c
>>> +++ b/drivers/gpu/drm/i915/intel_uncore.c
>>> @@ -1836,8 +1836,6 @@ intel_uncore_forcewake_for_read(struct 
>>> drm_i915_private *dev_priv,
>>>                 fw_domains = 0;
>>>         }
>>>
>>> -       WARN_ON(fw_domains & ~dev_priv->uncore.fw_domains);
>>> -
>
> And disregard above, I wrongly read that as "fw_domains_active".
> Btw, maybe it can be converted into GEM_BUG_ON ?
>
Yes. I feel this is good candidate for BUG_ON . Chris, please suggest.
> Michal

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-09-30 14:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 17:41 [PATCH 0/9] drm/i915: Guc code reorg Michal Wajdeczko
2017-09-29 17:41 ` [PATCH 1/9] drm/i915: Drop unnecessary forward declaration Michal Wajdeczko
2017-09-30  8:52   ` Sagar Arun Kamble
2017-09-29 17:41 ` [PATCH 2/9] drm/i915: Move uC fw helper code into dedicated files Michal Wajdeczko
2017-09-30 10:01   ` Sagar Arun Kamble
2017-09-30 14:43     ` Sagar Arun Kamble
2017-09-30 15:50       ` Michal Wajdeczko
2017-09-29 17:41 ` [PATCH 3/9] drm/i915: Move HuC declarations into dedicated header Michal Wajdeczko
2017-09-30 15:14   ` Sagar Arun Kamble
2017-09-29 17:41 ` [PATCH 4/9] drm/i915: Move GuC " Michal Wajdeczko
2017-09-30 15:30   ` Sagar Arun Kamble
2017-09-29 17:41 ` [PATCH 5/9] drm/i915: Move core GuC functions into dedicated file Michal Wajdeczko
2017-09-30 17:06   ` Sagar Arun Kamble
2017-09-30 17:16     ` Sagar Arun Kamble
2017-09-30 18:14       ` Michal Wajdeczko
2017-09-30 18:27         ` Sagar Arun Kamble
2017-10-07  4:25   ` [drm/i915] 202c1ca611: WARNING:at_drivers/gpu/drm/i915/intel_uncore.c:#intel_uncore_forcewake_for_reg[i915] kernel test robot
2017-10-07  8:36     ` Chris Wilson
2017-10-07  8:38       ` Chris Wilson
2017-10-07  9:54     ` Michal Wajdeczko
2017-09-29 17:41 ` [PATCH 6/9] drm/i915: Move intel_guc_sample_forcewake to guc.c Michal Wajdeczko
2017-09-30 17:21   ` Sagar Arun Kamble
2017-09-29 17:41 ` [PATCH 7/9] drm/i915: Move intel_guc_auth_huc " Michal Wajdeczko
2017-09-30 17:27   ` Sagar Arun Kamble
2017-09-29 17:41 ` [PATCH 8/9] drm/i915: Move intel_guc_suspend/resume " Michal Wajdeczko
2017-09-30 17:37   ` Sagar Arun Kamble
2017-09-29 17:41 ` [PATCH 9/9] drm/i915: Move intel_guc_allocate_vma " Michal Wajdeczko
2017-09-30 17:41   ` Sagar Arun Kamble
2017-09-29 18:07 ` ✗ Fi.CI.BAT: warning for drm/i915: Guc code reorg Patchwork
2017-09-29 21:56   ` Michal Wajdeczko
2017-09-30  8:30     ` Sagar Arun Kamble
2017-09-30 11:17       ` Michal Wajdeczko
2017-09-30 14:41         ` Sagar Arun Kamble [this message]
2017-10-02  8:45 ` [PATCH 0/9] " Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55aed3f6-c421-2744-c0ff-19dfa8d7bf35@intel.com \
    --to=sagar.a.kamble@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=patchwork@emeril.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox