From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Nick Hoath <nicholas.hoath@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove extraneous request cancel.
Date: Mon, 21 Sep 2015 14:31:59 +0100 [thread overview]
Message-ID: <560006CF.1050906@linux.intel.com> (raw)
In-Reply-To: <1442840549-687-1-git-send-email-nicholas.hoath@intel.com>
On 09/21/2015 02:02 PM, Nick Hoath wrote:
> Remove extraneous request cancel in request allocation failure path
> in intel_lr_context_deferred_alloc (Tvrtko Ursulin)
>
> Signed-off-by: Nick Hoath <nicholas.hoath@intel.com>
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index fe06accb0..3a50de6 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -2488,7 +2488,6 @@ int intel_lr_context_deferred_alloc(struct intel_context *ctx,
> if (ret) {
> DRM_ERROR("ring create req: %d\n",
> ret);
> - i915_gem_request_cancel(req);
> goto error_ringbuf;
> }
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Could add to the commit that popular blurb of:
Regression from:
commit e84fe80337dc85cca07d0417ea97edbec4789d8b
Author: Nick Hoath <nicholas.hoath@intel.com>
Date: Fri Sep 11 12:53:46 2015 +0100
drm/i915: Split alloc from init for lrc
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-21 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 13:02 [PATCH] drm/i915: Remove extraneous request cancel Nick Hoath
2015-09-21 13:31 ` Tvrtko Ursulin [this message]
2015-09-23 15:35 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560006CF.1050906@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nicholas.hoath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox