From: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
To: Sonika Jindal <sonika.jindal@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/bxt: Set oscaledcompmethod to enable scale value
Date: Mon, 21 Sep 2015 23:00:37 +0530 [thread overview]
Message-ID: <56003EBD.8010509@intel.com> (raw)
In-Reply-To: <1442565666-7468-1-git-send-email-sonika.jindal@intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
On 9/18/2015 2:11 PM, Sonika Jindal wrote:
> Bspec update tells that we have to enable oscaledcompmethod instead of
> ouniqetrangenmethod for enabling scale value during swing programming.
> Also, scale value is 'don't care' for other levels except the last entry
> translation table. So, make it 0 instead of 0x9A.
>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 812b7b2..cec6546 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1395,7 +1395,7 @@ enum skl_disp_power_wells {
> #define BXT_PORT_TX_DW3_LN0(port) _PORT3(port, _PORT_TX_DW3_LN0_A, \
> _PORT_TX_DW3_LN0_B, \
> _PORT_TX_DW3_LN0_C)
> -#define UNIQE_TRANGE_EN_METHOD (1 << 27)
> +#define SCALE_DCOMP_METHOD (1 << 26)
>
> #define _PORT_TX_DW4_LN0_A 0x162510
> #define _PORT_TX_DW4_LN0_B 0x6C510
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index fec51df..0d9b304 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -261,15 +261,15 @@ struct bxt_ddi_buf_trans {
> */
> static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {
> /* Idx NT mV diff db */
> - { 52, 0x9A, 0, 128, true }, /* 0: 400 0 */
> - { 78, 0x9A, 0, 85, false }, /* 1: 400 3.5 */
> - { 104, 0x9A, 0, 64, false }, /* 2: 400 6 */
> - { 154, 0x9A, 0, 43, false }, /* 3: 400 9.5 */
> - { 77, 0x9A, 0, 128, false }, /* 4: 600 0 */
> - { 116, 0x9A, 0, 85, false }, /* 5: 600 3.5 */
> - { 154, 0x9A, 0, 64, false }, /* 6: 600 6 */
> - { 102, 0x9A, 0, 128, false }, /* 7: 800 0 */
> - { 154, 0x9A, 0, 85, false }, /* 8: 800 3.5 */
> + { 52, 0, 0, 128, true }, /* 0: 400 0 */
> + { 78, 0, 0, 85, false }, /* 1: 400 3.5 */
> + { 104, 0, 0, 64, false }, /* 2: 400 6 */
> + { 154, 0, 0, 43, false }, /* 3: 400 9.5 */
> + { 77, 0, 0, 128, false }, /* 4: 600 0 */
> + { 116, 0, 0, 85, false }, /* 5: 600 3.5 */
> + { 154, 0, 0, 64, false }, /* 6: 600 6 */
> + { 102, 0, 0, 128, false }, /* 7: 800 0 */
> + { 154, 0, 0, 85, false }, /* 8: 800 3.5 */
> { 154, 0x9A, 1, 128, false }, /* 9: 1200 0 */
> };
>
> @@ -2151,9 +2151,9 @@ static void bxt_ddi_vswing_sequence(struct drm_device *dev, u32 level,
> I915_WRITE(BXT_PORT_TX_DW2_GRP(port), val);
>
> val = I915_READ(BXT_PORT_TX_DW3_LN0(port));
> - val &= ~UNIQE_TRANGE_EN_METHOD;
> + val &= ~SCALE_DCOMP_METHOD;
> if (ddi_translations[level].enable)
> - val |= UNIQE_TRANGE_EN_METHOD;
> + val |= SCALE_DCOMP_METHOD;
> I915_WRITE(BXT_PORT_TX_DW3_GRP(port), val);
>
> val = I915_READ(BXT_PORT_TX_DW4_LN0(port));
--
regards,
Sivakumar
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-21 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 8:41 [PATCH 1/2] drm/i915/bxt: Set oscaledcompmethod to enable scale value Sonika Jindal
2015-09-18 8:41 ` [PATCH 2/2] drm/i915/bxt: eDP low vswing support Sonika Jindal
2015-09-21 17:32 ` Sivakumar Thulasimani
2015-09-24 4:54 ` [PATCH] " Sonika Jindal
2015-09-28 8:22 ` Daniel Vetter
2015-09-21 17:30 ` Sivakumar Thulasimani [this message]
2015-09-22 13:02 ` [PATCH 1/2] drm/i915/bxt: Set oscaledcompmethod to enable scale value Imre Deak
2015-09-22 18:31 ` Sivakumar Thulasimani
2015-09-22 19:32 ` Imre Deak
2015-09-23 4:07 ` Jindal, Sonika
2015-09-23 11:45 ` Imre Deak
2015-09-24 4:52 ` [PATCH] " Sonika Jindal
2015-09-24 11:12 ` Imre Deak
2015-09-28 8:27 ` Daniel Vetter
2015-09-24 5:03 ` [PATCH 1/2] " Jindal, Sonika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56003EBD.8010509@intel.com \
--to=sivakumar.thulasimani@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox