From: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
To: Sonika Jindal <sonika.jindal@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/bxt: eDP low vswing support
Date: Mon, 21 Sep 2015 23:02:15 +0530 [thread overview]
Message-ID: <56003F1F.7080301@intel.com> (raw)
In-Reply-To: <1442565666-7468-2-git-send-email-sonika.jindal@intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
On 9/18/2015 2:11 PM, Sonika Jindal wrote:
> Adding voltage swing table for edp to support low vswings.
>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 23 +++++++++++++++++++----
> 1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 0d9b304..17281bc 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -256,9 +256,6 @@ struct bxt_ddi_buf_trans {
> bool default_index; /* true if the entry represents default value */
> };
>
> -/* BSpec does not define separate vswing/pre-emphasis values for eDP.
> - * Using DP values for eDP as well.
> - */
> static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {
> /* Idx NT mV diff db */
> { 52, 0, 0, 128, true }, /* 0: 400 0 */
> @@ -273,6 +270,20 @@ static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {
> { 154, 0x9A, 1, 128, false }, /* 9: 1200 0 */
> };
>
> +static const struct bxt_ddi_buf_trans bxt_ddi_translations_edp[] = {
> + /* Idx NT mV diff db */
> + { 26, 0, 0, 128, false }, /* 0: 200 0 */
> + { 38, 0, 0, 112, false }, /* 1: 200 1.5 */
> + { 48, 0, 0, 96, false }, /* 2: 200 4 */
> + { 54, 0, 0, 69, false }, /* 3: 200 6 */
> + { 32, 0, 0, 128, false }, /* 4: 250 0 */
> + { 48, 0, 0, 104, false }, /* 5: 250 1.5 */
> + { 54, 0, 0, 85, false }, /* 6: 250 4 */
> + { 43, 0, 0, 128, false }, /* 7: 300 0 */
> + { 54, 0, 0, 101, false }, /* 8: 300 1.5 */
> + { 48, 0, 0, 128, false }, /* 9: 300 0 */
> +};
> +
> /* BSpec has 2 recommended values - entries 0 and 8.
> * Using the entry with higher vswing.
> */
> @@ -2113,7 +2124,11 @@ static void bxt_ddi_vswing_sequence(struct drm_device *dev, u32 level,
> u32 n_entries, i;
> uint32_t val;
>
> - if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) {
> + if (type == INTEL_OUTPUT_EDP && dev_priv->edp_low_vswing) {
> + n_entries = ARRAY_SIZE(bxt_ddi_translations_edp);
> + ddi_translations = bxt_ddi_translations_edp;
> + } else if (type == INTEL_OUTPUT_DISPLAYPORT
> + || type == INTEL_OUTPUT_EDP) {
> n_entries = ARRAY_SIZE(bxt_ddi_translations_dp);
> ddi_translations = bxt_ddi_translations_dp;
> } else if (type == INTEL_OUTPUT_HDMI) {
--
regards,
Sivakumar
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-21 17:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 8:41 [PATCH 1/2] drm/i915/bxt: Set oscaledcompmethod to enable scale value Sonika Jindal
2015-09-18 8:41 ` [PATCH 2/2] drm/i915/bxt: eDP low vswing support Sonika Jindal
2015-09-21 17:32 ` Sivakumar Thulasimani [this message]
2015-09-24 4:54 ` [PATCH] " Sonika Jindal
2015-09-28 8:22 ` Daniel Vetter
2015-09-21 17:30 ` [PATCH 1/2] drm/i915/bxt: Set oscaledcompmethod to enable scale value Sivakumar Thulasimani
2015-09-22 13:02 ` Imre Deak
2015-09-22 18:31 ` Sivakumar Thulasimani
2015-09-22 19:32 ` Imre Deak
2015-09-23 4:07 ` Jindal, Sonika
2015-09-23 11:45 ` Imre Deak
2015-09-24 4:52 ` [PATCH] " Sonika Jindal
2015-09-24 11:12 ` Imre Deak
2015-09-28 8:27 ` Daniel Vetter
2015-09-24 5:03 ` [PATCH 1/2] " Jindal, Sonika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56003F1F.7080301@intel.com \
--to=sivakumar.thulasimani@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox