Re: [PATCH 4/5] drm/i915: Use only blitter forcewake

Kamble, Sagar A
2015-09-11T13:23:30Z

[-- Attachment #1.1: Type: text/plain, Size: 1054 bytes --]

Thanks Chris.

Domain refcount tracking is not common single function.
its present in __force_wake_get, __intel_uncore_forcewake_get and
likewise for put functions.

Either we will have to bring them together in fw_domains_get and then
add change you have suggested
Or
Prepare WA version of __force_wake_get and __intel_uncore_forcewake_get
Or
approach in the current patch where we only init blitter domain.
This will work from __intel_uncore_forcewake_get as well as it filters
domains based on dev_priv->uncore.fw_domains.

Let me know which approach looks good.

On 8/23/2015 6:00 PM, Chris Wilson wrote:
> On Sun, Aug 23, 2015 at 05:52:50PM +0530, Sagar Arun Kamble wrote:
>> Coarse power gating is disabled prior to BXT B0 and till SKL E0,
>> hence even for render and media well registers blitter forcewake request
>> need to be used.
> Just insert a custom force_wake_get/put for the w/a.
>
> Something like
>
> gen9_force_wake_get_wa()
> {
> return fw_domains_get(BLITTER);
> }
>
> The fw counting will make it work just fine.
> -Chris
>

[-- Attachment #1.2: Type: text/html, Size: 39752 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]