Re: [PATCH 1/5] drm/i915: Increase maximum polling time to 50ms for forcewake request/clear ack

Daniel Vetter
2015-08-26T09:26:39Z

On Sun, Aug 23, 2015 at 05:52:47PM +0530, Sagar Arun Kamble wrote:
> On BXT, We Observe timeout for forcewake request completion with 2ms polling period as given here:
> [drm:fw_domains_get] ERROR render: timed out waiting for forcewake ack request.
> Polling for 50ms is recommended to avoid these timeouts.
>
> Change-Id: Ie715b0069a3049606e9602bc5e97a6511890864d
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>

Probably needs cc: stable plus a pile of bugzilla links all over ...
-Daniel

> ---
> drivers/gpu/drm/i915/intel_uncore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 9d3c2e4..2df03b1 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -27,7 +27,7 @@
>
> #include <linux/pm_runtime.h>
>
> -#define FORCEWAKE_ACK_TIMEOUT_MS 2
> +#define FORCEWAKE_ACK_TIMEOUT_MS 50
>
> #define __raw_i915_read8(dev_priv__, reg__) readb((dev_priv__)->regs + (reg__))
> #define __raw_i915_write8(dev_priv__, reg__, val__) writeb(val__, (dev_priv__)->regs + (reg__))
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation