From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Paulo Zanoni <przanoni@gmail.com>, Imre Deak <imre.deak@intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH v3 1/2] drm/i915/gtt: Do not initialize drm_mm twice.
Date: Wed, 23 Sep 2015 13:47:38 -0700 [thread overview]
Message-ID: <56030FEA.80503@virtuousgeek.org> (raw)
In-Reply-To: <CA+gsUGRU6yRQ+-v6xO1NGe-vdkCDQTuDY9SL1Ni56JbQzvr6jQ@mail.gmail.com>
On 09/23/2015 11:55 AM, Paulo Zanoni wrote:
> 2015-09-23 13:48 GMT-03:00 Imre Deak <imre.deak@intel.com>:
>> On ke, 2015-09-16 at 11:49 +0200, Michał Winiarski wrote:
>>> It would be initialized just moments later by i915_init_vm.
>>>
>>> v2: Commit msg update,
>>> s/i915_init_vm/i915_address_space_init, move to i915_gem_gtt.c,
>>> init address_space during i915_gem_setup_global_gtt for ggtt.
>>> v3: Do not init global_link - we are adding it to vm_list moments later,
>>> make i915_address_space_init static, use OOP style parameter order.
>>>
>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Michel Thierry <michel.thierry@intel.com>
>>> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
>>> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
>>
>> With this patch I get the oops below when booting. Looking at it it's
>> caused by dev_priv->gtt being initialized now too late for
>> i915_gem_object_create_stolen_for_preallocated().
>
> My BDW machine stopped booting, and git bisect tells me this patch is
> the cause. I didn't setup anything to help me grab the logs before the
> crash, so I can't confirm the backtrace below.
>
> Something interesting is that if I boot with i915.modeset=0, then
> later "rmmod i915; modprobe i915 modeset=1", the driver loads
> successfully.
>
I see this too on BYT. Can we get this reverted or get a fix?
Michal?
Thanks,
Jesse
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-23 20:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 13:30 [PATCH 1/2] drm/i915/gtt: Do not initialize drm_mm twice Michał Winiarski
2015-09-15 13:30 ` [PATCH 2/2] drm/i915/gtt: Avoid using addresses in non-canonical form Michał Winiarski
2015-09-15 13:52 ` Chris Wilson
2015-09-15 14:01 ` Michel Thierry
2015-09-15 18:04 ` [PATCH v2 " Michał Winiarski
2015-09-15 20:03 ` Chris Wilson
2015-09-16 9:50 ` [PATCH v3 " Michał Winiarski
2015-09-16 9:57 ` Chris Wilson
2015-09-17 17:17 ` Winiarski, Michal
2015-09-23 12:31 ` Daniel Vetter
2015-09-15 13:39 ` [PATCH 1/2] drm/i915/gtt: Do not initialize drm_mm twice Chris Wilson
2015-09-15 14:01 ` Michel Thierry
2015-09-15 18:01 ` [PATCH v2 " Michał Winiarski
2015-09-15 20:07 ` Chris Wilson
2015-09-15 20:07 ` Chris Wilson
2015-09-16 9:49 ` [PATCH v3 " Michał Winiarski
2015-09-17 10:59 ` Chris Wilson
2015-09-23 9:51 ` Daniel Vetter
2015-09-23 16:48 ` Imre Deak
2015-09-23 18:55 ` Paulo Zanoni
2015-09-23 20:47 ` Jesse Barnes [this message]
2015-09-24 11:20 ` Winiarski, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56030FEA.80503@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox