Re: [PATCH v3 2/2] drm/i915/gtt: Avoid using addresses in non-canonical form.

Chris Wilson
2015-09-16T09:57:45Z

On Wed, Sep 16, 2015 at 11:50:50AM +0200, Michał Winiarski wrote:
> According to bspec, some parts of HW expect the addresses to be in
> a canonical form where bits [63:48] == [47].
> If we're using 32b addressing, we never need to handle such high
> addresses, but since we've recently added 48b address space support,
> lets satisfy the HW by converting the address prior to
> alloc/insert/clear.
>
> v2: Commit msg update,
> move WARN to gen8_alloc_va_range,
> also convert to canonical in insert_entries.
> v3: Also convert for !48b (causes no harm, improves code stucture),
> update wrap comment.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>

I didn't even complain about the surplus brackets :)
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre