From: Arun Siluvery <arun.siluvery@linux.intel.com>
To: imre.deak@intel.com
Cc: intel-gfx@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH 07/12] drm/i915/bxt: Update stepping check for WaDisableSDEUnitClockGating
Date: Mon, 28 Sep 2015 12:09:15 +0100 [thread overview]
Message-ID: <56091FDB.20703@linux.intel.com> (raw)
In-Reply-To: <1443438389.15040.1.camel@intel.com>
On 28/09/2015 12:06, Imre Deak wrote:
> On pe, 2015-09-25 at 14:33 +0100, Arun Siluvery wrote:
>> It is also applicable for B0.
>>
>> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 9151a2b..be39f7ad 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -121,8 +121,10 @@ static void bxt_init_clock_gating(struct drm_device *dev)
>> gen9_init_clock_gating(dev);
>>
>> /* WaDisableSDEUnitClockGating:bxt */
>> - I915_WRITE(GEN8_UCGCTL6, I915_READ(GEN8_UCGCTL6) |
>> - GEN8_SDEUNIT_CLOCK_GATE_DISABLE);
>> + if (INTEL_REVID(dev) >= BXT_REVID_A0) {
>
> This check looks redundant.
>
Yes, I am removing it in v2.
regards
Arun
>> + I915_WRITE(GEN8_UCGCTL6, (I915_READ(GEN8_UCGCTL6) |
>> + GEN8_SDEUNIT_CLOCK_GATE_DISABLE));
>> + }
>>
>> /* WaSetHDCunitClckGatingDisable:bxt */
>> /* WaSetHdcUnitClockGatingDisableInUcgctl6:bxt */
>
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-28 11:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 13:33 [PATCH 00/12] Gen9: Changes to add/merge/update/remove WA Arun Siluvery
2015-09-25 13:33 ` [PATCH 01/12] drm/i915/gen9: Handle error returned by gen9_init_workarounds Arun Siluvery
2015-09-25 17:47 ` Ville Syrjälä
2015-09-28 13:55 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 02/12] drm/i915/gen9: Add WaOCLCoherentLineFlush Arun Siluvery
2015-09-25 17:09 ` Ville Syrjälä
2015-09-28 15:51 ` Arun Siluvery
2015-09-28 16:02 ` Ville Syrjälä
2015-09-28 16:35 ` Arun Siluvery
2015-09-25 13:33 ` [PATCH 03/12] drm/i915/gen9: Merge two WA as they part of same register Arun Siluvery
2015-09-25 17:47 ` Ville Syrjälä
2015-09-28 13:56 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 04/12] drm/i915/gen9: Merge HALF_SLICE_CHICKEN3 WA Arun Siluvery
2015-09-25 17:12 ` Ville Syrjälä
2015-09-28 8:47 ` Jani Nikula
2015-09-28 13:56 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 05/12] drm/i915/bxt: update WaSetHDCunitClckGatingDisable Arun Siluvery
2015-09-25 17:32 ` Ville Syrjälä
2015-09-25 13:33 ` [PATCH 06/12] drm/i915/bxt: Add WaStoreMultiplePTEenable name Arun Siluvery
2015-09-25 17:34 ` Ville Syrjälä
2015-09-28 13:57 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 07/12] drm/i915/bxt: Update stepping check for WaDisableSDEUnitClockGating Arun Siluvery
2015-09-25 17:17 ` Ville Syrjälä
2015-09-28 11:06 ` Imre Deak
2015-09-28 11:09 ` Arun Siluvery [this message]
2015-09-25 13:33 ` [PATCH 08/12] drm/i915/skl: Remove WaDisableSDEUnitClockGating Arun Siluvery
2015-09-25 17:39 ` Ville Syrjälä
2015-09-28 13:58 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 09/12] drm/i915/skl: Remove WaSetGAPSunitClckGateDisable Arun Siluvery
2015-09-25 17:43 ` Ville Syrjälä
2015-09-25 13:33 ` [PATCH 10/12] drm/i915/skl: Remove WaDisableVFUnitClockGating Arun Siluvery
2015-09-25 17:45 ` Ville Syrjälä
2015-09-28 14:01 ` Daniel Vetter
2015-09-25 13:33 ` [PATCH 11/12] drm/i915/skl: Remove WaSetDisablePixMaskCammingAndRhwoInCommonSliceChicken Arun Siluvery
2015-09-25 18:34 ` Ville Syrjälä
2015-09-25 18:43 ` Ville Syrjälä
2015-09-25 21:39 ` Arun Siluvery
2015-09-25 13:33 ` [PATCH 12/12] drm/i915:skl: Remove WaDisablePowerCompilerClockGating Arun Siluvery
2015-09-25 17:24 ` Ville Syrjälä
2015-09-28 11:21 ` [PATCH 00/12] Gen9: Changes to add/merge/update/remove WA Arun Siluvery
2015-09-28 14:03 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56091FDB.20703@linux.intel.com \
--to=arun.siluvery@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox