From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v2] drm/i915: prevent out of range pt in the PDE macros (take 3) Date: Mon, 5 Oct 2015 17:36:04 +0100 Message-ID: <5612A6F4.7030706@intel.com> References: <1443715175-32567-1-git-send-email-michel.thierry@intel.com> <1443791813-30551-1-git-send-email-michel.thierry@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 6042889165 for ; Mon, 5 Oct 2015 09:36:19 -0700 (PDT) In-Reply-To: <1443791813-30551-1-git-send-email-michel.thierry@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDIvMTAvMTUgMTQ6MTYsIE1pY2hlbCBUaGllcnJ5IHdyb3RlOgo+IFdlIHRyaWVkIHRvIGZp eCB0aGlzIGluIGNvbW1pdCBmZGM0NTRjMTQ4NGEgKCJkcm0vaTkxNTogUHJldmVudCBvdXQgb2YK PiByYW5nZSBwdCBpbiBnZW42X2Zvcl9lYWNoX3BkZSIpLgo+Cj4gQnV0IHRoZSBzdGF0aWMgYW5h bHl6ZXIgc3RpbGwgY29tcGxhaW5zIHRoYXQsIGp1c3QgYmVmb3JlIHdlIGJyZWFrIGR1ZQo+IHRv ICJpdGVyIDwgSTkxNV9QREVTIiwgd2UgZG8gInB0ID0gKHBkKS0+cGFnZV90YWJsZVtpdGVyXSIg d2l0aCBhbgo+IGl0ZXIgdmFsdWUgdGhhdCBpcyBiaWdnZXIgdGhhbiBJOTE1X1BERVMuIE9mIGNv dXJzZSwgdGhpcyBpc24ndCByZWFsbHkKPiBhIHByb2JsZW0gc2luY2Ugbm8gb25lIHVzZXMgcHQg b3V0c2lkZSB0aGUgbWFjcm8uIFN0aWxsLCBldmVyeSBzaW5nbGUKPiBuZXcgdXNhZ2Ugb2YgdGhl IG1hY3JvIHdpbGwgY3JlYXRlIGEgbmV3IGlzc3VlIGZvciB1cyB0byBtYXJrIGFzIGEKPiBmYWxz ZSBwb3NpdGl2ZS4KPgo+IEFsc28sIFBhdWxvIHJlLXN0YXJ0ZWQgdGhlIGRpc2N1c3Npb24gYSB3 aGlsZSBhZ28gWzFdLCBidXQgZGlkbid0IGVuZCB1cAo+IGltcGxlbWVudGVkLgo+Cj4gSW4gb3Jk ZXIgdG8gInNvbHZlIiB0aGlzICJwcm9ibGVtIiwgdGhpcyBwYXRjaCB0YWtlcyB0aGUgaWRlYXMg ZnJvbQo+IENocmlzIGFuZCBEYXZlLCBidXQgdGhhdCBjaGVjayB3b3VsZCBjaGFuZ2UgdGhlIGRl c2lyZWQgYmVoYXZpb3Igb2YgdGhlCj4gY29kZSwgYmVjYXVzZSB0aGUgb2JqZWN0IChmb3IgZXhh bXBsZSBwZHAtPnBhZ2VfZGlyZWN0b3J5W2l0ZXJdKSBjYW4gYmUKPiBudWxsIGR1cmluZyBpbml0 L2FsbG9jLCBhbmQgQyB3b3VsZCB0YWtlIHRoaXMgYXMgZmFsc2UsIGJyZWFraW5nIHRoZSBmb3IK PiBsb29wIGltbWVkaWF0ZWx5Lgo+Cj4gVGhpcyBoYXMgYmVlbiBhbHJlYWR5IHZlcmlmaWVkIHdp dGggInN0YXRpYyBhbmFseXNpcyB0b29scyIuCj4KPiBbMV1odHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL2FyY2hpdmVzL2ludGVsLWdmeC8yMDE1LUp1bmUvMDY4NTQ4Lmh0bWwKPgo+IHYyOiBN YWtlIGl0IGEgc2luZ2xlIHN0YXRlbWVudCwgd2hpbGUgcHJldmVudGluZyB0aGUgY29tbW9uIHN1 YmV4cHJlc3Npb24KPiBlbGltaW5hdGlvbiAoQ2hyaXMpCj4KPiBDYzogUGF1bG8gWmFub25pIDxw YXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt d2lsc29uLmNvLnVrPgo+IENjOiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5j b20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaCB8IDE0ICsr KysrKysrLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA2IGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0 dC5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiBpbmRleCA5ZmJiMDdk Li5hMjE2Mzk3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0 dC5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiBAQCAtMzk0 LDcgKzM5NCw4IEBAIHN0cnVjdCBpOTE1X2h3X3BwZ3R0IHsKPiAgICAqLwo+ICAgI2RlZmluZSBn ZW42X2Zvcl9lYWNoX3BkZShwdCwgcGQsIHN0YXJ0LCBsZW5ndGgsIHRlbXAsIGl0ZXIpIFwKPiAg IAlmb3IgKGl0ZXIgPSBnZW42X3BkZV9pbmRleChzdGFydCk7IFwKPiAtCSAgICAgcHQgPSAocGQp LT5wYWdlX3RhYmxlW2l0ZXJdLCBsZW5ndGggPiAwICYmIGl0ZXIgPCBJOTE1X1BERVM7IFwKPiAr CSAgICAgbGVuZ3RoID4gMCAmJiBpdGVyIDwgSTkxNV9QREVTID8gXAo+ICsJCQkocHQgPSAocGQp LT5wYWdlX3RhYmxlW2l0ZXJdKSwgMSA6IDA7IFwKPiAgIAkgICAgIGl0ZXIrKywgXAo+ICAgCSAg ICAgdGVtcCA9IEFMSUdOKHN0YXJ0KzEsIDEgPDwgR0VONl9QREVfU0hJRlQpIC0gc3RhcnQsIFwK PiAgIAkgICAgIHRlbXAgPSBtaW5fdCh1bnNpZ25lZCwgdGVtcCwgbGVuZ3RoKSwgXAo+IEBAIC00 NTksNyArNDYwLDggQEAgc3RhdGljIGlubGluZSB1aW50MzJfdCBnZW42X3BkZV9pbmRleCh1aW50 MzJfdCBhZGRyKQo+ICAgICovCj4gICAjZGVmaW5lIGdlbjhfZm9yX2VhY2hfcGRlKHB0LCBwZCwg c3RhcnQsIGxlbmd0aCwgdGVtcCwgaXRlcikJCVwKPiAgIAlmb3IgKGl0ZXIgPSBnZW44X3BkZV9p bmRleChzdGFydCk7IFwKPiAtCSAgICAgcHQgPSAocGQpLT5wYWdlX3RhYmxlW2l0ZXJdLCBsZW5n dGggPiAwICYmIGl0ZXIgPCBJOTE1X1BERVM7CVwKPiArCSAgICAgbGVuZ3RoID4gMCAmJiBpdGVy IDwgSTkxNV9QREVTID8gXAo+ICsJCQkocHQgPSAocGQpLT5wYWdlX3RhYmxlW2l0ZXJdKSwgMSA6 IDA7IFwKPiAgIAkgICAgIGl0ZXIrKywJCQkJXAo+ICAgCSAgICAgdGVtcCA9IEFMSUdOKHN0YXJ0 KzEsIDEgPDwgR0VOOF9QREVfU0hJRlQpIC0gc3RhcnQsCVwKPiAgIAkgICAgIHRlbXAgPSBtaW4o dGVtcCwgbGVuZ3RoKSwJCQkJCVwKPiBAQCAtNDY3LDggKzQ2OSw4IEBAIHN0YXRpYyBpbmxpbmUg dWludDMyX3QgZ2VuNl9wZGVfaW5kZXgodWludDMyX3QgYWRkcikKPgo+ICAgI2RlZmluZSBnZW44 X2Zvcl9lYWNoX3BkcGUocGQsIHBkcCwgc3RhcnQsIGxlbmd0aCwgdGVtcCwgaXRlcikJXAo+ICAg CWZvciAoaXRlciA9IGdlbjhfcGRwZV9pbmRleChzdGFydCk7IFwKPiAtCSAgICAgcGQgPSAocGRw KS0+cGFnZV9kaXJlY3RvcnlbaXRlcl0sIFwKPiAtCSAgICAgbGVuZ3RoID4gMCAmJiAoaXRlciA8 IEk5MTVfUERQRVNfUEVSX1BEUChkZXYpKTsgXAo+ICsJICAgICBsZW5ndGggPiAwICYmIChpdGVy IDwgSTkxNV9QRFBFU19QRVJfUERQKGRldikpID8gXAo+ICsJCQkocGQgPSAocGRwKS0+cGFnZV9k aXJlY3RvcnlbaXRlcl0pLCAxIDogMDsgXAo+ICAgCSAgICAgaXRlcisrLAkJCQlcCj4gICAJICAg ICB0ZW1wID0gQUxJR04oc3RhcnQrMSwgMSA8PCBHRU44X1BEUEVfU0hJRlQpIC0gc3RhcnQsCVwK PiAgIAkgICAgIHRlbXAgPSBtaW4odGVtcCwgbGVuZ3RoKSwJCQkJCVwKPiBAQCAtNDc2LDggKzQ3 OCw4IEBAIHN0YXRpYyBpbmxpbmUgdWludDMyX3QgZ2VuNl9wZGVfaW5kZXgodWludDMyX3QgYWRk cikKPgo+ICAgI2RlZmluZSBnZW44X2Zvcl9lYWNoX3BtbDRlKHBkcCwgcG1sNCwgc3RhcnQsIGxl bmd0aCwgdGVtcCwgaXRlcikJXAo+ICAgCWZvciAoaXRlciA9IGdlbjhfcG1sNGVfaW5kZXgoc3Rh cnQpOwlcCj4gLQkgICAgIHBkcCA9IChwbWw0KS0+cGRwc1tpdGVyXSwgXAo+IC0JICAgICBsZW5n dGggPiAwICYmIGl0ZXIgPCBHRU44X1BNTDRFU19QRVJfUE1MNDsgXAo+ICsJICAgICBsZW5ndGgg PiAwICYmIGl0ZXIgPCBHRU44X1BNTDRFU19QRVJfUE1MNCA/IFwKPiArCQkJKHBkcCA9IChwbWw0 KS0+cGRwc1tpdGVyXSksIDEgOiAwOyBcCgp0aGlzIHdvbid0IGNvbXBpbGUgLS0gc2VlIGJlbG93 Cgo+ICAgCSAgICAgaXRlcisrLAkJCQlcCj4gICAJICAgICB0ZW1wID0gQUxJR04oc3RhcnQrMSwg MVVMTCA8PCBHRU44X1BNTDRFX1NISUZUKSAtIHN0YXJ0LAlcCj4gICAJICAgICB0ZW1wID0gbWlu KHRlbXAsIGxlbmd0aCksCQkJCQlcCgpUaGUgbWFuIHBhZ2UgZm9yIEMgb3BlcmF0b3JzIHRlbGxz IHVzOgoKICAgICAgICBPcGVyYXRvciAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQXNzb2Np YXRpdml0eQogICAgICAgICgpIFtdIC0+IC4gICAgICAgICAgICAgICAgICAgICAgICAgICBsZWZ0 IHRvIHJpZ2h0CiAgICAgICAgISB+ICsrIC0tICsgLSAodHlwZSkgKiAmIHNpemVvZiAgICAgIHJp Z2h0IHRvIGxlZnQKICAgICAgICAqIC8gJSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bGVmdCB0byByaWdodAogICAgICAgICsgLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBsZWZ0IHRvIHJpZ2h0CiAgICAgICAgPDwgPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGxlZnQgdG8gcmlnaHQKICAgICAgICA8IDw9ID4gPj0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgbGVmdCB0byByaWdodAogICAgICAgID09ICE9ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBsZWZ0IHRvIHJpZ2h0CiAgICAgICAgJiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGxlZnQgdG8gcmlnaHQKICAgICAgICBeICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbGVmdCB0byByaWdodAogICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBsZWZ0IHRvIHJpZ2h0CiAgICAgICAgJiYgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGxlZnQgdG8gcmlnaHQKICAgICAgICB8fCAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbGVmdCB0byByaWdodAogICAgICAgID86ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICByaWdodCB0byBsZWZ0CiAgICAgICAgPSArPSAtPSAqPSAvPSAl PSA8PD0gPj49ICY9IF49IHw9ICAgIHJpZ2h0IHRvIGxlZnQKICAgICAgICAsICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbGVmdCB0byByaWdodAoKU28gdGhlcmUncyBhIHByb2Js ZW0gd2l0aCB0aGUgYWJvdmUgY29kZSwgYmVjYXVzZSB0aGUgY29tbWEgb3BlcmF0b3IgaXMgCkxP V0VSIHByZWNlZGVuY2UgdGhhbiBlaXRoZXIgYXNzaWdubWVudCBvciA/OiBZb3UnZCBuZWVkIHRv IHB1dCB0aGUgCnBhcmVudGhlc2VzIGFyb3VuZCB0aGUgKHBkcCA9IC4uLiAsIDEpIHNlY3Rpb24s IG5vdCBqdXN0IHRoZSBhc3NpZ25tZW50LgoKT3IgZm9yIHlldCBhbm90aGVyIHZhcmlhdGlvbiwg aG93IGFib3V0OgoKI2RlZmluZSBnZW44X2Zvcl9lYWNoX3BkcGUocGQsIHBkcCwgc3RhcnQsIGxl bmd0aCwgdGVtcCwgaXRlcikgICAgICAgICBcCiAgICAgICAgIGZvciAoaXRlciA9IGdlbjhfcGRw ZV9pbmRleChzdGFydCk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAgICAgICAg ICBpdGVyIDwgSTkxNV9QRFBFU19QRVJfUERQKGRldikgJiYgICAgICAgICAgICAgICAgICAgICAg ICAgXAogICAgICAgICAgICAgICAgIChwZCA9IChwZHApLT5wYWdlX2RpcmVjdG9yeVtpdGVyXSwg bGVuZ3RoID4gMCk7ICAgICAgICBcCiAgICAgICAgICAgICAgaXRlcisrLCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAgICAgICAgICB0ZW1w ID0gQUxJR04oc3RhcnQrMSwgMSA8PCBHRU44X1BEUEVfU0hJRlQpIC0gc3RhcnQsICAgICAgXAog ICAgICAgICAgICAgIHRlbXAgPSBtaW4odGVtcCwgbGVuZ3RoKSwgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBcCiAgICAgICAgICAgICAgc3RhcnQgKz0gdGVtcCwgbGVuZ3RoIC09IHRl bXApCgojZGVmaW5lIGdlbjhfZm9yX2VhY2hfcG1sNGUocGRwLCBwbWw0LCBzdGFydCwgbGVuZ3Ro LCB0ZW1wLCBpdGVyKSAgICAgIFwKICAgICAgICAgZm9yIChpdGVyID0gZ2VuOF9wbWw0ZV9pbmRl eChzdGFydCk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgIGl0ZXIg PCBHRU44X1BNTDRFU19QRVJfUE1MNCAmJiAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAg ICAgICAgICAgICAgICAgKHBkcCA9IChwbWw0KS0+cGRwc1tpdGVyXSwgbGVuZ3RoID4gMCk7ICAg ICAgICAgICAgICAgIFwKICAgICAgICAgICAgICBpdGVyKyssICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgIHRlbXAgPSBBTElH TihzdGFydCsxLCAxVUxMIDw8IEdFTjhfUE1MNEVfU0hJRlQpIC0gc3RhcnQsICBcCiAgICAgICAg ICAgICAgdGVtcCA9IG1pbih0ZW1wLCBsZW5ndGgpLCAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFwKICAgICAgICAgICAgICBzdGFydCArPSB0ZW1wLCBsZW5ndGggLT0gdGVtcCkKCndp dGggbm8gdWdseSA/OiBhdCBhbGwgOikKCi5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=