From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH v2] drm/i915: prevent out of range pt in the PDE macros (take 3) Date: Mon, 5 Oct 2015 17:59:50 +0100 Message-ID: <5612AC86.3030202@intel.com> References: <1443715175-32567-1-git-send-email-michel.thierry@intel.com> <1443791813-30551-1-git-send-email-michel.thierry@intel.com> <5612A6F4.7030706@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 736216E28A for ; Mon, 5 Oct 2015 09:59:52 -0700 (PDT) In-Reply-To: <5612A6F4.7030706@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTAvNS8yMDE1IDU6MzYgUE0sIERhdmUgR29yZG9uIHdyb3RlOgo+IE9uIDAyLzEwLzE1IDE0 OjE2LCBNaWNoZWwgVGhpZXJyeSB3cm90ZToKPj4gV2UgdHJpZWQgdG8gZml4IHRoaXMgaW4gY29t bWl0IGZkYzQ1NGMxNDg0YSAoImRybS9pOTE1OiBQcmV2ZW50IG91dCBvZgo+PiByYW5nZSBwdCBp biBnZW42X2Zvcl9lYWNoX3BkZSIpLgo+Pgo+PiBCdXQgdGhlIHN0YXRpYyBhbmFseXplciBzdGls bCBjb21wbGFpbnMgdGhhdCwganVzdCBiZWZvcmUgd2UgYnJlYWsgZHVlCj4+IHRvICJpdGVyIDwg STkxNV9QREVTIiwgd2UgZG8gInB0ID0gKHBkKS0+cGFnZV90YWJsZVtpdGVyXSIgd2l0aCBhbgo+ PiBpdGVyIHZhbHVlIHRoYXQgaXMgYmlnZ2VyIHRoYW4gSTkxNV9QREVTLiBPZiBjb3Vyc2UsIHRo aXMgaXNuJ3QgcmVhbGx5Cj4+IGEgcHJvYmxlbSBzaW5jZSBubyBvbmUgdXNlcyBwdCBvdXRzaWRl IHRoZSBtYWNyby4gU3RpbGwsIGV2ZXJ5IHNpbmdsZQo+PiBuZXcgdXNhZ2Ugb2YgdGhlIG1hY3Jv IHdpbGwgY3JlYXRlIGEgbmV3IGlzc3VlIGZvciB1cyB0byBtYXJrIGFzIGEKPj4gZmFsc2UgcG9z aXRpdmUuCj4+Cj4+IEFsc28sIFBhdWxvIHJlLXN0YXJ0ZWQgdGhlIGRpc2N1c3Npb24gYSB3aGls ZSBhZ28gWzFdLCBidXQgZGlkbid0IGVuZCB1cAo+PiBpbXBsZW1lbnRlZC4KPj4KPj4gSW4gb3Jk ZXIgdG8gInNvbHZlIiB0aGlzICJwcm9ibGVtIiwgdGhpcyBwYXRjaCB0YWtlcyB0aGUgaWRlYXMg ZnJvbQo+PiBDaHJpcyBhbmQgRGF2ZSwgYnV0IHRoYXQgY2hlY2sgd291bGQgY2hhbmdlIHRoZSBk ZXNpcmVkIGJlaGF2aW9yIG9mIHRoZQo+PiBjb2RlLCBiZWNhdXNlIHRoZSBvYmplY3QgKGZvciBl eGFtcGxlIHBkcC0+cGFnZV9kaXJlY3RvcnlbaXRlcl0pIGNhbiBiZQo+PiBudWxsIGR1cmluZyBp bml0L2FsbG9jLCBhbmQgQyB3b3VsZCB0YWtlIHRoaXMgYXMgZmFsc2UsIGJyZWFraW5nIHRoZSBm b3IKPj4gbG9vcCBpbW1lZGlhdGVseS4KPj4KPj4gVGhpcyBoYXMgYmVlbiBhbHJlYWR5IHZlcmlm aWVkIHdpdGggInN0YXRpYyBhbmFseXNpcyB0b29scyIuCj4+Cj4+IFsxXWh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvaW50ZWwtZ2Z4LzIwMTUtSnVuZS8wNjg1NDguaHRtbAo+ Pgo+PiB2MjogTWFrZSBpdCBhIHNpbmdsZSBzdGF0ZW1lbnQsIHdoaWxlIHByZXZlbnRpbmcgdGhl IGNvbW1vbiBzdWJleHByZXNzaW9uCj4+IGVsaW1pbmF0aW9uIChDaHJpcykKPj4KPj4gQ2M6IFBh dWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+PiBDYzogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IENjOiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5n b3Jkb25AaW50ZWwuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBNaWNoZWwgVGhpZXJyeSA8bWljaGVs LnRoaWVycnlAaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ndHQuaCB8IDE0ICsrKysrKysrLS0tLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDggaW5z ZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fZ3R0LmgKPj4gaW5kZXggOWZiYjA3ZC4uYTIxNjM5NyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fZ3R0LmgKPj4gQEAgLTM5NCw3ICszOTQsOCBAQCBzdHJ1Y3QgaTkxNV9od19w cGd0dCB7Cj4+ICAgICovCj4+ICAgI2RlZmluZSBnZW42X2Zvcl9lYWNoX3BkZShwdCwgcGQsIHN0 YXJ0LCBsZW5ndGgsIHRlbXAsIGl0ZXIpIFwKPj4gICAgICAgZm9yIChpdGVyID0gZ2VuNl9wZGVf aW5kZXgoc3RhcnQpOyBcCj4+IC0gICAgICAgICBwdCA9IChwZCktPnBhZ2VfdGFibGVbaXRlcl0s IGxlbmd0aCA+IDAgJiYgaXRlciA8IEk5MTVfUERFUzsgXAo+PiArICAgICAgICAgbGVuZ3RoID4g MCAmJiBpdGVyIDwgSTkxNV9QREVTID8gXAo+PiArICAgICAgICAgICAgKHB0ID0gKHBkKS0+cGFn ZV90YWJsZVtpdGVyXSksIDEgOiAwOyBcCj4+ICAgICAgICAgICAgaXRlcisrLCBcCj4+ICAgICAg ICAgICAgdGVtcCA9IEFMSUdOKHN0YXJ0KzEsIDEgPDwgR0VONl9QREVfU0hJRlQpIC0gc3RhcnQs IFwKPj4gICAgICAgICAgICB0ZW1wID0gbWluX3QodW5zaWduZWQsIHRlbXAsIGxlbmd0aCksIFwK Pj4gQEAgLTQ1OSw3ICs0NjAsOCBAQCBzdGF0aWMgaW5saW5lIHVpbnQzMl90IGdlbjZfcGRlX2lu ZGV4KHVpbnQzMl90IGFkZHIpCj4+ICAgICovCj4+ICAgI2RlZmluZSBnZW44X2Zvcl9lYWNoX3Bk ZShwdCwgcGQsIHN0YXJ0LCBsZW5ndGgsIHRlbXAsIGl0ZXIpICAgICAgICBcCj4+ICAgICAgIGZv ciAoaXRlciA9IGdlbjhfcGRlX2luZGV4KHN0YXJ0KTsgXAo+PiAtICAgICAgICAgcHQgPSAocGQp LT5wYWdlX3RhYmxlW2l0ZXJdLCBsZW5ndGggPiAwICYmIGl0ZXIgPAo+PiBJOTE1X1BERVM7ICAg IFwKPj4gKyAgICAgICAgIGxlbmd0aCA+IDAgJiYgaXRlciA8IEk5MTVfUERFUyA/IFwKPj4gKyAg ICAgICAgICAgIChwdCA9IChwZCktPnBhZ2VfdGFibGVbaXRlcl0pLCAxIDogMDsgXAo+PiAgICAg ICAgICAgIGl0ZXIrKywgICAgICAgICAgICAgICAgXAo+PiAgICAgICAgICAgIHRlbXAgPSBBTElH TihzdGFydCsxLCAxIDw8IEdFTjhfUERFX1NISUZUKSAtIHN0YXJ0LCAgICBcCj4+ICAgICAgICAg ICAgdGVtcCA9IG1pbih0ZW1wLCBsZW5ndGgpLCAgICAgICAgICAgICAgICAgICAgXAo+PiBAQCAt NDY3LDggKzQ2OSw4IEBAIHN0YXRpYyBpbmxpbmUgdWludDMyX3QgZ2VuNl9wZGVfaW5kZXgodWlu dDMyX3QgYWRkcikKPj4KPj4gICAjZGVmaW5lIGdlbjhfZm9yX2VhY2hfcGRwZShwZCwgcGRwLCBz dGFydCwgbGVuZ3RoLCB0ZW1wLCBpdGVyKSAgICBcCj4+ICAgICAgIGZvciAoaXRlciA9IGdlbjhf cGRwZV9pbmRleChzdGFydCk7IFwKPj4gLSAgICAgICAgIHBkID0gKHBkcCktPnBhZ2VfZGlyZWN0 b3J5W2l0ZXJdLCBcCj4+IC0gICAgICAgICBsZW5ndGggPiAwICYmIChpdGVyIDwgSTkxNV9QRFBF U19QRVJfUERQKGRldikpOyBcCj4+ICsgICAgICAgICBsZW5ndGggPiAwICYmIChpdGVyIDwgSTkx NV9QRFBFU19QRVJfUERQKGRldikpID8gXAo+PiArICAgICAgICAgICAgKHBkID0gKHBkcCktPnBh Z2VfZGlyZWN0b3J5W2l0ZXJdKSwgMSA6IDA7IFwKPj4gICAgICAgICAgICBpdGVyKyssICAgICAg ICAgICAgICAgIFwKPj4gICAgICAgICAgICB0ZW1wID0gQUxJR04oc3RhcnQrMSwgMSA8PCBHRU44 X1BEUEVfU0hJRlQpIC0gc3RhcnQsICAgIFwKPj4gICAgICAgICAgICB0ZW1wID0gbWluKHRlbXAs IGxlbmd0aCksICAgICAgICAgICAgICAgICAgICBcCj4+IEBAIC00NzYsOCArNDc4LDggQEAgc3Rh dGljIGlubGluZSB1aW50MzJfdCBnZW42X3BkZV9pbmRleCh1aW50MzJfdCBhZGRyKQo+Pgo+PiAg ICNkZWZpbmUgZ2VuOF9mb3JfZWFjaF9wbWw0ZShwZHAsIHBtbDQsIHN0YXJ0LCBsZW5ndGgsIHRl bXAsIGl0ZXIpICAgIFwKPj4gICAgICAgZm9yIChpdGVyID0gZ2VuOF9wbWw0ZV9pbmRleChzdGFy dCk7ICAgIFwKPj4gLSAgICAgICAgIHBkcCA9IChwbWw0KS0+cGRwc1tpdGVyXSwgXAo+PiAtICAg ICAgICAgbGVuZ3RoID4gMCAmJiBpdGVyIDwgR0VOOF9QTUw0RVNfUEVSX1BNTDQ7IFwKPj4gKyAg ICAgICAgIGxlbmd0aCA+IDAgJiYgaXRlciA8IEdFTjhfUE1MNEVTX1BFUl9QTUw0ID8gXAo+PiAr ICAgICAgICAgICAgKHBkcCA9IChwbWw0KS0+cGRwc1tpdGVyXSksIDEgOiAwOyBcCj4KPiB0aGlz IHdvbid0IGNvbXBpbGUgLS0gc2VlIGJlbG93CgpIbW0sIGl0IGNvbXBpbGVkIChhbHNvIGdvdCBy aWQgb2Ygb2YgdGhlICJhbmFseXNpcyB0b29sIGVycm9yIiBhbmQgCmRpZG4ndCBzZWUgYW55IGJl aGF2aW9yIGNoYW5nZSkuCgo+Cj4+ICAgICAgICAgICAgaXRlcisrLCAgICAgICAgICAgICAgICBc Cj4+ICAgICAgICAgICAgdGVtcCA9IEFMSUdOKHN0YXJ0KzEsIDFVTEwgPDwgR0VOOF9QTUw0RV9T SElGVCkgLSBzdGFydCwgICAgXAo+PiAgICAgICAgICAgIHRlbXAgPSBtaW4odGVtcCwgbGVuZ3Ro KSwgICAgICAgICAgICAgICAgICAgIFwKPgo+IFRoZSBtYW4gcGFnZSBmb3IgQyBvcGVyYXRvcnMg dGVsbHMgdXM6Cj4KPiAgICAgICAgIE9wZXJhdG9yICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBBc3NvY2lhdGl2aXR5Cj4gICAgICAgICAoKSBbXSAtPiAuICAgICAgICAgICAgICAgICAgICAg ICAgICAgbGVmdCB0byByaWdodAo+ICAgICAgICAgISB+ICsrIC0tICsgLSAodHlwZSkgKiAmIHNp emVvZiAgICAgIHJpZ2h0IHRvIGxlZnQKPiAgICAgICAgICogLyAlICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBsZWZ0IHRvIHJpZ2h0Cj4gICAgICAgICArIC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbGVmdCB0byByaWdodAo+ICAgICAgICAgPDwgPj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGxlZnQgdG8gcmlnaHQKPiAgICAgICAgIDwgPD0gPiA+PSAg ICAgICAgICAgICAgICAgICAgICAgICAgICBsZWZ0IHRvIHJpZ2h0Cj4gICAgICAgICA9PSAhPSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGVmdCB0byByaWdodAo+ICAgICAgICAgJiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxlZnQgdG8gcmlnaHQKPiAgICAgICAg IF4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsZWZ0IHRvIHJpZ2h0Cj4gICAg ICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGVmdCB0byByaWdodAo+ ICAgICAgICAgJiYgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxlZnQgdG8gcmln aHQKPiAgICAgICAgIHx8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsZWZ0IHRv IHJpZ2h0Cj4gICAgICAgICA/OiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmln aHQgdG8gbGVmdAo+ICAgICAgICAgPSArPSAtPSAqPSAvPSAlPSA8PD0gPj49ICY9IF49IHw9ICAg IHJpZ2h0IHRvIGxlZnQKPiAgICAgICAgICwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBsZWZ0IHRvIHJpZ2h0Cj4KPiBTbyB0aGVyZSdzIGEgcHJvYmxlbSB3aXRoIHRoZSBhYm92 ZSBjb2RlLCBiZWNhdXNlIHRoZSBjb21tYSBvcGVyYXRvciBpcwo+IExPV0VSIHByZWNlZGVuY2Ug dGhhbiBlaXRoZXIgYXNzaWdubWVudCBvciA/OiBZb3UnZCBuZWVkIHRvIHB1dCB0aGUKPiBwYXJl bnRoZXNlcyBhcm91bmQgdGhlIChwZHAgPSAuLi4gLCAxKSBzZWN0aW9uLCBub3QganVzdCB0aGUg YXNzaWdubWVudC4KPgo+IE9yIGZvciB5ZXQgYW5vdGhlciB2YXJpYXRpb24sIGhvdyBhYm91dDoK Pgo+ICNkZWZpbmUgZ2VuOF9mb3JfZWFjaF9wZHBlKHBkLCBwZHAsIHN0YXJ0LCBsZW5ndGgsIHRl bXAsIGl0ZXIpICAgICAgICAgXAo+ICAgICAgICAgIGZvciAoaXRlciA9IGdlbjhfcGRwZV9pbmRl eChzdGFydCk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKPiAgICAgICAgICAgICAgIGl0 ZXIgPCBJOTE1X1BEUEVTX1BFUl9QRFAoZGV2KSAmJiAgICAgICAgICAgICAgICAgICAgICAgICBc Cj4gICAgICAgICAgICAgICAgICAocGQgPSAocGRwKS0+cGFnZV9kaXJlY3RvcnlbaXRlcl0sIGxl bmd0aCA+IDApOyAgICAgICAgXAo+ICAgICAgICAgICAgICAgaXRlcisrLCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKPiAgICAgICAgICAgICAgIHRl bXAgPSBBTElHTihzdGFydCsxLCAxIDw8IEdFTjhfUERQRV9TSElGVCkgLSBzdGFydCwgICAgICBc Cj4gICAgICAgICAgICAgICB0ZW1wID0gbWluKHRlbXAsIGxlbmd0aCksICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXAo+ICAgICAgICAgICAgICAgc3RhcnQgKz0gdGVtcCwgbGVuZ3Ro IC09IHRlbXApCj4KPiAjZGVmaW5lIGdlbjhfZm9yX2VhY2hfcG1sNGUocGRwLCBwbWw0LCBzdGFy dCwgbGVuZ3RoLCB0ZW1wLCBpdGVyKSAgICAgIFwKPiAgICAgICAgICBmb3IgKGl0ZXIgPSBnZW44 X3BtbDRlX2luZGV4KHN0YXJ0KTsgICAgICAgICAgICAgICAgICAgICAgICAgICBcCj4gICAgICAg ICAgICAgICBpdGVyIDwgR0VOOF9QTUw0RVNfUEVSX1BNTDQgJiYgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXAo+ICAgICAgICAgICAgICAgICAgKHBkcCA9IChwbWw0KS0+cGRwc1tpdGVyXSwg bGVuZ3RoID4gMCk7ICAgICAgICAgICAgICAgIFwKPiAgICAgICAgICAgICAgIGl0ZXIrKywgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCj4gICAgICAg ICAgICAgICB0ZW1wID0gQUxJR04oc3RhcnQrMSwgMVVMTCA8PCBHRU44X1BNTDRFX1NISUZUKSAt IHN0YXJ0LCAgXAo+ICAgICAgICAgICAgICAgdGVtcCA9IG1pbih0ZW1wLCBsZW5ndGgpLCAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKPiAgICAgICAgICAgICAgIHN0YXJ0ICs9IHRl bXAsIGxlbmd0aCAtPSB0ZW1wKQo+Cj4gd2l0aCBubyB1Z2x5ID86IGF0IGFsbCA6KQoKVGhpcyBh bHNvIHdvcmtzLgoKU2luY2UgaXQncyBhIGNoYW5nZSBmb3Igbm90IGEgcmVhbCBpc3N1ZSwgSSBk b24ndCBoYXZlIGEgcHJlZmVyZW5jZS4KSSBjYW4gc2VuZCBlaXRoZXIuCgpUaGFua3MsCgo+Cj4g LkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==