From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/2] drm/i915: Drop i915_gem_obj_is_pinned() from set-cache-level Date: Wed, 7 Oct 2015 16:57:25 +0100 Message-ID: <561540E5.7050207@linux.intel.com> References: <1444127996-23561-1-git-send-email-chris@chris-wilson.co.uk> <1444127996-23561-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 5666772147 for ; Wed, 7 Oct 2015 08:57:30 -0700 (PDT) In-Reply-To: <1444127996-23561-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CkhpLAoKT24gMDYvMTAvMTUgMTE6MzksIENocmlzIFdpbHNvbiB3cm90ZToKPiBTaW5jZSB0aGUg cmVtb3ZlIG9mIHRoZSBwaW4taW9jdGwsIHdlIG9ubHkgY2FyZSBhYm91dCBub3QgY2hhbmdpbmcg dGhlCj4gY2FjaGUgbGV2ZWwgb24gYnVmZmVycyBwaW5uZWQgdG8gdGhlIGhhcmR3YXJlIGFzIGlu ZGljYXRlZCBieQo+IG9iai0+cGluX2Rpc3BsYXkuIFNvIHdlIGNhbiBzYWZlbHkgcmVwbGFjZSBp OTE1X2dlbV9vYmplY3RfaXNfcGlubmVkKCkKCmk5MTVfZ2VtX29ial9pc19waW5uZWQKCj4gaGVy ZSB3aXRoIGEgcGxhaW4gb2JqLT5waW5fZGlzcGxheSBjaGVjay4gRHVyaW5nIHJlYmluZGluZywg d2Ugd2lsbCBjaGVjawo+IHNhbml0eSBjaGVja3MgaW4gY2FzZSB2bWEtPnBpbl9jb3VudCBpcyBl cnJvbmVvdXNseSBzZXQuCgoiZG8gc2FuaXR5IGNoZWNrcyIgb3Igc29tZXRoaW5nLgoKPiBBdCB0 aGUgc2FtZSB0aW1lLCB3ZSBjYW4gbWljcm8tb3B0aW1pc2UgR1RUIG1tYXAoKSBiZWhhdmlvdXIg c2luY2Ugd2UKPiBvbmx5IG5lZWQgdG8gcmVsaW5xdWlzaCB0aGUgbW1hcHMgYmVmb3JlIFNhbmR5 YnJpZGdlLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgNDAg KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5n ZWQsIDI0IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4gaW5kZXggZDRhM2JkZjBjNWI2Li4yYjhlZDdhMmZhYWIgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtLmMKPiBAQCAtMzYyOSwzMSArMzYyOSwzNCBAQCBpbnQgaTkxNV9nZW1fb2Jq ZWN0X3NldF9jYWNoZV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAg ewo+ICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBvYmotPmJhc2UuZGV2Owo+ICAgCXN0cnVj dCBpOTE1X3ZtYSAqdm1hLCAqbmV4dDsKPiArCWJvb2wgYm91bmQgPSBmYWxzZTsKPiAgIAlpbnQg cmV0ID0gMDsKPgo+ICAgCWlmIChvYmotPmNhY2hlX2xldmVsID09IGNhY2hlX2xldmVsKQo+ICAg CQlnb3RvIG91dDsKPgo+IC0JaWYgKGk5MTVfZ2VtX29ial9pc19waW5uZWQob2JqKSkgewo+IC0J CURSTV9ERUJVRygiY2FuIG5vdCBjaGFuZ2UgdGhlIGNhY2hlIGxldmVsIG9mIHBpbm5lZCBvYmpl Y3RzXG4iKTsKPiAtCQlyZXR1cm4gLUVCVVNZOwo+IC0JfQo+IC0KPiAgIAlsaXN0X2Zvcl9lYWNo X2VudHJ5X3NhZmUodm1hLCBuZXh0LCAmb2JqLT52bWFfbGlzdCwgdm1hX2xpbmspIHsKPiArCQlp ZiAoIWRybV9tbV9ub2RlX2FsbG9jYXRlZCgmdm1hLT5ub2RlKSkKPiArCQkJY29udGludWU7Cj4g Kwo+ICsJCWlmICh2bWEtPnBpbl9jb3VudCkgewo+ICsJCQlEUk1fREVCVUcoImNhbiBub3QgY2hh bmdlIHRoZSBjYWNoZSBsZXZlbCBvZiBwaW5uZWQgb2JqZWN0c1xuIik7Cj4gKwkJCXJldHVybiAt RUJVU1k7Cj4gKwkJfQo+ICsKCkJ1dCB0aGlzIGlzIHRoZSBzYW1lIGFzIGk5MTVfZ2VtX29ial9p c19waW5uZWQsIHdoZXJlIGlzIHRoZSAKb2JqLT5waW5fZGlzcGxheSBjaGFuZ2UgY29tbWl0IG1l c3NhZ2UgdGFsa3MgYWJvdXQ/Cgo+ICAgCQlpZiAoIWk5MTVfZ2VtX3ZhbGlkX2d0dF9zcGFjZSh2 bWEsIGNhY2hlX2xldmVsKSkgewo+ICAgCQkJcmV0ID0gaTkxNV92bWFfdW5iaW5kKHZtYSk7Cj4g ICAJCQlpZiAocmV0KQo+ICAgCQkJCXJldHVybiByZXQ7Cj4gLQkJfQo+ICsJCX0gZWxzZQo+ICsJ CQlib3VuZCA9IHRydWU7Cj4gICAJfQo+Cj4gLQlpZiAoaTkxNV9nZW1fb2JqX2JvdW5kX2FueShv YmopKSB7Cj4gKwlpZiAoYm91bmQpIHsKPiAgIAkJcmV0ID0gaTkxNV9nZW1fb2JqZWN0X3dhaXRf cmVuZGVyaW5nKG9iaiwgZmFsc2UpOwo+ICAgCQlpZiAocmV0KQo+ICAgCQkJcmV0dXJuIHJldDsK Pgo+IC0JCWk5MTVfZ2VtX29iamVjdF9maW5pc2hfZ3R0KG9iaik7Cj4gLQo+ICAgCQkvKiBCZWZv cmUgU2FuZHlCcmlkZ2UsIHlvdSBjb3VsZCBub3QgdXNlIHRpbGluZyBvciBmZW5jZQo+ICAgCQkg KiByZWdpc3RlcnMgd2l0aCBzbm9vcGVkIG1lbW9yeSwgc28gcmVsaW5xdWlzaCBhbnkgZmVuY2Vz Cj4gICAJCSAqIGN1cnJlbnRseSBwb2ludGluZyB0byBvdXIgcmVnaW9uIGluIHRoZSBhcGVydHVy ZS4KPiBAQCAtMzY2NCwxMyArMzY2NywxOCBAQCBpbnQgaTkxNV9nZW1fb2JqZWN0X3NldF9jYWNo ZV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAgCQkJCXJldHVybiBy ZXQ7Cj4gICAJCX0KPgo+IC0JCWxpc3RfZm9yX2VhY2hfZW50cnkodm1hLCAmb2JqLT52bWFfbGlz dCwgdm1hX2xpbmspCj4gLQkJCWlmIChkcm1fbW1fbm9kZV9hbGxvY2F0ZWQoJnZtYS0+bm9kZSkp IHsKPiAtCQkJCXJldCA9IGk5MTVfdm1hX2JpbmQodm1hLCBjYWNoZV9sZXZlbCwKPiAtCQkJCQkJ ICAgIFBJTl9VUERBVEUpOwo+IC0JCQkJaWYgKHJldCkKPiAtCQkJCQlyZXR1cm4gcmV0Owo+IC0J CQl9Cj4gKwkJLyogQWNjZXNzIHRvIHNub29wYWJsZSBwYWdlcyB0aHJvdWdoIHRoZSBHVFQgaXMg aW5jb2hlcmVudC4gKi8KPiArCQlpZiAoY2FjaGVfbGV2ZWwgIT0gSTkxNV9DQUNIRV9OT05FICYm ICFIQVNfTExDKGRldikpCj4gKwkJCWk5MTVfZ2VtX3JlbGVhc2VfbW1hcChvYmopOwoKRG9uJ3Qg ZnVsbHkgdW5kZXJzdGFuZCB0aGlzIG9uZSAtIGJ1dCBteSBxdWVzdGlvbiBpcyB0aGlzLiBQcmV2 aW91c2x5IAp1c2Vyc3BhY2Ugd291bGQgbG9zZSBtYXBwaW5ncyBvbiBjYWNoZSBsZXZlbCBjaGFu Z2VzIGFueSB0aW1lLCBhZnRlciAKdGhpcyBvbmx5IG9uICFMTEMgd2hlbiB0dXJuaW5nIG9uIGNh Y2hpbmcgbW9kZS4gU28gdGhpcyBtZWFucyB1c2Vyc3BhY2UgCm5lZWRzIHRvIGtub3cgYWJvdXQg dGhpcyBjaGFuZ2UgYW5kIG1vZGlmeSBpdCdzIGJlaGF2aW9yPyBPciB3aGF0IApleGFjdGx5IHdv dWxkIGhhcHBlbiBpbiBwcmFjdGljZT8KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK