From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/2] drm/i915: Drop i915_gem_obj_is_pinned() from set-cache-level Date: Thu, 8 Oct 2015 10:32:39 +0100 Message-ID: <56163837.5070302@linux.intel.com> References: <1444127996-23561-1-git-send-email-chris@chris-wilson.co.uk> <1444127996-23561-2-git-send-email-chris@chris-wilson.co.uk> <561540E5.7050207@linux.intel.com> <20151007161935.GG27939@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id A9DE46EC98 for ; Thu, 8 Oct 2015 02:33:01 -0700 (PDT) In-Reply-To: <20151007161935.GG27939@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzEwLzE1IDE3OjE5LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gV2VkLCBPY3QgMDcs IDIwMTUgYXQgMDQ6NTc6MjVQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IEhp LAo+Pgo+PiBPbiAwNi8xMC8xNSAxMTozOSwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+Pj4gU2luY2Ug dGhlIHJlbW92ZSBvZiB0aGUgcGluLWlvY3RsLCB3ZSBvbmx5IGNhcmUgYWJvdXQgbm90IGNoYW5n aW5nIHRoZQo+Pj4gY2FjaGUgbGV2ZWwgb24gYnVmZmVycyBwaW5uZWQgdG8gdGhlIGhhcmR3YXJl IGFzIGluZGljYXRlZCBieQo+Pj4gb2JqLT5waW5fZGlzcGxheS4gU28gd2UgY2FuIHNhZmVseSBy ZXBsYWNlIGk5MTVfZ2VtX29iamVjdF9pc19waW5uZWQoKQoKW3NuaXBdCgo+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbS5jCj4+PiBpbmRleCBkNGEzYmRmMGM1YjYuLjJiOGVkN2EyZmFhYiAxMDA2NDQK Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+IEBAIC0zNjI5LDMxICszNjI5LDM0IEBAIGlu dCBpOTE1X2dlbV9vYmplY3Rfc2V0X2NhY2hlX2xldmVsKHN0cnVjdCBkcm1faTkxNV9nZW1fb2Jq ZWN0ICpvYmosCj4+PiAgIHsKPj4+ICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBvYmotPmJh c2UuZGV2Owo+Pj4gICAJc3RydWN0IGk5MTVfdm1hICp2bWEsICpuZXh0Owo+Pj4gKwlib29sIGJv dW5kID0gZmFsc2U7Cj4+PiAgIAlpbnQgcmV0ID0gMDsKPj4+Cj4+PiAgIAlpZiAob2JqLT5jYWNo ZV9sZXZlbCA9PSBjYWNoZV9sZXZlbCkKPj4+ICAgCQlnb3RvIG91dDsKPj4+Cj4+PiAtCWlmIChp OTE1X2dlbV9vYmpfaXNfcGlubmVkKG9iaikpIHsKPj4+IC0JCURSTV9ERUJVRygiY2FuIG5vdCBj aGFuZ2UgdGhlIGNhY2hlIGxldmVsIG9mIHBpbm5lZCBvYmplY3RzXG4iKTsKPj4+IC0JCXJldHVy biAtRUJVU1k7Cj4+PiAtCX0KPj4+IC0KPj4+ICAgCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZSh2 bWEsIG5leHQsICZvYmotPnZtYV9saXN0LCB2bWFfbGluaykgewo+Pj4gKwkJaWYgKCFkcm1fbW1f bm9kZV9hbGxvY2F0ZWQoJnZtYS0+bm9kZSkpCj4+PiArCQkJY29udGludWU7Cj4+PiArCj4+PiAr CQlpZiAodm1hLT5waW5fY291bnQpIHsKPj4+ICsJCQlEUk1fREVCVUcoImNhbiBub3QgY2hhbmdl IHRoZSBjYWNoZSBsZXZlbCBvZiBwaW5uZWQgb2JqZWN0c1xuIik7Cj4+PiArCQkJcmV0dXJuIC1F QlVTWTsKPj4+ICsJCX0KPj4+ICsKPj4KPj4gQnV0IHRoaXMgaXMgdGhlIHNhbWUgYXMgaTkxNV9n ZW1fb2JqX2lzX3Bpbm5lZCwgd2hlcmUgaXMgdGhlCj4+IG9iai0+cGluX2Rpc3BsYXkgY2hhbmdl IGNvbW1pdCBtZXNzYWdlIHRhbGtzIGFib3V0Pwo+Cj4gUmlnaHQgaGVyZS4gVGhlIGRpZmZlcmVu Y2UgaXMgdGhhdCB3ZSBhcmUgb25seSBpdGVyYXRpbmcgdGhlIHZtYSBsaXN0Cj4gb25jZSByYXRo ZXIgdGhhbiAzeC4KClRoYXRzIHRydWUsIGJ1dCB0aGUgY29tbWl0IHNheXMgaXQgaXMgZ29pbmcg dG8gdXNlIG9iai0+cGluX2Rpc3BsYXkgZm9yIApzb21ldGhpbmcgYW5kIHRoZW4gZG9lc24ndCB1 c2UgaXQgYXQgYWxsLiBSaWRkbGVzIGluIHBhdGNoZXMgYXJlIG5vdCAKdGhhdCBob3QuIDopCgo+ Pj4gICAJCWlmICghaTkxNV9nZW1fdmFsaWRfZ3R0X3NwYWNlKHZtYSwgY2FjaGVfbGV2ZWwpKSB7 Cj4+PiAgIAkJCXJldCA9IGk5MTVfdm1hX3VuYmluZCh2bWEpOwo+Pj4gICAJCQlpZiAocmV0KQo+ Pj4gICAJCQkJcmV0dXJuIHJldDsKPj4+IC0JCX0KPj4+ICsJCX0gZWxzZQo+Pj4gKwkJCWJvdW5k ID0gdHJ1ZTsKPj4+ICAgCX0KPj4+Cj4+PiAtCWlmIChpOTE1X2dlbV9vYmpfYm91bmRfYW55KG9i aikpIHsKPj4+ICsJaWYgKGJvdW5kKSB7Cj4+PiAgIAkJcmV0ID0gaTkxNV9nZW1fb2JqZWN0X3dh aXRfcmVuZGVyaW5nKG9iaiwgZmFsc2UpOwo+Pj4gICAJCWlmIChyZXQpCj4+PiAgIAkJCXJldHVy biByZXQ7Cj4+Pgo+Pj4gLQkJaTkxNV9nZW1fb2JqZWN0X2ZpbmlzaF9ndHQob2JqKTsKPj4+IC0K Pj4+ICAgCQkvKiBCZWZvcmUgU2FuZHlCcmlkZ2UsIHlvdSBjb3VsZCBub3QgdXNlIHRpbGluZyBv ciBmZW5jZQo+Pj4gICAJCSAqIHJlZ2lzdGVycyB3aXRoIHNub29wZWQgbWVtb3J5LCBzbyByZWxp bnF1aXNoIGFueSBmZW5jZXMKPj4+ICAgCQkgKiBjdXJyZW50bHkgcG9pbnRpbmcgdG8gb3VyIHJl Z2lvbiBpbiB0aGUgYXBlcnR1cmUuCj4+PiBAQCAtMzY2NCwxMyArMzY2NywxOCBAQCBpbnQgaTkx NV9nZW1fb2JqZWN0X3NldF9jYWNoZV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAq b2JqLAo+Pj4gICAJCQkJcmV0dXJuIHJldDsKPj4+ICAgCQl9Cj4+Pgo+Pj4gLQkJbGlzdF9mb3Jf ZWFjaF9lbnRyeSh2bWEsICZvYmotPnZtYV9saXN0LCB2bWFfbGluaykKPj4+IC0JCQlpZiAoZHJt X21tX25vZGVfYWxsb2NhdGVkKCZ2bWEtPm5vZGUpKSB7Cj4+PiAtCQkJCXJldCA9IGk5MTVfdm1h X2JpbmQodm1hLCBjYWNoZV9sZXZlbCwKPj4+IC0JCQkJCQkgICAgUElOX1VQREFURSk7Cj4+PiAt CQkJCWlmIChyZXQpCj4+PiAtCQkJCQlyZXR1cm4gcmV0Owo+Pj4gLQkJCX0KPj4+ICsJCS8qIEFj Y2VzcyB0byBzbm9vcGFibGUgcGFnZXMgdGhyb3VnaCB0aGUgR1RUIGlzIGluY29oZXJlbnQuICov Cj4+PiArCQlpZiAoY2FjaGVfbGV2ZWwgIT0gSTkxNV9DQUNIRV9OT05FICYmICFIQVNfTExDKGRl dikpCj4+PiArCQkJaTkxNV9nZW1fcmVsZWFzZV9tbWFwKG9iaik7Cj4+Cj4+IERvbid0IGZ1bGx5 IHVuZGVyc3RhbmQgdGhpcyBvbmUgLSBidXQgbXkgcXVlc3Rpb24gaXMgdGhpcy4KPj4gUHJldmlv dXNseSB1c2Vyc3BhY2Ugd291bGQgbG9zZSBtYXBwaW5ncyBvbiBjYWNoZSBsZXZlbCBjaGFuZ2Vz IGFueQo+PiB0aW1lLCBhZnRlciB0aGlzIG9ubHkgb24gIUxMQyB3aGVuIHR1cm5pbmcgb24gY2Fj aGluZyBtb2RlLiBTbyB0aGlzCj4+IG1lYW5zIHVzZXJzcGFjZSBuZWVkcyB0byBrbm93IGFib3V0 IHRoaXMgY2hhbmdlIGFuZCBtb2RpZnkgaXQncwo+PiBiZWhhdmlvcj8gT3Igd2hhdCBleGFjdGx5 IHdvdWxkIGhhcHBlbiBpbiBwcmFjdGljZT8KPgo+IE5vLiBVc2Vyc3BhY2UgaGFzIG5vIGtub3ds ZWRnZSBvZiB0aGUga2VybmVsIGhhbmRsaW5nIHRoZSBQVEVzLCBpdHMKPiBtYXBwaW5nIGlzIHBl cnNpc3RlbnQgKGkuZS4gdGhlIG9iai0+bW1hcF9vZmZzZXQgaW5zaWRlIHRoZSBkZXYtPm1hcHBw aW5nKS4KPiBPdG9oLCB3ZSBhcmUgaW1wcm92aW5nIHRoZSBzaXR1YXRpb24gc28gZXZlbiBpZiB1 c2Vyc3BhY2UgdHJpZXMgdG8gYXZvaWQKPiBzZXQtY2FjaGUtbGV2ZWwgbm90aGluZyBpcyBsb3N0 LgoKSG0gc28gaWYgYSBWTUEgaXMgcmUtYm91bmQgaW4gdGhpcyBwcm9jZXNzIGFuZCBpdCBjb3Vs ZCBoYXZlIGdvdHRlbiBhIApuZXcgR0dUVCBhZGRyZXNzLCB3aHkgaXQgaXMgbm90IG5lY2Vzc2Fy eSB0byBhbHdheXMgcmVsZWFzZSBtbWFwcyBhbmQgc28gCnRvIHVwZGF0ZSBDUFUgUFRFcz8KCkFs c28gd2hhdCBhYm91dCBTYW5keSBCcmlkZ2U/IENvbW1pdCBtZXNzYWdlIG1lbnRpb25zIGl0IGFu ZCB0aGUgY29kZSAKZG9lc24ndD8KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK