From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kumar, Shobhit" Subject: Re: [v2] drm/i915/skl: Init cdclk in the driver rather than relying on pre-os Date: Thu, 8 Oct 2015 17:43:41 +0530 Message-ID: <56165DF5.1000307@linux.intel.com> References: <1444058564-13663-1-git-send-email-shobhit.kumar@intel.com> <1444278535-16483-1-git-send-email-shobhit.kumar@intel.com> <1444303746.13547.11.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 4572D6ECC5 for ; Thu, 8 Oct 2015 05:13:48 -0700 (PDT) In-Reply-To: <1444303746.13547.11.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: imre.deak@intel.com, Shobhit Kumar Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTAvMDgvMjAxNSAwNDo1OSBQTSwgSW1yZSBEZWFrIHdyb3RlOgo+IE9uIHRvLCAyMDE1LTEw LTA4IGF0IDA5OjU4ICswNTMwLCBTaG9iaGl0IEt1bWFyIHdyb3RlOgo+PiBSZXVzZSB3aGF0IGlz IHByb2dyYW1tZWQgYnkgcHJlLW9zLCBidXQgaW4gY2FzZSB0aGVyZSBpcyBubyBwcmUtb3MKPj4g aW5pdGlhbGl6YXRpb24sIGluaXQgdGhlIGNkY2xrIHdpdGggdGhlIG1heCB2YWx1ZSBieSBkZWZh dWx0IHVudGlsbAo+PiBkeW5hbWljIGNkY2xrIHN1cHBvcnQgY29tZXMuCj4+Cj4+IHYyOiBDaGVj ayBpZiBCSU9TIHByb2dyYW1tZWQgY29ycmVjdGx5IHJhdGhlciB0aGFuIGFsd2F5cyBjYWxsaW5n IGluaXQKPj4gICAgICAtIERvIHZhbGlkYXRpb24gb2YgcHJvZ3JhbW1lZCBjZGN0bCBhbmQgd2hh dCBpdCBpcyBleHBlY3RlZAo+PiAgICAgIC0gT25seSBkbyBzbGtfaW5pdF9jZGNsayBpZiB2YWxp ZGF0aW9uIGZhaWxlZCBlbHNlIHJldXNlIEJJT1MKPj4gICAgICAgIHByb2dyYW1tZWQgdmFsdWUK Pj4KPj4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPj4gQ2M6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6 IFNob2JoaXQgS3VtYXIgPHNob2JoaXQua3VtYXJAaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAgICAgfCAxOCArKysrKysrKysrKystLS0tLQo+ PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM5ICsrKysrKysrKysr KysrKysrKysrKysrKysrKy0tLS0tLS0tLQo+PiAgIDIgZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0 aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4+ IGluZGV4IDJkM2NjODIuLjNlYzU2MTggMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RkaS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5j Cj4+IEBAIC0yOTQ2LDExICsyOTQ2LDE5IEBAIHZvaWQgaW50ZWxfZGRpX3BsbF9pbml0KHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpCj4+ICAgCQlpbnQgY2RjbGtfZnJlcTsKPj4KPj4gICAJCWNkY2xr X2ZyZXEgPSBkZXZfcHJpdi0+ZGlzcGxheS5nZXRfZGlzcGxheV9jbG9ja19zcGVlZChkZXYpOwo+ PiAtCQlkZXZfcHJpdi0+c2tsX2Jvb3RfY2RjbGsgPSBjZGNsa19mcmVxOwo+PiAtCQlpZiAoIShJ OTE1X1JFQUQoTENQTEwxX0NUTCkgJiBMQ1BMTF9QTExfRU5BQkxFKSkKPj4gLQkJCURSTV9FUlJP UigiTENQTEwxIGlzIGRpc2FibGVkXG4iKTsKPj4gLQkJZWxzZQo+PiAtCQkJaW50ZWxfZGlzcGxh eV9wb3dlcl9nZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9QTExTKTsKPj4gKwo+PiArCQkvKiBJ bnZhbGlkIENEQ0xLIGZyb20gQklPUyA/ICovCj4+ICsJCWlmIChjZGNsa19mcmVxIDwgMCkgewo+ PiArCQkJLyogcHJvZ3JhbSB0byBtYXhpbXVtIGNkY2xrIHRpbGwgd2UgaGF2ZSBkeW5hbWljIGNk Y2xrIHN1cHBvcnQgKi8KPj4gKwkJCWRldl9wcml2LT5za2xfYm9vdF9jZGNsayA9IDY3NTAwMDsK Pj4gKwkJCXNrbF9pbml0X2NkY2xrKGRldl9wcml2KTsKPgo+IFRoaXMgd291bGQgc3RpbGwgdHJ5 IHRvIHJlcHJvZ3JhbSBDRENMSyBpZiBCSU9TIGVuYWJsZWQgYW4gb3V0cHV0IHdpdGgKPiBhbiBp bmNvcnJlY3QgQ0RDTEsgZGVjaW1hbCBwYXJ0LiBJc24ndCB0aGlzIHRoZSBleGFjdCBzY2VuYXJp byB5b3UncmUKPiBzZWVpbmc/IEFzIHNhaWQgYmVmb3JlIHJlcHJvZ3JhbW1pbmcgQ0RDTEsgaW4g dGhhdCBjYXNlIHdvdWxkIHJlcXVpcmUKPiBkaXNhYmxpbmcgdGhlIG91dHB1dHMgZmlyc3QuCgpJ IHdlbnQgd2l0aCB0aGUgaHlwb3RoZXNpcyB0aGF0IGlmIFZCSU9TL0dPUCB3YXMgbG9hZGVkIGl0 IHdvdWxkIGhhdmUgdG8gCmNvcnJlY3QgdGhlIGNkY2xvY2ssIHdpdGggd3JvbmcgZGVjaW1hbCB2 YWx1ZSBkaXNwbGF5IGNhbm5vdCBiZSBlbmFibGVkLiAKRm9yIGV4YW1wbGUgQVVYIHdpbGwgZmFp bCBvbiBTS0wuIFNvIGZvciBjb3JyZWN0IGRpc3BsYXkgb3V0cHV0IGVuYWJsZWQgCmNkY2xvY2sg aGFzIHRvIGJlIGNvcnJlY3RseSBwcm9ncmFtbWVkLiBJZiBpdCBpcyB3cm9uZyBkaXNwbGF5IHdh cyBub3QgCmVuYWJsZWQgYXQgYWxsLgoKVGhlIHNjZW5hcmlvIHdoaWNoIEkgYW0gc2VlaW5nIGlz IFZCSU9TL0dPUCBpcyBub3QgbG9hZGVkIGF0IGFsbCwgYW5kIAp0aGUgcHJlLW9zIGlzIG5vdCBs ZWF2aW5nIGNkY2xvY2sgaW4gY29ycmVjdCBzdGF0ZS4KCj4KPiBXZSB3b3VsZCBhbHNvIG5lZWQg dG8gY2FsbCBza2xfaW5pdF9jZGNsayBpZiB0aGUgQklPUyBoYXNuJ3QgZW5hYmxlZCB0aGUKPiBQ TEwgZm9yIHNvbWUgcmVhc29uLiBCdXQgSSBndWVzcyB0aGF0IGNvdWxkIGJlIGEgc2VwYXJhdGUg Y2hhbmdlLgo+Cj4+ICsJCX0gZWxzZSB7Cj4+ICsJCQlkZXZfcHJpdi0+c2tsX2Jvb3RfY2RjbGsg PSBjZGNsa19mcmVxOwo+PiArCQkJaWYgKCEoSTkxNV9SRUFEKExDUExMMV9DVEwpICYgTENQTExf UExMX0VOQUJMRSkpCj4+ICsJCQkJRFJNX0VSUk9SKCJMQ1BMTDEgaXMgZGlzYWJsZWRcbiIpOwo+ PiArCQkJZWxzZQo+PiArCQkJCWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KGRldl9wcml2LCBQT1dF Ul9ET01BSU5fUExMUyk7Cj4+ICsJCX0KPj4gICAJfSBlbHNlIGlmIChJU19CUk9YVE9OKGRldikp IHsKPj4gICAJCWJyb3h0b25faW5pdF9jZGNsayhkZXYpOwo+PiAgIAkJYnJveHRvbl9kZGlfcGh5 X2luaXQoZGV2KTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBpbmRleCBi YmViNmQzLi5mNzM0NDEwIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4+IEBAIC02NjM0LDEyICs2NjM0LDE1IEBAIHN0YXRpYyBpbnQgc2t5bGFrZV9nZXRfZGlzcGxh eV9jbG9ja19zcGVlZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgIAl1aW50MzJfdCBsY3Bs bDEgPSBJOTE1X1JFQUQoTENQTEwxX0NUTCk7Cj4+ICAgCXVpbnQzMl90IGNkY3RsID0gSTkxNV9S RUFEKENEQ0xLX0NUTCk7Cj4+ICAgCXVpbnQzMl90IGxpbmtyYXRlOwo+PiArCWludCBmcmVxOwo+ Pgo+PiAgIAlpZiAoIShsY3BsbDEgJiBMQ1BMTF9QTExfRU5BQkxFKSkKPj4gICAJCXJldHVybiAy NDAwMDsgLyogMjRNSHogaXMgdGhlIGNkIGZyZXEgd2l0aCBOU1NDIHJlZiAqLwo+Pgo+PiAtCWlm ICgoY2RjdGwgJiBDRENMS19GUkVRX1NFTF9NQVNLKSA9PSBDRENMS19GUkVRXzU0MCkKPj4gLQkJ cmV0dXJuIDU0MDAwMDsKPj4gKwlpZiAoKGNkY3RsICYgQ0RDTEtfRlJFUV9TRUxfTUFTSykgPT0g Q0RDTEtfRlJFUV81NDApIHsKPj4gKwkJZnJlcSA9IDU0MDAwMDsKPj4gKwkJZ290byB2ZXJpZnk7 Cj4+ICsJfQo+Pgo+PiAgIAlsaW5rcmF0ZSA9IChJOTE1X1JFQUQoRFBMTF9DVFJMMSkgJgo+PiAg IAkJICAgIERQTExfQ1RSTDFfTElOS19SQVRFX01BU0soU0tMX0RQTEwwKSkgPj4gMTsKPj4gQEAg LTY2NDksMzAgKzY2NTIsNDYgQEAgc3RhdGljIGludCBza3lsYWtlX2dldF9kaXNwbGF5X2Nsb2Nr X3NwZWVkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAgCQkvKiB2Y28gODY0MCAqLwo+PiAg IAkJc3dpdGNoIChjZGN0bCAmIENEQ0xLX0ZSRVFfU0VMX01BU0spIHsKPj4gICAJCWNhc2UgQ0RD TEtfRlJFUV80NTBfNDMyOgo+PiAtCQkJcmV0dXJuIDQzMjAwMDsKPj4gKwkJCWZyZXEgPSA0MzIw MDA7Cj4+ICsJCQlicmVhazsKPj4gICAJCWNhc2UgQ0RDTEtfRlJFUV8zMzdfMzA4Ogo+PiAtCQkJ cmV0dXJuIDMwODU3MDsKPj4gKwkJCWZyZXEgPSAzMDg1NzA7Cj4+ICsJCQlicmVhazsKPj4gICAJ CWNhc2UgQ0RDTEtfRlJFUV82NzVfNjE3Ogo+PiAtCQkJcmV0dXJuIDYxNzE0MDsKPj4gKwkJCWZy ZXEgPSA2MTcxNDA7Cj4+ICsJCQlicmVhazsKPj4gICAJCWRlZmF1bHQ6Cj4+ICAgCQkJV0FSTigx LCAiVW5rbm93biBjZCBmcmVxIHNlbGVjdGlvblxuIik7Cj4+ICsJCQlyZXR1cm4gLUVJTlZBTDsK Pj4gICAJCX0KPj4gICAJfSBlbHNlIHsKPj4gICAJCS8qIHZjbyA4MTAwICovCj4+ICAgCQlzd2l0 Y2ggKGNkY3RsICYgQ0RDTEtfRlJFUV9TRUxfTUFTSykgewo+PiAgIAkJY2FzZSBDRENMS19GUkVR XzQ1MF80MzI6Cj4+IC0JCQlyZXR1cm4gNDUwMDAwOwo+PiArCQkJZnJlcSA9IDQ1MDAwMDsKPj4g KwkJCWJyZWFrOwo+PiAgIAkJY2FzZSBDRENMS19GUkVRXzMzN18zMDg6Cj4+IC0JCQlyZXR1cm4g MzM3NTAwOwo+PiArCQkJZnJlcSA9IDMzNzUwMDsKPj4gKwkJCWJyZWFrOwo+PiAgIAkJY2FzZSBD RENMS19GUkVRXzY3NV82MTc6Cj4+IC0JCQlyZXR1cm4gNjc1MDAwOwo+PiArCQkJZnJlcSA9IDY3 NTAwMDsKPj4gKwkJCWJyZWFrOwo+PiAgIAkJZGVmYXVsdDoKPj4gICAJCQlXQVJOKDEsICJVbmtu b3duIGNkIGZyZXEgc2VsZWN0aW9uXG4iKTsKPj4gKwkJCXJldHVybiAtRUlOVkFMOwo+PiAgIAkJ fQo+PiAgIAl9Cj4+Cj4+IC0JLyogZXJyb3IgY2FzZSwgZG8gYXMgaWYgRFBMTDAgaXNuJ3QgZW5h YmxlZCAqLwo+PiAtCXJldHVybiAyNDAwMDsKPj4gK3ZlcmlmeToKPj4gKwkvKgo+PiArCSAqIE5v dGljZWQgaW4gc29tZSBpbnN0YW5jZXMgdGhhdCB0aGUgZnJlcSBzZWxlY3Rpb24gaXMgY29ycmVj dCBidXQKPj4gKwkgKiBkZWNpbWFsIHBhcnQgaXMgcHJvZ3JhbW1lZCB3cm9uZyBmcm9tIEJJT1Mg d2hlcmUgcHJlLW9zIGRvZXMgbm90Cj4+ICsJICogZW5hYmxlIGRpc3BsYXkuIFZlcmlmeSB0aGUg c2FtZSBhcyB3ZWxsLgo+PiArCSAqLwo+PiArCWlmIChjZGN0bCA9PSAoKGNkY3RsICYgQ0RDTEtf RlJFUV9TRUxfTUFTSykgfCBza2xfY2RjbGtfZGVjaW1hbChmcmVxKSkpCj4+ICsJCXJldHVybiBm cmVxOwo+PiArCWVsc2UKPj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4+ICAgfQo+Pgo+PiAgIHN0YXRp YyBpbnQgYnJveHRvbl9nZXRfZGlzcGxheV9jbG9ja19zcGVlZChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==