From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kumar, Shobhit" Subject: Re: [v2] drm/i915/skl: Init cdclk in the driver rather than relying on pre-os Date: Fri, 9 Oct 2015 16:23:32 +0530 Message-ID: <56179CAC.1030206@linux.intel.com> References: <1444058564-13663-1-git-send-email-shobhit.kumar@intel.com> <1444278535-16483-1-git-send-email-shobhit.kumar@intel.com> <1444303746.13547.11.camel@intel.com> <56165DF5.1000307@linux.intel.com> <20151008122414.GU26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id ADD486E14C for ; Fri, 9 Oct 2015 03:53:38 -0700 (PDT) In-Reply-To: <20151008122414.GU26517@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Shobhit Kumar , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTAvMDgvMjAxNSAwNTo1NCBQTSwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+IE9uIFRodSwg T2N0IDA4LCAyMDE1IGF0IDA1OjQzOjQxUE0gKzA1MzAsIEt1bWFyLCBTaG9iaGl0IHdyb3RlOgo+ PiBPbiAxMC8wOC8yMDE1IDA0OjU5IFBNLCBJbXJlIERlYWsgd3JvdGU6Cj4+PiBPbiB0bywgMjAx NS0xMC0wOCBhdCAwOTo1OCArMDUzMCwgU2hvYmhpdCBLdW1hciB3cm90ZToKPj4+PiBSZXVzZSB3 aGF0IGlzIHByb2dyYW1tZWQgYnkgcHJlLW9zLCBidXQgaW4gY2FzZSB0aGVyZSBpcyBubyBwcmUt b3MKPj4+PiBpbml0aWFsaXphdGlvbiwgaW5pdCB0aGUgY2RjbGsgd2l0aCB0aGUgbWF4IHZhbHVl IGJ5IGRlZmF1bHQgdW50aWxsCj4+Pj4gZHluYW1pYyBjZGNsayBzdXBwb3J0IGNvbWVzLgo+Pj4+ Cj4+Pj4gdjI6IENoZWNrIGlmIEJJT1MgcHJvZ3JhbW1lZCBjb3JyZWN0bHkgcmF0aGVyIHRoYW4g YWx3YXlzIGNhbGxpbmcgaW5pdAo+Pj4+ICAgICAgIC0gRG8gdmFsaWRhdGlvbiBvZiBwcm9ncmFt bWVkIGNkY3RsIGFuZCB3aGF0IGl0IGlzIGV4cGVjdGVkCj4+Pj4gICAgICAgLSBPbmx5IGRvIHNs a19pbml0X2NkY2xrIGlmIHZhbGlkYXRpb24gZmFpbGVkIGVsc2UgcmV1c2UgQklPUwo+Pj4+ICAg ICAgICAgcHJvZ3JhbW1lZCB2YWx1ZQo+Pj4+Cj4+Pj4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFr QGludGVsLmNvbT4KPj4+PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBTaG9iaGl0IEt1bWFyIDxzaG9iaGl0Lmt1 bWFyQGludGVsLmNvbT4KPj4+PiAtLS0KPj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kZGkuYyAgICAgfCAxOCArKysrKysrKysrKystLS0tLQo+Pj4+ICAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLQo+Pj4+ICAgIDIgZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMTUgZGVs ZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+Pj4+IGluZGV4IDJk M2NjODIuLjNlYzU2MTggMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGRpLmMKPj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+Pj4+ IEBAIC0yOTQ2LDExICsyOTQ2LDE5IEBAIHZvaWQgaW50ZWxfZGRpX3BsbF9pbml0KHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpCj4+Pj4gICAgCQlpbnQgY2RjbGtfZnJlcTsKPj4+Pgo+Pj4+ICAgIAkJ Y2RjbGtfZnJlcSA9IGRldl9wcml2LT5kaXNwbGF5LmdldF9kaXNwbGF5X2Nsb2NrX3NwZWVkKGRl dik7Cj4+Pj4gLQkJZGV2X3ByaXYtPnNrbF9ib290X2NkY2xrID0gY2RjbGtfZnJlcTsKPj4+PiAt CQlpZiAoIShJOTE1X1JFQUQoTENQTEwxX0NUTCkgJiBMQ1BMTF9QTExfRU5BQkxFKSkKPj4+PiAt CQkJRFJNX0VSUk9SKCJMQ1BMTDEgaXMgZGlzYWJsZWRcbiIpOwo+Pj4+IC0JCWVsc2UKPj4+PiAt CQkJaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9QTExTKTsK Pj4+PiArCj4+Pj4gKwkJLyogSW52YWxpZCBDRENMSyBmcm9tIEJJT1MgPyAqLwo+Pj4+ICsJCWlm IChjZGNsa19mcmVxIDwgMCkgewo+Pj4+ICsJCQkvKiBwcm9ncmFtIHRvIG1heGltdW0gY2RjbGsg dGlsbCB3ZSBoYXZlIGR5bmFtaWMgY2RjbGsgc3VwcG9ydCAqLwo+Pj4+ICsJCQlkZXZfcHJpdi0+ c2tsX2Jvb3RfY2RjbGsgPSA2NzUwMDA7Cj4+Pj4gKwkJCXNrbF9pbml0X2NkY2xrKGRldl9wcml2 KTsKPj4+Cj4+PiBUaGlzIHdvdWxkIHN0aWxsIHRyeSB0byByZXByb2dyYW0gQ0RDTEsgaWYgQklP UyBlbmFibGVkIGFuIG91dHB1dCB3aXRoCj4+PiBhbiBpbmNvcnJlY3QgQ0RDTEsgZGVjaW1hbCBw YXJ0LiBJc24ndCB0aGlzIHRoZSBleGFjdCBzY2VuYXJpbyB5b3UncmUKPj4+IHNlZWluZz8gQXMg c2FpZCBiZWZvcmUgcmVwcm9ncmFtbWluZyBDRENMSyBpbiB0aGF0IGNhc2Ugd291bGQgcmVxdWly ZQo+Pj4gZGlzYWJsaW5nIHRoZSBvdXRwdXRzIGZpcnN0Lgo+Pgo+PiBJIHdlbnQgd2l0aCB0aGUg aHlwb3RoZXNpcyB0aGF0IGlmIFZCSU9TL0dPUCB3YXMgbG9hZGVkIGl0IHdvdWxkIGhhdmUgdG8K Pj4gY29ycmVjdCB0aGUgY2RjbG9jaywgd2l0aCB3cm9uZyBkZWNpbWFsIHZhbHVlIGRpc3BsYXkg Y2Fubm90IGJlIGVuYWJsZWQuCj4+IEZvciBleGFtcGxlIEFVWCB3aWxsIGZhaWwgb24gU0tMLiBT byBmb3IgY29ycmVjdCBkaXNwbGF5IG91dHB1dCBlbmFibGVkCj4+IGNkY2xvY2sgaGFzIHRvIGJl IGNvcnJlY3RseSBwcm9ncmFtbWVkLiBJZiBpdCBpcyB3cm9uZyBkaXNwbGF5IHdhcyBub3QKPj4g ZW5hYmxlZCBhdCBhbGwuCj4+Cj4+IFRoZSBzY2VuYXJpbyB3aGljaCBJIGFtIHNlZWluZyBpcyBW QklPUy9HT1AgaXMgbm90IGxvYWRlZCBhdCBhbGwsIGFuZAo+PiB0aGUgcHJlLW9zIGlzIG5vdCBs ZWF2aW5nIGNkY2xvY2sgaW4gY29ycmVjdCBzdGF0ZS4KPgo+IEJ1dCBpdCBzdGlsbCBlbmFibGVk IERQTEwwPyBXaHkgZG9lcyBpdCBkbyB0aGF0IGlmIGl0IGRvZXNuJ3Qgc2V0IHVwCj4gY2RjbGs/ CgpTbyBJIGhhZCBkaXNjdXNzaW9uIHdpdGggc29tZSBmb2xrcyBpbiBCSU9TIHRlYW0gYW5kIGNh bWUgdG8ga25vdyB0aGF0IApvbiBzb21lIGJvYXJkcyBldmVuIGlmIGhpZ2hlciBjZGNsb2NrcyBh cmUgc3VwcG9ydGVkLCB3ZSBtaWdodCB3YW50IHRvIApsaW1pdCBtYXhpbXVtIGNkY2xvY2suIFRo aXMgaXMgZG9uZSBieSBCSU9TIHByb2dyYW1taW5nIHRoZSBjZGNsb2NrIHRvIAphbGxvd2VkIG1h eGltdW0gYW5kIFZCSU9TL0dPUCB1c2VzIHRoYXQgYXMgdGhlIG1heCB2YWx1ZSByYXRoZXIgdGhh biAKdGhlIHJlYWwgcG9zc2libGUgbWF4LiBTbyB0aGUgQklPUyBpcyBzdXBwb3NlZCB0byBwcm9n cmFtIGNkY2xvY2sgCmNvcnJlY3RseSBhbmQgaGVuY2UgRFBMTDAgYXMgd2VsbC4gTXkgb25seSBh c3N1bXB0aW9uIGlzIGluIHRoaXMgY2FzZSBpdCAKaGFzIG5vdCBjb3JyZWN0bHkgcHJvZ3JhbW1l ZCBkdWUgdG8gc29tZSBidWcuIEkga25vdyBpZiBJIHdvcmsgd2l0aCB0aGVtIAphbmQgZW5zdXJl IHRoYXQgQklPUyBwcm9ncmFtcyBjb3JyZWN0bHksIHRoZSBwcm9ibGVtIHdpbGwgYmUgc29sdmVk LCBidXQgCmRvIHlvdSB0aGluayBpdCBpcyB3b3J0aCB3aGlsZSB0byByZW1vdmUgdGhlIHRpZ2h0 IGRlcGVuZGVuY3kgYWx0b2dldGhlciA/Cgo+Cj4+Cj4+Pgo+Pj4gV2Ugd291bGQgYWxzbyBuZWVk IHRvIGNhbGwgc2tsX2luaXRfY2RjbGsgaWYgdGhlIEJJT1MgaGFzbid0IGVuYWJsZWQgdGhlCj4+ PiBQTEwgZm9yIHNvbWUgcmVhc29uLiBCdXQgSSBndWVzcyB0aGF0IGNvdWxkIGJlIGEgc2VwYXJh dGUgY2hhbmdlLgo+Pj4KPj4+PiArCQl9IGVsc2Ugewo+Pj4+ICsJCQlkZXZfcHJpdi0+c2tsX2Jv b3RfY2RjbGsgPSBjZGNsa19mcmVxOwo+Pj4+ICsJCQlpZiAoIShJOTE1X1JFQUQoTENQTEwxX0NU TCkgJiBMQ1BMTF9QTExfRU5BQkxFKSkKPj4+PiArCQkJCURSTV9FUlJPUigiTENQTEwxIGlzIGRp c2FibGVkXG4iKTsKPj4+PiArCQkJZWxzZQo+Pj4+ICsJCQkJaW50ZWxfZGlzcGxheV9wb3dlcl9n ZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9QTExTKTsKPj4+PiArCQl9Cj4+Pj4gICAgCX0gZWxz ZSBpZiAoSVNfQlJPWFRPTihkZXYpKSB7Cj4+Pj4gICAgCQlicm94dG9uX2luaXRfY2RjbGsoZGV2 KTsKPj4+PiAgICAJCWJyb3h0b25fZGRpX3BoeV9pbml0KGRldik7Cj4+Pj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+Pj4+IGluZGV4IGJiZWI2ZDMuLmY3MzQ0MTAgMTAwNjQ0Cj4+ Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+Pj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+Pj4gQEAgLTY2MzQsMTIgKzY2 MzQsMTUgQEAgc3RhdGljIGludCBza3lsYWtlX2dldF9kaXNwbGF5X2Nsb2NrX3NwZWVkKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpCj4+Pj4gICAgCXVpbnQzMl90IGxjcGxsMSA9IEk5MTVfUkVBRChM Q1BMTDFfQ1RMKTsKPj4+PiAgICAJdWludDMyX3QgY2RjdGwgPSBJOTE1X1JFQUQoQ0RDTEtfQ1RM KTsKPj4+PiAgICAJdWludDMyX3QgbGlua3JhdGU7Cj4+Pj4gKwlpbnQgZnJlcTsKPj4+Pgo+Pj4+ ICAgIAlpZiAoIShsY3BsbDEgJiBMQ1BMTF9QTExfRU5BQkxFKSkKPj4+PiAgICAJCXJldHVybiAy NDAwMDsgLyogMjRNSHogaXMgdGhlIGNkIGZyZXEgd2l0aCBOU1NDIHJlZiAqLwo+Pj4+Cj4+Pj4g LQlpZiAoKGNkY3RsICYgQ0RDTEtfRlJFUV9TRUxfTUFTSykgPT0gQ0RDTEtfRlJFUV81NDApCj4+ Pj4gLQkJcmV0dXJuIDU0MDAwMDsKPj4+PiArCWlmICgoY2RjdGwgJiBDRENMS19GUkVRX1NFTF9N QVNLKSA9PSBDRENMS19GUkVRXzU0MCkgewo+Pj4+ICsJCWZyZXEgPSA1NDAwMDA7Cj4+Pj4gKwkJ Z290byB2ZXJpZnk7Cj4+Pj4gKwl9Cj4+Pj4KPj4+PiAgICAJbGlua3JhdGUgPSAoSTkxNV9SRUFE KERQTExfQ1RSTDEpICYKPj4+PiAgICAJCSAgICBEUExMX0NUUkwxX0xJTktfUkFURV9NQVNLKFNL TF9EUExMMCkpID4+IDE7Cj4+Pj4gQEAgLTY2NDksMzAgKzY2NTIsNDYgQEAgc3RhdGljIGludCBz a3lsYWtlX2dldF9kaXNwbGF5X2Nsb2NrX3NwZWVkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ Pj4gICAgCQkvKiB2Y28gODY0MCAqLwo+Pj4+ICAgIAkJc3dpdGNoIChjZGN0bCAmIENEQ0xLX0ZS RVFfU0VMX01BU0spIHsKPj4+PiAgICAJCWNhc2UgQ0RDTEtfRlJFUV80NTBfNDMyOgo+Pj4+IC0J CQlyZXR1cm4gNDMyMDAwOwo+Pj4+ICsJCQlmcmVxID0gNDMyMDAwOwo+Pj4+ICsJCQlicmVhazsK Pj4+PiAgICAJCWNhc2UgQ0RDTEtfRlJFUV8zMzdfMzA4Ogo+Pj4+IC0JCQlyZXR1cm4gMzA4NTcw Owo+Pj4+ICsJCQlmcmVxID0gMzA4NTcwOwo+Pj4+ICsJCQlicmVhazsKPj4+PiAgICAJCWNhc2Ug Q0RDTEtfRlJFUV82NzVfNjE3Ogo+Pj4+IC0JCQlyZXR1cm4gNjE3MTQwOwo+Pj4+ICsJCQlmcmVx ID0gNjE3MTQwOwo+Pj4+ICsJCQlicmVhazsKPj4+PiAgICAJCWRlZmF1bHQ6Cj4+Pj4gICAgCQkJ V0FSTigxLCAiVW5rbm93biBjZCBmcmVxIHNlbGVjdGlvblxuIik7Cj4+Pj4gKwkJCXJldHVybiAt RUlOVkFMOwo+Pj4+ICAgIAkJfQo+Pj4+ICAgIAl9IGVsc2Ugewo+Pj4+ICAgIAkJLyogdmNvIDgx MDAgKi8KPj4+PiAgICAJCXN3aXRjaCAoY2RjdGwgJiBDRENMS19GUkVRX1NFTF9NQVNLKSB7Cj4+ Pj4gICAgCQljYXNlIENEQ0xLX0ZSRVFfNDUwXzQzMjoKPj4+PiAtCQkJcmV0dXJuIDQ1MDAwMDsK Pj4+PiArCQkJZnJlcSA9IDQ1MDAwMDsKPj4+PiArCQkJYnJlYWs7Cj4+Pj4gICAgCQljYXNlIENE Q0xLX0ZSRVFfMzM3XzMwODoKPj4+PiAtCQkJcmV0dXJuIDMzNzUwMDsKPj4+PiArCQkJZnJlcSA9 IDMzNzUwMDsKPj4+PiArCQkJYnJlYWs7Cj4+Pj4gICAgCQljYXNlIENEQ0xLX0ZSRVFfNjc1XzYx NzoKPj4+PiAtCQkJcmV0dXJuIDY3NTAwMDsKPj4+PiArCQkJZnJlcSA9IDY3NTAwMDsKPj4+PiAr CQkJYnJlYWs7Cj4+Pj4gICAgCQlkZWZhdWx0Ogo+Pj4+ICAgIAkJCVdBUk4oMSwgIlVua25vd24g Y2QgZnJlcSBzZWxlY3Rpb25cbiIpOwo+Pj4+ICsJCQlyZXR1cm4gLUVJTlZBTDsKPj4+PiAgICAJ CX0KPj4+PiAgICAJfQo+Pj4+Cj4+Pj4gLQkvKiBlcnJvciBjYXNlLCBkbyBhcyBpZiBEUExMMCBp c24ndCBlbmFibGVkICovCj4+Pj4gLQlyZXR1cm4gMjQwMDA7Cj4+Pj4gK3ZlcmlmeToKPj4+PiAr CS8qCj4+Pj4gKwkgKiBOb3RpY2VkIGluIHNvbWUgaW5zdGFuY2VzIHRoYXQgdGhlIGZyZXEgc2Vs ZWN0aW9uIGlzIGNvcnJlY3QgYnV0Cj4+Pj4gKwkgKiBkZWNpbWFsIHBhcnQgaXMgcHJvZ3JhbW1l ZCB3cm9uZyBmcm9tIEJJT1Mgd2hlcmUgcHJlLW9zIGRvZXMgbm90Cj4+Pj4gKwkgKiBlbmFibGUg ZGlzcGxheS4gVmVyaWZ5IHRoZSBzYW1lIGFzIHdlbGwuCj4+Pj4gKwkgKi8KPj4+PiArCWlmIChj ZGN0bCA9PSAoKGNkY3RsICYgQ0RDTEtfRlJFUV9TRUxfTUFTSykgfCBza2xfY2RjbGtfZGVjaW1h bChmcmVxKSkpCj4+Pj4gKwkJcmV0dXJuIGZyZXE7Cj4+Pj4gKwllbHNlCj4+Pj4gKwkJcmV0dXJu IC1FSU5WQUw7Cj4+Pj4gICAgfQo+Pj4+Cj4+Pj4gICAgc3RhdGljIGludCBicm94dG9uX2dldF9k aXNwbGF5X2Nsb2NrX3NwZWVkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+Pgo+Pj4KPj4+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+PiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+PiBo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4+ Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK Pj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==