Re: [PATCH 13/43] drm/i915: Always use GEN8_RING_PDP_{LDW, UDW} instead of hand rolling the register offsets

Jani Nikula
2015-09-28T11:38:48Z

On Fri, 18 Sep 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 5615d3d..24baa5a 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2231,10 +2231,9 @@ static void gen8_ppgtt_info(struct seq_file *m, struct drm_device *dev)
> for_each_ring(ring, dev_priv, unused) {
> seq_printf(m, "%s\n", ring->name);
> for (i = 0; i < 4; i++) {
> - u32 offset = 0x270 + i * 8;
> - u64 pdp = I915_READ(ring->mmio_base + offset + 4);
> + u64 pdp = I915_READ(GEN8_RING_PDP_UDW(ring, i));
> pdp <<= 32;
> - pdp |= I915_READ(ring->mmio_base + offset);
> + pdp |= I915_READ(GEN8_RING_PDP_LDW(ring, i));
> seq_printf(m, "\tPDP%d 0x%016llx\n", i, pdp);
> }
> }
> --
> 2.4.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center