From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 32/43] drm/i915: Clean up LVDS register handling Date: Mon, 12 Oct 2015 09:09:52 -0700 Message-ID: <561BDB50.7040300@virtuousgeek.org> References: <1442595836-23981-1-git-send-email-ville.syrjala@linux.intel.com> <1442595836-23981-33-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0EA946EAA3 for ; Mon, 12 Oct 2015 09:09:04 -0700 (PDT) Received: by pacex6 with SMTP id ex6so3680428pac.3 for ; Mon, 12 Oct 2015 09:09:03 -0700 (PDT) In-Reply-To: <1442595836-23981-33-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDkvMTgvMjAxNSAxMDowMyBBTSwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3Jv dGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiAKPiBLZWVwIHNpbmdsZSAnbHZkc19yZWcnIGFuZCAnbHZkcycgdmFyaWFibGUgYXJvdW5k IGluCj4gaW50ZWxfbHZkc19pbml0KCksIGFuZCByZWFkIGl0IGp1c3Qgb25jZSBhdCB0aGUgc3Rh cnQuCj4gCj4gQWxzbyBpbnRlbF9sdmRzX2dldF9jb25maWcoKSBkb2Vzbid0IG5lZWQgdG8gZmln dXJlIG91dCB3aGljaCByZWcgdG8gdXNlCj4gc2luY2UgaXQgY2FuIGp1c3QgY29uc3VsdCBsdmRz X2VuY29kZXItPnJlZy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9sdmRzLmMgfCAzMCArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9sdmRzLmMKPiBpbmRleCAyYzJkMWYwLi4zNWJhZDcxIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2ZHMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2x2ZHMuYwo+IEBAIC05OCwxNSArOTgsMTEgQEAgc3RhdGljIHZvaWQgaW50 ZWxfbHZkc19nZXRfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICB7Cj4g IAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZW5jb2Rlci0+YmFzZS5kZXY7Cj4gIAlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+IC0JdTMyIGx2 ZHNfcmVnLCB0bXAsIGZsYWdzID0gMDsKPiArCXN0cnVjdCBpbnRlbF9sdmRzX2VuY29kZXIgKmx2 ZHNfZW5jb2RlciA9IHRvX2x2ZHNfZW5jb2RlcigmZW5jb2Rlci0+YmFzZSk7Cj4gKwl1MzIgdG1w LCBmbGFncyA9IDA7Cj4gIAlpbnQgZG90Y2xvY2s7Cj4gIAo+IC0JaWYgKEhBU19QQ0hfU1BMSVQo ZGV2KSkKPiAtCQlsdmRzX3JlZyA9IFBDSF9MVkRTOwo+IC0JZWxzZQo+IC0JCWx2ZHNfcmVnID0g TFZEUzsKPiAtCj4gLQl0bXAgPSBJOTE1X1JFQUQobHZkc19yZWcpOwo+ICsJdG1wID0gSTkxNV9S RUFEKGx2ZHNfZW5jb2Rlci0+cmVnKTsKPiAgCWlmICh0bXAgJiBMVkRTX0hTWU5DX1BPTEFSSVRZ KQo+ICAJCWZsYWdzIHw9IERSTV9NT0RFX0ZMQUdfTkhTWU5DOwo+ICAJZWxzZQo+IEBAIC05NDQs NiArOTQwLDcgQEAgdm9pZCBpbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikK PiAgCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpkb3duY2xvY2tfbW9kZSA9IE5VTEw7Cj4gIAlz dHJ1Y3QgZWRpZCAqZWRpZDsKPiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiArCXUzMiBsdmRz X3JlZzsKPiAgCXUzMiBsdmRzOwo+ICAJaW50IHBpcGU7Cj4gIAl1OCBwaW47Cj4gQEAgLTk2Niw4 ICs5NjMsMTUgQEAgdm9pZCBpbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikK PiAgCWlmIChkbWlfY2hlY2tfc3lzdGVtKGludGVsX25vX2x2ZHMpKQo+ICAJCXJldHVybjsKPiAg Cj4gKwlpZiAoSEFTX1BDSF9TUExJVChkZXYpKQo+ICsJCWx2ZHNfcmVnID0gUENIX0xWRFM7Cj4g KwllbHNlCj4gKwkJbHZkc19yZWcgPSBMVkRTOwo+ICsKPiArCWx2ZHMgPSBJOTE1X1JFQUQobHZk c19yZWcpOwo+ICsKPiAgCWlmIChIQVNfUENIX1NQTElUKGRldikpIHsKPiAtCQlpZiAoKEk5MTVf UkVBRChQQ0hfTFZEUykgJiBMVkRTX0RFVEVDVEVEKSA9PSAwKQo+ICsJCWlmICgobHZkcyAmIExW RFNfREVURUNURUQpID09IDApCj4gIAkJCXJldHVybjsKPiAgCQlpZiAoZGV2X3ByaXYtPnZidC5l ZHBfc3VwcG9ydCkgewo+ICAJCQlEUk1fREVCVUdfS01TKCJkaXNhYmxlIExWRFMgZm9yIGVEUCBz dXBwb3J0XG4iKTsKPiBAQCAtOTc3LDggKzk4MSw3IEBAIHZvaWQgaW50ZWxfbHZkc19pbml0KHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAo+ICAJcGluID0gR01CVVNfUElOX1BBTkVMOwo+ICAJ aWYgKCFsdmRzX2lzX3ByZXNlbnRfaW5fdmJ0KGRldiwgJnBpbikpIHsKPiAtCQl1MzIgcmVnID0g SEFTX1BDSF9TUExJVChkZXYpID8gUENIX0xWRFMgOiBMVkRTOwo+IC0JCWlmICgoSTkxNV9SRUFE KHJlZykgJiBMVkRTX1BPUlRfRU4pID09IDApIHsKPiArCQlpZiAoKGx2ZHMgJiBMVkRTX1BPUlRf RU4pID09IDApIHsKPiAgCQkJRFJNX0RFQlVHX0tNUygiTFZEUyBpcyBub3QgcHJlc2VudCBpbiBW QlRcbiIpOwo+ICAJCQlyZXR1cm47Cj4gIAkJfQo+IEBAIC0xMDU1LDExICsxMDU4LDcgQEAgdm9p ZCBpbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCWNvbm5lY3Rvci0+ aW50ZXJsYWNlX2FsbG93ZWQgPSBmYWxzZTsKPiAgCWNvbm5lY3Rvci0+ZG91Ymxlc2Nhbl9hbGxv d2VkID0gZmFsc2U7Cj4gIAo+IC0JaWYgKEhBU19QQ0hfU1BMSVQoZGV2KSkgewo+IC0JCWx2ZHNf ZW5jb2Rlci0+cmVnID0gUENIX0xWRFM7Cj4gLQl9IGVsc2Ugewo+IC0JCWx2ZHNfZW5jb2Rlci0+ cmVnID0gTFZEUzsKPiAtCX0KPiArCWx2ZHNfZW5jb2Rlci0+cmVnID0gbHZkc19yZWc7Cj4gIAo+ ICAJLyogY3JlYXRlIHRoZSBzY2FsaW5nIG1vZGUgcHJvcGVydHkgKi8KPiAgCWRybV9tb2RlX2Ny ZWF0ZV9zY2FsaW5nX21vZGVfcHJvcGVydHkoZGV2KTsKPiBAQCAtMTE0MCw3ICsxMTM5LDYgQEAg dm9pZCBpbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCWlmIChIQVNf UENIX1NQTElUKGRldikpCj4gIAkJZ290byBmYWlsZWQ7Cj4gIAo+IC0JbHZkcyA9IEk5MTVfUkVB RChMVkRTKTsKPiAgCXBpcGUgPSAobHZkcyAmIExWRFNfUElQRUJfU0VMRUNUKSA/IDEgOiAwOwo+ ICAJY3J0YyA9IGludGVsX2dldF9jcnRjX2Zvcl9waXBlKGRldiwgcGlwZSk7Cj4gIAo+IAoKUmV2 aWV3ZWQtYnk6IEplc3NlIEJhcm5lcyA8amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=