public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Sharma, Shashank" <shashank.sharma@intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "Matheson, Annie J" <annie.j.matheson@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	"Barnes, Jesse" <jesse.barnes@intel.com>,
	Kausal Malladi <kausalmalladi@gmail.com>,
	"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [PATCH 13/22] drm/i915: CHV: Pipe level Gamma correction
Date: Tue, 13 Oct 2015 19:34:17 +0530	[thread overview]
Message-ID: <561D0F61.3030605@intel.com> (raw)
In-Reply-To: <CACvgo51r2JfQP6fsyrycsHgG7hW07UsrnZ2ZMnj5b7f-ysDoqg@mail.gmail.com>

Regards
Shashank

On 10/13/2015 7:29 PM, Emil Velikov wrote:
> On 13 October 2015 at 14:40, Sharma, Shashank <shashank.sharma@intel.com> wrote:
>
>> I am not sure if I915 follows a general rule of using for(...) over while(),
>> coz I see many instances of using a while in i915_gem, i915_drv, i915_irq
>> etc, so it should be good. I would see if someone else can suggest another
>> good reason.
> I'm not saying "you should never use while loops", but more of "people
> use for loops when accessing arrays of information". I cannot see any
> cases of the latter in i915. Perhaps I'm looking at some old code ?
>
> The point I'm trying to make here is that people are unlikely to make
> comments about such trivial nitpicks (bikeshedding), but new
> contributions should stick with the existing approach, rather than
> going for "I like XXX" :)
>
> Take any and all of my with a grain of salt, just in case.
>
Its a very well written and logical comment, but I like this last line 
the most :) :)
> Regards,
> Emil
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-10-13 14:04 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 19:28 [PATCH 00/22] Color Management for DRM Shashank Sharma
2015-10-09 19:28 ` [PATCH 01/22] drm: Create Color Management DRM properties Shashank Sharma
2015-10-09 19:48   ` kbuild test robot
2015-10-09 19:28 ` [PATCH 02/22] drm: Create Color Management query properties Shashank Sharma
2015-10-09 20:05   ` [Intel-gfx] " kbuild test robot
2015-10-09 19:28 ` [PATCH 03/22] drm: Add color correction blobs in CRTC state Shashank Sharma
2015-10-09 20:21   ` kbuild test robot
2015-10-09 22:23   ` Emil Velikov
2015-10-10  4:48     ` Sharma, Shashank
2015-10-09 19:28 ` [PATCH 04/22] drm: Add set property support for color manager Shashank Sharma
2015-10-09 20:39   ` kbuild test robot
2015-10-09 22:25   ` Emil Velikov
2015-10-10  4:50     ` Sharma, Shashank
2015-10-09 19:28 ` [PATCH 05/22] drm: Add get " Shashank Sharma
2015-10-09 19:28 ` [PATCH 06/22] drm: Add drm structures for palette color property Shashank Sharma
2015-10-09 19:28 ` [PATCH 07/22] drm: Add structure to set/get a CTM " Shashank Sharma
2015-10-09 19:28 ` [PATCH 08/22] drm/i915: Add set property interface for CRTC Shashank Sharma
2015-10-09 19:28 ` [PATCH 09/22] drm/i915: Create color management files Shashank Sharma
2015-10-09 22:47   ` Emil Velikov
2015-10-10  4:55     ` Sharma, Shashank
2015-10-13 12:59       ` Emil Velikov
2015-10-13 13:33         ` Sharma, Shashank
2015-10-09 19:29 ` [PATCH 10/22] drm/i915: Register color correction capabilities Shashank Sharma
2015-10-09 22:21   ` Emil Velikov
2015-10-10  5:01     ` Sharma, Shashank
2015-10-13 13:03       ` Emil Velikov
2015-10-13 13:36         ` Sharma, Shashank
2015-10-13 13:53           ` Emil Velikov
2015-10-13 14:01             ` Sharma, Shashank
2015-10-09 19:29 ` [PATCH 11/22] drm/i915: CHV: Load gamma color correction values Shashank Sharma
2015-10-09 19:29 ` [PATCH 12/22] drm/i915: CHV: Load degamma " Shashank Sharma
2015-10-09 19:29 ` [PATCH 13/22] drm/i915: CHV: Pipe level Gamma correction Shashank Sharma
2015-10-09 23:07   ` Emil Velikov
2015-10-10  5:09     ` Sharma, Shashank
2015-10-13 13:08       ` Emil Velikov
2015-10-13 13:40         ` Sharma, Shashank
2015-10-13 13:59           ` Emil Velikov
2015-10-13 14:04             ` Sharma, Shashank [this message]
2015-10-09 19:29 ` [PATCH 14/22] drm/i915: CHV: Pipe level degamma correction Shashank Sharma
2015-10-09 23:11   ` Emil Velikov
2015-10-10  5:13     ` Sharma, Shashank
2015-10-09 19:29 ` [PATCH 15/22] drm/i915: CHV: Pipe level CSC correction Shashank Sharma
2015-10-09 23:43   ` Emil Velikov
2015-10-10  5:26     ` Sharma, Shashank
2015-10-13 13:33       ` Emil Velikov
2015-10-13 13:49         ` Sharma, Shashank
2015-10-09 19:29 ` [PATCH 16/22] drm/i915: Commit color correction to CRTC Shashank Sharma
2015-10-09 23:24   ` Emil Velikov
2015-10-10  5:20     ` Sharma, Shashank
2015-10-13 13:17       ` Emil Velikov
2015-10-13 13:44         ` Sharma, Shashank
2015-10-09 19:29 ` [PATCH 17/22] drm/i915: Attach color properties " Shashank Sharma
2015-10-09 23:45   ` Emil Velikov
2015-10-10  5:28     ` Sharma, Shashank
2015-10-09 19:29 ` [PATCH 18/22] drm/i915: BDW: Load gamma correction values Shashank Sharma
2015-10-09 19:29 ` [PATCH 19/22] drm/i915: BDW: Pipe level Gamma correction Shashank Sharma
2015-10-09 23:39   ` Emil Velikov
2015-10-10  5:21     ` Sharma, Shashank
2015-10-13 13:23       ` Emil Velikov
2015-10-13 13:46         ` Sharma, Shashank
2015-10-12 18:09   ` Rob Bradford
2015-10-13 10:56     ` Sharma, Shashank
2015-10-09 19:29 ` [PATCH 20/22] drm/i915: BDW: Load degamma correction values Shashank Sharma
2015-10-12 18:13   ` Rob Bradford
2015-10-13 10:59     ` Sharma, Shashank
2015-10-09 19:29 ` [PATCH 21/22] drm/i915: BDW: Pipe level degamma correction Shashank Sharma
2015-10-09 23:49   ` Emil Velikov
2015-10-10  5:31     ` Sharma, Shashank
2015-10-13 13:39       ` Emil Velikov
2015-10-12 18:08   ` Rob Bradford
2015-10-13 10:51     ` Sharma, Shashank
2015-10-09 19:29 ` [PATCH 22/22] drm/i915: BDW: Pipe level CSC correction Shashank Sharma
2015-10-09 23:54   ` Emil Velikov
2015-10-10  5:34     ` Sharma, Shashank
2015-10-13 13:45       ` Emil Velikov
2015-10-13 13:52         ` Sharma, Shashank
2015-10-12 16:49   ` Rob Bradford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561D0F61.3030605@intel.com \
    --to=shashank.sharma@intel.com \
    --cc=annie.j.matheson@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jesse.barnes@intel.com \
    --cc=kausalmalladi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox