From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 10:06:58 +0100 Message-ID: <56260432.1030007@linux.intel.com> References: <1444212083-3302-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20151019182036.GD26517@intel.com> <20151020074225.GS13786@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EDA06E084 for ; Tue, 20 Oct 2015 02:07:00 -0700 (PDT) In-Reply-To: <20151020074225.GS13786@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIwLzEwLzE1IDA4OjQyLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IE9uIE1vbiwgT2N0IDE5 LCAyMDE1IGF0IDA5OjIwOjM2UE0gKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPj4gT24g V2VkLCBPY3QgMDcsIDIwMTUgYXQgMTE6MDE6MjNBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3Jv dGU6Cj4+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+ Pj4KPj4+IFByZXZpb3VzbHkgcm90YXRpb24gd2FzIGlnbm9yZWQgYW5kIHdyb25nIHN0cmlkZSBw cm9ncmFtbWVkCj4+PiBpbnRvIHRoZSBwbGFuZSByZWdpc3RlcnMgcmVzdWx0aW5nIGluIGEgY29y cnVwdCBpbWFnZSBvbiBzY3JlZW4uCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4+IENjOiBTb25pa2EgSmluZGFsIDxzb25p a2EuamluZGFsQGludGVsLmNvbT4KPj4+IC0tLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgfCAxNiArKysrKysrKysrKystLS0tCj4+PiAgIDEgZmlsZSBjaGFuZ2Vk LCAxMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPj4+IGluZGV4IDUzOWMzNzM3ZTgyMy4uNjMyODc4ODE5M2U0IDEw MDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+IEBAIC0xMTEyNiw5 ICsxMTEyNiwxMCBAQCBzdGF0aWMgdm9pZCBza2xfZG9fbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9j cnRjICppbnRlbF9jcnRjKQo+Pj4gICB7Cj4+PiAgIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0g aW50ZWxfY3J0Yy0+YmFzZS5kZXY7Cj4+PiAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+Pj4gKwlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9 IGludGVsX2NydGMtPmJhc2UucHJpbWFyeTsKPj4+ICAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIg KmZiID0gaW50ZWxfY3J0Yy0+YmFzZS5wcmltYXJ5LT5mYjsKPj4+ICAgCWNvbnN0IGVudW0gcGlw ZSBwaXBlID0gaW50ZWxfY3J0Yy0+cGlwZTsKPj4+IC0JdTMyIGN0bCwgc3RyaWRlOwo+Pj4gKwl1 MzIgY3RsLCBzdHJpZGUsIHRpbGVfaGVpZ2h0Owo+Pj4KPj4+ICAgCWN0bCA9IEk5MTVfUkVBRChQ TEFORV9DVEwocGlwZSwgMCkpOwo+Pj4gICAJY3RsICY9IH5QTEFORV9DVExfVElMRURfTUFTSzsK Pj4+IEBAIC0xMTE1Miw5ICsxMTE1MywxNiBAQCBzdGF0aWMgdm9pZCBza2xfZG9fbW1pb19mbGlw KHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjKQo+Pj4gICAJICogVGhlIHN0cmlkZSBpcyBl aXRoZXIgZXhwcmVzc2VkIGFzIGEgbXVsdGlwbGUgb2YgNjQgYnl0ZXMgY2h1bmtzIGZvcgo+Pj4g ICAJICogbGluZWFyIGJ1ZmZlcnMgb3IgaW4gbnVtYmVyIG9mIHRpbGVzIGZvciB0aWxlZCBidWZm ZXJzLgo+Pj4gICAJICovCj4+PiAtCXN0cmlkZSA9IGZiLT5waXRjaGVzWzBdIC8KPj4+IC0JCSBp bnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGRldiwgZmItPm1vZGlmaWVyWzBdLAo+Pj4gLQkJCQkJ ICAgZmItPnBpeGVsX2Zvcm1hdCk7Cj4+PiArCWlmIChpbnRlbF9yb3RhdGlvbl85MF9vcl8yNzAo cGxhbmUtPnN0YXRlLT5yb3RhdGlvbikpIHsKPj4+ICsJCS8qIHN0cmlkZSA9IFN1cmZhY2UgaGVp Z2h0IGluIHRpbGVzICovCj4+PiArCQl0aWxlX2hlaWdodCA9IGludGVsX3RpbGVfaGVpZ2h0KGRl diwgZmItPnBpeGVsX2Zvcm1hdCwKPj4+ICsJCQkJCQlmYi0+bW9kaWZpZXJbMF0sIDApOwo+Pj4g KwkJc3RyaWRlID0gRElWX1JPVU5EX1VQKGZiLT5oZWlnaHQsIHRpbGVfaGVpZ2h0KTsKPj4+ICsJ fSBlbHNlIHsKPj4+ICsJCXN0cmlkZSA9IGZiLT5waXRjaGVzWzBdIC8KPj4+ICsJCQkJaW50ZWxf ZmJfc3RyaWRlX2FsaWdubWVudChkZXYsIGZiLT5tb2RpZmllclswXSwKPj4+ICsJCQkJCQkJICBm Yi0+cGl4ZWxfZm9ybWF0KTsKPj4+ICsJfQo+Pgo+PiBJIHdhcyB3b25kZXJpbmcgd2h5IHdlIGFy ZSBhbGxvd2luZyBzdHJpZGUgY2hhbmdlcyBkdXJpbmcgcGFnZSBmbGlwLCBidXQKPj4gYWZ0ZXIg bG9va2luZyBhdCB0aGUgaGlzdG9yeSBpdCBzZWVtcyB3ZSBhcmUgbm90LiBUaGUgcmVhc29uIGZv cgo+PiB1cGRhdGluZyB0aGUgc3RyaWRlIHJlZ2lzdGVyIGlzIHRoZSBmYWN0IHRoYXQgdGhlIHVu aXRzIHdlIHNwZWNpZnkgaXQKPj4gaW4gY2hhbmdlIGJldHdlZW4gZGlmZmVyZW50IHRpbGluZyBt b2RlcyBvbiBTS0wrLiBXZSBzdGlsbCByZWplY3QgYWN0dWFsCj4+IHN0cmlkZSBjaGFuZ2VzIGR1 cmluZyBwYWdlIGZsaXAsIHdoaWNoIGlzIGdvb2QgYmVjYXVzZSBhbGxvd2luZyBpdCB3b3VsZAo+ PiBjYXVzZSBwcm9ibGVtcyBmb3IgbXkgZmItPm9mZnNldHNbXSBzdHVmZiBzaW5jZSB0aGUgaW50 ZXJwcmV0YXRpb24gb2YgdGhlCj4+IGxpbmVhciBvZmZzZXQgd291bGQgY2hhbmdlIHdpdGggdGhl IHN0cmlkZS4KPj4KPj4gV2UgZG8gYWxsb3cgY2hhbmdlcyB0byB0aGUgcm90YXRlZCBzdHJpZGUg dGhvdWdoIHNpbmNlIHdlIGRvbid0IHJlamVjdAo+PiBjaGFuZ2VzIHRvIHRoZSBmYiBoZWlnaHQu IEkgdGhpbmsgSSBuZWVkIHRvIGRyYXcgc29tZSBwaWN0dXJlcyBiZWZvcmUgSQo+PiBjYW4gc2F5 IGZvciBzdXJlIHdoZXRoZXIgdGhhdCBjYW4gY2F1c2UgcHJvYmxlbXMgb3Igbm90LiBCdXQgd2Ug Y2EKPj4gbGVhdmUgdGhhdCBmb3IgYW5vdGhlciBwYXRjaCBpZiBpdCB0dXJucyBvdXQgdG8gbmVl ZCBoYW5kbGluZy4KPj4KPj4gT25lIHRoaW5nIHRoYXQncyBkb2RneSBoZXJlIGlzIHRoZSBwbGFu ZS0+c3RhdGUtPnJvdGF0aW9uIGNoZWNrLiBJCj4+IHRoaW5rIGN1cnJlbnRseSB3ZSB3YWl0IGZv ciBwZW5kaW5nIGZsaXBzIGR1cmluZyB0aGUgYXRvbWljIGNvbW1pdAo+PiBwaGFzZSBhZnRlciB3 ZSd2ZSBzd2FwcGVkIHRoZSBzdGF0ZS4gU28gdGhpcyBtYXkgZW5kIHVwIHVzaW5nIHRoZQo+PiB3 cm9uZyByb3RhdGlvbiBzZXR0aW5nLiBJdCB3b3VsZCBiZSBhbiBldmVuIGJpZ2dlciBwcm9ibGVt IGlmIHdlCj4+IGFscmVhZHkgYWxsb3dlZCBxdWV1ZWluZyB1cCBvciByZXBsYWNlaW5nIHBlbmRp bmcgcGxhbmUgdXBkYXRlcy4gSQo+PiBzdXBwb3NlIHRoZSBwcmltYXJ5LT5mYiB0aGluZyBkb2Vz bid0IHN1ZmZlciBmcm9tIHRoaXMgcHJvYmxlbSBiZWNhdXNlCj4+IHdlIHN3YXAgdGhhdCBwb2lu dGVyIG9ubHkgYWZ0ZXIgd2UndmUgd2FpdGVkIGZvciBwZW5kaW5nIGZsaXBzLgo+Cj4gQ3VycmVu dCBydWxlIGlzIHRoYXQgcGFnZWZsaXAgZG9lc24ndCBhbGxvdyBhbnkgY2hhbmdlIGluIGFueSBt ZXRhZGF0YS4KPiBUaGVyZSdzIHNvbWUgbWlub3IgZXhjZXB0aW9uIHRoYXQgb24gc29tZSBwbGF0 Zm9ybXMgd2UgY2FuIGNoYW5nZSB0aGUKPiB0aWxpbmcgYmVjYXVzZSBzb21lb25lIGFza2VkIGZv ciB0aGF0IHNwZWNpZmljYWxseSBhbmQgaXQncyBwb3NzaWJsZS4KPgo+IGF0b21pYyBmbGlwcyB3 aWxsIGJlIGFibGUgdG8gY29wZSB3aXRoIHRoaXMuIEJ1dCBmb3IgbGVnYWN5IHBhZ2VmbGlwcyBp bW8KPiByZWplY3QgZXZlcnl0aGluZyBhZ2dyZXNzaXZlbHkgdGhhdCBjaGFuZ2VzIG1ldGFkYXRh IChzdHJpZGUsIHRpbGluZywKPiByb3RhdGlvbikuCgpJIGFtIG5vdCBzdXJlIHdoYXQgaXMgdGhl IGNvbmNsdXNpb24uIFRvIHJlLWl0ZXJhdGUsIGlkZWEgaXMgbm90IHRvIAphbGxvdyByb3RhdGlv biBjaGFuZ2VzIGJldHdlZW4gcGFnZSBmbGlwcywganVzdCB0byBwcm9ncmFtIFBMQU5FX1NUUklE RSAKYWNjb3JkaW5nbHksIHdoZW4gcm90YXRpb24gaXMgYWxyZWFkeSBlbmFibGVkLiBTaW5jZSBv dGhlcndpc2UgcGFnZSBmbGlwIAp3aWxsIGNhbGN1bGF0ZSBpdCBpbmNvcnJlY3RseS4KCkkgdGhv dWdoIFZpbGxlIHdhcyByYWlzaW5nIHR3byBjb25jZXJuczoKCjEuIFdpbGwgdGhlIHBsYW5lIHN0 YXRlIGJlIHN3YXBwZWQgZnJvbSB1bmRlciB0aGUgcGVuZGluZyBwYWdlIGZsaXBzIApwcmVtYXR1 cmVseT8KCjIuIERvIHdlIG5lZWQgdG8gcHJvZ3JhbSB0aGUgc3RyaWRlIGluIHBhZ2UgZmxpcHMg YXQgYWxsPwoKRGlkIEkgZ2V0IHRoYXQgcmlnaHQ/IFVubGVzcyAxKSBpcyB0cnVlIGl0IGxvb2tz IHNhZmUgdG8gbWUgdG8gaGF2ZSB0aGlzIApwYXRjaCwgYW5kIGlmIGFuc3dlciB0byAyKSBpcyBu byB0aGVuIHdlIGNvdWxkIHJpcCBvdXQgbW9yZSBjb2RlPwoKUmVnYXJkcywKClR2cnRrbwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=