From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 12:44:05 +0100 Message-ID: <56262905.5070705@linux.intel.com> References: <1444212083-3302-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20151019182036.GD26517@intel.com> <20151020074225.GS13786@phenom.ffwll.local> <56260432.1030007@linux.intel.com> <20151020110716.GF26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 8AC9E6E434 for ; Tue, 20 Oct 2015 04:44:10 -0700 (PDT) In-Reply-To: <20151020110716.GF26517@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIwLzEwLzE1IDEyOjA3LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gT24gVHVlLCBPY3Qg MjAsIDIwMTUgYXQgMTA6MDY6NThBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+ IE9uIDIwLzEwLzE1IDA4OjQyLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+Pj4gT24gTW9uLCBPY3Qg MTksIDIwMTUgYXQgMDk6MjA6MzZQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+Pj4+ IE9uIFdlZCwgT2N0IDA3LCAyMDE1IGF0IDExOjAxOjIzQU0gKzAxMDAsIFR2cnRrbyBVcnN1bGlu IHdyb3RlOgo+Pj4+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu Y29tPgo+Pj4+Pgo+Pj4+PiBQcmV2aW91c2x5IHJvdGF0aW9uIHdhcyBpZ25vcmVkIGFuZCB3cm9u ZyBzdHJpZGUgcHJvZ3JhbW1lZAo+Pj4+PiBpbnRvIHRoZSBwbGFuZSByZWdpc3RlcnMgcmVzdWx0 aW5nIGluIGEgY29ycnVwdCBpbWFnZSBvbiBzY3JlZW4uCj4+Pj4+Cj4+Pj4+IFNpZ25lZC1vZmYt Ynk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Pj4+IENjOiBT b25pa2EgSmluZGFsIDxzb25pa2EuamluZGFsQGludGVsLmNvbT4KPj4+Pj4gLS0tCj4+Pj4+ICAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDE2ICsrKysrKysrKysrKy0t LS0KPj4+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25z KC0pCj4+Pj4+Cj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+Pj4gaW5k ZXggNTM5YzM3MzdlODIzLi42MzI4Nzg4MTkzZTQgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+Pj4gQEAgLTExMTI2LDkgKzExMTI2LDEwIEBAIHN0YXRp YyB2b2lkIHNrbF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMpCj4+ Pj4+ICAgIHsKPj4+Pj4gICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9jcnRjLT5i YXNlLmRldjsKPj4+Pj4gICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRl di0+ZGV2X3ByaXZhdGU7Cj4+Pj4+ICsJc3RydWN0IGRybV9wbGFuZSAqcGxhbmUgPSBpbnRlbF9j cnRjLT5iYXNlLnByaW1hcnk7Cj4+Pj4+ICAgIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9 IGludGVsX2NydGMtPmJhc2UucHJpbWFyeS0+ZmI7Cj4+Pj4+ICAgIAljb25zdCBlbnVtIHBpcGUg cGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4+Pj4+IC0JdTMyIGN0bCwgc3RyaWRlOwo+Pj4+PiAr CXUzMiBjdGwsIHN0cmlkZSwgdGlsZV9oZWlnaHQ7Cj4+Pj4+Cj4+Pj4+ICAgIAljdGwgPSBJOTE1 X1JFQUQoUExBTkVfQ1RMKHBpcGUsIDApKTsKPj4+Pj4gICAgCWN0bCAmPSB+UExBTkVfQ1RMX1RJ TEVEX01BU0s7Cj4+Pj4+IEBAIC0xMTE1Miw5ICsxMTE1MywxNiBAQCBzdGF0aWMgdm9pZCBza2xf ZG9fbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjKQo+Pj4+PiAgICAJICog VGhlIHN0cmlkZSBpcyBlaXRoZXIgZXhwcmVzc2VkIGFzIGEgbXVsdGlwbGUgb2YgNjQgYnl0ZXMg Y2h1bmtzIGZvcgo+Pj4+PiAgICAJICogbGluZWFyIGJ1ZmZlcnMgb3IgaW4gbnVtYmVyIG9mIHRp bGVzIGZvciB0aWxlZCBidWZmZXJzLgo+Pj4+PiAgICAJICovCj4+Pj4+IC0Jc3RyaWRlID0gZmIt PnBpdGNoZXNbMF0gLwo+Pj4+PiAtCQkgaW50ZWxfZmJfc3RyaWRlX2FsaWdubWVudChkZXYsIGZi LT5tb2RpZmllclswXSwKPj4+Pj4gLQkJCQkJICAgZmItPnBpeGVsX2Zvcm1hdCk7Cj4+Pj4+ICsJ aWYgKGludGVsX3JvdGF0aW9uXzkwX29yXzI3MChwbGFuZS0+c3RhdGUtPnJvdGF0aW9uKSkgewo+ Pj4+PiArCQkvKiBzdHJpZGUgPSBTdXJmYWNlIGhlaWdodCBpbiB0aWxlcyAqLwo+Pj4+PiArCQl0 aWxlX2hlaWdodCA9IGludGVsX3RpbGVfaGVpZ2h0KGRldiwgZmItPnBpeGVsX2Zvcm1hdCwKPj4+ Pj4gKwkJCQkJCWZiLT5tb2RpZmllclswXSwgMCk7Cj4+Pj4+ICsJCXN0cmlkZSA9IERJVl9ST1VO RF9VUChmYi0+aGVpZ2h0LCB0aWxlX2hlaWdodCk7Cj4+Pj4+ICsJfSBlbHNlIHsKPj4+Pj4gKwkJ c3RyaWRlID0gZmItPnBpdGNoZXNbMF0gLwo+Pj4+PiArCQkJCWludGVsX2ZiX3N0cmlkZV9hbGln bm1lbnQoZGV2LCBmYi0+bW9kaWZpZXJbMF0sCj4+Pj4+ICsJCQkJCQkJICBmYi0+cGl4ZWxfZm9y bWF0KTsKPj4+Pj4gKwl9Cj4+Pj4KPj4+PiBJIHdhcyB3b25kZXJpbmcgd2h5IHdlIGFyZSBhbGxv d2luZyBzdHJpZGUgY2hhbmdlcyBkdXJpbmcgcGFnZSBmbGlwLCBidXQKPj4+PiBhZnRlciBsb29r aW5nIGF0IHRoZSBoaXN0b3J5IGl0IHNlZW1zIHdlIGFyZSBub3QuIFRoZSByZWFzb24gZm9yCj4+ Pj4gdXBkYXRpbmcgdGhlIHN0cmlkZSByZWdpc3RlciBpcyB0aGUgZmFjdCB0aGF0IHRoZSB1bml0 cyB3ZSBzcGVjaWZ5IGl0Cj4+Pj4gaW4gY2hhbmdlIGJldHdlZW4gZGlmZmVyZW50IHRpbGluZyBt b2RlcyBvbiBTS0wrLiBXZSBzdGlsbCByZWplY3QgYWN0dWFsCj4+Pj4gc3RyaWRlIGNoYW5nZXMg ZHVyaW5nIHBhZ2UgZmxpcCwgd2hpY2ggaXMgZ29vZCBiZWNhdXNlIGFsbG93aW5nIGl0IHdvdWxk Cj4+Pj4gY2F1c2UgcHJvYmxlbXMgZm9yIG15IGZiLT5vZmZzZXRzW10gc3R1ZmYgc2luY2UgdGhl IGludGVycHJldGF0aW9uIG9mIHRoZQo+Pj4+IGxpbmVhciBvZmZzZXQgd291bGQgY2hhbmdlIHdp dGggdGhlIHN0cmlkZS4KPj4+Pgo+Pj4+IFdlIGRvIGFsbG93IGNoYW5nZXMgdG8gdGhlIHJvdGF0 ZWQgc3RyaWRlIHRob3VnaCBzaW5jZSB3ZSBkb24ndCByZWplY3QKPj4+PiBjaGFuZ2VzIHRvIHRo ZSBmYiBoZWlnaHQuIEkgdGhpbmsgSSBuZWVkIHRvIGRyYXcgc29tZSBwaWN0dXJlcyBiZWZvcmUg SQo+Pj4+IGNhbiBzYXkgZm9yIHN1cmUgd2hldGhlciB0aGF0IGNhbiBjYXVzZSBwcm9ibGVtcyBv ciBub3QuIEJ1dCB3ZSBjYQo+Pj4+IGxlYXZlIHRoYXQgZm9yIGFub3RoZXIgcGF0Y2ggaWYgaXQg dHVybnMgb3V0IHRvIG5lZWQgaGFuZGxpbmcuCj4+Pj4KPj4+PiBPbmUgdGhpbmcgdGhhdCdzIGRv ZGd5IGhlcmUgaXMgdGhlIHBsYW5lLT5zdGF0ZS0+cm90YXRpb24gY2hlY2suIEkKPj4+PiB0aGlu ayBjdXJyZW50bHkgd2Ugd2FpdCBmb3IgcGVuZGluZyBmbGlwcyBkdXJpbmcgdGhlIGF0b21pYyBj b21taXQKPj4+PiBwaGFzZSBhZnRlciB3ZSd2ZSBzd2FwcGVkIHRoZSBzdGF0ZS4gU28gdGhpcyBt YXkgZW5kIHVwIHVzaW5nIHRoZQo+Pj4+IHdyb25nIHJvdGF0aW9uIHNldHRpbmcuIEl0IHdvdWxk IGJlIGFuIGV2ZW4gYmlnZ2VyIHByb2JsZW0gaWYgd2UKPj4+PiBhbHJlYWR5IGFsbG93ZWQgcXVl dWVpbmcgdXAgb3IgcmVwbGFjZWluZyBwZW5kaW5nIHBsYW5lIHVwZGF0ZXMuIEkKPj4+PiBzdXBw b3NlIHRoZSBwcmltYXJ5LT5mYiB0aGluZyBkb2Vzbid0IHN1ZmZlciBmcm9tIHRoaXMgcHJvYmxl bSBiZWNhdXNlCj4+Pj4gd2Ugc3dhcCB0aGF0IHBvaW50ZXIgb25seSBhZnRlciB3ZSd2ZSB3YWl0 ZWQgZm9yIHBlbmRpbmcgZmxpcHMuCj4+Pgo+Pj4gQ3VycmVudCBydWxlIGlzIHRoYXQgcGFnZWZs aXAgZG9lc24ndCBhbGxvdyBhbnkgY2hhbmdlIGluIGFueSBtZXRhZGF0YS4KPj4+IFRoZXJlJ3Mg c29tZSBtaW5vciBleGNlcHRpb24gdGhhdCBvbiBzb21lIHBsYXRmb3JtcyB3ZSBjYW4gY2hhbmdl IHRoZQo+Pj4gdGlsaW5nIGJlY2F1c2Ugc29tZW9uZSBhc2tlZCBmb3IgdGhhdCBzcGVjaWZpY2Fs bHkgYW5kIGl0J3MgcG9zc2libGUuCj4+Pgo+Pj4gYXRvbWljIGZsaXBzIHdpbGwgYmUgYWJsZSB0 byBjb3BlIHdpdGggdGhpcy4gQnV0IGZvciBsZWdhY3kgcGFnZWZsaXBzIGltbwo+Pj4gcmVqZWN0 IGV2ZXJ5dGhpbmcgYWdncmVzc2l2ZWx5IHRoYXQgY2hhbmdlcyBtZXRhZGF0YSAoc3RyaWRlLCB0 aWxpbmcsCj4+PiByb3RhdGlvbikuCj4+Cj4+IEkgYW0gbm90IHN1cmUgd2hhdCBpcyB0aGUgY29u Y2x1c2lvbi4gVG8gcmUtaXRlcmF0ZSwgaWRlYSBpcyBub3QgdG8KPj4gYWxsb3cgcm90YXRpb24g Y2hhbmdlcyBiZXR3ZWVuIHBhZ2UgZmxpcHMsIGp1c3QgdG8gcHJvZ3JhbSBQTEFORV9TVFJJREUK Pj4gYWNjb3JkaW5nbHksIHdoZW4gcm90YXRpb24gaXMgYWxyZWFkeSBlbmFibGVkLiBTaW5jZSBv dGhlcndpc2UgcGFnZSBmbGlwCj4+IHdpbGwgY2FsY3VsYXRlIGl0IGluY29ycmVjdGx5Lgo+Pgo+ PiBJIHRob3VnaCBWaWxsZSB3YXMgcmFpc2luZyB0d28gY29uY2VybnM6Cj4+Cj4+IDEuIFdpbGwg dGhlIHBsYW5lIHN0YXRlIGJlIHN3YXBwZWQgZnJvbSB1bmRlciB0aGUgcGVuZGluZyBwYWdlIGZs aXBzCj4+IHByZW1hdHVyZWx5Pwo+Cj4gVGhlIGFuc3dlciBpcyB5ZXMuCgpBbmQgaXMgdGhhdCBP Sz8gV291bGQgaXQgbm90IG1ha2UgbW9yZSBzZW5zZSB0byB3YWl0IGZvciBwZW5kaW5nIGZsaXBz IAphbmQgdGhlbiBzd2FwIHN0YXRlPwoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=