From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 13:05:22 +0100 Message-ID: <56262E02.8010400@linux.intel.com> References: <1444212083-3302-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20151019182036.GD26517@intel.com> <20151020074225.GS13786@phenom.ffwll.local> <56260432.1030007@linux.intel.com> <20151020110716.GF26517@intel.com> <56262905.5070705@linux.intel.com> <20151020115324.GH26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id E2CA46E1EF for ; Tue, 20 Oct 2015 05:05:24 -0700 (PDT) In-Reply-To: <20151020115324.GH26517@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIwLzEwLzE1IDEyOjUzLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gT24gVHVlLCBPY3Qg MjAsIDIwMTUgYXQgMTI6NDQ6MDVQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+ IE9uIDIwLzEwLzE1IDEyOjA3LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4+PiBPbiBUdWUsIE9j dCAyMCwgMjAxNSBhdCAxMDowNjo1OEFNICswMTAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4+ Pgo+Pj4+IE9uIDIwLzEwLzE1IDA4OjQyLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+Pj4+PiBPbiBN b24sIE9jdCAxOSwgMjAxNSBhdCAwOToyMDozNlBNICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3Jv dGU6Cj4+Pj4+PiBPbiBXZWQsIE9jdCAwNywgMjAxNSBhdCAxMTowMToyM0FNICswMTAwLCBUdnJ0 a28gVXJzdWxpbiB3cm90ZToKPj4+Pj4+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVy c3VsaW5AaW50ZWwuY29tPgo+Pj4+Pj4+Cj4+Pj4+Pj4gUHJldmlvdXNseSByb3RhdGlvbiB3YXMg aWdub3JlZCBhbmQgd3Jvbmcgc3RyaWRlIHByb2dyYW1tZWQKPj4+Pj4+PiBpbnRvIHRoZSBwbGFu ZSByZWdpc3RlcnMgcmVzdWx0aW5nIGluIGEgY29ycnVwdCBpbWFnZSBvbiBzY3JlZW4uCj4+Pj4+ Pj4KPj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A aW50ZWwuY29tPgo+Pj4+Pj4+IENjOiBTb25pa2EgSmluZGFsIDxzb25pa2EuamluZGFsQGludGVs LmNvbT4KPj4+Pj4+PiAtLS0KPj4+Pj4+PiAgICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIHwgMTYgKysrKysrKysrKysrLS0tLQo+Pj4+Pj4+ICAgICAxIGZpbGUgY2hhbmdl ZCwgMTIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPj4+Pj4+Pgo+Pj4+Pj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+Pj4+PiBpbmRleCA1MzljMzczN2U4MjMuLjYz Mjg3ODgxOTNlNCAxMDA2NDQKPj4+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPj4+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPj4+Pj4+PiBAQCAtMTExMjYsOSArMTExMjYsMTAgQEAgc3RhdGljIHZvaWQgc2tsX2Rv X21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YykKPj4+Pj4+PiAgICAgewo+ Pj4+Pj4+ICAgICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2NydGMtPmJhc2UuZGV2 Owo+Pj4+Pj4+ICAgICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5k ZXZfcHJpdmF0ZTsKPj4+Pj4+PiArCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lID0gaW50ZWxfY3J0 Yy0+YmFzZS5wcmltYXJ5Owo+Pj4+Pj4+ICAgICAJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIg PSBpbnRlbF9jcnRjLT5iYXNlLnByaW1hcnktPmZiOwo+Pj4+Pj4+ICAgICAJY29uc3QgZW51bSBw aXBlIHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+Pj4+Pj4+IC0JdTMyIGN0bCwgc3RyaWRlOwo+ Pj4+Pj4+ICsJdTMyIGN0bCwgc3RyaWRlLCB0aWxlX2hlaWdodDsKPj4+Pj4+Pgo+Pj4+Pj4+ICAg ICAJY3RsID0gSTkxNV9SRUFEKFBMQU5FX0NUTChwaXBlLCAwKSk7Cj4+Pj4+Pj4gICAgIAljdGwg Jj0gflBMQU5FX0NUTF9USUxFRF9NQVNLOwo+Pj4+Pj4+IEBAIC0xMTE1Miw5ICsxMTE1MywxNiBA QCBzdGF0aWMgdm9pZCBza2xfZG9fbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9j cnRjKQo+Pj4+Pj4+ICAgICAJICogVGhlIHN0cmlkZSBpcyBlaXRoZXIgZXhwcmVzc2VkIGFzIGEg bXVsdGlwbGUgb2YgNjQgYnl0ZXMgY2h1bmtzIGZvcgo+Pj4+Pj4+ICAgICAJICogbGluZWFyIGJ1 ZmZlcnMgb3IgaW4gbnVtYmVyIG9mIHRpbGVzIGZvciB0aWxlZCBidWZmZXJzLgo+Pj4+Pj4+ICAg ICAJICovCj4+Pj4+Pj4gLQlzdHJpZGUgPSBmYi0+cGl0Y2hlc1swXSAvCj4+Pj4+Pj4gLQkJIGlu dGVsX2ZiX3N0cmlkZV9hbGlnbm1lbnQoZGV2LCBmYi0+bW9kaWZpZXJbMF0sCj4+Pj4+Pj4gLQkJ CQkJICAgZmItPnBpeGVsX2Zvcm1hdCk7Cj4+Pj4+Pj4gKwlpZiAoaW50ZWxfcm90YXRpb25fOTBf b3JfMjcwKHBsYW5lLT5zdGF0ZS0+cm90YXRpb24pKSB7Cj4+Pj4+Pj4gKwkJLyogc3RyaWRlID0g U3VyZmFjZSBoZWlnaHQgaW4gdGlsZXMgKi8KPj4+Pj4+PiArCQl0aWxlX2hlaWdodCA9IGludGVs X3RpbGVfaGVpZ2h0KGRldiwgZmItPnBpeGVsX2Zvcm1hdCwKPj4+Pj4+PiArCQkJCQkJZmItPm1v ZGlmaWVyWzBdLCAwKTsKPj4+Pj4+PiArCQlzdHJpZGUgPSBESVZfUk9VTkRfVVAoZmItPmhlaWdo dCwgdGlsZV9oZWlnaHQpOwo+Pj4+Pj4+ICsJfSBlbHNlIHsKPj4+Pj4+PiArCQlzdHJpZGUgPSBm Yi0+cGl0Y2hlc1swXSAvCj4+Pj4+Pj4gKwkJCQlpbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGRl diwgZmItPm1vZGlmaWVyWzBdLAo+Pj4+Pj4+ICsJCQkJCQkJICBmYi0+cGl4ZWxfZm9ybWF0KTsK Pj4+Pj4+PiArCX0KPj4+Pj4+Cj4+Pj4+PiBJIHdhcyB3b25kZXJpbmcgd2h5IHdlIGFyZSBhbGxv d2luZyBzdHJpZGUgY2hhbmdlcyBkdXJpbmcgcGFnZSBmbGlwLCBidXQKPj4+Pj4+IGFmdGVyIGxv b2tpbmcgYXQgdGhlIGhpc3RvcnkgaXQgc2VlbXMgd2UgYXJlIG5vdC4gVGhlIHJlYXNvbiBmb3IK Pj4+Pj4+IHVwZGF0aW5nIHRoZSBzdHJpZGUgcmVnaXN0ZXIgaXMgdGhlIGZhY3QgdGhhdCB0aGUg dW5pdHMgd2Ugc3BlY2lmeSBpdAo+Pj4+Pj4gaW4gY2hhbmdlIGJldHdlZW4gZGlmZmVyZW50IHRp bGluZyBtb2RlcyBvbiBTS0wrLiBXZSBzdGlsbCByZWplY3QgYWN0dWFsCj4+Pj4+PiBzdHJpZGUg Y2hhbmdlcyBkdXJpbmcgcGFnZSBmbGlwLCB3aGljaCBpcyBnb29kIGJlY2F1c2UgYWxsb3dpbmcg aXQgd291bGQKPj4+Pj4+IGNhdXNlIHByb2JsZW1zIGZvciBteSBmYi0+b2Zmc2V0c1tdIHN0dWZm IHNpbmNlIHRoZSBpbnRlcnByZXRhdGlvbiBvZiB0aGUKPj4+Pj4+IGxpbmVhciBvZmZzZXQgd291 bGQgY2hhbmdlIHdpdGggdGhlIHN0cmlkZS4KPj4+Pj4+Cj4+Pj4+PiBXZSBkbyBhbGxvdyBjaGFu Z2VzIHRvIHRoZSByb3RhdGVkIHN0cmlkZSB0aG91Z2ggc2luY2Ugd2UgZG9uJ3QgcmVqZWN0Cj4+ Pj4+PiBjaGFuZ2VzIHRvIHRoZSBmYiBoZWlnaHQuIEkgdGhpbmsgSSBuZWVkIHRvIGRyYXcgc29t ZSBwaWN0dXJlcyBiZWZvcmUgSQo+Pj4+Pj4gY2FuIHNheSBmb3Igc3VyZSB3aGV0aGVyIHRoYXQg Y2FuIGNhdXNlIHByb2JsZW1zIG9yIG5vdC4gQnV0IHdlIGNhCj4+Pj4+PiBsZWF2ZSB0aGF0IGZv ciBhbm90aGVyIHBhdGNoIGlmIGl0IHR1cm5zIG91dCB0byBuZWVkIGhhbmRsaW5nLgo+Pj4+Pj4K Pj4+Pj4+IE9uZSB0aGluZyB0aGF0J3MgZG9kZ3kgaGVyZSBpcyB0aGUgcGxhbmUtPnN0YXRlLT5y b3RhdGlvbiBjaGVjay4gSQo+Pj4+Pj4gdGhpbmsgY3VycmVudGx5IHdlIHdhaXQgZm9yIHBlbmRp bmcgZmxpcHMgZHVyaW5nIHRoZSBhdG9taWMgY29tbWl0Cj4+Pj4+PiBwaGFzZSBhZnRlciB3ZSd2 ZSBzd2FwcGVkIHRoZSBzdGF0ZS4gU28gdGhpcyBtYXkgZW5kIHVwIHVzaW5nIHRoZQo+Pj4+Pj4g d3Jvbmcgcm90YXRpb24gc2V0dGluZy4gSXQgd291bGQgYmUgYW4gZXZlbiBiaWdnZXIgcHJvYmxl bSBpZiB3ZQo+Pj4+Pj4gYWxyZWFkeSBhbGxvd2VkIHF1ZXVlaW5nIHVwIG9yIHJlcGxhY2Vpbmcg cGVuZGluZyBwbGFuZSB1cGRhdGVzLiBJCj4+Pj4+PiBzdXBwb3NlIHRoZSBwcmltYXJ5LT5mYiB0 aGluZyBkb2Vzbid0IHN1ZmZlciBmcm9tIHRoaXMgcHJvYmxlbSBiZWNhdXNlCj4+Pj4+PiB3ZSBz d2FwIHRoYXQgcG9pbnRlciBvbmx5IGFmdGVyIHdlJ3ZlIHdhaXRlZCBmb3IgcGVuZGluZyBmbGlw cy4KPj4+Pj4KPj4+Pj4gQ3VycmVudCBydWxlIGlzIHRoYXQgcGFnZWZsaXAgZG9lc24ndCBhbGxv dyBhbnkgY2hhbmdlIGluIGFueSBtZXRhZGF0YS4KPj4+Pj4gVGhlcmUncyBzb21lIG1pbm9yIGV4 Y2VwdGlvbiB0aGF0IG9uIHNvbWUgcGxhdGZvcm1zIHdlIGNhbiBjaGFuZ2UgdGhlCj4+Pj4+IHRp bGluZyBiZWNhdXNlIHNvbWVvbmUgYXNrZWQgZm9yIHRoYXQgc3BlY2lmaWNhbGx5IGFuZCBpdCdz IHBvc3NpYmxlLgo+Pj4+Pgo+Pj4+PiBhdG9taWMgZmxpcHMgd2lsbCBiZSBhYmxlIHRvIGNvcGUg d2l0aCB0aGlzLiBCdXQgZm9yIGxlZ2FjeSBwYWdlZmxpcHMgaW1vCj4+Pj4+IHJlamVjdCBldmVy eXRoaW5nIGFnZ3Jlc3NpdmVseSB0aGF0IGNoYW5nZXMgbWV0YWRhdGEgKHN0cmlkZSwgdGlsaW5n LAo+Pj4+PiByb3RhdGlvbikuCj4+Pj4KPj4+PiBJIGFtIG5vdCBzdXJlIHdoYXQgaXMgdGhlIGNv bmNsdXNpb24uIFRvIHJlLWl0ZXJhdGUsIGlkZWEgaXMgbm90IHRvCj4+Pj4gYWxsb3cgcm90YXRp b24gY2hhbmdlcyBiZXR3ZWVuIHBhZ2UgZmxpcHMsIGp1c3QgdG8gcHJvZ3JhbSBQTEFORV9TVFJJ REUKPj4+PiBhY2NvcmRpbmdseSwgd2hlbiByb3RhdGlvbiBpcyBhbHJlYWR5IGVuYWJsZWQuIFNp bmNlIG90aGVyd2lzZSBwYWdlIGZsaXAKPj4+PiB3aWxsIGNhbGN1bGF0ZSBpdCBpbmNvcnJlY3Rs eS4KPj4+Pgo+Pj4+IEkgdGhvdWdoIFZpbGxlIHdhcyByYWlzaW5nIHR3byBjb25jZXJuczoKPj4+ Pgo+Pj4+IDEuIFdpbGwgdGhlIHBsYW5lIHN0YXRlIGJlIHN3YXBwZWQgZnJvbSB1bmRlciB0aGUg cGVuZGluZyBwYWdlIGZsaXBzCj4+Pj4gcHJlbWF0dXJlbHk/Cj4+Pgo+Pj4gVGhlIGFuc3dlciBp cyB5ZXMuCj4+Cj4+IEFuZCBpcyB0aGF0IE9LPwo+Cj4gTm8sIHdlIGNvdWxkIG1pc3Byb2dyYW0g dGhlIHN0cmlkZSBhbmQgY29ycnVwdCB0aGUgZGlzcGxheS4KCk9oIEkgZGlkIG5vdCBtZWFuIHRo YXQgYnV0IGlmIGl0IGlzIE9LIHRvIHJlcGxhY2UgdGhlIHN0YXRlIHVuZGVyIHF1ZXVlZCAKZmxp cHMuIFNvdW5kZWQgbGlrZSBhIGJ1ZyB0byBtZSBidXQgd2hhdCBkbyBJIGtub3cuCgo+PiBXb3Vs ZCBpdCBub3QgbWFrZSBtb3JlIHNlbnNlIHRvIHdhaXQgZm9yIHBlbmRpbmcgZmxpcHMKPj4gYW5k IHRoZW4gc3dhcCBzdGF0ZT8KPgo+IEkgdGhpbmsgZXZlbnR1YWxseSB3ZSB3YW50IHRvIHF1ZXVl IHVwIG11bHRpcGxlIGZsaXBzIGFuZC9vciBhbGxvdwo+IGxhdGVyIGZsaXBzIHRvIG92ZXJyaWRl IHByZXZpb3VzIG9uZXMsIHNvIGNvbnN1bHRpbmcgdGhlIGN1cnJlbnQKPiBzdGF0ZSBmcm9tIHRo ZSBtbWlvIGZsaXAgaXMgYSBub3QgYSBnb29kIGlkZWEgaW4gYW55IGNhc2UuIEkgd291bGQKPiBq dXN0IGFkZCB3b3JrLT5yb3RhdGlvbiBhbmQgcG9wdWxhdGUgaXQgd2l0aCBhIHNuYXBzaG90IGF0 IHRoZSB0aW1lCj4gd2hlbiB0aGUgZmxpcCBpcyBxdWV1ZWQuCgpZZXMgSSBjYW4gY2VydGFpbmx5 IGRvIHRoYXQgaWYgZGVlbWVkIGFjY2VwdGFibGUuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==