From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915/skl: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 16:11:34 +0100 Message-ID: <562659A6.3070105@linux.intel.com> References: <1445352851-26796-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20151020150804.GM26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E3DE56E0F6 for ; Tue, 20 Oct 2015 08:11:36 -0700 (PDT) In-Reply-To: <20151020150804.GM26517@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIwLzEwLzE1IDE2OjA4LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gT24gVHVlLCBPY3Qg MjAsIDIwMTUgYXQgMDM6NTQ6MTFQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZy b206IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IFByZXZp b3VzbHkgcm90YXRpb24gd2FzIGlnbm9yZWQgYW5kIHdyb25nIHN0cmlkZSBwcm9ncmFtbWVkCj4+ IGludG8gdGhlIHBsYW5lIHJlZ2lzdGVycyByZXN1bHRpbmcgaW4gYSBjb3JydXB0IGltYWdlIG9u IHNjcmVlbi4KPj4KPj4gdjI6IERvIG5vdCBhY2Nlc3MgcG90ZW50aWFseSBvbGQgcGxhbmUgc3Rh dGUgYXQgZmxpcCB0aW1lLAo+PiAgICAgIGJ1dCBzdG9yZSB0aGUgcm90YXRpb24gdmFsdWUgYXQg dGhlIHRpbWUgb2YgcXVlaW5nIHRoZSBmbGlwLgo+PiAgICAgIChWaWxsZSkKPj4KPj4gU2lnbmVk LW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4gVGVz dGNhc2U6IGlndC9rbXNfcm90YXRpb25fY3JjL3ByaW1hcnktcm90YXRpb24tOTAtZmxpcC1zdHJl c3MgKFNLTCkKPj4gQ2M6IFNvbmlrYSBKaW5kYWwgPHNvbmlrYS5qaW5kYWxAaW50ZWwuY29tPgo+ PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPj4g LS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMzAgKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmggICAgIHwgIDEgKwo+PiAgIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwg MTEgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4g aW5kZXggMWZjMWQyNDBkM2MxLi45Y2IyOTA4Njk3MWEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPj4gQEAgLTExMDkxLDEzICsxMTA5MSwxNCBAQCBzdGF0aWMgYm9v bCB1c2VfbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsCj4+ICAgfQo+Pgo+ PiAgIHN0YXRpYyB2b2lkIHNrbF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVsX2NydGMgKmludGVs X2NydGMsCj4+ICsJCQkgICAgIHVuc2lnbmVkIGludCByb3RhdGlvbiwKPj4gICAJCQkgICAgIHN0 cnVjdCBpbnRlbF91bnBpbl93b3JrICp3b3JrKQo+PiAgIHsKPj4gICAJc3RydWN0IGRybV9kZXZp Y2UgKmRldiA9IGludGVsX2NydGMtPmJhc2UuZGV2Owo+PiAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+PiAgIAlzdHJ1Y3QgZHJtX2ZyYW1l YnVmZmVyICpmYiA9IGludGVsX2NydGMtPmJhc2UucHJpbWFyeS0+ZmI7Cj4+ICAgCWNvbnN0IGVu dW0gcGlwZSBwaXBlID0gaW50ZWxfY3J0Yy0+cGlwZTsKPj4gLQl1MzIgY3RsLCBzdHJpZGU7Cj4+ ICsJdTMyIGN0bCwgc3RyaWRlLCB0aWxlX2hlaWdodDsKPj4KPj4gICAJY3RsID0gSTkxNV9SRUFE KFBMQU5FX0NUTChwaXBlLCAwKSk7Cj4+ICAgCWN0bCAmPSB+UExBTkVfQ1RMX1RJTEVEX01BU0s7 Cj4+IEBAIC0xMTEyMSw5ICsxMTEyMiwxNiBAQCBzdGF0aWMgdm9pZCBza2xfZG9fbW1pb19mbGlw KHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+PiAgIAkgKiBUaGUgc3RyaWRlIGlzIGVp dGhlciBleHByZXNzZWQgYXMgYSBtdWx0aXBsZSBvZiA2NCBieXRlcyBjaHVua3MgZm9yCj4+ICAg CSAqIGxpbmVhciBidWZmZXJzIG9yIGluIG51bWJlciBvZiB0aWxlcyBmb3IgdGlsZWQgYnVmZmVy cy4KPj4gICAJICovCj4+IC0Jc3RyaWRlID0gZmItPnBpdGNoZXNbMF0gLwo+PiAtCQkgaW50ZWxf ZmJfc3RyaWRlX2FsaWdubWVudChkZXYsIGZiLT5tb2RpZmllclswXSwKPj4gLQkJCQkJICAgZmIt PnBpeGVsX2Zvcm1hdCk7Cj4+ICsJaWYgKGludGVsX3JvdGF0aW9uXzkwX29yXzI3MChyb3RhdGlv bikpIHsKPj4gKwkJLyogc3RyaWRlID0gU3VyZmFjZSBoZWlnaHQgaW4gdGlsZXMgKi8KPj4gKwkJ dGlsZV9oZWlnaHQgPSBpbnRlbF90aWxlX2hlaWdodChkZXYsIGZiLT5waXhlbF9mb3JtYXQsCj4+ ICsJCQkJCQlmYi0+bW9kaWZpZXJbMF0sIDApOwo+PiArCQlzdHJpZGUgPSBESVZfUk9VTkRfVVAo ZmItPmhlaWdodCwgdGlsZV9oZWlnaHQpOwo+PiArCX0gZWxzZSB7Cj4+ICsJCXN0cmlkZSA9IGZi LT5waXRjaGVzWzBdIC8KPj4gKwkJCQlpbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGRldiwgZmIt Pm1vZGlmaWVyWzBdLAo+PiArCQkJCQkJCSAgZmItPnBpeGVsX2Zvcm1hdCk7Cj4+ICsJfQo+Pgo+ PiAgIAkvKgo+PiAgIAkgKiBCb3RoIFBMQU5FX0NUTCBhbmQgUExBTkVfU1RSSURFIGFyZSBub3Qg dXBkYXRlZCBvbiB2YmxhbmsgYnV0IG9uCj4+IEBAIC0xMTE4MSw3ICsxMTE4OSw3IEBAIHN0YXRp YyB2b2lkIGludGVsX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfbW1pb19mbGlwICptbWlvX2Zs aXApCj4+ICAgCWludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGNydGMpOwo+Pgo+PiAgIAlpZiAoSU5U RUxfSU5GTyhtbWlvX2ZsaXAtPmk5MTUpLT5nZW4gPj0gOSkKPj4gLQkJc2tsX2RvX21taW9fZmxp cChjcnRjLCB3b3JrKTsKPj4gKwkJc2tsX2RvX21taW9fZmxpcChjcnRjLCBtbWlvX2ZsaXAtPnJv dGF0aW9uLCB3b3JrKTsKPj4gICAJZWxzZQo+PiAgIAkJLyogdXNlX21taW9fZmxpcCgpIHJldHJp Y3RzIE1NSU8gZmxpcHMgdG8gaWxrKyAqLwo+PiAgIAkJaWxrX2RvX21taW9fZmxpcChjcnRjLCB3 b3JrKTsKPj4gQEAgLTExMjA4LDEwICsxMTIxNiw4IEBAIHN0YXRpYyB2b2lkIGludGVsX21taW9f ZmxpcF93b3JrX2Z1bmMoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+Pgo+PiAgIHN0YXRpYyBp bnQgaW50ZWxfcXVldWVfbW1pb19mbGlwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICAgCQkJ CSBzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4+IC0JCQkJIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIg KmZiLAo+PiAtCQkJCSBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+PiAtCQkJCSBz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+PiAtCQkJCSB1aW50MzJfdCBmbGFncykKPj4g KwkJCQkgdW5zaWduZWQgaW50IHJvdGF0aW9uLAo+PiArCQkJCSBzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X29iamVjdCAqb2JqKQo+PiAgIHsKPj4gICAJc3RydWN0IGludGVsX21taW9fZmxpcCAqbW1pb19m bGlwOwo+Pgo+PiBAQCAtMTEyMjIsNiArMTEyMjgsNyBAQCBzdGF0aWMgaW50IGludGVsX3F1ZXVl X21taW9fZmxpcChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgIAltbWlvX2ZsaXAtPmk5MTUg PSB0b19pOTE1KGRldik7Cj4+ICAgCW1taW9fZmxpcC0+cmVxID0gaTkxNV9nZW1fcmVxdWVzdF9y ZWZlcmVuY2Uob2JqLT5sYXN0X3dyaXRlX3JlcSk7Cj4+ICAgCW1taW9fZmxpcC0+Y3J0YyA9IHRv X2ludGVsX2NydGMoY3J0Yyk7Cj4+ICsJbW1pb19mbGlwLT5yb3RhdGlvbiA9IHJvdGF0aW9uOwo+ Cj4gQ291bGQganVzdCBkbyB0aGUgY3J0Yy0+cHJpbWFyeS0+c3RhdGUtPnJvdGF0aW9uIHRoaW5n IGhlcmUgYW5kIGF2b2lkCj4gaGF2aW5nIHRvIHBhc3MgdGhlIHJvdGF0aW9uIGZyb20gdGhlIGNh bGxlci4KCk9oIHRoYXQgd291bGQgaW5kZWVkIGJlIG5pY2VyLiBJJ2xsIGRvIGEgdjMuCgo+IEJ1 dCB0aGUgcGF0Y2ggbG9va3MgT0sgYW55d2F5Ogo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rs w6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKQ2FuIEkgY2Fycnkgb3ZlciB0aGUg ci1iIHRvIHYzPwoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=