From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915/guc: Fix a false alert of memory leak when free LRC Date: Fri, 23 Oct 2015 22:40:11 +0100 Message-ID: <562AA93B.2010400@intel.com> References: <1445292346-7693-1-git-send-email-yu.dai@intel.com> <1445452063-9286-1-git-send-email-yu.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id F07EB6F0FA for ; Fri, 23 Oct 2015 14:40:12 -0700 (PDT) In-Reply-To: <1445452063-9286-1-git-send-email-yu.dai@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, "Dai, Yu" List-Id: intel-gfx@lists.freedesktop.org T24gMjEvMTAvMTUgMTk6MjcsIHl1LmRhaUBpbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogQWxleCBE YWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4KPiBUaGVyZSBpcyBhIG1lbW9yeSBsZWFrIHdhcm5pbmcg bWVzc2FnZSBmcm9tIGk5MTVfZ2VtX2NvbnRleHRfY2xlYW4KPiB3aGVuIEd1QyBzdWJtaXNzaW9u IGlzIGVuYWJsZWQuIFRoZSByZWFzb24gaXMgdGhhdCBnZW1fcmVxdWVzdCAoc28KPiB0aGUgTFJD IGFzc29jaWF0ZWQgd2l0aCBpdCkgaXMgZnJlZWQgZWFybHkgdGhhbiBtb3ZpbmcgdGhlIHZtYSBs aXN0Cj4gdG8gaW5hY3RpdmUuCj4KPiBXZSBhcmUgbm90IHNlZWluZyB0aGlzIGluIEV4ZWNMaXN0 IChub24tR3VDKSBtb2RlIGJlY2F1c2UgdGhlCj4gZ2VtX3JlcXVlc3QgaXMgdHJhY2tlZCBieSBl eGVjbGlzdF9yZXRpcmVkX3JlcV9saXN0LiBUaGUgbWFuYWdlbWVudAo+IG9mIHRoaXMgcXVldWUs IHRoZXJlZm9yZSBmcmVlIG9mIExSQywgaGFwcGVucyBhZnRlciByZXRpcmUgb2Ygdm1hCj4gbGlz dC4gSW4gdGhpcyBwYXRjaCwgd2UgdXNlIHRoZSBzYW1lIGdlbV9yZXF1ZXN0IG1hbmFnZW1lbnQg Zm9yIEd1Qwo+IHN1Ym1pc3Npb24uIEJlY2F1c2UgdGhlIGNvbnRleHQgc3dpdGNoIGludGVycnVw dCBpcyBoYW5kbGVkIGJ5Cj4gZmlybXdhcmUsIGludGVsX2d1Y19yZXRpcmVfcmVxdWVzdHMgaXMg aW50cm9kdWNlZCB0byBtb3ZlIHJldGlyZWQKPiBnZW1fcmVxdWVzdCB0byBleGVjbGlzdF9yZXRp cmVkX3JlcV9saXN0IHRoZW4gYmUgcmVsZWFzZWQgbGF0ZXIgaW4KPiB3b3JrcXVldWUuCj4KPiBT aWduZWQtb2ZmLWJ5OiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgICAgICAgICAgICB8ICAxICsKPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDM1ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmggICAgICAg ICAgIHwgIDIgKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAg ICB8IDEwICsrKystLS0tLQo+ICAgNCBmaWxlcyBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCA2 IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggN2Q2YjBjOC4u NmQ4YTBmMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0yODc5LDYgKzI4Nzks NyBAQCBpOTE1X2dlbV9yZXRpcmVfcmVxdWVzdHMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAg IAkJCWlkbGUgJj0gbGlzdF9lbXB0eSgmcmluZy0+ZXhlY2xpc3RfcXVldWUpOwo+ICAgCQkJc3Bp bl91bmxvY2tfaXJxcmVzdG9yZSgmcmluZy0+ZXhlY2xpc3RfbG9jaywgZmxhZ3MpOwo+Cj4gKwkJ CWludGVsX2d1Y19yZXRpcmVfcmVxdWVzdHMocmluZyk7Cj4gICAJCQlpbnRlbF9leGVjbGlzdHNf cmV0aXJlX3JlcXVlc3RzKHJpbmcpOwo+ICAgCQl9Cj4gICAJfQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCA3MzdiNGY1Li5hMzVjZmVlIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IEBAIC01OTcs NyArNTk3LDggQEAgaW50IGk5MTVfZ3VjX3N1Ym1pdChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpj bGllbnQsCj4gICAJCSAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKQo+ICAgewo+ ICAgCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9IGNsaWVudC0+Z3VjOwo+IC0JZW51bSBpbnRlbF9y aW5nX2lkIHJpbmdfaWQgPSBycS0+cmluZy0+aWQ7Cj4gKwlzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICpyaW5nID0gcnEtPnJpbmc7Cj4gKwllbnVtIGludGVsX3JpbmdfaWQgcmluZ19pZCA9IHJpbmct PmlkOwo+ICAgCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gICAJaW50IHFfcmV0LCBiX3JldDsKPgo+ IEBAIC02MjgsOSArNjI5LDQxIEBAIGludCBpOTE1X2d1Y19zdWJtaXQoc3RydWN0IGk5MTVfZ3Vj X2NsaWVudCAqY2xpZW50LAo+ICAgCWd1Yy0+bGFzdF9zZXFub1tyaW5nX2lkXSA9IHJxLT5zZXFu bzsKPiAgIAlzcGluX3VubG9jaygmZ3VjLT5ob3N0Mmd1Y19sb2NrKTsKPgo+ICsJc3Bpbl9sb2Nr X2lycSgmcmluZy0+ZXhlY2xpc3RfbG9jayk7Cj4gKwlsaXN0X2FkZF90YWlsKCZycS0+ZXhlY2xp c3RfbGluaywgJnJpbmctPmV4ZWNsaXN0X3F1ZXVlKTsKPiArCXNwaW5fdW5sb2NrX2lycSgmcmlu Zy0+ZXhlY2xpc3RfbG9jayk7Cj4gKwo+ICAgCXJldHVybiBxX3JldDsKPiAgIH0KPgo+ICt2b2lk IGludGVsX2d1Y19yZXRpcmVfcmVxdWVzdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykK PiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gcmluZy0+ZGV2LT5k ZXZfcHJpdmF0ZTsKPiArCj4gKwlpZiAoIWRldl9wcml2LT5ndWMuZXhlY2J1Zl9jbGllbnQpCj4g KwkJcmV0dXJuOwo+ICsKPiArCXNwaW5fbG9ja19pcnEoJnJpbmctPmV4ZWNsaXN0X2xvY2spOwo+ ICsKPiArCXdoaWxlICghbGlzdF9lbXB0eSgmcmluZy0+ZXhlY2xpc3RfcXVldWUpKSB7Cj4gKwkJ c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0Owo+ICsKPiArCQlyZXF1ZXN0ID0g bGlzdF9maXJzdF9lbnRyeSgmcmluZy0+ZXhlY2xpc3RfcXVldWUsCj4gKwkJCQlzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QsCj4gKwkJCQlleGVjbGlzdF9saW5rKTsKPiArCj4gKwkJaWYgKCFp OTE1X2dlbV9yZXF1ZXN0X2NvbXBsZXRlZChyZXF1ZXN0LCB0cnVlKSkKPiArCQkJYnJlYWs7Cj4g Kwo+ICsJCWxpc3RfZGVsKCZyZXF1ZXN0LT5leGVjbGlzdF9saW5rKTsKPiArCQlsaXN0X2FkZF90 YWlsKCZyZXF1ZXN0LT5leGVjbGlzdF9saW5rLAo+ICsJCQkmcmluZy0+ZXhlY2xpc3RfcmV0aXJl ZF9yZXFfbGlzdCk7Cj4gKwo+ICsJfQo+ICsKPiArCXNwaW5fdW5sb2NrKCZyaW5nLT5leGVjbGlz dF9sb2NrKTsKPiArfQo+ICsKPiAgIC8qCj4gICAgKiBFdmVyeXRoaW5nIGJlbG93IGhlcmUgaXMg Y29uY2VybmVkIHdpdGggc2V0dXAgJiB0ZWFyZG93biwgYW5kIGlzCj4gICAgKiB0aGVyZWZvcmUg bm90IHBhcnQgb2YgdGhlIHNvbWV3aGF0IHRpbWUtY3JpdGljYWwgYmF0Y2gtc3VibWlzc2lvbgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaCBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gaW5kZXggOGM1ZjgyZi4uNGM2NDdiOSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gQEAgLTEyOSw0ICsxMjksNiBAQCBpbnQgaTkxNV9n dWNfc3VibWl0KHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCwKPiAgIHZvaWQgaTkxNV9n dWNfc3VibWlzc2lvbl9kaXNhYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICAgdm9pZCBp OTE1X2d1Y19zdWJtaXNzaW9uX2Zpbmkoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4KPiArdm9p ZCBpbnRlbF9ndWNfcmV0aXJlX3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcp Owo+ICsKPiAgICNlbmRpZgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggOTgzODli ZC4uMDU2MjBmMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTU2NiwxMSAr NTY2LDYgQEAgc3RhdGljIGludCBleGVjbGlzdHNfY29udGV4dF9xdWV1ZShzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0 ICpjdXJzb3I7Cj4gICAJaW50IG51bV9lbGVtZW50cyA9IDA7Cj4KPiAtCWlmIChyZXF1ZXN0LT5j dHggIT0gcmluZy0+ZGVmYXVsdF9jb250ZXh0KQo+IC0JCWludGVsX2xyX2NvbnRleHRfcGluKHJl cXVlc3QpOwo+IC0KPiAtCWk5MTVfZ2VtX3JlcXVlc3RfcmVmZXJlbmNlKHJlcXVlc3QpOwo+IC0K PiAgIAlzcGluX2xvY2tfaXJxKCZyaW5nLT5leGVjbGlzdF9sb2NrKTsKPgo+ICAgCWxpc3RfZm9y X2VhY2hfZW50cnkoY3Vyc29yLCAmcmluZy0+ZXhlY2xpc3RfcXVldWUsIGV4ZWNsaXN0X2xpbmsp Cj4gQEAgLTczMiw2ICs3MjcsMTEgQEAgaW50ZWxfbG9naWNhbF9yaW5nX2FkdmFuY2VfYW5kX3N1 Ym1pdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gICAJaWYgKGludGVs X3Jpbmdfc3RvcHBlZChyaW5nKSkKPiAgIAkJcmV0dXJuOwo+Cj4gKwlpZiAocmVxdWVzdC0+Y3R4 ICE9IHJpbmctPmRlZmF1bHRfY29udGV4dCkKPiArCQlpbnRlbF9scl9jb250ZXh0X3BpbihyZXF1 ZXN0KTsKPiArCj4gKwlpOTE1X2dlbV9yZXF1ZXN0X3JlZmVyZW5jZShyZXF1ZXN0KTsKPiArCj4g ICAJaWYgKGRldl9wcml2LT5ndWMuZXhlY2J1Zl9jbGllbnQpCj4gICAJCWk5MTVfZ3VjX3N1Ym1p dChkZXZfcHJpdi0+Z3VjLmV4ZWNidWZfY2xpZW50LCByZXF1ZXN0KTsKPiAgIAllbHNlCgpOb3Qg ZW50aXJlbHkgaGFwcHkgYWJvdXQgdGhpcy4gSWYgYW4gZXh0cmEgcmVmIGlzIG5lZWRlZCBmb3Ig Ym90aCAKZXhlY2xpc3QgYW5kIEd1QyBtb2RlIChvZiB3aGljaCBJJ20gbm90IGNvbnZpbmNlZCkg d2hhdCBhYm91dCBsZWdhY3kgCnJpbmdidWZmZXIgbW9kZT8gSSB0aG91Z2h0IGV4ZWNsaXN0cyBu ZWVkZWQgdGhlIGV4dHJhIHJlZiBvbmx5IGJlY2F1c2UgCml0IGFkZGVkIGFuIGV4dHJhIHF1ZXVl IHRvIGhvbGQgd29yayBub3QgeWV0IHN1Ym1pdHRlZCB0byBoYXJkd2FyZS4KVGhhdCBxdWV1ZSBp c24ndCBuZWVkZWQgaW4gcmluZ2J1ZmZlciBPUiBHdUMgbW9kZS4gT1RPSCBpZiBhbiBleHRyYSBy ZWYgCmlzIG5lZWRlZCBpbiBBTEwgbW9kZXMgaXQgc2hvdWxkIGJlIGluIGNvbW1vbiBjb3JlIGNv ZGUsIG5vdCByZXBsaWNhdGVkIAppbnRvIGFsbCBzdWJtaXNzaW9uIHBhdGhzIDopCgpZb3UndmUg Z290IGludGVsX2xvZ2ljYWxfcmluZ19hZHZhbmNlX2FuZF9zdWJtaXQoKSB0YWtpbmcgdGhlIGV4 dHJhIApyZWZlcmVuY2UsIGJ1dCBlYWNoIG9mIHRoZSBleGVjbGlzdCBhbmQgR3VDIHBhdGhzIGFk ZGluZyB0aGUgcmVxdWVzdCB0byAKdGhlICJleGVjbGlzdF9xdWV1ZSIgOiggQW5kIHRoZW4gdHdv IHNlcGFyYXRlIGJ1dCB2ZXJ5IHNpbWlsYXIgZnVuY3Rpb25zIApyZXZlcnNpbmcgdGhlc2UgdHdv IG9wZXJhdGlvbnMgOigKClN1cmVseSB0aGUgVk1BIHNob3VsZCBub3QgYmUgZnJlZWQgd2hpbGUg dGhlcmUgYXJlIGFueSBvdXRzdGFuZGluZyAKKG5vdC15ZXQtcmV0aXJlZCkgcmVxdWVzdHMgcmVm ZXJyaW5nIHRvIGl0PyBQZXJoYXBzIAppOTE1X2dlbV9jb250ZXh0X2NsZWFuKCkgaXMgY2FsbGVk IGluIHRoZSB3cm9uZyBwbGFjZSAodG9vIGVhcmx5PykuIApTaG91bGRuJ3Qgd2UgaGF2ZSB3YWl0 ZWQgZm9yIGFsbCByZXF1ZXN0cyB0byBjb21wbGV0ZSBhbmQgYmUgcmV0aXJlZCAKQkVGT1JFIGZy ZWVpbmcgdGhlIGNvbnRleHQgdGhleSdyZSB1c2luZz8KCi5EYXZlLgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=