From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 1/3] drm/i915: Do not acquire crtc state to check clock during modeset, v2. Date: Tue, 27 Oct 2015 14:41:16 +0100 Message-ID: <562F7EFC.80909@linux.intel.com> References: <1445514996-18733-3-git-send-email-maarten.lankhorst@linux.intel.com> <1445952393-25283-1-git-send-email-maarten.lankhorst@linux.intel.com> <20151027132917.GC4437@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 4294C6EAEA for ; Tue, 27 Oct 2015 06:41:19 -0700 (PDT) In-Reply-To: <20151027132917.GC4437@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjctMTAtMTUgb20gMTQ6Mjkgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVHVlLCBP Y3QgMjcsIDIwMTUgYXQgMDI6MjY6MzFQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IFBhcmFsbGVsIG1vZGVzZXRzIGFyZSBzdGlsbCBub3QgYWxsb3dlZCwgYnV0IHRoaXMgd2ls bCBhbGxvdyB1cGRhdGluZwo+PiBhIGRpZmZlcmVudCBjcnRjIGR1cmluZyBhIG1vZGVzZXQgaWYg dGhlIGNsb2NrIGlzIG5vdCBjaGFuZ2VkLgo+Pgo+PiBBZGRpdGlvbmFsbHkgd2hlbiBhbGwgcGlw ZXMgYXJlIERQTVMgb2ZmIHRoZSBjZGNsayB3aWxsIGJlIGxvd2VyZWQKPj4gdG8gdGhlIG1pbmlt dW0gYWxsb3dlZC4KPj4KPj4gQ2hhbmdlcyBzaW5jZSB2MToKPj4gLSBBZGQgZGV2X3ByaXYtPmFj dGl2ZV9jcnRjcyBmb3IgdHJhY2tpbmcgd2hpY2ggY3J0Y3MgYXJlIGFjdGl2ZS4KPj4gLSBSZW5h bWUgbWluX2NkY2xrIHRvIG1pbl9waXhjbGsgYW5kIG1vdmUgdG8gZGV2X3ByaXYuCj4+IC0gQWRk IGEgYWN0aXZlX2NydGNzIG1hc2sgd2hpY2ggaXMgdXBkYXRlZCBhdG9taWNhbGx5Lgo+PiAtIEFk ZCBpbnRlbF9hdG9taWNfc3RhdGUtPm1vZGVzZXQgd2hpY2ggaXMgc2V0IG9uIG1vZGVzZXRzLgo+ PiAtIENvbW1pdCBuZXcgcGl4Y2xrL2FjdGl2ZV9jcnRjcyByaWdodCBhZnRlciBzdGF0ZSBzd2Fw Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9y c3RAbGludXguaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmggICAgICB8ICAgNSArKwo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWlj LmMgIHwgICAyICstCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAx NjAgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICAgNyArLQo+PiAgNCBmaWxlcyBjaGFuZ2VkLCAxMjUg aW5zZXJ0aW9ucygrKSwgNDkgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+PiBpbmRleCA1OWM5NDkyOWYyNWIuLjM3ZWVmODZlNGEwYSAxMDA2NDQKPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2Rydi5oCj4+IEBAIC0xODM3LDggKzE4MzcsMTMgQEAgc3RydWN0IGRybV9pOTE1X3By aXZhdGUgewo+PiAgCXN0cnVjdCBpbnRlbF9waXBlX2NyYyBwaXBlX2NyY1tJOTE1X01BWF9QSVBF U107Cj4+ICAjZW5kaWYKPj4gIAo+PiArCS8qIGRwbGwgYW5kIGNkY2xrIHN0YXRlIGlzIHByb3Rl Y3RlZCBieSBjb25uZWN0aW9uX211dGV4ICovCj4+ICAJaW50IG51bV9zaGFyZWRfZHBsbDsKPj4g IAlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgc2hhcmVkX2RwbGxzW0k5MTVfTlVNX1BMTFNdOwo+ PiArCj4+ICsJdW5zaWduZWQgaW50IGFjdGl2ZV9jcnRjczsKPj4gKwl1bnNpZ25lZCBpbnQgbWlu X3BpeGNsa1tJOTE1X01BWF9QSVBFU107Cj4+ICsKPj4gIAlpbnQgZHBpb19waHlfaW9zZl9wb3J0 W0k5MTVfTlVNX1BIWVNfVkxWXTsKPj4gIAo+PiAgCXN0cnVjdCBpOTE1X3dvcmthcm91bmRzIHdv cmthcm91bmRzOwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRv bWljLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+PiBpbmRleCAyNWE4 OTFhYTM4MjQuLmNiOGZjZjRmZTdmMiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfYXRvbWljLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRv bWljLmMKPj4gQEAgLTMwNSw1ICszMDUsNSBAQCB2b2lkIGludGVsX2F0b21pY19zdGF0ZV9jbGVh cihzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqcykKPj4gIHsKPj4gIAlzdHJ1Y3QgaW50ZWxfYXRv bWljX3N0YXRlICpzdGF0ZSA9IHRvX2ludGVsX2F0b21pY19zdGF0ZShzKTsKPj4gIAlkcm1fYXRv bWljX3N0YXRlX2RlZmF1bHRfY2xlYXIoJnN0YXRlLT5iYXNlKTsKPj4gLQlzdGF0ZS0+ZHBsbF9z ZXQgPSBmYWxzZTsKPj4gKwlzdGF0ZS0+ZHBsbF9zZXQgPSBzdGF0ZS0+bW9kZXNldCA9IGZhbHNl Owo+PiAgfQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IGluZGV4IDAyMmU2 MjhiODUyMC4uYTA1MDhkNWU5ZTEzIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4+IEBAIC01MjM3LDYgKzUyMzcsNyBAQCBzdGF0aWMgdm9pZCBtb2Rlc2V0X3B1dF9w b3dlcl9kb21haW5zKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gIAo+PiAg c3RhdGljIHZvaWQgbW9kZXNldF91cGRhdGVfY3J0Y19wb3dlcl9kb21haW5zKHN0cnVjdCBkcm1f YXRvbWljX3N0YXRlICpzdGF0ZSkKPj4gIHsKPj4gKwlzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRl ICppbnRlbF9zdGF0ZSA9IHRvX2ludGVsX2F0b21pY19zdGF0ZShzdGF0ZSk7Cj4+ICAJc3RydWN0 IGRybV9kZXZpY2UgKmRldiA9IHN0YXRlLT5kZXY7Cj4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4gIAl1bnNpZ25lZCBsb25nIHB1dF9k b21haW5zW0k5MTVfTUFYX1BJUEVTXSA9IHt9Owo+PiBAQCAtNTI0NSwxMyArNTI0NiwxOCBAQCBz dGF0aWMgdm9pZCBtb2Rlc2V0X3VwZGF0ZV9jcnRjX3Bvd2VyX2RvbWFpbnMoc3RydWN0IGRybV9h dG9taWNfc3RhdGUgKnN0YXRlKQo+PiAgCWludCBpOwo+PiAgCj4+ICAJZm9yX2VhY2hfY3J0Y19p bl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+PiAtCQlpZiAobmVlZHNfbW9k ZXNldChjcnRjLT5zdGF0ZSkpCj4+IC0JCQlwdXRfZG9tYWluc1t0b19pbnRlbF9jcnRjKGNydGMp LT5waXBlXSA9Cj4+IC0JCQkJbW9kZXNldF9nZXRfY3J0Y19wb3dlcl9kb21haW5zKGNydGMpOwo+ PiArCQlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9Cj4+ICsJCQl0b19pbnRlbF9jcnRj KGNydGMpOwo+PiArCQllbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4+ICsKPj4g KwkJaWYgKCFuZWVkc19tb2Rlc2V0KGNydGMtPnN0YXRlKSkKPj4gKwkJCWNvbnRpbnVlOwo+PiAr Cj4+ICsJCXB1dF9kb21haW5zW3BpcGVdID0gbW9kZXNldF9nZXRfY3J0Y19wb3dlcl9kb21haW5z KGNydGMpOwo+PiAgCX0KPj4gIAo+PiAgCWlmIChkZXZfcHJpdi0+ZGlzcGxheS5tb2Rlc2V0X2Nv bW1pdF9jZGNsaykgewo+PiAtCQl1bnNpZ25lZCBpbnQgY2RjbGsgPSB0b19pbnRlbF9hdG9taWNf c3RhdGUoc3RhdGUpLT5jZGNsazsKPj4gKwkJdW5zaWduZWQgaW50IGNkY2xrID0gaW50ZWxfc3Rh dGUtPmNkY2xrOwo+PiAgCj4+ICAJCWlmIChjZGNsayAhPSBkZXZfcHJpdi0+Y2RjbGtfZnJlcSAm Jgo+PiAgCQkgICAgIVdBUk5fT04oIXN0YXRlLT5hbGxvd19tb2Rlc2V0KSkKPj4gQEAgLTU5Mzgs MjMgKzU5NDQsMzIgQEAgc3RhdGljIGludCBicm94dG9uX2NhbGNfY2RjbGsoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgc3RhdGljIGludCBpbnRlbF9tb2RlX21heF9waXhj bGsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4gIAkJCQkgc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlKQo+PiAgewo+PiAtCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjOwo+PiAt CXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+PiAtCWludCBtYXhfcGl4Y2xr ID0gMDsKPj4gKwlzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICppbnRlbF9zdGF0ZSA9IHRvX2lu dGVsX2F0b21pY19zdGF0ZShzdGF0ZSk7Cj4+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4+ ICsJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+PiArCXVuc2lnbmVkIG1heF9w aXhlbF9yYXRlID0gMCwgaTsKPj4gKwllbnVtIHBpcGUgcGlwZTsKPj4gIAo+PiAtCWZvcl9lYWNo X2ludGVsX2NydGMoZGV2LCBpbnRlbF9jcnRjKSB7Cj4+IC0JCWNydGNfc3RhdGUgPSBpbnRlbF9h dG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUsIGludGVsX2NydGMpOwo+PiAtCQlpZiAoSVNfRVJS KGNydGNfc3RhdGUpKQo+PiAtCQkJcmV0dXJuIFBUUl9FUlIoY3J0Y19zdGF0ZSk7Cj4+ICsJbWVt Y3B5KGludGVsX3N0YXRlLT5taW5fcGl4Y2xrLCBkZXZfcHJpdi0+bWluX3BpeGNsaywKPj4gKwkg ICAgICAgc2l6ZW9mKGludGVsX3N0YXRlLT5taW5fcGl4Y2xrKSk7Cj4+ICAKPj4gLQkJaWYgKCFj cnRjX3N0YXRlLT5iYXNlLmVuYWJsZSkKPj4gLQkJCWNvbnRpbnVlOwo+PiArCWZvcl9lYWNoX2Ny dGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpIHsKPj4gKwkJaW50IHBpeGNs ayA9IDA7Cj4+ICAKPj4gLQkJbWF4X3BpeGNsayA9IG1heChtYXhfcGl4Y2xrLAo+PiAtCQkJCSBj cnRjX3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19jbG9jayk7Cj4+ICsJCWlmIChjcnRj X3N0YXRlLT5lbmFibGUpCj4+ICsJCQlwaXhjbGsgPSBjcnRjX3N0YXRlLT5hZGp1c3RlZF9tb2Rl LmNydGNfY2xvY2s7Cj4+ICsKPj4gKwkJaW50ZWxfc3RhdGUtPm1pbl9waXhjbGtbaV0gPSBwaXhj bGs7Cj4+ICAJfQo+PiAgCj4+IC0JcmV0dXJuIG1heF9waXhjbGs7Cj4+ICsJaWYgKCFpbnRlbF9z dGF0ZS0+YWN0aXZlX2NydGNzKQo+PiArCQlyZXR1cm4gMDsKPj4gKwo+PiArCWZvcl9lYWNoX3Bp cGUoZGV2X3ByaXYsIHBpcGUpCj4+ICsJCW1heF9waXhlbF9yYXRlID0gbWF4KGludGVsX3N0YXRl LT5taW5fcGl4Y2xrW3BpcGVdLCBtYXhfcGl4ZWxfcmF0ZSk7Cj4+ICsKPj4gKwlyZXR1cm4gbWF4 X3BpeGVsX3JhdGU7Cj4+ICB9Cj4+ICAKPj4gIHN0YXRpYyBpbnQgdmFsbGV5dmlld19tb2Rlc2V0 X2NhbGNfY2RjbGsoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+PiBAQCAtNjI1NSw2 ICs2MjcwLDkgQEAgc3RhdGljIHZvaWQgaW50ZWxfY3J0Y19kaXNhYmxlX25vYXRvbWljKHN0cnVj dCBkcm1fY3J0YyAqY3J0YykKPj4gIAlmb3JfZWFjaF9wb3dlcl9kb21haW4oZG9tYWluLCBkb21h aW5zKQo+PiAgCQlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgZG9tYWluKTsKPj4g IAlpbnRlbF9jcnRjLT5lbmFibGVkX3Bvd2VyX2RvbWFpbnMgPSAwOwo+PiArCj4+ICsJZGV2X3By aXYtPmFjdGl2ZV9jcnRjcyAmPSB+KDEgPDwgaW50ZWxfY3J0Yy0+cGlwZSk7Cj4+ICsJZGV2X3By aXYtPm1pbl9waXhjbGtbaW50ZWxfY3J0Yy0+cGlwZV0gPSAwOwo+PiAgfQo+PiAgCj4+ICAvKgo+ PiBAQCAtOTQ5MCwyOSArOTUwOCwzOSBAQCBzdGF0aWMgdm9pZCBicm94dG9uX21vZGVzZXRfY29t bWl0X2NkY2xrKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpvbGRfc3RhdGUpCj4+ICAvKiBjb21w dXRlIHRoZSBtYXggcmF0ZSBmb3IgbmV3IGNvbmZpZ3VyYXRpb24gKi8KPj4gIHN0YXRpYyBpbnQg aWxrX21heF9waXhlbF9yYXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPj4gIHsK Pj4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YzsKPj4gLQlzdHJ1Y3QgaW50ZWxfY3J0 Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPj4gLQlpbnQgbWF4X3BpeGVsX3JhdGUgPSAwOwo+PiArCXN0 cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKmludGVsX3N0YXRlID0gdG9faW50ZWxfYXRvbWljX3N0 YXRlKHN0YXRlKTsKPj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBzdGF0 ZS0+ZGV2LT5kZXZfcHJpdmF0ZTsKPj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4+ICsJc3Ry dWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+PiArCXVuc2lnbmVkIG1heF9waXhlbF9y YXRlID0gMCwgaTsKPj4gKwllbnVtIHBpcGUgcGlwZTsKPj4gIAo+PiAtCWZvcl9lYWNoX2ludGVs X2NydGMoc3RhdGUtPmRldiwgaW50ZWxfY3J0Yykgewo+PiAtCQlpbnQgcGl4ZWxfcmF0ZTsKPj4g KwltZW1jcHkoaW50ZWxfc3RhdGUtPm1pbl9waXhjbGssIGRldl9wcml2LT5taW5fcGl4Y2xrLAo+ PiArCSAgICAgICBzaXplb2YoaW50ZWxfc3RhdGUtPm1pbl9waXhjbGspKTsKPj4gIAo+PiAtCQlj cnRjX3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBpbnRlbF9jcnRj KTsKPj4gLQkJaWYgKElTX0VSUihjcnRjX3N0YXRlKSkKPj4gLQkJCXJldHVybiBQVFJfRVJSKGNy dGNfc3RhdGUpOwo+PiArCWZvcl9lYWNoX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNf c3RhdGUsIGkpIHsKPj4gKwkJaW50IHBpeGNsayA9IDA7Cj4+ICAKPj4gLQkJaWYgKCFjcnRjX3N0 YXRlLT5iYXNlLmVuYWJsZSkKPj4gLQkJCWNvbnRpbnVlOwo+PiArCQlpZiAoY3J0Y19zdGF0ZS0+ ZW5hYmxlKSB7Cj4+ICsJCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqaW50ZWxfY3J0Y19zdGF0 ZSA9Cj4+ICsJCQkJdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjX3N0YXRlKTsKPj4gIAo+PiAtCQlw aXhlbF9yYXRlID0gaWxrX3BpcGVfcGl4ZWxfcmF0ZShjcnRjX3N0YXRlKTsKPj4gKwkJCXBpeGNs ayA9IGlsa19waXBlX3BpeGVsX3JhdGUoaW50ZWxfY3J0Y19zdGF0ZSk7Cj4gQ291bGQgeW91IGF2 b2lkIHRoZSByZWluZGVudCBhbmQgcmVuYW1lcyBwbGVhc2U/Cj4KVGhlIHBpeGNsayBoYXMgdG8g YmUgc2V0IGV2ZW4gd2hlbiBlbmFibGVkID0gZmFsc2UuIFRoaXMgd2F5IHRoZSBuYW1lcyBmb3Ig aWxrX21heF9waXhlbF9yYXRlIGFuZCBpbnRlbF9tb2RlX21heF9waXhjbGsgYXJlIGlkZW50aWNh bC4KCn5NYWFydGVuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==