From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [RFC 6/9] drm/i915: Delay the freeing of requests until retire time Date: Wed, 28 Oct 2015 13:42:44 +0000 Message-ID: <5630D0D4.5070602@linux.intel.com> References: <1437143483-6234-1-git-send-email-John.C.Harrison@Intel.com> <1437143483-6234-7-git-send-email-John.C.Harrison@Intel.com> <55B0F94A.10901@linux.intel.com> <5630C6E4.8070603@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id BC6916E005 for ; Wed, 28 Oct 2015 06:42:47 -0700 (PDT) In-Reply-To: <5630C6E4.8070603@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Harrison , Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI4LzEwLzE1IDEzOjAwLCBKb2huIEhhcnJpc29uIHdyb3RlOgo+IE9uIDIzLzA3LzIwMTUg MTU6MjUsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Pgo+PiBIaSwKPj4KPj4gT24gMDcvMTcvMjAx NSAwMzozMSBQTSwgSm9obi5DLkhhcnJpc29uQEludGVsLmNvbSB3cm90ZToKPj4+IEZyb206IEpv aG4gSGFycmlzb24gPEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4+Pgo+Pj4gVGhlIHJlcXVl c3Qgc3RydWN0dXJlIGlzIHJlZmVyZW5jZSBjb3VudGVkLiBXaGVuIHRoZSBjb3VudCByZWFjaGVk Cj4+PiB6ZXJvLCB0aGUgcmVxdWVzdCB3YXMgaW1tZWRpYXRlbHkgZnJlZWQgYW5kIGFsbCBhc3Nv Y2lhdGVkIG9iamVjdHMKPj4+IHdlcmUgdW5yZWZlcmVjZWQvdW5hbGxvY2F0ZWQuIFRoaXMgbWVh bnQgdGhhdCB0aGUgZHJpdmVyIG11dGV4IGxvY2sKPj4+IG11c3QgYmUgaGVsZCBhdCB0aGUgcG9p bnQgd2hlcmUgdGhlIGNvdW50IHJlYWNoZXMgemVyby4gVGhpcyB3YXMgZmluZQo+Pj4gd2hpbGUg YWxsIHJlZmVyZW5jZXMgd2VyZSBoZWxkIGludGVybmFsbHkgdG8gdGhlIGRyaXZlci4gSG93ZXZl ciwgdGhlCj4+PiBwbGFuIGlzIHRvIGFsbG93IHRoZSB1bmRlcmx5aW5nIGZlbmNlIG9iamVjdCAo YW5kIGhlbmNlIHRoZSByZXF1ZXN0Cj4+PiBpdHNlbGYpIHRvIGJlIHJldHVybmVkIHRvIG90aGVy IGRyaXZlcnMgYW5kIHRvIHVzZXJsYW5kLiBFeHRlcm5hbAo+Pj4gdXNlcnMgY2Fubm90IGJlIGV4 cGVjdGVkIHRvIGFjcXVpcmUgYSBkcml2ZXIgcHJpdmF0ZSBtdXRleCBsb2NrLgo+Pj4KPj4+IFJh dGhlciB0aGFuIGF0dGVtcHQgdG8gZGlzZW50YW5nbGUgdGhlIHJlcXVlc3Qgc3RydWN0dXJlIGZy b20gdGhlCj4+PiBkcml2ZXIgbXV0ZXggbG9jaywgdGhlIGRlY3Npb24gd2FzIHRvIGRlZmVyIHRo ZSBmcmVlIGNvZGUgdW50aWwgYQo+Pj4gbGF0ZXIgKHNhZmVyKSBwb2ludC4gSGVuY2UgdGhpcyBw YXRjaCBjaGFuZ2VzIHRoZSB1bnJlZmVyZW5jZSBjYWxsYmFjawo+Pj4gdG8gbWVyZWx5IG1vdmUg dGhlIHJlcXVlc3Qgb250byBhIGRlbGF5ZWQgZnJlZSBsaXN0LiBUaGUgZHJpdmVyJ3MKPj4+IHJl dGlyZSB3b3JrZXIgdGhyZWFkIHdpbGwgdGhlbiBwcm9jZXNzIHRoZSBsaXN0IGFuZCBhY3R1YWxs eSBjYWxsIHRoZQo+Pj4gZnJlZSBmdW5jdGlvbiBvbiB0aGUgcmVxdWVzdHMuCj4+Pgo+Pj4gW25l dyBwYXRjaCBpbiBzZXJpZXNdCj4+Pgo+Pj4gRm9yOiBWSVotNTE5MAo+Pj4gU2lnbmVkLW9mZi1i eTogSm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPj4+IC0tLQo+Pj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgICAgfCAyMiArKystLS0tLS0t LS0tLS0tLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgIHwg NDEKPj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+Pj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgICAgfCAgMiArLQo+Pj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgfCAgMiArKwo+Pj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wbS5jICAgICAgICAgfCAgMiArLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9yaW5nYnVmZmVyLmMgfCAgMiArKwo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9yaW5nYnVmZmVyLmggfCAgNCArKysrCj4+PiAgIDcgZmlsZXMgY2hhbmdlZCwgNTAgaW5z ZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+Pj4gaW5kZXggODhhNDc0Ni4uNjFjM2RiMiAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmgKPj4+IEBAIC0yMTYxLDE0ICsyMTYxLDkgQEAgdm9pZCBpOTE1X2dlbV90cmFja19m YihzdHJ1Y3QKPj4+IGRybV9pOTE1X2dlbV9vYmplY3QgKm9sZCwKPj4+ICAgICogaW5pdGlhbCBy ZWZlcmVuY2UgdGFrZW4gdXNpbmcga3JlZl9pbml0Cj4+PiAgICAqLwo+Pj4gICBzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3Qgewo+Pj4gLSAgICAvKioKPj4+IC0gICAgICogVW5kZXJseWluZyBv YmplY3QgZm9yIGltcGxlbWVudGluZyB0aGUgc2lnbmFsL3dhaXQgc3R1ZmYuCj4+PiAtICAgICAq IE5COiBOZXZlciByZXR1cm4gdGhpcyBmZW5jZSBvYmplY3QgdG8gdXNlciBsYW5kISBJdCBpcyB1 bnNhZmUgdG8KPj4+IC0gICAgICogbGV0IGFueXRoaW5nIG91dHNpZGUgb2YgdGhlIGk5MTUgZHJp dmVyIGdldCBob2xkIG9mIHRoZSBmZW5jZQo+Pj4gLSAgICAgKiBvYmplY3QgYXMgdGhlIGNsZWFu IHVwIHdoZW4gZGVjcmVtZW50aW5nIHRoZSByZWZlcmVuY2UgY291bnQKPj4+IC0gICAgICogcmVx dWlyZXMgaG9sZGluZyB0aGUgZHJpdmVyIG11dGV4IGxvY2suCj4+PiAtICAgICAqLwo+Pj4gKyAg ICAvKiogVW5kZXJseWluZyBvYmplY3QgZm9yIGltcGxlbWVudGluZyB0aGUgc2lnbmFsL3dhaXQg c3R1ZmYuICovCj4+PiAgICAgICBzdHJ1Y3QgZmVuY2UgZmVuY2U7Cj4+PiArICAgIHN0cnVjdCBs aXN0X2hlYWQgZGVsYXlfZnJlZV9saXN0Owo+Pgo+PiBNYXliZSBjYWxsIHRoaXMgZGVsYXlfZnJl ZV9saW5rIHRvIGNvbnRpbnVlIHRoZSBlc3RhYmxpc2hlZCBjb252ZW50aW9uLgo+Pgo+Pj4KPj4+ ICAgICAgIC8qKiBPbiBXaGljaCByaW5nIHRoaXMgcmVxdWVzdCB3YXMgZ2VuZXJhdGVkICovCj4+ PiAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNTsKPj4+IEBAIC0yMjgxLDIxICsy Mjc2LDEwIEBAIGk5MTVfZ2VtX3JlcXVlc3RfcmVmZXJlbmNlKHN0cnVjdAo+Pj4gZHJtX2k5MTVf Z2VtX3JlcXVlc3QgKnJlcSkKPj4+ICAgc3RhdGljIGlubGluZSB2b2lkCj4+PiAgIGk5MTVfZ2Vt X3JlcXVlc3RfdW5yZWZlcmVuY2Uoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEpCj4+ PiAgIHsKPj4+IC0gV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZyZXEtPnJpbmctPmRldi0+c3Ry dWN0X211dGV4KSk7Cj4+PiAtICAgIGZlbmNlX3B1dCgmcmVxLT5mZW5jZSk7Cj4+PiAtfQo+Pj4g LQo+Pj4gLXN0YXRpYyBpbmxpbmUgdm9pZAo+Pj4gLWk5MTVfZ2VtX3JlcXVlc3RfdW5yZWZlcmVu Y2VfX3VubG9ja2VkKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdAo+Pj4gKnJlcSkKPj4+IC17 Cj4+PiAtICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXY7Cj4+PiAtCj4+PiAgICAgICBpZiAoIXJl cSkKPj4+ICAgICAgICAgICByZXR1cm47Cj4+Pgo+Pj4gLSAgICBkZXYgPSByZXEtPnJpbmctPmRl djsKPj4+IC0gICAgaWYgKGtyZWZfcHV0X211dGV4KCZyZXEtPmZlbmNlLnJlZmNvdW50LCBmZW5j ZV9yZWxlYXNlLAo+Pj4gJmRldi0+c3RydWN0X211dGV4KSkKPj4+IC0gICAgICAgIG11dGV4X3Vu bG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+Pj4gKyAgICBmZW5jZV9wdXQoJnJlcS0+ZmVuY2Up Owo+Pj4gICB9Cj4+Pgo+Pj4gICBzdGF0aWMgaW5saW5lIHZvaWQgaTkxNV9nZW1fcmVxdWVzdF9h c3NpZ24oc3RydWN0Cj4+PiBkcm1faTkxNV9nZW1fcmVxdWVzdCAqKnBkc3QsCj4+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4gYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jCj4+PiBpbmRleCBhZjc5NzE2Li40ODI4MzVhIDEwMDY0NAo+Pj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4gQEAgLTI2MTYsMTAgKzI2MTYsMjcgQEAgc3RhdGlj IHZvaWQgaTkxNV9zZXRfcmVzZXRfc3RhdHVzKHN0cnVjdAo+Pj4gZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4+PiAgICAgICB9Cj4+PiAgIH0KPj4+Cj4+PiAtc3RhdGljIHZvaWQgaTkxNV9n ZW1fcmVxdWVzdF9mcmVlKHN0cnVjdCBmZW5jZSAqcmVxX2ZlbmNlKQo+Pj4gK3N0YXRpYyB2b2lk IGk5MTVfZ2VtX3JlcXVlc3RfcmVsZWFzZShzdHJ1Y3QgZmVuY2UgKnJlcV9mZW5jZSkKPj4+ICAg ewo+Pj4gICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEgPSBjb250YWluZXJf b2YocmVxX2ZlbmNlLAo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgdHlwZW9mKCpyZXEp LCBmZW5jZSk7Cj4+PiArICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcgPSByZXEtPnJp bmc7Cj4+PiArICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUo cmluZy0+ZGV2KTsKPj4+ICsgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKPj4+ICsKPj4+ICsgICAg LyoKPj4+ICsgICAgICogTmVlZCB0byBhZGQgdGhlIHJlcXVlc3QgdG8gYSBkZWZlcnJlZCBkZXJl ZmVyZW5jZSBsaXN0IHRvIGJlCj4+PiArICAgICAqIHByb2Nlc3NlZCBhdCBhIG11dGV4IGxvY2sg c2FmZSB0aW1lLgo+Pj4gKyAgICAgKi8KPj4+ICsgICAgc3Bpbl9sb2NrX2lycXNhdmUoJnJpbmct PmRlbGF5ZWRfZnJlZV9sb2NrLCBmbGFncyk7Cj4+Cj4+IEF0IHRoZSBtb21lbnQgdGhlcmUgaXMg bm8gcmVxdWVzdCB1bnJlZmVyZW5jaW5nIGZyb20gaXJxIGhhbmRsZXJzCj4+IHJpZ2h0PyBVbmxl c3MgKG9yIHVudGlsKSB5b3UgcGxhbiB0byBhZGQgdGhhdCB5b3UgY291bGQgdXNlIHNpbXBsZQo+ PiBzcGluX2xvY2sgaGVyZS4gKEFuZCBpbiB0aGUgaTkxNV9nZW1fcmV0aXJlX3JlcXVlc3RzX3Jp bmcuKQo+Cj4gSSBkb24ndCBiZWxpZXZlIHRoZXJlIGlzIGFuIHVucmVmZXJlbmNlIGF0IElSUSB0 aW1lIGF0IHRoaXMgcHJlY2lzZQo+IG1vbWVudC4gSG93ZXZlciwgdGhlcmUgY2VydGFpbmx5IGhh dmUgYmVlbiBpbiB2YXJpb3VzIG90aGVyIGl0ZXJhdGlvbnMKPiBvZiB0aGUgY29kZSAoaW5jbHVk aW5nIG9uZSBvbiB0aGUgZGlzcGxheSBzaWRlIHRoYXQgaGFzIHNpbmNlCj4gZGlzYXBwZWFyZWQg ZHVlIHRvIGNoYW5nZXMgYnkgb3RoZXJzIGNvbXBsZXRlbHkgdW5yZWxhdGVkIHRvIHRoaXMgd29y aykuCj4gU28gSSB3b3VsZCBiZSBuZXJ2b3VzIGFib3V0IG5vdCBtYWtpbmcgaXQgSVJRIGNvbXBh dGlibGUuIEl0IHNlZW1zIGxpa2UKPiBhIGJ1ZyB3YWl0aW5nIHRvIGhhcHBlbi4KCkkgdGhpbmsg aXQgaXMgYmFkIHRvIHRha2UgdGhlIGNvc3Qgb2YgZGlzYWJsaW5nIGludGVycnVwdHMgZm9yIG5v dGhpbmcuCgpPbmNlIHRoZSB1bnRoaW5rYWJsZSBoYXBwZW5zIGFuZCBkcml2ZXIgaXMgcmUtZGVz aWduZWQgc28gdGhhdCBpdCBpcyAKcG9zc2libGUgdG8gdW5yZWZlcmVuY2UgZnJvbSBJUlEgY29u dGV4dCBpdCBjb3VsZCBiZSBhZGRlZC4KCj4+PiBAQCAtMjk5Miw2ICszMDA5LDIxIEBAIGk5MTVf Z2VtX3JldGlyZV9yZXF1ZXN0c19yaW5nKHN0cnVjdAo+Pj4gaW50ZWxfZW5naW5lX2NzICpyaW5n KQo+Pj4gICAgICAgICAgIGk5MTVfZ2VtX3JlcXVlc3RfYXNzaWduKCZyaW5nLT50cmFjZV9pcnFf cmVxLCBOVUxMKTsKPj4+ICAgICAgIH0KPj4+Cj4+PiArICAgIHdoaWxlICghbGlzdF9lbXB0eSgm cmluZy0+ZGVsYXllZF9mcmVlX2xpc3QpKSB7Cj4+PiArICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVf Z2VtX3JlcXVlc3QgKnJlcXVlc3Q7Cj4+PiArICAgICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwo+ Pj4gKwo+Pj4gKyAgICAgICAgcmVxdWVzdCA9IGxpc3RfZmlyc3RfZW50cnkoJnJpbmctPmRlbGF5 ZWRfZnJlZV9saXN0LAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9pOTE1 X2dlbV9yZXF1ZXN0LAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgZGVsYXlfZnJlZV9saXN0 KTsKPj4KPj4gTmVlZCBhIHNwaW5sb2NrIHRvIHNhbXBsZSBsaXN0IGhlYWQgaGVyZS4gVGhlbiBt YXliZSBtb3ZlIGl0IG9uIGEKPj4gdGVtcG9yYXJ5IGxpc3QgYW5kIGRvIHRoZSBmcmVlaW5nIGFm dGVyd2FyZHMuCj4KPiBOb3QgbmVjZXNzYXJ5LiBUaGUgb25seSBvdGhlciB1c2FnZSBvZiB0aGUg bGlzdCBpcyB0byBhZGQgdG8gaXQuIFNvIHRoaXMKPiBjb2RlIGNhbid0IHB1bGwgYW4gZW50cnkg dGhhdCBnZXRzIHJlbW92ZWQgYmVuZWF0aCBpdHMgZmVldC4gRWl0aGVyIHRoZQo+IGxpc3QgZW1w dHkgdGVzdCB3aWxsIHJldHVybiB0cnVlIGFuZCBub3RoaW5nIGZ1cnRoZXIgaGFwcGVucyBvciB0 aGVyZSBpcwo+IGRlZmluaXRlbHkgYSBub2RlIG9uIHRoZSBsaXN0IGFuZCBsaXN0X2ZpcnN0X2Vu dHJ5KCkgd2lsbCByZXR1cm4KPiBzb21ldGhpbmcgc2FuZS4gVGhlIHNwaW5sb2NrIGlzIG9ubHkg cmVxdWlyZWQgd2hlbiBhY3R1YWxseSBkZWxldGluZwo+IHRoYXQgbm9kZS4KCk5BSyEgOkQKCkl0 IG9ubHkgd29ya3MgYmVjYXVzZSB5b3Uga25vdyBob3cgbGlzdHMgYXJlIGltcGxlbWVudGVkLiBT YXkgaWYgCmxpc3RfZW1wdHkgY2hlY2tlZCBmb3IgaGVhZC0+cHJldiA9PSBoZWFkLCBhbmQgbGlz dF9maXJzdF9lbnRyeSAKb2J2aW91c2x5IHVzZXMgaGVhZC0+bmV4dCwgdGhlbiBkZXBlbmRpbmcg b24gb3JkZXJpbmcgaW4gbGlzdF9hZGQsIHlvdSAKY291bGQgZ3JhYiBzb21lIGdhcmJhZ2UsIHRh a2UgdGhlIGxvY2sgYW5kIGRlcmVmZXJlbmNlIHRoYXQgZ2FyYmFnZS4KCkkgc2VlIG5vIGdhaW4g aW4gZG9pbmcgdGhpcyB0cmlja2VyeSBhbmQgaXQgaXMgZnJhZ2lsZS4gQW5kIHlvdSBzdGlsbCAK bG9jay91bmxvY2sgb25jZSBwZXIgbG9vcC4KCldoeSBub3QgdXNlIHRoZSBjb21tb24gcGF0dGVy biBvZiByZXBsYWNpbmcgdGhlIGxpc3QgdW5kZXIgdGhlIGxvY2sgYW5kIAp0aGVuIG9wZXJhdGlu ZyBvbiB5b3VyIGxvY2FsIGNvcHkgdW5yZXN0cmljdGVkPwoKUmVnYXJkcywKClR2cnRrbwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=