From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Avoid pointer arithmetic in
 calculating plane surface offset
Date: Fri, 30 Oct 2015 11:40:46 +0000
Message-ID: <5633573E.1090703@linux.intel.com>
References: <1446204375-29831-1-git-send-email-mika.kuoppala@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6C5586EBB9
 for <intel-gfx@lists.freedesktop.org>; Fri, 30 Oct 2015 04:40:48 -0700 (PDT)
In-Reply-To: <1446204375-29831-1-git-send-email-mika.kuoppala@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDMwLzEwLzE1IDExOjI2LCBNaWthIEt1b3BwYWxhIHdyb3RlOgo+IFZNQSBvZmZzZXRzIGFy
ZSA2NCBiaXRzLiBQbGFuZSBzdXJmYWNlIG9mZnNldHMgYXJlIGluIGdndHQgYW5kCj4gdGhlIGhh
cmR3YXJlIHJlZ2lzdGVyIHRvIHNldCB0aGlzIGlzIHRodXMgMzIgYml0cy4gQmUgZXhwbGljaXQK
PiBhYm91dCB0aGVzZSBhbmQgY29udmVydCBjYXJlZnVsbHkgdG8gZnJvbSB2bWEgdG8gZmluYWwg
c2l6ZS4KPgo+IFRoaXMgd2lsbCBtYWtlIHNwYXJzZSBoYXBweSBieSBub3QgY3JlYXRpbmcgMzJi
aXQgcG9pbnRlcnMgb3V0Cj4gb2YgNjRiaXQgdm1hIG9mZnNldHMuCj4KPiBDYzogVHZydGtvIFVy
c3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNaWthIEt1
b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDE2ICsrKysrKysrKy0tLS0tLS0KPiAgIGRyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICA2ICsrKy0tLQo+ICAgZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgIHwgIDIgKy0KPiAgIDMgZmlsZXMgY2hhbmdlZCwgMTMg
aW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGlzcGxheS5jCj4gaW5kZXggM2YxYjU0NS4uMzdlODNmOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMjkyNiwxMyArMjkyNiwxMyBAQCB1MzIgaW50ZWxfZmJf
c3RyaWRlX2FsaWdubWVudChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1aW50NjRfdCBmYl9tb2Rp
ZmllciwKPiAgIAl9Cj4gICB9Cj4KPiAtdW5zaWduZWQgbG9uZyBpbnRlbF9wbGFuZV9vYmpfb2Zm
c2V0KHN0cnVjdCBpbnRlbF9wbGFuZSAqaW50ZWxfcGxhbmUsCj4gLQkJCQkgICAgIHN0cnVjdCBk
cm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gLQkJCQkgICAgIHVuc2lnbmVkIGludCBwbGFuZSkK
PiArdTMyIGludGVsX3BsYW5lX29ial9vZmZzZXQoc3RydWN0IGludGVsX3BsYW5lICppbnRlbF9w
bGFuZSwKPiArCQkJICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiArCQkJICAg
dW5zaWduZWQgaW50IHBsYW5lKQo+ICAgewo+ICAgCWNvbnN0IHN0cnVjdCBpOTE1X2dndHRfdmll
dyAqdmlldyA9ICZpOTE1X2dndHRfdmlld19ub3JtYWw7Cj4gICAJc3RydWN0IGk5MTVfdm1hICp2
bWE7Cj4gLQl1bnNpZ25lZCBjaGFyICpvZmZzZXQ7Cj4gKwl1NjQgb2Zmc2V0Owo+Cj4gICAJaWYg
KGludGVsX3JvdGF0aW9uXzkwX29yXzI3MChpbnRlbF9wbGFuZS0+YmFzZS5zdGF0ZS0+cm90YXRp
b24pKQo+ICAgCQl2aWV3ID0gJmk5MTVfZ2d0dF92aWV3X3JvdGF0ZWQ7Cj4gQEAgLTI5NDIsMTQg
KzI5NDIsMTYgQEAgdW5zaWduZWQgbG9uZyBpbnRlbF9wbGFuZV9vYmpfb2Zmc2V0KHN0cnVjdCBp
bnRlbF9wbGFuZSAqaW50ZWxfcGxhbmUsCj4gICAJCXZpZXctPnR5cGUpKQo+ICAgCQlyZXR1cm4g
LTE7Cj4KPiAtCW9mZnNldCA9ICh1bnNpZ25lZCBjaGFyICopdm1hLT5ub2RlLnN0YXJ0Owo+ICsJ
b2Zmc2V0ID0gdm1hLT5ub2RlLnN0YXJ0Owo+Cj4gICAJaWYgKHBsYW5lID09IDEpIHsKPiAgIAkJ
b2Zmc2V0ICs9IHZtYS0+Z2d0dF92aWV3LnJvdGF0aW9uX2luZm8udXZfc3RhcnRfcGFnZSAqCj4g
ICAJCQkgIFBBR0VfU0laRTsKPiAgIAl9Cj4KPiAtCXJldHVybiAodW5zaWduZWQgbG9uZylvZmZz
ZXQ7Cj4gKwlXQVJOX09OKHVwcGVyXzMyX2JpdHMob2Zmc2V0KSk7Cj4gKwo+ICsJcmV0dXJuIGxv
d2VyXzMyX2JpdHMob2Zmc2V0KTsKPiAgIH0KPgo+ICAgc3RhdGljIHZvaWQgc2tsX2RldGFjaF9z
Y2FsZXIoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsIGludCBpZCkKPiBAQCAtMzA3NSw3
ICszMDc3LDcgQEAgc3RhdGljIHZvaWQgc2t5bGFrZV91cGRhdGVfcHJpbWFyeV9wbGFuZShzdHJ1
Y3QgZHJtX2NydGMgKmNydGMsCj4gICAJdTMyIHRpbGVfaGVpZ2h0LCBwbGFuZV9vZmZzZXQsIHBs
YW5lX3NpemU7Cj4gICAJdW5zaWduZWQgaW50IHJvdGF0aW9uOwo+ICAgCWludCB4X29mZnNldCwg
eV9vZmZzZXQ7Cj4gLQl1bnNpZ25lZCBsb25nIHN1cmZfYWRkcjsKPiArCXUzMiBzdXJmX2FkZHI7
Cj4gICAJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUgPSBpbnRlbF9jcnRjLT5j
b25maWc7Cj4gICAJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiAgIAlp
bnQgc3JjX3ggPSAwLCBzcmNfeSA9IDAsIHNyY193ID0gMCwgc3JjX2ggPSAwOwo+IGRpZmYgLS1n
aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2Rydi5oCj4gaW5kZXggMWEzYmJkYy4uYmM2MDM4NSAxMDA2NDQKPiAtLS0gYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2Rydi5oCj4gQEAgLTExOTYsOSArMTE5Niw5IEBAIHZvaWQgaW50ZWxfbW9kZXNl
dF9wcmVjbG9zZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUp
Owo+ICAgaW50IHNrbF91cGRhdGVfc2NhbGVyX2NydGMoc3RydWN0IGludGVsX2NydGNfc3RhdGUg
KmNydGNfc3RhdGUpOwo+ICAgaW50IHNrbF9tYXhfc2NhbGUoc3RydWN0IGludGVsX2NydGMgKmNy
dGMsIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKTsKPgo+IC11bnNpZ25lZCBs
b25nIGludGVsX3BsYW5lX29ial9vZmZzZXQoc3RydWN0IGludGVsX3BsYW5lICppbnRlbF9wbGFu
ZSwKPiAtCQkJCSAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAtCQkJCSAg
ICAgdW5zaWduZWQgaW50IHBsYW5lKTsKPiArdTMyIGludGVsX3BsYW5lX29ial9vZmZzZXQoc3Ry
dWN0IGludGVsX3BsYW5lICppbnRlbF9wbGFuZSwKPiArCQkJICAgc3RydWN0IGRybV9pOTE1X2dl
bV9vYmplY3QgKm9iaiwKPiArCQkJICAgdW5zaWduZWQgaW50IHBsYW5lKTsKPgo+ICAgdTMyIHNr
bF9wbGFuZV9jdGxfZm9ybWF0KHVpbnQzMl90IHBpeGVsX2Zvcm1hdCk7Cj4gICB1MzIgc2tsX3Bs
YW5lX2N0bF90aWxpbmcodWludDY0X3QgZmJfbW9kaWZpZXIpOwo+IGRpZmYgLS1naXQgYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX3Nwcml0ZS5jCj4gaW5kZXggNDI3NmMxMy4uYTJjMTVmOCAxMDA2NDQKPiAtLS0gYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX3Nwcml0ZS5jCj4gQEAgLTE5NCw3ICsxOTQsNyBAQCBza2xfdXBkYXRlX3BsYW5l
KHN0cnVjdCBkcm1fcGxhbmUgKmRybV9wbGFuZSwgc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAg
CXUzMiBwbGFuZV9jdGwsIHN0cmlkZV9kaXYsIHN0cmlkZTsKPiAgIAljb25zdCBzdHJ1Y3QgZHJt
X2ludGVsX3Nwcml0ZV9jb2xvcmtleSAqa2V5ID0KPiAgIAkJJnRvX2ludGVsX3BsYW5lX3N0YXRl
KGRybV9wbGFuZS0+c3RhdGUpLT5ja2V5Owo+IC0JdW5zaWduZWQgbG9uZyBzdXJmX2FkZHI7Cj4g
Kwl1MzIgc3VyZl9hZGRyOwo+ICAgCXUzMiB0aWxlX2hlaWdodCwgcGxhbmVfb2Zmc2V0LCBwbGFu
ZV9zaXplOwo+ICAgCXVuc2lnbmVkIGludCByb3RhdGlvbjsKPiAgIAlpbnQgeF9vZmZzZXQsIHlf
b2Zmc2V0Owo+CgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlu
dGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0
aW5mby9pbnRlbC1nZngK