public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 19/26] drm/i915: move adjusted_mode checks from fbc_update to fbc_enable
Date: Mon, 2 Nov 2015 09:53:32 +0100	[thread overview]
Message-ID: <5637248C.9060201@linux.intel.com> (raw)
In-Reply-To: <1446141494.2750.56.camel@intel.com>

Op 29-10-15 om 18:58 schreef Zanoni, Paulo R:
> Em Qui, 2015-10-29 às 13:59 +0100, Maarten Lankhorst escreveu:
>> Op 27-10-15 om 17:50 schreef Paulo Zanoni:
>>> These things can't change without a full modeset.
>> False! Fastset can update parameters too. Although I don't think it
>> currently prevents DBLSCAN updates,
>> so maybe make sure cfb enable/disable is called when updating pipe
>> too?
> You mean that if we change for an interlaced (or double-scanned) to a
> non-interlaced (or non-double-scanned) mode we won't get
> crtc_disable+crtc_enable? That's surprising. I'll take a better look
> here and try to write a test case. Is this just through some specific
> API (like drmModeSetPlane)?
>
> I'm trying to get test cases for every single bug I discover or
> introduce.
>
Yeah if it does happen it's a bug though. :)

~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-11-02  8:53 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 16:50 [PATCH 00/26] Yet another FBC series, v2 Paulo Zanoni
2015-10-27 16:50 ` [PATCH 01/26] drm/i915: change no_fbc_reason from enum to string Paulo Zanoni
2015-10-27 16:50 ` [PATCH 02/26] drm/i915: don't stop+start FBC at every flip Paulo Zanoni
2015-10-27 18:32   ` Ville Syrjälä
2015-10-28 16:56     ` Zanoni, Paulo R
2015-10-28 17:20       ` Ville Syrjälä
2015-10-29 12:05         ` Maarten Lankhorst
2015-10-29 17:30         ` Ville Syrjälä
2015-10-29 17:52           ` Zanoni, Paulo R
2015-10-29 18:14             ` Ville Syrjälä
2015-10-27 19:50   ` Chris Wilson
2015-10-28 16:58     ` Zanoni, Paulo R
2015-10-27 16:50 ` [PATCH 03/26] drm/i915: rename intel_fbc_nuke to intel_fbc_recompress Paulo Zanoni
2015-10-27 16:50 ` [PATCH 04/26] drm/i915: only nuke FBC when a drawing operation triggers a flush Paulo Zanoni
2015-10-27 16:50 ` [PATCH 05/26] drm/i915: extract fbc_on_pipe_a_only() Paulo Zanoni
2015-10-29 12:05   ` Maarten Lankhorst
2015-10-29 15:55     ` Zanoni, Paulo R
2015-10-27 16:50 ` [PATCH 06/26] drm/i915: remove unnecessary check for crtc->primary->fb Paulo Zanoni
2015-10-27 16:50 ` [PATCH 07/26] drm/i915: extract crtc_is_valid() on the FBC code Paulo Zanoni
2015-10-27 16:50 ` [PATCH 08/26] drm/i915: set dev_priv->fbc.crtc before scheduling the enable work Paulo Zanoni
2015-10-27 16:50 ` [PATCH 09/26] drm/i915: use struct intel_crtc *crtc at __intel_fbc_update() Paulo Zanoni
2015-10-27 16:50 ` [PATCH 10/26] drm/i915: fix the __intel_fbc_update() comments Paulo Zanoni
2015-10-27 16:50 ` [PATCH 11/26] drm/i915: pass the crtc as an argument to intel_fbc_update() Paulo Zanoni
2015-10-27 16:50 ` [PATCH 12/26] drm/i915: don't disable_fbc() if FBC is already disabled Paulo Zanoni
2015-10-27 16:50 ` [PATCH 13/26] drm/i915: introduce is_active/activate/deactivate to the FBC terminology Paulo Zanoni
2015-10-27 16:50 ` [PATCH 14/26] drm/i915: refactor FBC deactivation at init Paulo Zanoni
2015-10-27 16:50 ` [PATCH 15/26] drm/i915: introduce intel_fbc_{enable, disable} Paulo Zanoni
2015-10-27 16:50 ` [PATCH 16/26] drm/i915: remove too-frequent FBC debug message Paulo Zanoni
2015-10-27 16:50 ` [PATCH 17/26] drm/i915: fix the CFB size check Paulo Zanoni
2015-10-27 16:50 ` [PATCH 18/26] drm/i915: alloc/free the FBC CFB during enable/disable Paulo Zanoni
2015-10-27 16:50 ` [PATCH 19/26] drm/i915: move adjusted_mode checks from fbc_update to fbc_enable Paulo Zanoni
2015-10-29 12:59   ` Maarten Lankhorst
2015-10-29 17:58     ` Zanoni, Paulo R
2015-11-02  8:53       ` Maarten Lankhorst [this message]
2015-10-27 16:50 ` [PATCH 20/26] drm/i915: move clock frequency " Paulo Zanoni
2015-10-27 16:50 ` [PATCH 21/26] drm/i915: check for FBC planes in the same place as the pipes Paulo Zanoni
2015-10-27 16:50 ` [PATCH 22/26] drm/i915: clarify that checking the FB stride for CFB is intentional Paulo Zanoni
2015-10-27 16:50 ` [PATCH 23/26] drm/i915: use a single intel_fbc_work struct Paulo Zanoni
2015-10-27 20:29   ` Chris Wilson
2015-10-28 17:24     ` Zanoni, Paulo R
2015-10-28 17:40       ` chris
2015-10-27 16:50 ` [PATCH 24/26] drm/i915: wait for a vblank instead of 50ms when enabling FBC Paulo Zanoni
2015-10-27 16:50 ` [PATCH 25/26] drm/i915: remove in_dbg_master check from intel_fbc.c Paulo Zanoni
2015-10-27 16:50 ` [PATCH 26/26] drm/i915: kill fbc.uncompressed_size Paulo Zanoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5637248C.9060201@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox