Re: [PATCH v2 03/14] drm/i915: Do not acquire crtc state to check clock during modeset, v2.

Maarten Lankhorst
2015-11-03T10:09:17Z

Op 03-11-15 om 08:31 schreef Maarten Lankhorst:
> Parallel modesets are still not allowed, but this will allow updating
> a different crtc during a modeset if the clock is not changed.
>
> Additionally when all pipes are DPMS off the cdclk will be lowered
> to the minimum allowed.
>
> Changes since v1:
> - Add dev_priv->active_crtcs for tracking which crtcs are active.
> - Rename min_cdclk to min_pixclk and move to dev_priv.
> - Add a active_crtcs mask which is updated atomically.
> - Add intel_atomic_state->modeset which is set on modesets.
> - Commit new pixclk/active_crtcs right after state swap.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 5 ++
> drivers/gpu/drm/i915/intel_atomic.c | 2 +-
> drivers/gpu/drm/i915/intel_display.c | 160 +++++++++++++++++++++++++----------
> drivers/gpu/drm/i915/intel_drv.h | 7 +-
> 4 files changed, 125 insertions(+), 49 deletions(-)
>
As I mentioned in discussion of 14/14, patch 3 4 and 5 should be dropped from the series.