From: Yu Dai <yu.dai@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix locking around GuC firmware load
Date: Wed, 4 Nov 2015 08:47:12 -0800 [thread overview]
Message-ID: <563A3690.5020806@intel.com> (raw)
In-Reply-To: <CAPM=9tzTSqgZ7j_eCMKO5utZ-aoSOmd++7=7U3K3KY=0x8-j8A@mail.gmail.com>
On 11/03/2015 07:22 PM, Dave Airlie wrote:
> On 4 November 2015 at 07:42, Daniel Stone <daniels@collabora.com> wrote:
> > The GuC firmware load requires struct_mutex to create a GEM object,
> > but this collides badly with request_firmware. Move struct_mutex
> > locking down into the loader itself, so we don't hold it across the
> > entire load process, including request_firmware.
> >
> > Signed-off-by: Daniel Stone <daniels@collabora.com>
>
> This avoids the lockdep spew on my machine.
>
> Reviewed-by: Dave AIrlie <airlied@redhat.com>
>
> I'm going to put this into -next, granted I've still got the other WARN spew
> but lockdep working is a good start.
>
>
Looks good to me. Thanks for the fix.
Reviewed-by: Alex Dai <yu.dai@intel.com>
Alex
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-11-04 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 21:42 [PATCH] drm/i915: Fix locking around GuC firmware load Daniel Stone
2015-11-04 3:22 ` Dave Airlie
2015-11-04 16:47 ` Yu Dai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563A3690.5020806@intel.com \
--to=yu.dai@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox