From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put" Date: Fri, 6 Nov 2015 13:55:37 +0100 Message-ID: <563CA349.7030004@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <563CA07D.30805@users.sourceforge.net> <87h9kzl27o.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87h9kzl27o.fsf@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Jani Nikula , Daniel Vetter , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: intel-gfx@lists.freedesktop.org >> The pwm_put() function tests whether its argument is NULL and then >> returns immediately. Thus the test around the call is not needed. > > The compiler doesn't need it, but IMO it's useful documentation for humans. How do you think about to extend the explicit documentation for the affected parameters in the Linux programming interfaces? Regards, Markus