From: Yu Dai <yu.dai@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: Fix a fw content lost issue after it is evicted
Date: Fri, 6 Nov 2015 15:18:37 -0800 [thread overview]
Message-ID: <563D354D.40306@intel.com> (raw)
In-Reply-To: <20151106220729.GC18324@nuc-i3427.alporthouse.com>
On 11/06/2015 02:07 PM, Chris Wilson wrote:
> On Fri, Nov 06, 2015 at 01:55:27PM -0800, yu.dai@intel.com wrote:
> > From: Alex Dai <yu.dai@intel.com>
> >
> > We keep a copy of GuC fw in a GEM obj. However its content is lost
> > if the GEM obj is evicted (igt/gem_evict_*). Therefore, the later
> > fw loading during GPU reset will fail.
>
> No, it's not. The bug is in sg_copy_buffer called by
> i915_gem_object_create_from_data introduced by yourselves.
>
My understanding is that sg_copy_from_buffer is used to copy data. Can
you clarify why using this will cause such issue? I also did another
experiment that always leaving the GEM obj pinned, then it's content
never changed.
Alex
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-06 23:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 21:55 [PATCH] drm/i915/guc: Fix a fw content lost issue after it is evicted yu.dai
2015-11-06 22:07 ` Chris Wilson
2015-11-06 23:18 ` Yu Dai [this message]
2015-11-09 10:15 ` Chris Wilson
2015-11-10 23:27 ` [PATCH v1] " yu.dai
2015-11-11 9:07 ` Chris Wilson
2015-11-11 19:01 ` Yu Dai
2015-11-23 9:18 ` akash goel
2015-11-23 9:37 ` Chris Wilson
2015-11-24 15:47 ` Dave Gordon
2015-11-24 16:04 ` Daniel Vetter
2015-11-24 17:47 ` Dave Gordon
2015-11-24 18:06 ` Daniel Vetter
2015-11-24 23:01 ` Chris Wilson
2015-11-25 8:40 ` Daniel Vetter
2015-11-25 9:02 ` Chris Wilson
2015-11-25 9:59 ` Daniel Vetter
2015-11-10 23:29 ` [PATCH] " Yu Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563D354D.40306@intel.com \
--to=yu.dai@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox