From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix crtc_y assignment in intel_find_initial_plane_obj()
Date: Mon, 16 Nov 2015 13:15:05 +0100 [thread overview]
Message-ID: <5649C8C9.2090902@linux.intel.com> (raw)
In-Reply-To: <1447434973-12369-1-git-send-email-ville.syrjala@linux.intel.com>
Op 13-11-15 om 18:16 schreef ville.syrjala@linux.intel.com:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Let's set crtc_y to 0 instead of setting src_y twice.
>
> Multiple assignments in one statement is a good way to hide bugs.
> Please don't do that.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Fixes: be5651f2d581 ("drm/i915: Update missing properties in find_initial_plane_obj")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
Oops.
R-b
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-16 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 17:16 [PATCH] drm/i915: Fix crtc_y assignment in intel_find_initial_plane_obj() ville.syrjala
2015-11-13 17:36 ` Jani Nikula
2015-11-13 17:44 ` Ville Syrjälä
2015-11-16 12:15 ` Maarten Lankhorst [this message]
2015-11-16 12:46 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5649C8C9.2090902@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox