From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu Dai Subject: Re: [PATCH] drm/i915/guc: Move wait for GuC out of spinlock/unlock Date: Tue, 24 Nov 2015 09:00:37 -0800 Message-ID: <565497B5.8070103@intel.com> References: <20151120084542.GU17050@phenom.ffwll.local> <1448319778-29282-1-git-send-email-yu.dai@intel.com> <20151124130410.GW17050@phenom.ffwll.local> <1448371593.32235.17.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E1AA89C1A for ; Tue, 24 Nov 2015 09:03:06 -0800 (PST) In-Reply-To: <1448371593.32235.17.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: imre.deak@intel.com, Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxMS8yNC8yMDE1IDA1OjI2IEFNLCBJbXJlIERlYWsgd3JvdGU6Cj4gT24gdGksIDIwMTUt MTEtMjQgYXQgMTQ6MDQgKzAxMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBNb24sIE5v diAyMywgMjAxNSBhdCAwMzowMjo1OFBNIC0wODAwLCB5dS5kYWlAaW50ZWwuY29tIHdyb3RlOgo+ ID4gPiBGcm9tOiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiA+ID4KPiA+ID4gV2hlbiBH dUMgV29yayBRdWV1ZSBpcyBmdWxsLCBkcml2ZXIgd2lsbCB3YWl0IEd1QyBmb3IgYXZhbGlhYmxl Cj4gPiA+IHNwYWNlIGJ5IGRlbGF5aW5nIDFtcy4gVGhlIHdhaXQgbmVlZHMgdG8gYmUgb3V0IG9m IHNwaW5sb2NraXJxIC8KPiA+ID4gdW5sb2NrLiBPdGhlcndpc2UsIGxvY2t1cCBoYXBwZW5zIGJl Y2F1c2UgamlmZmllcyB3b24ndCBiZSB1cGRhdGVkCj4gPiA+IGR1ciB0byBpcnEgaXMgZGlzYWJs ZWQuCj4gPiA+Cj4gPiA+IElzc3VlIGlzIGZvdW5kIGluIGlndC9nZW1fY2xvc2VfcmFjZS4KPiA+ ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4gPiA+ IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwg MjcgKysrKysrKysrKysrKysrKystCj4gPiA+IC0tLS0tLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5n ZWQsIDE3IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gPiA+IGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gPiA+IGluZGV4IDBh NmIwMDcuLjE0MTgzOTcgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2d1Y19zdWJtaXNzaW9uLmMKPiA+ID4gQEAgLTIwMSwxMCArMjAxLDEzIEBAIHN0YXRpYyBpbnQg Z3VjX3JpbmdfZG9vcmJlbGwoc3RydWN0Cj4gPiA+IGk5MTVfZ3VjX2NsaWVudCAqZ2MpCj4gPiA+ ICAJdW5pb24gZ3VjX2Rvb3JiZWxsX3F3ICpkYjsKPiA+ID4gIAl2b2lkICpiYXNlOwo+ID4gPiAg CWludCBhdHRlbXB0ID0gMiwgcmV0ID0gLUVBR0FJTjsKPiA+ID4gKwl1bnNpZ25lZCBsb25nIGZs YWdzOwo+ID4gPgo+ID4gPiAgCWJhc2UgPSBrbWFwX2F0b21pYyhpOTE1X2dlbV9vYmplY3RfZ2V0 X3BhZ2UoZ2MtCj4gPiA+ID5jbGllbnRfb2JqLCAwKSk7Cj4gPgo+ID4gV2UgZG9uJ3QgbmVlZCBr bWFwX2F0b21pYyBhbnltb3JlIGhlcmUgbm93LCBzaW5jZSBpdCdzIG91dHNpZGUgb2YgdGhlCj4g PiBzcGlubG9jay4KPiA+Cj4gPiA+ICAJZGVzYyA9IGJhc2UgKyBnYy0+cHJvY19kZXNjX29mZnNl dDsKPiA+ID4KPiA+ID4gKwlzcGluX2xvY2tfaXJxc2F2ZSgmZ2MtPndxX2xvY2ssIGZsYWdzKTsK PiA+Cj4gPiBQbGVhc2UgZG9uJ3QgdXNlIHRoZSBzdXBlci1nZW5lcmljIF9pcnFzYXZlLiBJdCdz IGV4cGVuc2l2ZSBhbmQKPiA+IHJlc3VsdHMgaW4KPiA+IGZyYWdpbGUgY29kZSB3aGVuIHNvbWVv bmUgYWNjaWRlbnRhbGx5IHJldXNlcyBzb21ldGhpbmcgaW4gYW4KPiA+IGludGVycnVwdAo+ID4g aGFuZGxlciB0aGF0IHdhcyBuZXZlciBtZWFudCB0byBydW4gaW4gdGhhdCBjb250ZXh0Lgo+ID4K PiA+IEluc3RlYWQgcGxlYXNlIHVzZSB0aGUgbW9zdCBzcGVjaWZpYyBmdW50aW9uOgo+ID4gLSBz cGluX2xvY2sgaWYgeW91IGtub3cgeW91IGFyZSBpbiBpcnEgY29udGV4dC4KPiA+IC0gc2lwbl9s b2NrX2lycSBpZiB5b3Uga25vdyB5b3UgYXJlIG5vdC4KPgo+IFJpZ2h0LCBhbmQgc2ltcGx5IHNw aW5fbG9jaygpIGlmIHRoZSBsb2NrIGlzIG5vdCB0YWtlbiBpbiBJUlEgY29udGV4dAo+IGV2ZXIu CgpUaGlzIGlzIG5vdCBpbiBJUlEgY29udGV4dC4gU28gSSB3aWxsIHVzZSBzcGluX2xvY2tfaXJx IGluc3RlYWQuCj4gPiAtIHNwaW5fbG9ja19pcnFzYXZlIHNob3VsZCBiZSBhIGJpZyB3YXJuaW5n IHNpZ24gdGhhdCB5b3VyIGNvZGUgaGFzCj4gPiAgIGxheWVyaW5nIGlzc3Vlcy4KPiA+Cj4gPiBQ bGVhc2UgYXVkaXQgdGhlIGVudGlyZSBndWMgY29kZSBmb3IgdGhlIGFib3ZlIHR3byBpc3N1ZXMu Cj4KPiBBZ3JlZWQsIGl0IGxvb2tzIGluY29uc2lzdGVudCBhdG06IHdlIGRvIHNwaW5fbG9jayh3 cV9sb2NrKSBmcm9tCj4gZGVidWdmcyBhbmQgc3Bpbl9sb2NrX2lycSh3cV9sb2NrKSBmcm9tIGk5 MTVfZ3VjX3N1Ym1pdCgpLiBOZWl0aGVyIG9mCj4gdGhlbSBhcmUgY2FsbGVkIGZyb20gSVJRIGNv bnRleHQgQUZBSUNTLCBpbiB3aGljaCBjYXNlIGEgc2ltcGxlCj4gc3Bpbl9sb2NrKCkgd291bGQg ZG8uCj4KPiAtLUltcmUKPgo+ID4gPiArCj4gPiA+ICAJLyogVXBkYXRlIHRoZSB0YWlsIHNvIGl0 IGlzIHZpc2libGUgdG8gR3VDICovCj4gPiA+ICAJZGVzYy0+dGFpbCA9IGdjLT53cV90YWlsOwo+ ID4gPgo+ID4gPiBAQCAtMjQ4LDcgKzI1MSwxMCBAQCBzdGF0aWMgaW50IGd1Y19yaW5nX2Rvb3Ji ZWxsKHN0cnVjdAo+ID4gPiBpOTE1X2d1Y19jbGllbnQgKmdjKQo+ID4gPiAgCQkJZGJfZXhjLmNv b2tpZSA9IDE7Cj4gPiA+ICAJfQo+ID4gPgo+ID4gPiArCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUo JmdjLT53cV9sb2NrLCBmbGFncyk7Cj4gPiA+ICsKPiA+ID4gIAlrdW5tYXBfYXRvbWljKGJhc2Up Owo+ID4gPiArCj4gPiA+ICAJcmV0dXJuIHJldDsKPiA+ID4gIH0KPiA+ID4KPiA+ID4gQEAgLTQ4 NywxNiArNDkzLDE2IEBAIHN0YXRpYyBpbnQgZ3VjX2dldF93b3JrcXVldWVfc3BhY2Uoc3RydWN0 Cj4gPiA+IGk5MTVfZ3VjX2NsaWVudCAqZ2MsIHUzMiAqb2Zmc2V0KQo+ID4gPiAgCXN0cnVjdCBn dWNfcHJvY2Vzc19kZXNjICpkZXNjOwo+ID4gPiAgCXZvaWQgKmJhc2U7Cj4gPiA+ICAJdTMyIHNp emUgPSBzaXplb2Yoc3RydWN0IGd1Y193cV9pdGVtKTsKPiA+ID4gLQlpbnQgcmV0ID0gMCwgdGlt ZW91dF9jb3VudGVyID0gMjAwOwo+ID4gPiArCWludCByZXQgPSAtRVRJTUVET1VULCB0aW1lb3V0 X2NvdW50ZXIgPSAyMDA7Cj4gPiA+ICsJdW5zaWduZWQgbG9uZyBmbGFnczsKPiA+ID4KPiA+ID4g IAliYXNlID0ga21hcF9hdG9taWMoaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlKGdjLQo+ID4gPiA+ Y2xpZW50X29iaiwgMCkpOwo+ID4gPiAgCWRlc2MgPSBiYXNlICsgZ2MtPnByb2NfZGVzY19vZmZz ZXQ7Cj4gPiA+Cj4gPiA+ICAJd2hpbGUgKHRpbWVvdXRfY291bnRlci0tID4gMCkgewo+ID4gPiAt CQlyZXQgPSB3YWl0X2Zvcl9hdG9taWMoQ0lSQ19TUEFDRShnYy0+d3FfdGFpbCwKPiA+ID4gZGVz Yy0+aGVhZCwKPiA+ID4gLQkJCQlnYy0+d3Ffc2l6ZSkgPj0gc2l6ZSwgMSk7Cj4gPiA+ICsJCXNw aW5fbG9ja19pcnFzYXZlKCZnYy0+d3FfbG9jaywgZmxhZ3MpOwo+ID4gPgo+ID4gPiAtCQlpZiAo IXJldCkgewo+ID4gPiArCQlpZiAoQ0lSQ19TUEFDRShnYy0+d3FfdGFpbCwgZGVzYy0+aGVhZCwg Z2MtCj4gPiA+ID53cV9zaXplKSA+PSBzaXplKSB7Cj4gPiA+ICAJCQkqb2Zmc2V0ID0gZ2MtPndx X3RhaWw7Cj4gPiA+Cj4gPiA+ICAJCQkvKiBhZHZhbmNlIHRoZSB0YWlsIGZvciBuZXh0IHdvcmtx dWV1ZQo+ID4gPiBpdGVtICovCj4gPiA+IEBAIC01MDUsNyArNTExLDEzIEBAIHN0YXRpYyBpbnQg Z3VjX2dldF93b3JrcXVldWVfc3BhY2Uoc3RydWN0Cj4gPiA+IGk5MTVfZ3VjX2NsaWVudCAqZ2Ms IHUzMiAqb2Zmc2V0KQo+ID4gPgo+ID4gPiAgCQkJLyogdGhpcyB3aWxsIGJyZWFrIHRoZSBsb29w ICovCj4gPiA+ICAJCQl0aW1lb3V0X2NvdW50ZXIgPSAwOwo+ID4gPiArCQkJcmV0ID0gMDsKPiA+ ID4gIAkJfQo+ID4gPiArCj4gPiA+ICsJCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmdjLT53cV9s b2NrLCBmbGFncyk7Cj4gPiA+ICsKPiA+ID4gKwkJaWYgKHRpbWVvdXRfY291bnRlcikKPiA+ID4g KwkJCXVzbGVlcF9yYW5nZSgxMDAwLCAyMDAwKTsKPiA+Cj4gPiBEbyB3ZSByZWFsbHkgbm90IGhh dmUgYSBpbnRlcnJ1cHQvc2lnbmFsIGZyb20gdGhlIGd1YyB3aGVuIGl0IGhhcwo+ID4gY2xlYXJl ZAo+ID4gdXAgc29tZSBzcGFjZT8KPiA+CgpUaGlzIGlzIG5vdCBpbXBsZW1lbnRlZCBpbiBmdyBh bHRob3VnaCBJIHRoaW5rIGl0IGNvdWxkIGJlIGRvbmUgdGhyb3VnaCAKdGhlIGd1YyB0byBob3N0 IGludGVycnVwdC4gSSBhbSB3b3JyeSBhYm91dCB0aGF0IGlmIHdlIGltcGxlbWVudCB0aGlzLCAK aXQgd2lsbCBlbmQgdXAgd2l0aCBkcml2ZXIgaGFuZGxlcyB0b28gbWFueSBpbnRlcnJ1cHRzICht YXliZSBzYW1lIAphbW91bnQgb2YgY29udGV4dCBzd2l0Y2gpLiBIb3dldmVyLCBpZGVhbGx5IHdl IGRvbid0IHdhbnQgdG8gaGFuZGxlIAppbnRlcnJ1cHRzIGF0IGFsbC4KPiA+ID4gIAl9Owo+ID4g Pgo+ID4gPiAgCWt1bm1hcF9hdG9taWMoYmFzZSk7Cj4gPiA+IEBAIC01OTcsMTkgKzYwOSwxNyBA QCBpbnQgaTkxNV9ndWNfc3VibWl0KHN0cnVjdCBpOTE1X2d1Y19jbGllbnQKPiA+ID4gKmNsaWVu dCwKPiA+ID4gIHsKPiA+ID4gIAlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSBjbGllbnQtPmd1YzsK PiA+ID4gIAllbnVtIGludGVsX3JpbmdfaWQgcmluZ19pZCA9IHJxLT5yaW5nLT5pZDsKPiA+ID4g LQl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ID4gPiAgCWludCBxX3JldCwgYl9yZXQ7Cj4gPiA+Cj4g PiA+ICAJLyogTmVlZCB0aGlzIGJlY2F1c2Ugb2YgdGhlIGRlZmVycmVkIHBpbiBjdHggYW5kIHJp bmcgKi8KPiA+ID4gIAkvKiBTaGFsbCB3ZSBtb3ZlIHRoaXMgcmlnaHQgYWZ0ZXIgcmluZyBpcyBw aW5uZWQ/ICovCj4gPiA+ICAJbHJfY29udGV4dF91cGRhdGUocnEpOwo+ID4gPgo+ID4gPiAtCXNw aW5fbG9ja19pcnFzYXZlKCZjbGllbnQtPndxX2xvY2ssIGZsYWdzKTsKPiA+ID4gLQo+ID4gPiAg CXFfcmV0ID0gZ3VjX2FkZF93b3JrcXVldWVfaXRlbShjbGllbnQsIHJxKTsKPiA+ID4gIAlpZiAo cV9yZXQgPT0gMCkKPiA+ID4gIAkJYl9yZXQgPSBndWNfcmluZ19kb29yYmVsbChjbGllbnQpOwo+ ID4gPgo+ID4gPiArCXNwaW5fbG9jaygmZ3VjLT5ob3N0Mmd1Y19sb2NrKTsKPiA+Cj4gPiBTbyBh dCBmaXJzdCBJIHRob3VnaHQgdGhlcmUncyBhIHJhY2Ugbm93LCBidXQgdGhlbiBJIGxvb2tlZCBh dCB3aGF0Cj4gPiBob3N0Mmd1YyBhbmQgd3FfbG9jayBwcm90ZWN0LiBJdCBzZWVtcyBsaWtlIHRo ZSBvbmx5IHRoaW5nIHRoZXkgZG8gaXMKPiA+IHByb3RlY3QgYWdhaW5zdCBkZWJ1Z2ZzLCBhbGwg dGhlIHJlYWwgcHJvdGVjdGlvbiBhZ2FpbnN0IGluY29uc2lzdGVudAo+ID4gc3RhdGUgaXMgZG9u ZSB0aHJvdWdoIGRldi0+c3RydWN0X211dGV4Lgo+ID4KPiA+IENhbid0IHdlIGp1c3QgcmlwIG91 dCBhbGwgdGhpcyBzcGlubG9jayBidXNpbmVzcyBmcm9tIHRoZSBndWMgY29kZT8KPiA+IEl0IHdv dWxkIGJlIGVhc2llciB0aGFuIGZpeGluZyB1cCB0aGUgcmFjZXMgaW4gaGVyZS4KPgo+CgpZZXMs IGhvc3QyZ3VjIGxvY2sgY2FuIGJlIGRvbmUgdGhyb3VnaCBkZXYtPnN0cnVjdF9tdXRleC4gQnV0 IGRlZmluaXRlbHkgCndlIGRvbid0IHdhbnQgdG8gaW50ZXJydXB0IHRoZSBwcm9jZXNzIHdoZW4g ZHJpdmVyIHByb2dyYW0gZ3VjIHdvcmsgCnF1ZXVlIGFuZCByaW5nIHRoZSBkb29yIGJlbGwuCj4g PiAtRGFuaWVsCj4gPgo+ID4gPiAgCWNsaWVudC0+c3VibWlzc2lvbnNbcmluZ19pZF0gKz0gMTsK PiA+ID4gIAlpZiAocV9yZXQpIHsKPiA+ID4gIAkJY2xpZW50LT5xX2ZhaWwgKz0gMTsKPiA+ID4g QEAgLTYyMCw5ICs2MzAsNiBAQCBpbnQgaTkxNV9ndWNfc3VibWl0KHN0cnVjdCBpOTE1X2d1Y19j bGllbnQKPiA+ID4gKmNsaWVudCwKPiA+ID4gIAl9IGVsc2Ugewo+ID4gPiAgCQljbGllbnQtPnJl dGNvZGUgPSAwOwo+ID4gPiAgCX0KPiA+ID4gLQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZjbGll bnQtPndxX2xvY2ssIGZsYWdzKTsKPiA+ID4gLQo+ID4gPiAtCXNwaW5fbG9jaygmZ3VjLT5ob3N0 Mmd1Y19sb2NrKTsKPiA+ID4gIAlndWMtPnN1Ym1pc3Npb25zW3JpbmdfaWRdICs9IDE7Cj4gPiA+ ICAJZ3VjLT5sYXN0X3NlcW5vW3JpbmdfaWRdID0gcnEtPnNlcW5vOwo+ID4gPiAgCXNwaW5fdW5s b2NrKCZndWMtPmhvc3QyZ3VjX2xvY2spOwo+ID4gPiAtLQo+ID4gPiAyLjUuMAo+ID4gPgo+ID4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==