From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 02/15] drm/i915: Limit the busy wait on requests to 10us not 10ms! Date: Mon, 30 Nov 2015 10:02:30 +0000 Message-ID: <565C1EB6.4060309@linux.intel.com> References: <1448786893-2522-1-git-send-email-chris@chris-wilson.co.uk> <1448786893-2522-3-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A3246E4DA for ; Mon, 30 Nov 2015 02:02:51 -0800 (PST) In-Reply-To: <1448786893-2522-3-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Eero Tamminen , stable@kernel.vger.org, "Rantala, Valtteri" List-Id: intel-gfx@lists.freedesktop.org CgpPbiAyOS8xMS8xNSAwODo0OCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IFdoZW4gd2FpdGluZyBm b3IgaGlnaCBmcmVxdWVuY3kgcmVxdWVzdHMsIHRoZSBmaW5pdGUgYW1vdW50IG9mIHRpbWUKPiBy ZXF1aXJlZCB0byBzZXQgdXAgdGhlIGlycSBhbmQgd2FpdCB1cG9uIGl0IGxpbWl0cyB0aGUgcmVz cG9uc2UgcmF0ZS4gQnkKPiBidXN5d2FpdGluZyBvbiB0aGUgcmVxdWVzdCBjb21wbGV0aW9uIGZv ciBhIHNob3J0IHdoaWxlIHdlIGNhbiBzZXJ2aWNlCj4gdGhlIGhpZ2ggZnJlcXVlbmN5IHdhaXRz IGFzIHF1aWNrIGFzIHBvc3NpYmxlLiBIb3dldmVyLCBpZiBpdCBpcyBhIHNsb3cKPiByZXF1ZXN0 LCB3ZSB3YW50IHRvIHNsZWVwIGFzIHF1aWNrbHkgYXMgcG9zc2libGUuIFRoZSB0cmFkZW9mZiBi ZXR3ZWVuCj4gd2FpdGluZyBhbmQgc2xlZXBpbmcgaXMgcm91Z2hseSB0aGUgdGltZSBpdCB0YWtl cyB0byBzbGVlcCBvbiBhIHJlcXVlc3QsCj4gb24gdGhlIG9yZGVyIG9mIGEgbWljcm9zZWNvbmQu IEJhc2VkIG9uIG1lYXN1cmVtZW50cyBvZiBzeW5jaHJvbm91cwo+IHdvcmtsb2FkcyBmcm9tIGFj cm9zcyBiaWcgY29yZSBhbmQgbGl0dGxlIGF0b20sIEkgaGF2ZSBzZXQgdGhlIGxpbWl0IGZvcgo+ IGJ1c3l3YWl0aW5nIGFzIDEwIG1pY3Jvc2Vjb25kcy4gSW4gbW9zdCBvZiB0aGUgc3luY2hyb25v dXMgY2FzZXMsIHdlIGNhbgo+IHJlZHVjZSB0aGUgbGltaXQgZG93biB0byBhcyBsaXR0bGUgYXMg MiBtaXNjcm9zZWNvbmRzLCBidXQgdGhhdCBsZWF2ZXMKPiBxdWl0ZSBhIGZldyB0ZXN0IGNhc2Vz IHJlZ3Jlc3NpbmcgYnkgZmFjdG9ycyBvZiAzIGFuZCBtb3JlLgo+Cj4gVGhlIGNvZGUgY3VycmVu dGx5IHVzZXMgdGhlIGppZmZpZSBjbG9jaywgYnV0IHRoYXQgaXMgZmFyIHRvbyBjb2Fyc2UgKG9u Cj4gdGhlIG9yZGVyIG9mIDEwIG1pbGxpc2Vjb25kcykgYW5kIHJlc3VsdHMgaW4gcG9vciBpbnRl cmFjdGl2aXR5IGFzIHRoZQo+IENQVSBlbmRzIHVwIGJlaW5nIGhvZ2dlZCBieSBzbG93IHJlcXVl c3RzLiBUbyBnZXQgbWljcm9zZWNvbmQgcmVzb2x1dGlvbgo+IHdlIG5lZWQgdG8gdXNlIGEgaGln aCByZXNvbHV0aW9uIHRpbWVyLiBUaGUgY2hlYXBlc3Qgb2Ygd2hpY2ggaXMgcG9sbGluZwo+IGxv Y2FsX2Nsb2NrKCksIGJ1dCB0aGF0IGlzIG9ubHkgdmFsaWQgb24gdGhlIHNhbWUgQ1BVLiBJZiB3 ZSBzd2l0Y2ggQ1BVcwo+IGJlY2F1c2UgdGhlIHRhc2sgd2FzIHByZWVtcHRlZCwgd2UgY2FuIGFs c28gdXNlIHRoYXQgYXMgYW4gaW5kaWNhdG9yIHRoYXQKPiAgIHRoZSBzeXN0ZW0gaXMgdG9vIGJ1 c3kgdG8gd2FzdGUgY3ljbGVzIG9uIHNwaW5uaW5nIGFuZCB3ZSBzaG91bGQgc2xlZXAKPiBpbnN0 ZWFkLgo+Cj4gX19pOTE1X3NwaW5fcmVxdWVzdCB3YXMgaW50cm9kdWNlZCBpbgo+IGNvbW1pdCAy ZGVmNGFkOTliZWZhMjU3NzVkZDJmNzE0ZmRkNGQ5MmZhZWM2ZTM0IFt2NC4yXQo+IEF1dGhvcjog Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gRGF0ZTogICBUdWUgQXBy IDcgMTY6MjA6NDEgMjAxNSArMDEwMAo+Cj4gICAgICAgZHJtL2k5MTU6IE9wdGltaXN0aWNhbGx5 IHNwaW4gZm9yIHRoZSByZXF1ZXN0IGNvbXBsZXRpb24KPgo+IHYyOiBEcm9wIGZ1bGwgdTY0IGZv ciB1bnNpZ25lZCBsb25nIC0gdGhlIHRpbWVyIGlzIDMyYml0IHdyYXBhcm91bmQgc2FmZSwKPiBz byB3ZSBjYW4gdXNlIG5hdGl2ZSByZWdpc3RlciBzaXplcyBvbiBzbWFsbGVyIGFyY2hpdGVjdHVy ZXMuIE1lbnRpb24KPiB0aGUgYXBwcm94aW1hdGUgbWljcm9zZWNvbmRzIHVuaXRzIGZvciBlbGFw c2VkIHRpbWUgYW5kIGFkZCBzb21lIGV4dHJhCj4gY29tbWVudHMgZGVzY3JpYmluZyB0aGUgcmVh c29uIGZvciBidXN5d2FpdGluZy4KPgo+IHYzOiBSYWlzZSB0aGUgbGltaXQgdG8gMTB1cwo+Cj4g UmVwb3J0ZWQtYnk6IEplbnMgQXhib2UgPGF4Ym9lQGtlcm5lbC5kaz4KPiBMaW5rOiBodHRwczov L2xrbWwub3JnL2xrbWwvMjAxNS8xMS8xMi82MjEKPiBDYzsgIlJvZ296aGtpbiwgRG1pdHJ5IFYi IDxkbWl0cnkudi5yb2dvemhraW5AaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5p ZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A bGludXguaW50ZWwuY29tPgo+IENjOiBFZXJvIFRhbW1pbmVuIDxlZXJvLnQudGFtbWluZW5AaW50 ZWwuY29tPgo+IENjOiAiUmFudGFsYSwgVmFsdHRlcmkiIDx2YWx0dGVyaS5yYW50YWxhQGludGVs LmNvbT4KPiBDYzogc3RhYmxlQGtlcm5lbC52Z2VyLm9yZwo+IC0tLQo+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDQ3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKy0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKCkFnYWluLAoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxp bkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ IGluZGV4IDg3ZmMzNGY1ODk5Zi4uYmFkMTEyYWJiMTZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4gQEAgLTExNDYsMTQgKzExNDYsNTcgQEAgc3RhdGljIGJvb2wgbWlzc2VkX2lycShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJcmV0dXJuIHRlc3RfYml0KHJp bmctPmlkLCAmZGV2X3ByaXYtPmdwdV9lcnJvci5taXNzZWRfaXJxX3JpbmdzKTsKPiAgIH0KPgo+ ICtzdGF0aWMgdW5zaWduZWQgbG9uZyBsb2NhbF9jbG9ja191cyh1bnNpZ25lZCAqY3B1KQo+ICt7 Cj4gKwl1bnNpZ25lZCBsb25nIHQ7Cj4gKwo+ICsJLyogQ2hlYXBseSBhbmQgYXBwcm94aW1hdGVs eSBjb252ZXJ0IGZyb20gbmFub3NlY29uZHMgdG8gbWljcm9zZWNvbmRzLgo+ICsJICogVGhlIHJl c3VsdCBhbmQgc3Vic2VxdWVudCBjYWxjdWxhdGlvbnMgYXJlIGFsc28gZGVmaW5lZCBpbiB0aGUg c2FtZQo+ICsJICogYXBwcm94aW1hdGUgbWljcm9zZWNvbmRzIHVuaXRzLiBUaGUgcHJpbmNpcGFs IHNvdXJjZSBvZiB0aW1pbmcKPiArCSAqIGVycm9yIGhlcmUgaXMgZnJvbSB0aGUgc2ltcGxlIHRy dW5jYXRpb24uCj4gKwkgKgo+ICsJICogTm90ZSB0aGF0IGxvY2FsX2Nsb2NrKCkgaXMgb25seSBk ZWZpbmVkIHdydCB0byB0aGUgY3VycmVudCBDUFU7Cj4gKwkgKiB0aGUgY29tcGFyaXNvbnMgYXJl IG5vIGxvbmdlciB2YWxpZCBpZiB3ZSBzd2l0Y2ggQ1BVcy4gSW5zdGVhZCBvZgo+ICsJICogYmxv Y2tpbmcgcHJlZW1wdGlvbiBmb3IgdGhlIGVudGlyZSBidXN5d2FpdCwgd2UgY2FuIGRldGVjdCB0 aGUgQ1BVCj4gKwkgKiBzd2l0Y2ggYW5kIHVzZSB0aGF0IGFzIGluZGljYXRvciBvZiBzeXN0ZW0g bG9hZCBhbmQgYSByZWFzb24gdG8KPiArCSAqIHN0b3AgYnVzeXdhaXRpbmcsIHNlZSBidXN5d2Fp dF9zdG9wKCkuCj4gKwkgKi8KPiArCSpjcHUgPSBnZXRfY3B1KCk7Cj4gKwl0ID0gbG9jYWxfY2xv Y2soKSA+PiAxMDsKPiArCXB1dF9jcHUoKTsKPiArCj4gKwlyZXR1cm4gdDsKPiArfQo+ICsKPiAr c3RhdGljIGJvb2wgYnVzeXdhaXRfc3RvcCh1bnNpZ25lZCBsb25nIHRpbWVvdXQsIHVuc2lnbmVk IGNwdSkKPiArewo+ICsJdW5zaWduZWQgdGhpc19jcHU7Cj4gKwo+ICsJaWYgKHRpbWVfYWZ0ZXIo bG9jYWxfY2xvY2tfdXMoJnRoaXNfY3B1KSwgdGltZW91dCkpCj4gKwkJcmV0dXJuIHRydWU7Cj4g Kwo+ICsJcmV0dXJuIHRoaXNfY3B1ICE9IGNwdTsKPiArfQo+ICsKPiAgIHN0YXRpYyBpbnQgX19p OTE1X3NwaW5fcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwgaW50IHN0 YXRlKQo+ICAgewo+ICAgCXVuc2lnbmVkIGxvbmcgdGltZW91dDsKPiArCXVuc2lnbmVkIGNwdTsK PiArCj4gKwkvKiBXaGVuIHdhaXRpbmcgZm9yIGhpZ2ggZnJlcXVlbmN5IHJlcXVlc3RzLCBlLmcu IGR1cmluZyBzeW5jaHJvbm91cwo+ICsJICogcmVuZGVyaW5nIHNwbGl0IGJldHdlZW4gdGhlIENQ VSBhbmQgR1BVLCB0aGUgZmluaXRlIGFtb3VudCBvZiB0aW1lCj4gKwkgKiByZXF1aXJlZCB0byBz ZXQgdXAgdGhlIGlycSBhbmQgd2FpdCB1cG9uIGl0IGxpbWl0cyB0aGUgcmVzcG9uc2UKPiArCSAq IHJhdGUuIEJ5IGJ1c3l3YWl0aW5nIG9uIHRoZSByZXF1ZXN0IGNvbXBsZXRpb24gZm9yIGEgc2hv cnQgd2hpbGUgd2UKPiArCSAqIGNhbiBzZXJ2aWNlIHRoZSBoaWdoIGZyZXF1ZW5jeSB3YWl0cyBh cyBxdWljayBhcyBwb3NzaWJsZS4gSG93ZXZlciwKPiArCSAqIGlmIGl0IGlzIGEgc2xvdyByZXF1 ZXN0LCB3ZSB3YW50IHRvIHNsZWVwIGFzIHF1aWNrbHkgYXMgcG9zc2libGUuCj4gKwkgKiBUaGUg dHJhZGVvZmYgYmV0d2VlbiB3YWl0aW5nIGFuZCBzbGVlcGluZyBpcyByb3VnaGx5IHRoZSB0aW1l IGl0Cj4gKwkgKiB0YWtlcyB0byBzbGVlcCBvbiBhIHJlcXVlc3QsIG9uIHRoZSBvcmRlciBvZiBh IG1pY3Jvc2Vjb25kLgo+ICsJICovCj4KPiAgIAlpZiAoaTkxNV9nZW1fcmVxdWVzdF9nZXRfcmlu ZyhyZXEpLT5pcnFfcmVmY291bnQpCj4gICAJCXJldHVybiAtRUJVU1k7Cj4KPiAtCXRpbWVvdXQg PSBqaWZmaWVzICsgMTsKPiArCXRpbWVvdXQgPSBsb2NhbF9jbG9ja191cygmY3B1KSArIDEwOwo+ ICAgCXdoaWxlICghbmVlZF9yZXNjaGVkKCkpIHsKPiAgIAkJaWYgKGk5MTVfZ2VtX3JlcXVlc3Rf Y29tcGxldGVkKHJlcSwgdHJ1ZSkpCj4gICAJCQlyZXR1cm4gMDsKPiBAQCAtMTE2MSw3ICsxMjA0 LDcgQEAgc3RhdGljIGludCBfX2k5MTVfc3Bpbl9yZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9nZW1f cmVxdWVzdCAqcmVxLCBpbnQgc3RhdGUpCj4gICAJCWlmIChzaWduYWxfcGVuZGluZ19zdGF0ZShz dGF0ZSwgY3VycmVudCkpCj4gICAJCQlicmVhazsKPgo+IC0JCWlmICh0aW1lX2FmdGVyX2VxKGpp ZmZpZXMsIHRpbWVvdXQpKQo+ICsJCWlmIChidXN5d2FpdF9zdG9wKHRpbWVvdXQsIGNwdSkpCj4g ICAJCQlicmVhazsKPgo+ICAgCQljcHVfcmVsYXhfbG93bGF0ZW5jeSgpOwo+Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==