From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 03/15] drm/i915: Only spin whilst waiting on the current request Date: Mon, 30 Nov 2015 10:06:10 +0000 Message-ID: <565C1F92.2010501@linux.intel.com> References: <1448786893-2522-1-git-send-email-chris@chris-wilson.co.uk> <1448786893-2522-4-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 530696E4DD for ; Mon, 30 Nov 2015 02:06:13 -0800 (PST) In-Reply-To: <1448786893-2522-4-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Eero Tamminen , stable@kernel.vger.org, "Rantala, Valtteri" List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI5LzExLzE1IDA4OjQ4LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gTGltaXQgYnVzeXdhaXRp bmcgb25seSB0byB0aGUgcmVxdWVzdCBjdXJyZW50bHkgYmVpbmcgcHJvY2Vzc2VkIGJ5IHRoZQo+ IEdQVS4gSWYgdGhlIHJlcXVlc3QgaXMgbm90IGN1cnJlbnRseSBiZWluZyBwcm9jZXNzZWQgYnkg dGhlIEdQVSwgdGhlcmUKPiBpcyBhIHZlcnkgbG93IGxpa2VsaWhvb2Qgb2YgaXQgYmVpbmcgY29t cGxldGVkIHdpdGhpbiB0aGUgMiBtaWNyb3NlY29uZAo+IHNwaW4gdGltZW91dCBhbmQgc28gd2Ug d2lsbCBqdXN0IGJlIHdhc3RpbmcgQ1BVIGN5Y2xlcy4KPgo+IHYyOiBDaGVjayBmb3IgbG9naWNh bCBpbnZlcnNpb24gd2hlbiByZWJhc2luZyAtIHdlIHdlcmUgaW5jb3JyZWN0bHkKPiBjaGVja2lu ZyBmb3IgdGhpcyByZXF1ZXN0IGJlaW5nIGFjdGl2ZSwgYW5kIGluc3RlYWQgYnVzeXdhaXRpbmcg Zm9yCj4gd2hlbiB0aGUgR1BVIHdhcyBub3QgeWV0IHByb2Nlc3NpbmcgdGhlIHJlcXVlc3Qgb2Yg aW50ZXJlc3QuCj4KPiB2MzogVHJ5IGFub3RoZXIgY29sb3VyIGZvciB0aGUgc2Vxbm8gbmFtZXMu Cj4gdjQ6IEFub3RoZXIgY29sb3VyIGZvciB0aGUgZnVuY3Rpb24gbmFtZXMuCj4KPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogIlJv Z296aGtpbiwgRG1pdHJ5IFYiIDxkbWl0cnkudi5yb2dvemhraW5AaW50ZWwuY29tPgo+IENjOiBE YW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBUdnJ0a28gVXJzdWxp biA8dHZydGtvLnVyc3VsaW5AbGludXguaW50ZWwuY29tPgo+IENjOiBFZXJvIFRhbW1pbmVuIDxl ZXJvLnQudGFtbWluZW5AaW50ZWwuY29tPgo+IENjOiAiUmFudGFsYSwgVmFsdHRlcmkiIDx2YWx0 dGVyaS5yYW50YWxhQGludGVsLmNvbT4KPiBDYzogc3RhYmxlQGtlcm5lbC52Z2VyLm9yZwo+IC0t LQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCB8IDI3ICsrKysrKysrKysrKysr KysrKystLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8ICA4ICsr KysrKystCj4gICAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25z KC0pCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNv bT4KClJlZ2FyZHMsCgpUdnJ0a28KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggYmM4 NjVlMjM0ZGYyLi5kMDcwNDFjMTcyOWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBA QCAtMjE4Miw4ICsyMTgyLDE3IEBAIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCB7Cj4gICAJ c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTU7Cj4gICAJc3RydWN0IGludGVsX2VuZ2luZV9j cyAqcmluZzsKPgo+IC0JLyoqIEdFTSBzZXF1ZW5jZSBudW1iZXIgYXNzb2NpYXRlZCB3aXRoIHRo aXMgcmVxdWVzdC4gKi8KPiAtCXVpbnQzMl90IHNlcW5vOwo+ICsJIC8qKiBHRU0gc2VxdWVuY2Ug bnVtYmVyIGFzc29jaWF0ZWQgd2l0aCB0aGUgcHJldmlvdXMgcmVxdWVzdCwKPiArCSAgKiB3aGVu IHRoZSBIV1MgYnJlYWRjcnVtYiBpcyBlcXVhbCB0byB0aGlzIHRoZSBHUFUgaXMgcHJvY2Vzc2lu Zwo+ICsJICAqIHRoaXMgcmVxdWVzdC4KPiArCSAgKi8KPiArCXUzMiBwcmV2aW91c19zZXFubzsK PiArCj4gKwkgLyoqIEdFTSBzZXF1ZW5jZSBudW1iZXIgYXNzb2NpYXRlZCB3aXRoIHRoaXMgcmVx dWVzdCwKPiArCSAgKiB3aGVuIHRoZSBIV1MgYnJlYWRjcnVtYiBpcyBlcXVhbCBvciBncmVhdGVy IHRoYW4gdGhpcyB0aGUgR1BVCj4gKwkgICogaGFzIGZpbmlzaGVkIHByb2Nlc3NpbmcgdGhpcyBy ZXF1ZXN0Lgo+ICsJICAqLwo+ICsJdTMyIHNlcW5vOwo+Cj4gICAJLyoqIFBvc2l0aW9uIGluIHRo ZSByaW5nYnVmZmVyIG9mIHRoZSBzdGFydCBvZiB0aGUgcmVxdWVzdCAqLwo+ICAgCXUzMiBoZWFk Owo+IEBAIC0yOTQ1LDE1ICsyOTU0LDE3IEBAIGk5MTVfc2Vxbm9fcGFzc2VkKHVpbnQzMl90IHNl cTEsIHVpbnQzMl90IHNlcTIpCj4gICAJcmV0dXJuIChpbnQzMl90KShzZXExIC0gc2VxMikgPj0g MDsKPiAgIH0KPgo+ICtzdGF0aWMgaW5saW5lIGJvb2wgaTkxNV9nZW1fcmVxdWVzdF9zdGFydGVk KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+ICsJCQkJCSAgIGJvb2wgbGF6eV9j b2hlcmVuY3kpCj4gK3sKPiArCXUzMiBzZXFubyA9IHJlcS0+cmluZy0+Z2V0X3NlcW5vKHJlcS0+ cmluZywgbGF6eV9jb2hlcmVuY3kpOwo+ICsJcmV0dXJuIGk5MTVfc2Vxbm9fcGFzc2VkKHNlcW5v LCByZXEtPnByZXZpb3VzX3NlcW5vKTsKPiArfQo+ICsKPiAgIHN0YXRpYyBpbmxpbmUgYm9vbCBp OTE1X2dlbV9yZXF1ZXN0X2NvbXBsZXRlZChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJl cSwKPiAgIAkJCQkJICAgICAgYm9vbCBsYXp5X2NvaGVyZW5jeSkKPiAgIHsKPiAtCXUzMiBzZXFu bzsKPiAtCj4gLQlCVUdfT04ocmVxID09IE5VTEwpOwo+IC0KPiAtCXNlcW5vID0gcmVxLT5yaW5n LT5nZXRfc2Vxbm8ocmVxLT5yaW5nLCBsYXp5X2NvaGVyZW5jeSk7Cj4gLQo+ICsJdTMyIHNlcW5v ID0gcmVxLT5yaW5nLT5nZXRfc2Vxbm8ocmVxLT5yaW5nLCBsYXp5X2NvaGVyZW5jeSk7Cj4gICAJ cmV0dXJuIGk5MTVfc2Vxbm9fcGFzc2VkKHNlcW5vLCByZXEtPnNlcW5vKTsKPiAgIH0KPgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IGJhZDExMmFiYjE2Yi4uYWRhNDYxZTAyNzE4IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTExOTMsOSArMTE5MywxMyBAQCBzdGF0 aWMgaW50IF9faTkxNV9zcGluX3JlcXVlc3Qoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpy ZXEsIGludCBzdGF0ZSkKPiAgIAkgKiB0YWtlcyB0byBzbGVlcCBvbiBhIHJlcXVlc3QsIG9uIHRo ZSBvcmRlciBvZiBhIG1pY3Jvc2Vjb25kLgo+ICAgCSAqLwo+Cj4gLQlpZiAoaTkxNV9nZW1fcmVx dWVzdF9nZXRfcmluZyhyZXEpLT5pcnFfcmVmY291bnQpCj4gKwlpZiAocmVxLT5yaW5nLT5pcnFf cmVmY291bnQpCj4gICAJCXJldHVybiAtRUJVU1k7Cj4KPiArCS8qIE9ubHkgc3BpbiBpZiB3ZSBr bm93IHRoZSBHUFUgaXMgcHJvY2Vzc2luZyB0aGlzIHJlcXVlc3QgKi8KPiArCWlmICghaTkxNV9n ZW1fcmVxdWVzdF9zdGFydGVkKHJlcSwgZmFsc2UpKQo+ICsJCXJldHVybiAtRUFHQUlOOwo+ICsK PiAgIAl0aW1lb3V0ID0gbG9jYWxfY2xvY2tfdXMoJmNwdSkgKyAxMDsKPiAgIAl3aGlsZSAoIW5l ZWRfcmVzY2hlZCgpKSB7Cj4gICAJCWlmIChpOTE1X2dlbV9yZXF1ZXN0X2NvbXBsZXRlZChyZXEs IHRydWUpKQo+IEBAIC0xMjA5LDYgKzEyMTMsNyBAQCBzdGF0aWMgaW50IF9faTkxNV9zcGluX3Jl cXVlc3Qoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEsIGludCBzdGF0ZSkKPgo+ICAg CQljcHVfcmVsYXhfbG93bGF0ZW5jeSgpOwo+ICAgCX0KPiArCj4gICAJaWYgKGk5MTVfZ2VtX3Jl cXVlc3RfY29tcGxldGVkKHJlcSwgZmFsc2UpKQo+ICAgCQlyZXR1cm4gMDsKPgo+IEBAIC0yNTky LDYgKzI1OTcsNyBAQCB2b2lkIF9faTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X3JlcXVlc3QgKnJlcXVlc3QsCj4gICAJcmVxdWVzdC0+YmF0Y2hfb2JqID0gb2JqOwo+Cj4gICAJ cmVxdWVzdC0+ZW1pdHRlZF9qaWZmaWVzID0gamlmZmllczsKPiArCXJlcXVlc3QtPnByZXZpb3Vz X3NlcW5vID0gcmluZy0+bGFzdF9zdWJtaXR0ZWRfc2Vxbm87Cj4gICAJcmluZy0+bGFzdF9zdWJt aXR0ZWRfc2Vxbm8gPSByZXF1ZXN0LT5zZXFubzsKPiAgIAlsaXN0X2FkZF90YWlsKCZyZXF1ZXN0 LT5saXN0LCAmcmluZy0+cmVxdWVzdF9saXN0KTsKPgo+Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==