From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [RFC PATCH] drm/i915: fix potential dangling else problems in for_each_ macros Date: Wed, 2 Dec 2015 13:29:21 +0000 Message-ID: <565EF231.3020100@intel.com> References: <1448386585-4144-1-git-send-email-jani.nikula@intel.com> <20151124222601.GB16277@nuc-i3427.alporthouse.com> <20151124234726.GA29196@nuc-i3427.alporthouse.com> <20151125092323.GP17050@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B3476E9AA for ; Wed, 2 Dec 2015 05:29:24 -0800 (PST) In-Reply-To: <20151125092323.GP17050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Chris Wilson , Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjUvMTEvMTUgMDk6MjMsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gVHVlLCBOb3YgMjQs IDIwMTUgYXQgMTE6NDc6MjZQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+PiBPbiBUdWUs IE5vdiAyNCwgMjAxNSBhdCAxMDoyNjowMVBNICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+ PiBPbiBUdWUsIE5vdiAyNCwgMjAxNSBhdCAwNzozNjoyNVBNICswMjAwLCBKYW5pIE5pa3VsYSB3 cm90ZToKPj4+PiAgIC8qIEl0ZXJhdGUgb3ZlciBpbml0aWFsaXNlZCByaW5ncyAqLwo+Pj4+ICAg I2RlZmluZSBmb3JfZWFjaF9yaW5nKHJpbmdfXywgZGV2X3ByaXZfXywgaV9fKSBcCj4+Pj4gICAJ Zm9yICgoaV9fKSA9IDA7IChpX18pIDwgSTkxNV9OVU1fUklOR1M7IChpX18pKyspIFwKPj4+PiAt CQlpZiAoKChyaW5nX18pID0gJihkZXZfcHJpdl9fKS0+cmluZ1soaV9fKV0pLCBpbnRlbF9yaW5n X2luaXRpYWxpemVkKChyaW5nX18pKSkKPj4+PiArCQlmb3JfZWFjaF9pZiAoKCgocmluZ19fKSA9 ICYoZGV2X3ByaXZfXyktPnJpbmdbKGlfXyldKSwgaW50ZWxfcmluZ19pbml0aWFsaXplZCgocmlu Z19fKSkpKQo+Pj4KPj4+IElkbHkgd29uZGVyaW5nIGlmIHdlIHdvdWxkIGJlIGhhcHB5IHdpdGgK Pj4+Cj4+PiBmb3JfZWFjaF9yaW5nKHJpbmdfXywgZGV2X3ByaXZfXykKPj4+IAlmb3IgKChyaW5n X18pID0gJihkZXZfcHJpdl9fKS0+cmluZ1swXTsKPj4+IAkgICAgIChyaW5nX18pIDw9ICYoZGV2 X3ByaXZfXyktPnJpbmdbSTkxNV9OVU1fUklOR1NdOwo+Pj4gCSAgICAgKHJpbmdfXykrKykKPj4+ IAkgICAgIGZvcl9lYWNoX2lmKGludGVsX3JpbmdfaW5pdGlhbGl6ZWQocmluZ19fKSkKPj4+Cj4+ PiA/Cj4+Pgo+Pj4gVGhlIGRvd25zaWRlIGlzIHRoYXQgd2UgaGF2ZSB1c2VkIGlfXyBpbiBzZXZl cmFsIHBsYWNlcyByYXRoZXIgdGhhbgo+Pj4gcmluZy0+aWQuCj4+Cj4+IEZ3aXcsIDEzIGZpbGVz IGNoYW5nZWQsIDExMyBpbnNlcnRpb25zKCspLCAxNDAgZGVsZXRpb25zKC0pCj4+Cj4+IFNlZW1z IGEgcmVhc29uYWJsZSBzaHJpbmthZ2UuCj4KPiBNYXliZSBmb3JfZWFjaF9lbmdpbmUgZXZlbiwg YW5kIHBoYXNlIG91dCBmb3JfZWFjaF9yaW5nIGNvbXBsZXRlbHk/Cj4gLURhbmllbAo+CgpXb3Vs ZG4ndCBpdCBiZSBuaWNlciAoYW5kIHNhZmVyKSBub3QgdG8gYnVpbGQgbWFjcm9zIHRoYXQgZm9s ZCB0aGUgbG9vcCAKc3RydWN0dXJlIGludG8gdGhlIG1hY3JvIChpbiBjb250cmF2ZW50aW9uIG9m IGtlcm5lbCBwcm9ncmFtbWluZyAKZ3VpZGVsaW5lcykuCgpTbyBob3cgYWJvdXQgTk9UIGluY2x1 ZGluZyB0aGUgYWN0dWFsIGZvcigpIGluc2lkZSB0aGUgbWFjcm8sIHNvIHRoYXQgCmluc3RlYWQg b2Ygd3JpdGluZwoKCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2KQoJCWRvX3N0dWZm KGVuZ2luZSkKCndlIHdvdWxkIHdyaXRlIGl0IGFzCgoJZm9yIChFQUNIX0VOR0lORShlbmdpbmUs IGRldl9wcml2KSkKCQlpbml0aWFsaXNlKGVuZ2luZSkKCglmb3IgKEVBQ0hfQUNUSVZFX0VOR0lO RShlbmdpbmUsIGRldl9wcml2KSkgewoJCXNlcnZpY2UoZW5naW5lKQoJCXJlc3RhcnQoZW5naW5l KQoJfQoKZXRjLiBUaGUgZm9yLWxvb3AgaXMgdmlzaWJsZSBhbmQgdGhlIHNjb3BlIGRvZXNuJ3Qg Z2l2ZSB5b3UgYW55IHN1cnByaXNlcy4KCltUaGUgRUFDSF9FTkdJTkUoKSBtYWNyb3MgZXhwYW5k cyB0byBhIHNlbWljb2xvbi1zZXBhcmF0ZWQgdHJpcGxldCBvZiAKZXhwcmVzc2lvbnM7IHN0aWxs IGEgdmlvbGF0aW9uIG9mIHRoZSAiZG9uJ3QgdXNlIG1hY3JvcyB0byByZWRlZmluZSBDIApzeW50 YXgiIGd1aWRlbGluZSwgYnV0IG11Y2ggbGVzcyBlZ3JlZ2lvdXMgdGhhbiBtYWNyb3MgdGhhdCBj b250YWluIAplbWJlZGRlZCAnZm9yJ3MgYW5kICdpZidzLgoKLkRhdmUuCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==